<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[225312] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/225312">225312</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-11-29 18:31:43 -0800 (Wed, 29 Nov 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179778

Reviewed by Youenn Fablet.

As per the specification [1], when clearing a registration, the registration's workers are first
marked as redundant *before* the registration's worker is set to null.

The test was waiting for the service worker's state to become redundant and then checking in a
setTimeout(0) that the registration's worker became null. However, a setTimeout(0) is racy here.
To address the issue, we now use setInterval() and wait until the worker becomes null.

[1] https://w3c.github.io/ServiceWorker/#clear-registration-algorithm

* TestExpectations:
* http/tests/workers/service/registration-clear-redundant-worker.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestshttptestsworkersserviceregistrationclearredundantworkerhtml">trunk/LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (225311 => 225312)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2017-11-30 02:23:44 UTC (rev 225311)
+++ trunk/LayoutTests/ChangeLog 2017-11-30 02:31:43 UTC (rev 225312)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-11-29  Chris Dumez  <cdumez@apple.com>
+
+        LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=179778
+
+        Reviewed by Youenn Fablet.
+
+        As per the specification [1], when clearing a registration, the registration's workers are first
+        marked as redundant *before* the registration's worker is set to null.
+
+        The test was waiting for the service worker's state to become redundant and then checking in a
+        setTimeout(0) that the registration's worker became null. However, a setTimeout(0) is racy here.
+        To address the issue, we now use setInterval() and wait until the worker becomes null.
+
+        [1] https://w3c.github.io/ServiceWorker/#clear-registration-algorithm
+
+        * TestExpectations:
+        * http/tests/workers/service/registration-clear-redundant-worker.html:
+
</ins><span class="cx"> 2017-11-29  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         ServiceWorkerClient objects should be reused if there is already one existing with the same identifier
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (225311 => 225312)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations       2017-11-30 02:23:44 UTC (rev 225311)
+++ trunk/LayoutTests/TestExpectations  2017-11-30 02:31:43 UTC (rev 225312)
</span><span class="lines">@@ -183,7 +183,6 @@
</span><span class="cx"> imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Skip ]
</span><span class="cx"> imported/w3c/web-platform-tests/service-workers/service-worker/client-navigate.https.html [ Skip ]
</span><span class="cx"> 
</span><del>-webkit.org/b/179778 http/tests/workers/service/registration-clear-redundant-worker.html [ Pass Failure ]
</del><span class="cx"> http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/179137 imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Pass Failure ]
</span><span class="cx"> imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsworkersserviceregistrationclearredundantworkerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html (225311 => 225312)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html    2017-11-30 02:23:44 UTC (rev 225311)
+++ trunk/LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html       2017-11-30 02:31:43 UTC (rev 225312)
</span><span class="lines">@@ -15,22 +15,23 @@
</span><span class="cx">         }).then(function() {
</span><span class="cx">             waitForState(worker, "redundant").then(function() {
</span><span class="cx">                 log("PASS: Worker became redundant after unregistering");
</span><del>-                setTimeout(function() {
-                    if (registration.installing)
-                        log("FAIL: registration.installing should be null");
-                    else
-                        log("PASS: registration.installing is null");
</del><ins>+                if (registration.installing)
+                    log("FAIL: registration.installing should be null");
+                else
+                    log("PASS: registration.installing is null");
</ins><span class="cx"> 
</span><del>-                    if (registration.waiting)
-                        log("FAIL: registration.waiting should be null");
-                    else
-                        log("PASS: registration.waiting is null");
</del><ins>+                if (registration.waiting)
+                    log("FAIL: registration.waiting should be null");
+                else
+                    log("PASS: registration.waiting is null");
</ins><span class="cx"> 
</span><ins>+                handle = setInterval(function() {
</ins><span class="cx">                     if (registration.active)
</span><del>-                        log("FAIL: registration.active should be null");
-                    else
-                        log("PASS: registration.active is null");
</del><ins>+                        return;
</ins><span class="cx"> 
</span><ins>+                    log("PASS: registration.active is null");
+                    clearInterval(handle);
+
</ins><span class="cx">                     finishSWTest();
</span><span class="cx">                 }, 0);
</span><span class="cx">             });
</span></span></pre>
</div>
</div>

</body>
</html>