<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[225258] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/225258">225258</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-11-28 22:10:50 -0800 (Tue, 28 Nov 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Write script syntax tree tests for template literals and default parameter values
https://bugs.webkit.org/show_bug.cgi?id=149450
<rdar://problem/22796879>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-11-28
Reviewed by Devin Rousso.

* inspector/model/parse-script-syntax-tree-expected.txt:
* inspector/model/parse-script-syntax-tree.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectormodelparsescriptsyntaxtreeexpectedtxt">trunk/LayoutTests/inspector/model/parse-script-syntax-tree-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectormodelparsescriptsyntaxtreehtml">trunk/LayoutTests/inspector/model/parse-script-syntax-tree.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (225257 => 225258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2017-11-29 05:08:21 UTC (rev 225257)
+++ trunk/LayoutTests/ChangeLog 2017-11-29 06:10:50 UTC (rev 225258)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-11-28  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Write script syntax tree tests for template literals and default parameter values
+        https://bugs.webkit.org/show_bug.cgi?id=149450
+        <rdar://problem/22796879>
+
+        Reviewed by Devin Rousso.
+
+        * inspector/model/parse-script-syntax-tree-expected.txt:
+        * inspector/model/parse-script-syntax-tree.html:
+
</ins><span class="cx"> 2017-11-28  Zalan Bujtas  <zalan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Clean up spanners before creating nested column context
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelparsescriptsyntaxtreeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/parse-script-syntax-tree-expected.txt (225257 => 225258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/parse-script-syntax-tree-expected.txt  2017-11-29 05:08:21 UTC (rev 225257)
+++ trunk/LayoutTests/inspector/model/parse-script-syntax-tree-expected.txt     2017-11-29 06:10:50 UTC (rev 225258)
</span><span class="lines">@@ -20,6 +20,8 @@
</span><span class="cx"> passed Identifier
</span><span class="cx"> passed IfStatement
</span><span class="cx"> passed Literal
</span><ins>+passed TemplateLiteral, TemplateElement
+passed TaggedTemplateExpression
</ins><span class="cx"> passed LabeledStatement
</span><span class="cx"> passed LogicalExpression
</span><span class="cx"> passed MemberExpression
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelparsescriptsyntaxtreehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/parse-script-syntax-tree.html (225257 => 225258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/parse-script-syntax-tree.html  2017-11-29 05:08:21 UTC (rev 225257)
+++ trunk/LayoutTests/inspector/model/parse-script-syntax-tree.html     2017-11-29 06:10:50 UTC (rev 225258)
</span><span class="lines">@@ -271,8 +271,39 @@
</span><span class="cx">     node = makeNode("\"a\"", true);
</span><span class="cx">     InspectorTest.assert(node.value === "a");
</span><span class="cx">     InspectorTest.assert(node.raw === "\"a\"");
</span><ins>+    node = makeNode("'abc'", true);
+    InspectorTest.assert(node.value === "abc");
+    InspectorTest.assert(node.raw === "'abc'");
</ins><span class="cx">     InspectorTest.log("passed Literal");
</span><span class="cx"> 
</span><ins>+    node = makeNode("`abc`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasis.length === 1);
+    InspectorTest.assert(node.expressions.length === 0);
+    InspectorTest.assert(node.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[0].value.raw === "abc");
+    node = makeNode("`abc${1}def`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasis.length === 2);
+    InspectorTest.assert(node.expressions.length === 1);
+    InspectorTest.assert(node.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[0].value.raw === "abc");
+    InspectorTest.assert(node.quasis[1].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[1].value.raw === "def");
+    InspectorTest.assert(node.expressions[0].type === WI.ScriptSyntaxTree.NodeType.Literal);
+    InspectorTest.assert(node.expressions[0].value === 1);
+    InspectorTest.log("passed TemplateLiteral, TemplateElement");
+
+    node = makeNode("tag`abcd`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TaggedTemplateExpression);
+    InspectorTest.assert(node.tag.name === "tag");
+    InspectorTest.assert(node.quasi.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasi.quasis.length === 1);
+    InspectorTest.assert(node.quasi.expressions.length === 0);
+    InspectorTest.assert(node.quasi.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasi.quasis[0].value.raw === "abcd");
+    InspectorTest.log("passed TaggedTemplateExpression");
+
</ins><span class="cx">     node = makeNode("label:while(true)20;", false);
</span><span class="cx">     InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.LabeledStatement);
</span><span class="cx">     InspectorTest.assert(node.label);
</span><span class="lines">@@ -539,6 +570,15 @@
</span><span class="cx">     InspectorTest.assert(node.declarations[0].id.elements[0].left.name === "x");
</span><span class="cx">     InspectorTest.assert(node.declarations[0].id.elements[0].right.type === WI.ScriptSyntaxTree.NodeType.Literal);
</span><span class="cx">     InspectorTest.assert(node.declarations[0].id.elements[0].right.value === 20);
</span><ins>+    node = makeNode("function foo(a, b=1) { return a + b; }", false);
+    InspectorTest.assert(node.params.length === 2);
+    InspectorTest.assert(node.params[0].type === WI.ScriptSyntaxTree.NodeType.Identifier);
+    InspectorTest.assert(node.params[0].name === "a");
+    InspectorTest.assert(node.params[1].type === WI.ScriptSyntaxTree.NodeType.AssignmentPattern);
+    InspectorTest.assert(node.params[1].left.type === WI.ScriptSyntaxTree.NodeType.Identifier);
+    InspectorTest.assert(node.params[1].left.name === "b");
+    InspectorTest.assert(node.params[1].right.type === WI.ScriptSyntaxTree.NodeType.Literal);
+    InspectorTest.assert(node.params[1].right.value === 1);
</ins><span class="cx">     InspectorTest.log("passed AssignmentPattern");
</span><span class="cx"> 
</span><span class="cx">     node = makeNode("(x) => x;", true);
</span></span></pre>
</div>
</div>

</body>
</html>