<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[224419] branches/safari-604.4.7.1-branch</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/224419">224419</a></dd>
<dt>Author</dt> <dd>jmarcell@apple.com</dd>
<dt>Date</dt> <dd>2017-11-03 13:12:31 -0700 (Fri, 03 Nov 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/224398">r224398</a>. rdar://problem/35329684</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari604471branchLayoutTestsChangeLog">branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog</a></li>
<li><a href="#branchessafari604471branchSourceWebCoreChangeLog">branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari604471branchSourceWebCorehtmlHTMLFormElementcpp">branches/safari-604.4.7.1-branch/Source/WebCore/html/HTMLFormElement.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#branchessafari604471branchLayoutTestsfastformsnodelistremovebuttonfromformexpectedtxt">branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form-expected.txt</a></li>
<li><a href="#branchessafari604471branchLayoutTestsfastformsnodelistremovebuttonfromformhtml">branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari604471branchLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog (224418 => 224419)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog   2017-11-03 20:12:10 UTC (rev 224418)
+++ branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog      2017-11-03 20:12:31 UTC (rev 224419)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2017-11-03  Jason Marcell  <jmarcell@apple.com>
+
+        Cherry-pick r224398. rdar://problem/35329684
+
+    2017-11-03  Daniel Bates  <dabates@apple.com>
+
+            Invalidate node list when associated form control element is removed
+            https://bugs.webkit.org/show_bug.cgi?id=179232
+            <rdar://problem/35308269>
+
+            Reviewed by Ryosuke Niwa.
+
+            Add a test to ensure the node list returned by HTMLFormElement.elements stays synchronized
+            with the document.
+
+            * fast/forms/node-list-remove-button-from-form-expected.txt: Added.
+            * fast/forms/node-list-remove-button-from-form.html: Added.
+
</ins><span class="cx"> 2017-10-29  Jason Marcell  <jmarcell@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Cherry-pick r224139. rdar://problem/35143359
</span></span></pre></div>
<a id="branchessafari604471branchLayoutTestsfastformsnodelistremovebuttonfromformexpectedtxt"></a>
<div class="addfile"><h4>Added: branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form-expected.txt (0 => 224419)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form-expected.txt                           (rev 0)
+++ branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form-expected.txt      2017-11-03 20:12:31 UTC (rev 224419)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Tests that removing a <button> from the document removes it from HTMLFormElement.elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Before removal of button:
+PASS document.getElementById('aForm').elements is non-null.
+PASS document.getElementById('aForm')['aButton'] is document.getElementById('aButton')
+
+After removal of button:
+PASS document.getElementById('aForm')['aButton'] is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="branchessafari604471branchLayoutTestsfastformsnodelistremovebuttonfromformhtml"></a>
<div class="addfile"><h4>Added: branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form.html (0 => 224419)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form.html                           (rev 0)
+++ branches/safari-604.4.7.1-branch/LayoutTests/fast/forms/node-list-remove-button-from-form.html      2017-11-03 20:12:31 UTC (rev 224419)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../resources/js-test.js"></script>
+</head>
+<body>
+<p id="description"></p>
+<div id="console"></div>
+<button id="aButton" form="aForm"></button>
+<form id="aForm"></form>
+<script>
+description("Tests that removing a &lt;button&gt; from the document removes it from HTMLFormElement.elements.");
+
+runTest();
+
+function runTest()
+{
+    debug("Before removal of button:");
+    shouldBeNonNull("document.getElementById('aForm').elements");
+    shouldBe("document.getElementById('aForm')['aButton']", "document.getElementById('aButton')");
+    document.getElementById('aButton').remove();
+
+    debug("<br>After removal of button:");
+    shouldBeUndefined("document.getElementById('aForm')['aButton']");
+}
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="branchessafari604471branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog (224418 => 224419)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog        2017-11-03 20:12:10 UTC (rev 224418)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog   2017-11-03 20:12:31 UTC (rev 224419)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2017-11-03  Jason Marcell  <jmarcell@apple.com>
+
+        Cherry-pick r224398. rdar://problem/35329684
+
+    2017-11-03  Daniel Bates  <dabates@apple.com>
+
+            Invalidate node list when associated form control element is removed
+            https://bugs.webkit.org/show_bug.cgi?id=179232
+            <rdar://problem/35308269>
+
+            Reviewed by Ryosuke Niwa.
+
+            A node list represents a live view of the DOM. Invalidate the node list
+            associated with a form element whenever one of its associated form control
+            elements is removed.
+
+            Test: fast/forms/node-list-remove-button-from-form.html
+
+            * html/HTMLFormElement.cpp:
+            (WebCore::HTMLFormElement::removeFormElement):
+
</ins><span class="cx"> 2017-10-29  Jason Marcell  <jmarcell@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Cherry-pick r224134. rdar://problem/35143359
</span></span></pre></div>
<a id="branchessafari604471branchSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-604.4.7.1-branch/Source/WebCore/html/HTMLFormElement.cpp (224418 => 224419)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-604.4.7.1-branch/Source/WebCore/html/HTMLFormElement.cpp 2017-11-03 20:12:10 UTC (rev 224418)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/html/HTMLFormElement.cpp    2017-11-03 20:12:31 UTC (rev 224419)
</span><span class="lines">@@ -606,6 +606,9 @@
</span><span class="cx">     removeFromPastNamesMap(e);
</span><span class="cx">     m_associatedElements.remove(index);
</span><span class="cx"> 
</span><ins>+    if (auto* nodeLists = this->nodeLists())
+        nodeLists->invalidateCaches();
+
</ins><span class="cx">     if (e == m_defaultButton)
</span><span class="cx">         resetDefaultButton();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>