<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[218943] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/218943">218943</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-06-29 10:54:32 -0700 (Thu, 29 Jun 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Full stop shows to the right of the picture-in-picture localised string in Hebrew
https://bugs.webkit.org/show_bug.cgi?id=173966
<rdar://problem/32847376>

Patch by Antoine Quint <graouts@apple.com> on 2017-06-29
Reviewed by Dean Jackson.

Source/WebCore:

We manually set the CSS "direction" property to "rtl" when we're not using an LTR language for a placard.

Test: media/modern-media-controls/placard/placard-ltr.html

* Modules/modern-media-controls/controls/placard.css:
(.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard):

LayoutTests:

* media/modern-media-controls/placard/placard-ltr-expected.txt: Added.
* media/modern-media-controls/placard/placard-ltr.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsplacardcss">trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsplacardplacardltrexpectedtxt">trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsplacardplacardltrhtml">trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (218942 => 218943)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/LayoutTests/ChangeLog 2017-06-29 17:54:32 UTC (rev 218943)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-06-29  Antoine Quint  <graouts@apple.com>
+
+        Full stop shows to the right of the picture-in-picture localised string in Hebrew
+        https://bugs.webkit.org/show_bug.cgi?id=173966
+        <rdar://problem/32847376>
+
+        Reviewed by Dean Jackson.
+
+        * media/modern-media-controls/placard/placard-ltr-expected.txt: Added.
+        * media/modern-media-controls/placard/placard-ltr.html: Added.
+
</ins><span class="cx"> 2017-06-29  Romain Bellessort  <romain.bellessort@crf.canon.fr>
</span><span class="cx"> 
</span><span class="cx">         [Readable Streams API] Fix ReadableStream "strategy" argument handling
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsplacardplacardltrexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt (0 => 218943)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt                           (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt      2017-06-29 17:54:32 UTC (rev 218943)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+Testing placard has 'direction: rtl' set for RTL languages.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Waiting for placard to appear
+PASS !!shadowRoot.querySelector('.placard') became true
+
+Default layout direction is LTR
+PASS getComputedStyle(shadowRoot.querySelector('.placard')).direction became "ltr"
+
+Setting layout direction to RTL
+PASS getComputedStyle(shadowRoot.querySelector('.placard')).direction became "rtl"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsplacardplacardltrhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html (0 => 218943)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html                           (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html      2017-06-29 17:54:32 UTC (rev 218943)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test-pre.js"></script>
+<body>
+<video src="../../content/test.mp4" style="width: 320px; height: 240px;" controls></video>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing placard has 'direction: rtl' set for RTL languages.");
+
+const media = document.querySelector("video");
+const shadowRoot = window.internals.shadowRoot(media);
+
+media.addEventListener("error", event => {
+    debug("Waiting for placard to appear");
+    shouldBecomeEqual("!!shadowRoot.querySelector('.placard')", "true", () => {
+        debug("");
+        debug("Default layout direction is LTR");
+        shouldBecomeEqualToString("getComputedStyle(shadowRoot.querySelector('.placard')).direction", "ltr", () => {
+            debug("");
+            debug("Setting layout direction to RTL");
+            window.internals.setUserInterfaceLayoutDirection("RTL");
+            shouldBecomeEqualToString("getComputedStyle(shadowRoot.querySelector('.placard')).direction", "rtl", finishJSTest);
+        });
+    });
+});
+
+media.src = "";
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (218942 => 218943)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/Source/WebCore/ChangeLog      2017-06-29 17:54:32 UTC (rev 218943)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-06-29  Antoine Quint  <graouts@apple.com>
+
+        Full stop shows to the right of the picture-in-picture localised string in Hebrew
+        https://bugs.webkit.org/show_bug.cgi?id=173966
+        <rdar://problem/32847376>
+
+        Reviewed by Dean Jackson.
+
+        We manually set the CSS "direction" property to "rtl" when we're not using an LTR language for a placard.
+
+        Test: media/modern-media-controls/placard/placard-ltr.html
+
+        * Modules/modern-media-controls/controls/placard.css:
+        (.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard):
+
</ins><span class="cx"> 2017-06-29  Brent Fulgham  <bfulgham@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed Apple CMake build after r218901
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsplacardcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css (218942 => 218943)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css  2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css     2017-06-29 17:54:32 UTC (rev 218943)
</span><span class="lines">@@ -73,3 +73,7 @@
</span><span class="cx">     -webkit-box-orient: vertical;
</span><span class="cx">     -webkit-line-clamp: 2;
</span><span class="cx"> }
</span><ins>+
+.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard {
+    direction: rtl;
+}
</ins></span></pre>
</div>
</div>

</body>
</html>