<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[218959] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/218959">218959</a></dd>
<dt>Author</dt> <dd>drousso@apple.com</dd>
<dt>Date</dt> <dd>2017-06-29 13:15:55 -0700 (Thu, 29 Jun 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Create a single -webkit-canvas for use inside popovers
https://bugs.webkit.org/show_bug.cgi?id=173820

Reviewed by Matt Baker.

* UserInterface/Views/Popover.css:
(.popover):
* UserInterface/Views/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype._drawBackground):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsPopovercss">trunk/Source/WebInspectorUI/UserInterface/Views/Popover.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsPopoverjs">trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (218958 => 218959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2017-06-29 19:51:05 UTC (rev 218958)
+++ trunk/Source/WebInspectorUI/ChangeLog       2017-06-29 20:15:55 UTC (rev 218959)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-06-29  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Create a single -webkit-canvas for use inside popovers
+        https://bugs.webkit.org/show_bug.cgi?id=173820
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/Popover.css:
+        (.popover):
+        * UserInterface/Views/Popover.js:
+        (WebInspector.Popover):
+        (WebInspector.Popover.prototype._drawBackground):
+
</ins><span class="cx"> 2017-06-28  Devin Rousso  <drousso@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: Instrument active pixel memory used by canvases
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsPopovercss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Popover.css (218958 => 218959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Popover.css      2017-06-29 19:51:05 UTC (rev 218958)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Popover.css 2017-06-29 20:15:55 UTC (rev 218959)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">     min-width: 20px;
</span><span class="cx">     min-height: 20px;
</span><span class="cx">     box-sizing: border-box;
</span><ins>+    background-image: -webkit-canvas(popover);
</ins><span class="cx">     pointer-events: none;
</span><span class="cx">     z-index: var(--z-index-popover);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsPopoverjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js (218958 => 218959)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js       2017-06-29 19:51:05 UTC (rev 218958)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js  2017-06-29 20:15:55 UTC (rev 218959)
</span><span class="lines">@@ -41,11 +41,8 @@
</span><span class="cx">         this._contentNeedsUpdate = false;
</span><span class="cx">         this._dismissing = false;
</span><span class="cx"> 
</span><del>-        this._canvasId = "popover-" + (WebInspector.Popover.canvasId++);
-
</del><span class="cx">         this._element = document.createElement("div");
</span><span class="cx">         this._element.className = "popover";
</span><del>-        this._element.style.backgroundImage = "-webkit-canvas(" + this._canvasId + ")";
</del><span class="cx">         this._element.addEventListener("transitionend", this, true);
</span><span class="cx"> 
</span><span class="cx">         this._container = this._element.appendChild(document.createElement("div"));
</span><span class="lines">@@ -439,15 +436,12 @@
</span><span class="cx">         ctx.stroke();
</span><span class="cx"> 
</span><span class="cx">         // Draw the popover into the final context with a drop shadow.
</span><del>-        var finalContext = document.getCSSCanvasContext("2d", this._canvasId, scaledWidth, scaledHeight);
-
</del><ins>+        let finalContext = document.getCSSCanvasContext("2d", "popover", scaledWidth, scaledHeight);
</ins><span class="cx">         finalContext.clearRect(0, 0, scaledWidth, scaledHeight);
</span><del>-
</del><span class="cx">         finalContext.shadowOffsetX = 1;
</span><span class="cx">         finalContext.shadowOffsetY = 1;
</span><span class="cx">         finalContext.shadowBlur = 5;
</span><span class="cx">         finalContext.shadowColor = "rgba(0, 0, 0, 0.5)";
</span><del>-
</del><span class="cx">         finalContext.drawImage(scratchCanvas, 0, 0, scaledWidth, scaledHeight);
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="lines">@@ -591,7 +585,6 @@
</span><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> WebInspector.Popover.FadeOutClassName = "fade-out";
</span><del>-WebInspector.Popover.canvasId = 0;
</del><span class="cx"> WebInspector.Popover.CornerRadius = 5;
</span><span class="cx"> WebInspector.Popover.MinWidth = 40;
</span><span class="cx"> WebInspector.Popover.MinHeight = 40;
</span></span></pre>
</div>
</div>

</body>
</html>