<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[218025] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/218025">218025</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2017-06-09 15:45:00 -0700 (Fri, 09 Jun 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
https://bugs.webkit.org/show_bug.cgi?id=172720

Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2017-06-09
Reviewed by Darin Adler.

Reenable DateTimeFormat tests, allowing for some variation in the
formatting of time zone names.

* js/intl-datetimeformat-expected.txt:
* js/script-tests/intl-datetimeformat.js:
* platform/mac/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsintldatetimeformatexpectedtxt">trunk/LayoutTests/js/intl-datetimeformat-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsintldatetimeformatjs">trunk/LayoutTests/js/script-tests/intl-datetimeformat.js</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (218024 => 218025)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/ChangeLog 2017-06-09 22:45:00 UTC (rev 218025)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-06-09  Andy VanWagoner  <thetalecrafter@gmail.com>
+
+        REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=172720
+
+        Reviewed by Darin Adler.
+
+        Reenable DateTimeFormat tests, allowing for some variation in the
+        formatting of time zone names.
+
+        * js/intl-datetimeformat-expected.txt:
+        * js/script-tests/intl-datetimeformat.js:
+        * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2017-06-09  Joseph Pecoraro  <pecoraro@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>)
</span></span></pre></div>
<a id="trunkLayoutTestsjsintldatetimeformatexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/intl-datetimeformat-expected.txt (218024 => 218025)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/intl-datetimeformat-expected.txt    2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/js/intl-datetimeformat-expected.txt       2017-06-09 22:45:00 UTC (rev 218025)
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx"> PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short' }).resolvedOptions().timeZoneName is 'short'
</span><span class="cx"> PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0) is '12:00 AM GMT'
</span><span class="cx"> PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName is 'long'
</span><del>-PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0) is '00:00 GMT'
</del><ins>+PASS ['00:00 GMT','00:00 HorĂ¡rio do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)) is true
</ins><span class="cx"> PASS 
</span><span class="cx">     var options = { weekday: "short", year: "numeric", month: "short", day: "numeric", hour: "numeric", minute: "numeric", second: "numeric" };
</span><span class="cx">     var resolved = Intl.DateTimeFormat("ar", options).resolvedOptions();
</span><span class="lines">@@ -2555,7 +2555,7 @@
</span><span class="cx">   Intl.DateTimeFormat('en-US', {
</span><span class="cx">     hour: "numeric", minute: "numeric", second: "numeric",
</span><span class="cx">     year: "numeric", month: "long", day: "numeric", weekday: "long",
</span><del>-    timeZoneName: "long", era: "long", timeZone: "UTC"
</del><ins>+    timeZoneName: "short", era: "long", timeZone: "UTC"
</ins><span class="cx">   }).formatToParts(0)
</span><span class="cx"> ) is JSON.stringify([
</span><span class="cx">   {"type":"weekday","value":"Thursday"},
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsintldatetimeformatjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/intl-datetimeformat.js (218024 => 218025)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/intl-datetimeformat.js 2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/js/script-tests/intl-datetimeformat.js    2017-06-09 22:45:00 UTC (rev 218025)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-//@ skip
</del><ins>+//@ skip if $hostOS == "windows"
</ins><span class="cx"> description("This test checks the behavior of Intl.DateTimeFormat as described in the ECMAScript Internationalization API Specification (ECMA-402 2.0).");
</span><span class="cx"> 
</span><span class="cx"> // 12.1 The Intl.DateTimeFormat Constructor
</span><span class="lines">@@ -461,7 +461,7 @@
</span><span class="cx"> shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short' }).resolvedOptions().timeZoneName", "'short'");
</span><span class="cx"> shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0)", "'12:00 AM GMT'");
</span><span class="cx"> shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName", "'long'");
</span><del>-shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)", "'00:00 GMT'")
</del><ins>+shouldBeTrue("['00:00 GMT','00:00 HorĂ¡rio do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0))");
</ins><span class="cx"> 
</span><span class="cx"> let localesSample = [
</span><span class="cx">   "ar", "ar-SA", "be", "ca", "cs", "da", "de", "de-CH", "en", "en-AU", "en-GB",
</span><span class="lines">@@ -578,7 +578,7 @@
</span><span class="cx">   Intl.DateTimeFormat('en-US', {
</span><span class="cx">     hour: "numeric", minute: "numeric", second: "numeric",
</span><span class="cx">     year: "numeric", month: "long", day: "numeric", weekday: "long",
</span><del>-    timeZoneName: "long", era: "long", timeZone: "UTC"
</del><ins>+    timeZoneName: "short", era: "long", timeZone: "UTC"
</ins><span class="cx">   }).formatToParts(0)
</span><span class="cx"> )`, `JSON.stringify([
</span><span class="cx">   {"type":"weekday","value":"Thursday"},
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (218024 => 218025)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations  2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/platform/mac/TestExpectations     2017-06-09 22:45:00 UTC (rev 218025)
</span><span class="lines">@@ -1542,8 +1542,6 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
</span><span class="cx"> 
</span><del>-webkit.org/b/172720 [ Sierra+ ] js/intl-datetimeformat.html [ Failure ]
-
</del><span class="cx"> # This test tests a feature that only exists on iOS.
</span><span class="cx"> webkit.org/b/172737 fast/text/accessibility-bold-system-font-2.html [ ImageOnlyFailure ]
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>