<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[217949] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/217949">217949</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-06-08 15:03:00 -0700 (Thu, 08 Jun 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS] Buttons in top-left and bottom media controls bar are positioned too high
https://bugs.webkit.org/show_bug.cgi?id=173111
<rdar://problem/32650615>

Patch by Antoine Quint <graouts@apple.com> on 2017-06-08
Reviewed by Jon Lee.

Source/WebCore:

Test: media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html

Since we use flex box to vertically center buttons in a buttons container, there is no
need to offset the button due to padding in the y-axis.

* Modules/modern-media-controls/controls/buttons-container.css:
(.ios .buttons-container button):

LayoutTests:

Add a test that checks that the appropriate styles as set in buttons-container.css
are applied to a button in a buttons container on iOS.

* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt: Added.
* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html: Added.
* platform/ios-simulator/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsbuttonscontainercss">trunk/Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsbuttonpaddingexpectedtxt">trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsbuttonpaddinghtml">trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (217948 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2017-06-08 21:47:39 UTC (rev 217948)
+++ trunk/LayoutTests/ChangeLog 2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-06-08  Antoine Quint  <graouts@apple.com>
+
+        [iOS] Buttons in top-left and bottom media controls bar are positioned too high
+        https://bugs.webkit.org/show_bug.cgi?id=173111
+        <rdar://problem/32650615>
+
+        Reviewed by Jon Lee.
+
+        Add a test that checks that the appropriate styles as set in buttons-container.css
+        are applied to a button in a buttons container on iOS.
+
+        * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt: Added.
+        * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html: Added.
+        * platform/ios-simulator/TestExpectations:
+
</ins><span class="cx"> 2017-06-08  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         getUserMedia should not be prompted again if user denied access
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsbuttonpaddingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt (0 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt                            (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding-expected.txt       2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Testing that buttons on iOS have extra padding and remain centered.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaControls.querySelector('button.fullscreen') instanceof HTMLButtonElement became true
+PASS getComputedStyle(mediaControls.querySelector('button.fullscreen')).padding is "8px"
+PASS getComputedStyle(mediaControls.querySelector('button.fullscreen')).transform is "matrix(1, 0, 0, 1, -8, 0)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsbuttonpaddinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html (0 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html                            (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html       2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test-pre.js"></script>
+<body>
+<video src="../../content/test.mp4" style="width: 320px; height: 240px;" controls autoplay></video>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing that buttons on iOS have extra padding and remain centered.");
+
+const mediaControls = window.internals.shadowRoot(document.querySelector("video")).lastElementChild;
+
+shouldBecomeEqual("mediaControls.querySelector('button.fullscreen') instanceof HTMLButtonElement", "true", () => {
+    shouldBeEqualToString("getComputedStyle(mediaControls.querySelector('button.fullscreen')).padding", "8px");
+    shouldBeEqualToString("getComputedStyle(mediaControls.querySelector('button.fullscreen')).transform", "matrix(1, 0, 0, 1, -8, 0)");
+    finishJSTest();
+});
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (217948 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations        2017-06-08 21:47:39 UTC (rev 217948)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations   2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -77,6 +77,9 @@
</span><span class="cx"> media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
</span><span class="cx"> 
</span><ins>+# These tests specifically test iOS-only media controls features
+media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html [ Pass ]
+
</ins><span class="cx"> webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/156718 storage/websql/alter-to-info-table.html [ Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (217948 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2017-06-08 21:47:39 UTC (rev 217948)
+++ trunk/Source/WebCore/ChangeLog      2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-06-08  Antoine Quint  <graouts@apple.com>
+
+        [iOS] Buttons in top-left and bottom media controls bar are positioned too high
+        https://bugs.webkit.org/show_bug.cgi?id=173111
+        <rdar://problem/32650615>
+
+        Reviewed by Jon Lee.
+
+        Test: media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html
+
+        Since we use flex box to vertically center buttons in a buttons container, there is no
+        need to offset the button due to padding in the y-axis.
+
+        * Modules/modern-media-controls/controls/buttons-container.css:
+        (.ios .buttons-container button):
+
</ins><span class="cx"> 2017-06-08  Jeremy Jones  <jeremyj@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Implement additional AVPlayerController interfaces for minTime and maxTime.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsbuttonscontainercss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css (217948 => 217949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css        2017-06-08 21:47:39 UTC (rev 217948)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css   2017-06-08 22:03:00 UTC (rev 217949)
</span><span class="lines">@@ -33,6 +33,6 @@
</span><span class="cx"> /* Increase the touch region for buttons in containers on iOS */
</span><span class="cx"> .ios .buttons-container button {
</span><span class="cx">     padding: 8px;
</span><del>-    transform: translate(-8px, -8px);
</del><ins>+    transform: translateX(-8px);
</ins><span class="cx">     box-sizing: content-box;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>