<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[217728] trunk/Source/WebKit2</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/217728">217728</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-06-02 12:04:59 -0700 (Fri, 02 Jun 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add abilility to specify presentingApplicationPID for a WebProcessPool.
https://bugs.webkit.org/show_bug.cgi?id=172839
rdar://problem/32247170

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-02
Reviewed by Tim Horton.

Expose presentingApplicationPID through WebProcessPoolConfiguration.
This allows rehosted WebViews to specify the hosting application.

* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration setPresentingApplicationPID:]):
(-[_WKProcessPoolConfiguration presentingApplicationPID]):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIAPIProcessPoolConfigurationcpp">trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIAPIProcessPoolConfigurationh">trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoa_WKProcessPoolConfigurationh">trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoa_WKProcessPoolConfigurationmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolcpp">trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog   2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/ChangeLog      2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2017-06-02  Jeremy Jones  <jeremyj@apple.com>
+
+        Add abilility to specify presentingApplicationPID for a WebProcessPool.
+        https://bugs.webkit.org/show_bug.cgi?id=172839
+        rdar://problem/32247170
+
+        Reviewed by Tim Horton.
+
+        Expose presentingApplicationPID through WebProcessPoolConfiguration.
+        This allows rehosted WebViews to specify the hosting application.
+
+        * UIProcess/API/APIProcessPoolConfiguration.cpp:
+        (API::ProcessPoolConfiguration::copy):
+        * UIProcess/API/APIProcessPoolConfiguration.h:
+        * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
+        * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
+        (-[_WKProcessPoolConfiguration setPresentingApplicationPID:]):
+        (-[_WKProcessPoolConfiguration presentingApplicationPID]):
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::ensureNetworkProcess):
+        (WebKit::WebProcessPool::createNewWebProcess):
+
</ins><span class="cx"> 2017-06-02  Frederic Wang  <fwang@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [Mac] Use compositing for frames when ScrollingTreeIncludesFrames=true
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIAPIProcessPoolConfigurationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp       2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp  2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -123,6 +123,7 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx">     copy->m_ctDataConnectionServiceType = this->m_ctDataConnectionServiceType;
</span><span class="cx"> #endif
</span><ins>+    copy->m_presentingApplicationPID = this->m_presentingApplicationPID;
</ins><span class="cx">     
</span><span class="cx">     return copy;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIAPIProcessPoolConfigurationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h 2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h    2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -131,6 +131,9 @@
</span><span class="cx">     void setCTDataConnectionServiceType(const WTF::String& ctDataConnectionServiceType) { m_ctDataConnectionServiceType = ctDataConnectionServiceType; }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+    pid_t presentingApplicationPID() const { return m_presentingApplicationPID; }
+    void setPresentingApplicationPID(pid_t pid) { m_presentingApplicationPID = pid; }
+
</ins><span class="cx"> private:
</span><span class="cx">     bool m_shouldHaveLegacyDataStore { false };
</span><span class="cx"> 
</span><span class="lines">@@ -162,6 +165,7 @@
</span><span class="cx">     bool m_alwaysRunsAtBackgroundPriority { false };
</span><span class="cx">     bool m_shouldTakeUIBackgroundAssertion { true };
</span><span class="cx">     bool m_shouldCaptureAudioInUIProcess { false };
</span><ins>+    pid_t m_presentingApplicationPID { getpid() };
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx">     WTF::String m_ctDataConnectionServiceType;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoa_WKProcessPoolConfigurationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h   2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h      2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -56,8 +56,8 @@
</span><span class="cx"> @property (nonatomic) BOOL alwaysRunsAtBackgroundPriority WK_API_AVAILABLE(ios(WK_IOS_TBA));
</span><span class="cx"> @property (nonatomic) BOOL shouldTakeUIBackgroundAssertion WK_API_AVAILABLE(ios(WK_IOS_TBA));
</span><span class="cx"> #endif
</span><ins>+@property (nonatomic) pid_t presentingApplicationPID WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
</ins><span class="cx"> 
</span><del>-
</del><span class="cx"> @end
</span><span class="cx"> 
</span><span class="cx"> NS_ASSUME_NONNULL_END
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoa_WKProcessPoolConfigurationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm  2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm     2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -218,6 +218,16 @@
</span><span class="cx">     _processPoolConfiguration->setShouldCaptureAudioInUIProcess(shouldCaptureAudioInUIProcess);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (void)setPresentingApplicationPID:(pid_t)presentingApplicationPID
+{
+    _processPoolConfiguration->setPresentingApplicationPID(presentingApplicationPID);
+}
+
+- (pid_t)presentingApplicationPID
+{
+    return _processPoolConfiguration->presentingApplicationPID();
+}
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> - (NSString *)CTDataConnectionServiceType
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (217727 => 217728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp        2017-06-02 19:04:53 UTC (rev 217727)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp   2017-06-02 19:04:59 UTC (rev 217728)
</span><span class="lines">@@ -460,7 +460,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     parameters.shouldUseTestingNetworkSession = m_shouldUseTestingNetworkSession;
</span><del>-    parameters.presentingApplicationPID = getpid();
</del><ins>+    parameters.presentingApplicationPID = m_configuration->presentingApplicationPID();
</ins><span class="cx"> 
</span><span class="cx">     // Add any platform specific parameters
</span><span class="cx">     platformInitializeNetworkProcess(parameters);
</span><span class="lines">@@ -753,7 +753,7 @@
</span><span class="cx">     parameters.shouldCaptureAudioInUIProcess = m_configuration->shouldCaptureAudioInUIProcess();
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    parameters.presentingApplicationPID = getpid();
</del><ins>+    parameters.presentingApplicationPID = m_configuration->presentingApplicationPID();
</ins><span class="cx"> 
</span><span class="cx">     // Add any platform specific parameters
</span><span class="cx">     platformInitializeWebProcess(parameters);
</span></span></pre>
</div>
</div>

</body>
</html>