<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215222] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215222">215222</a></dd>
<dt>Author</dt> <dd>rego@igalia.com</dd>
<dt>Date</dt> <dd>2017-04-11 02:20:16 -0700 (Tue, 11 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
https://bugs.webkit.org/show_bug.cgi?id=167538
Reviewed by Darin Adler.
fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
as the caret was not always painted in the test runner.
The test was checking for a crash in simplified layout (see bug #163450)
and has nothing to do with the caret or "autofocus" behavior.
"autofocus" was needed to get the crash, so this change modifies
the test to blur the element, so the caret is not painted anymore.
* fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
Don't focus the input element.
* fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
the input element to avoid showing the caret.
* platform/mac-wk2/TestExpectations: Remove file from expectations.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridsimplifiedlayoutpositionedexpectedhtml">trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridsimplifiedlayoutpositionedhtml">trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (215221 => 215222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/ChangeLog        2017-04-11 09:20:16 UTC (rev 215222)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2017-04-11 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
+ https://bugs.webkit.org/show_bug.cgi?id=167538
+
+ Reviewed by Darin Adler.
+
+ fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
+ as the caret was not always painted in the test runner.
+ The test was checking for a crash in simplified layout (see bug #163450)
+ and has nothing to do with the caret or "autofocus" behavior.
+ "autofocus" was needed to get the crash, so this change modifies
+ the test to blur the element, so the caret is not painted anymore.
+
+ * fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
+ Don't focus the input element.
+ * fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
+ the input element to avoid showing the caret.
+ * platform/mac-wk2/TestExpectations: Remove file from expectations.
+
</ins><span class="cx"> 2017-04-10 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, test expectations update
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridsimplifiedlayoutpositionedexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html (215221 => 215222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html        2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html        2017-04-11 09:20:16 UTC (rev 215222)
</span><span class="lines">@@ -9,4 +9,4 @@
</span><span class="cx"> </style>
</span><span class="cx"> This text and input should appear at 100x100 position.
</span><span class="cx"> Like if they have a left and top margin of 100px.
</span><del>-<input autofocus>
</del><ins>+<input>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridsimplifiedlayoutpositionedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html (215221 => 215222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html        2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html        2017-04-11 09:20:16 UTC (rev 215222)
</span><span class="lines">@@ -15,3 +15,15 @@
</span><span class="cx"> This text and input should appear at 100x100 position.
</span><span class="cx"> Like if they have a left and top margin of 100px.
</span><span class="cx"> <input autofocus>
</span><ins>+<script>
+ if (window.testRunner)
+ window.testRunner.waitUntilDone();
+ // "autofocus" is needed to force the simplified layout call.
+ // We are removing the focus here to match the expected file and avoid issues with the caret.
+ // We need a small timeout so "blur()" is run after "autofocus".
+ setTimeout(function() {
+ document.querySelector("input").blur();
+ if (window.testRunner)
+ window.testRunner.notifyDone();
+ }, 100);
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (215221 => 215222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations        2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations        2017-04-11 09:20:16 UTC (rev 215222)
</span><span class="lines">@@ -613,8 +613,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/168065 inspector/unit-tests/heap-snapshot.html [ Pass Failure Timeout ]
</span><span class="cx">
</span><del>-webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
-
</del><span class="cx"> webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]
</span></span></pre>
</div>
</div>
</body>
</html>