<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215198] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215198">215198</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-10 12:59:26 -0700 (Mon, 10 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove deprecated parts of media stream spec
https://bugs.webkit.org/show_bug.cgi?id=169879
Patch by Youenn Fablet <youenn@apple.com> on 2017-04-10
Reviewed by Jon Lee.
Removing MediaStreamTrackState 'new' value which was unused.
Removing MediaStreamTrack _readonly attribute which was unused.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readonly): Deleted.
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
* platform/mediastream/MediaStreamTrackPrivate.h:
* platform/mediastream/RealtimeMediaSource.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackcpp">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackh">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackidl">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamMediaStreamTrackPrivatecpp">trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamMediaStreamTrackPrivateh">trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamRealtimeMediaSourcecpp">trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamRealtimeMediaSourceh">trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-04-10 Youenn Fablet <youenn@apple.com>
+
+ Remove deprecated parts of media stream spec
+ https://bugs.webkit.org/show_bug.cgi?id=169879
+
+ Reviewed by Jon Lee.
+
+ Removing MediaStreamTrackState 'new' value which was unused.
+ Removing MediaStreamTrack _readonly attribute which was unused.
+
+ * Modules/mediastream/MediaStreamTrack.cpp:
+ (WebCore::MediaStreamTrack::readonly): Deleted.
+ * Modules/mediastream/MediaStreamTrack.h:
+ * Modules/mediastream/MediaStreamTrack.idl:
+ * platform/mediastream/MediaStreamTrackPrivate.cpp:
+ (WebCore::MediaStreamTrackPrivate::readonly): Deleted.
+ * platform/mediastream/MediaStreamTrackPrivate.h:
+ * platform/mediastream/RealtimeMediaSource.h:
+
</ins><span class="cx"> 2017-04-10 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r215175.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -98,11 +98,6 @@
</span><span class="cx"> return m_private->muted();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MediaStreamTrack::readonly() const
-{
- return m_private->readonly();
-}
-
</del><span class="cx"> auto MediaStreamTrack::readyState() const -> State
</span><span class="cx"> {
</span><span class="cx"> return ended() ? State::Ended : State::Live;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -64,9 +64,8 @@
</span><span class="cx"> void setEnabled(bool);
</span><span class="cx">
</span><span class="cx"> bool muted() const;
</span><del>- bool readonly() const;
</del><span class="cx">
</span><del>- enum class State { New, Live, Ended };
</del><ins>+ enum class State { Live, Ended };
</ins><span class="cx"> State readyState() const;
</span><span class="cx">
</span><span class="cx"> bool ended() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> // FIXME 169871: remove "new"
</span><del>-enum MediaStreamTrackState { "new", "live", "ended" };
</del><ins>+enum MediaStreamTrackState { "live", "ended" };
</ins><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> ActiveDOMObject,
</span><span class="lines">@@ -53,9 +53,6 @@
</span><span class="cx"> Promise<void> applyConstraints(optional MediaTrackConstraints constraints);
</span><span class="cx">
</span><span class="cx"> attribute EventHandler onoverconstrained;
</span><del>-
- // FIXME 169871: legacy or remove?
- readonly attribute boolean _readonly;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> [
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamMediaStreamTrackPrivatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -80,11 +80,6 @@
</span><span class="cx"> return m_source->muted();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MediaStreamTrackPrivate::readonly() const
-{
- return m_source->readonly();
-}
-
</del><span class="cx"> bool MediaStreamTrackPrivate::isCaptureTrack() const
</span><span class="cx"> {
</span><span class="cx"> return m_source->isCaptureSource();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamMediaStreamTrackPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -71,7 +71,6 @@
</span><span class="cx"> bool muted() const;
</span><span class="cx"> void setMuted(bool muted) { m_source->setMuted(muted); }
</span><span class="cx">
</span><del>- bool readonly() const;
</del><span class="cx"> bool isCaptureTrack() const;
</span><span class="cx">
</span><span class="cx"> bool enabled() const { return m_isEnabled; }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamRealtimeMediaSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -63,7 +63,6 @@
</span><span class="cx"> {
</span><span class="cx"> m_stopped = false;
</span><span class="cx"> m_muted = false;
</span><del>- m_readonly = false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RealtimeMediaSource::addObserver(RealtimeMediaSource::Observer& observer)
</span><span class="lines">@@ -147,11 +146,6 @@
</span><span class="cx"> observer->audioSamplesAvailable(time, audioData, description, numberOfFrames);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool RealtimeMediaSource::readonly() const
-{
- return m_readonly;
-}
-
</del><span class="cx"> void RealtimeMediaSource::stop(Observer* callingObserver)
</span><span class="cx"> {
</span><span class="cx"> if (stopped())
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamRealtimeMediaSourceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (215197 => 215198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2017-04-10 19:59:26 UTC (rev 215198)
</span><span class="lines">@@ -133,9 +133,6 @@
</span><span class="cx"> virtual bool enabled() const { return m_enabled; }
</span><span class="cx"> virtual void setEnabled(bool);
</span><span class="cx">
</span><del>- virtual bool readonly() const;
- virtual void setReadonly(bool readonly) { m_readonly = readonly; }
-
</del><span class="cx"> virtual bool isCaptureSource() const { return false; }
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void addObserver(Observer&);
</span><span class="lines">@@ -228,7 +225,6 @@
</span><span class="cx">
</span><span class="cx"> bool m_echoCancellation { false };
</span><span class="cx"> bool m_stopped { false };
</span><del>- bool m_readonly { false };
</del><span class="cx"> bool m_pendingSettingsDidChangeNotification { false };
</span><span class="cx"> bool m_suppressNotifications { true };
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>