<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215205] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215205">215205</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-10 14:45:11 -0700 (Mon, 10 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add the UI for scheduling a A/B testing with a custom root
https://bugs.webkit.org/show_bug.cgi?id=170622
Reviewed by Anders Carlsson.
This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch
would update the syncing script to schedule such an A/B testing job to a buildbot instance.
* ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace
the file path for the backup.
* init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column
to store the root file in commit_set_relationships.
* public/api/build-requests.php:
(main): Include the uploaded files.
* public/api/commits.php:
(main): Added the support for querying the latest commits for a given platform. This is used in a new page
to create a custom analysis task to autofill the latest revisions for a given platform.
* public/api/test-groups.php:
(main): Include the uploaded files.
* public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::__construct): Added a list of uploaded_files and a map from its id.
(BuildRequestsFetcher::uploaded_files): Added.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added the support for including custom roots' id in
each commit set, and inserting its meta data in the list of uplaoded files.
* public/include/commit-log-fetcher.php:
(CommitLogFetcher::fetch_latest_for_platform): Added. Finds the latest commit for a given platform. Ideally,
we should be finding the latest commit for a given platform, but this is very slow so instead find the commit
of the latest build for a given platform.
* public/privileged-api/create-test-group.php:
(main): Added the support for creating an analysis task along with a group.
(commit_sets_from_revision_sets): Added the support for custom roots. Verify the specified uploaded file exists
and include it in commit_set_relationships. Because commits and upload files are stored in a different column
in commit_set_relationships, this function now stores the information for each row of commit_set_relationships
except the commit set ID, which is unknown until the set is created, instead of a commit ID.
(ensure_commit_sets): Made the each entry in a commit set a row instead of a commit ID as done. As this format
is only by v2 UI and detect-changes.js, we don't add the support for specifying custom roots here.
* public/privileged-api/upload-file.php:
(main): Fixed a typo. Also added one more error check.
* public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,
and a set of revisions, as well as custom roots for a custom A/B testing job. The first set of revision with
custom roots is referred as "baseline", and the second configuration is referred as "comparison" in this class.
(CustomAnalysisTaskConfigurator):
(CustomAnalysisTaskConfigurator.prototype.tests): Added.
(CustomAnalysisTaskConfigurator.prototype.platform): Added.
(CustomAnalysisTaskConfigurator.prototype.commitSets): Added. Returns a pair of baseline and comparsion if both
have been configured by the user.
(CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): Added.
(CustomAnalysisTaskConfigurator.prototype._configureComparison): Added. Called when the user is to configu the
"comparison" configuration.
(CustomAnalysisTaskConfigurator.prototype.render): Added.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests): Added. Renders the list of top-level tests
that can be scheduled by a triggerable.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerablePlatforms): Added. Renders the list of platforms
that can be schedule with the currently selected list of tests by a triggerable. Note that the current UI only
lets the user select a single test but the intent is to allow multiple tests to be selected in the near future.
(CustomAnalysisTaskConfigurator.prototype._buildCheckboxList): Added. Creates a list of radio boxes to select
an item with a callback for each. It automatically sets "selected" class on the selected item. It's used to
render both the list of tests and platforms.
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable): Added. Finds the triggerable for a given list of
tests and platforms. Returns an error when some tests belong to another triggearalbe.
(CustomAnalysisTaskConfigurator.prototype._updateRepositoryGroups): Added. Finds a repository group to use when
the current triggerable has changed. We try to use the repository group of the same name if there is any, and
defaults to the first repository group if there is none. This allows the set of repositories to be specified to
more or less persist across different triggerables. For example, if iOS platforms and Mac platforms use two
distinct triggerables , and both triggerables have two repository groups: one that only specify the OS and the
other that specifies both teh OS and WebKit revision, then this code allows the choice the user had made to
specify either just the OS or the OS and WebKit will be preserved when the user switches from an iOS platform
to a Mac platform.
(CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Added. Create a commit set map, the format that
TestGroup.createWithTask accepts given "baseline" and "comparison" commit sets. Pretend "comparison" is not set
if two sets are identical since it makes no sense to schedule an A/B testing job when A and B are identical.
(CustomAnalysisTaskConfigurator.prototype._computeCommitSet): Added. Creates a commit set using the revisions
and the csutom roots the user had specified.
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Added. Renders the pane to specify revisions
and custom roots for "baseline" and "comparison".
(CustomAnalysisTaskConfigurator.prototype._renderBaselineRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._renderComparisonRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._optionalRepositoryList): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionTable): Added. Creates a table for specifying revisions
and custom roots along with a list of repository groups to pick. The set of repositories and custom roots are
shown at the all if all repository groups require them. Otherwise, they are grouped at the bottom as optional.
(CustomAnalysisTaskConfigurator.prototype._buildRepositoryGroupList): Added.
(CustomAnalysisTaskConfigurator.prototype._selectRepositoryGroup): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionInput): Added. Creates an input element to specify
a revision for a given repository. Autofills it with the latest commit for the currently selected platform if
the user had not modified the field by the time the revisions are fetched.
(CustomAnalysisTaskConfigurator.htmlTemplate): Added.
(CustomAnalysisTaskConfigurator.cssTemplate): Added.
* public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"
or "comparison" configurations of CustomAnalysisTaskConfigurator. It's "instant" because it auto-detects when a
file to be uploaded had already been uploaded elsewhere by checking its SHA-256 hash.
(InstantFileUploader):
(InstantFileUploader.prototype.hasFileToUpload): Added.
(InstantFileUploader.prototype.uploadedFiles): Added.
(InstantFileUploader.prototype.addUploadedFile): Added. It's called on the uploader for "comparison"
configuration when the uploader for "baseline" configuration dipsatches "uploadedFile" action to automatically
mirror the newly uploaded custom root to "comparision" configuration.
(InstantFileUploader.prototype.didConstructShadowTree): Added.
(InstantFileUploader.prototype.render): Added.
(InstantFileUploader.prototype._renderUploadedFiles): Added. Renders the list of the uploaded files.
(InstantFileUploader.prototype._renderPreuploadFiles): Added. Renders the list of the files to be uploaded with
a progress bar.
(InstantFileUploader.prototype._updateUploadStatus): Added. Updates the progress bar for uploading the file.
(InstantFileUploader.prototype._formatUploadError): Added.
(InstantFileUploader.prototype._didFileInputChange): Added. Called when the user picks a file to uploaded on
the input element. Fetch the meta data for the uploaded file with the same SHA-256 hash if there is any, and
start uploading the file if there isn't one.
(InstantFileUploader.prototype._removeUploadedFile): Added.
(InstantFileUploader.prototype._didUploadFile): Added. Move a file from the list of files to be uploaded to
the list of uploaded files.
(InstantFileUploader.htmlTemplate): Added.
(InstantFileUploader.cssTemplate): Added.
* public/v3/index.html:
* public/v3/models/analysis-task.js:
(AnalysisTask): Made platform and metric optional as it is now.
(AnalysisTask.findByPlatformAndMetric): Skip analysis tasks without a platform or a metric.
(AnalysisTask.prototype.isCustom): Added. Returns true for a custom analysis task.
(AnalysisTask.fetchRelatedTasks): Skip custom analysis tasks.
(AnalysisTask._constructAnalysisTasksFromRawData): Construct analysis tasks even if they were missing a metric
or a platform instead of silently skipping them.
* public/v3/models/build-request.js:
(BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.
* public/v3/models/commit-log.js:
(CommitLog.fetchLatestCommitForPlatform): Added.
* public/v3/models/commit-set.js:
(CommitSet): Added this._customRoots.
(CommitSet.prototype.customRoots): Returns this._customRoots.
(CommitSet.prototype.equals): Returns false when the set of custom roots are not equal.
(CommitSet.areCustomRootsEqual): Added.
(CustomCommitSet):
(CustomCommitSet.prototype.equals): Added.
(CustomCommitSet.prototype.customRoots): Added.
(CustomCommitSet.prototype.addCustomRoot): Added.
* public/v3/models/manifest.js:
(Manifest._didFetchManifest): Store fileUploadSizeLimit in the manifest as UploadedFile.fileUploadSizeLimit.
This allows a file size check in the client size instead of uploading it to the server and receiving an error.
* public/v3/models/metric.js:
(Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.
* public/v3/models/test-group.js:
(TestGroup.prototype.createWithTask): Added.
(TestGroup.prototype.createAndRefetchTestGroups):
(TestGroup.prototype._revisionSetsFromCommitSets): Added. Extracted from createAndRefetchTestGroups.
(TestGroup.prototype._fetchTestGroupsForTask): Added. Extracted from createAndRefetchTestGroups.
* public/v3/models/triggerable.js:
(Triggerable.triggerablePlatformsForTests): Added.
(Triggerable.sortByNamePreferringSmallerRepositories): Added.
* public/v3/models/uploaded-file.js:
(UploadedFile.prototype.createdAt): Added.
(UploadedFile.prototype.filename): Added.
(UploadedFile.prototype.author): Added.
(UploadedFile.prototype.size): Added.
(UploadedFile.uploadFile): Added a client-side check for the file size using UploadedFile.fileUploadSizeLimit.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Ditto. Also fixed a bug that 404 was resulting in a rejected
promise instead of a resolved promise with null.
* public/v3/pages/analysis-category-page.js:
(AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
metric being null for some analysis tasks.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._didFetchTask): Don't fetch the measurement set or create a chart for custom tasks.
(AnalysisTaskPage.prototype.render): Don't display the charts or the stacking table for custom tasks.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus): Don't try to show the full test name for custom tasks
since it's not associated with exactly one pair.
* public/v3/pages/chart-pane-status-view.js:
(ChartPaneStatusView.prototype._renderBuildRevisionTable):
(ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.
* public/v3/pages/chart-pane.js:
(ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.
* public/v3/pages/create-analysis-task-page.js:
(CreateAnalysisTaskPage): This page now shows CustomAnalysisTaskConfigurator by default, and lets a user create
a custom analysis task by picking a test, a platform, and a set of revisions and custom darwinup roots.
(CreateAnalysisTaskPage.prototype.updateFromSerializedState): Show a message when inProgress is set. This is
the old behavior of this page.
(CreateAnalysisTaskPage.prototype.didConstructShadowTree): Added.
(CreateAnalysisTaskPage.prototype._createAnalysisTaskWithGroup): Added.
(CreateAnalysisTaskPage.prototype.render):
(CreateAnalysisTaskPage.prototype._renderMessage): Added. Hides CustomAnalysisTaskConfigurator and the select
element to specify the numebr of iterations when a message is set.
(CreateAnalysisTaskPage.htmlTemplate):
(CreateAnalysisTaskPage.cssTemplate):
* public/v3/pages/page-router.js:
(PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.
* server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of
uploaded files associated with build requests.
* server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task
and a test group with custom roots.
* server-tests/resources/mock-data.js:
(MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table.
* tools/js/remote.js: Include global.FormData from form-data.js.
* unit-tests/build-request-tests.js:
(sampleBuildRequestData): Updated the mock response.
* unit-tests/buildbot-syncer-tests.js:
(createSampleBuildRequest): Ditto.
* unit-tests/test-groups-tests.js:
(sampleTestGroup): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgReadMemd">trunk/Websites/perf.webkit.org/ReadMe.md</a></li>
<li><a href="#trunkWebsitesperfwebkitorginitdatabasesql">trunk/Websites/perf.webkit.org/init-database.sql</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapibuildrequestsphp">trunk/Websites/perf.webkit.org/public/api/build-requests.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapicommitsphp">trunk/Websites/perf.webkit.org/public/api/commits.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapitestgroupsphp">trunk/Websites/perf.webkit.org/public/api/test-groups.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludebuildrequestsfetcherphp">trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludecommitlogfetcherphp">trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicprivilegedapicreatetestgroupphp">trunk/Websites/perf.webkit.org/public/privileged-api/create-test-group.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicprivilegedapiuploadfilephp">trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3indexhtml">trunk/Websites/perf.webkit.org/public/v3/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsanalysistaskjs">trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsbuildrequestjs">trunk/Websites/perf.webkit.org/public/v3/models/build-request.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelscommitlogjs">trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelscommitsetjs">trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmanifestjs">trunk/Websites/perf.webkit.org/public/v3/models/manifest.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmetricjs">trunk/Websites/perf.webkit.org/public/v3/models/metric.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelstestgroupjs">trunk/Websites/perf.webkit.org/public/v3/models/test-group.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelstriggerablejs">trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsuploadedfilejs">trunk/Websites/perf.webkit.org/public/v3/models/uploaded-file.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagesanalysiscategorypagejs">trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagesanalysistaskpagejs">trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pageschartpanestatusviewjs">trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane-status-view.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pageschartpanejs">trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagescreateanalysistaskpagejs">trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagespagerouterjs">trunk/Websites/perf.webkit.org/public/v3/pages/page-router.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgservertestsapibuildrequeststestsjs">trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgservertestsprivilegedapicreatetestgrouptestsjs">trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgservertestsresourcesmockdatajs">trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtoolsjsremotejs">trunk/Websites/perf.webkit.org/tools/js/remote.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgunittestsbuildrequesttestsjs">trunk/Websites/perf.webkit.org/unit-tests/build-request-tests.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgunittestsbuildbotsyncertestsjs">trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgunitteststestgroupstestsjs">trunk/Websites/perf.webkit.org/unit-tests/test-groups-tests.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentscustomanalysistaskconfiguratorjs">trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentsinstantfileuploaderjs">trunk/Websites/perf.webkit.org/public/v3/components/instant-file-uploader.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -1,3 +1,233 @@
</span><ins>+2017-04-10 Ryosuke Niwa <rniwa@webkit.org>
+
+ Add the UI for scheduling a A/B testing with a custom root
+ https://bugs.webkit.org/show_bug.cgi?id=170622
+
+ Reviewed by Anders Carlsson.
+
+ This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch
+ would update the syncing script to schedule such an A/B testing job to a buildbot instance.
+
+
+ * ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace
+ the file path for the backup.
+
+ * init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column
+ to store the root file in commit_set_relationships.
+
+ * public/api/build-requests.php:
+ (main): Include the uploaded files.
+
+ * public/api/commits.php:
+ (main): Added the support for querying the latest commits for a given platform. This is used in a new page
+ to create a custom analysis task to autofill the latest revisions for a given platform.
+
+ * public/api/test-groups.php:
+ (main): Include the uploaded files.
+
+ * public/include/build-requests-fetcher.php:
+ (BuildRequestsFetcher::__construct): Added a list of uploaded_files and a map from its id.
+ (BuildRequestsFetcher::uploaded_files): Added.
+ (BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added the support for including custom roots' id in
+ each commit set, and inserting its meta data in the list of uplaoded files.
+
+ * public/include/commit-log-fetcher.php:
+ (CommitLogFetcher::fetch_latest_for_platform): Added. Finds the latest commit for a given platform. Ideally,
+ we should be finding the latest commit for a given platform, but this is very slow so instead find the commit
+ of the latest build for a given platform.
+
+ * public/privileged-api/create-test-group.php:
+ (main): Added the support for creating an analysis task along with a group.
+ (commit_sets_from_revision_sets): Added the support for custom roots. Verify the specified uploaded file exists
+ and include it in commit_set_relationships. Because commits and upload files are stored in a different column
+ in commit_set_relationships, this function now stores the information for each row of commit_set_relationships
+ except the commit set ID, which is unknown until the set is created, instead of a commit ID.
+ (ensure_commit_sets): Made the each entry in a commit set a row instead of a commit ID as done. As this format
+ is only by v2 UI and detect-changes.js, we don't add the support for specifying custom roots here.
+
+ * public/privileged-api/upload-file.php:
+ (main): Fixed a typo. Also added one more error check.
+
+ * public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,
+ and a set of revisions, as well as custom roots for a custom A/B testing job. The first set of revision with
+ custom roots is referred as "baseline", and the second configuration is referred as "comparison" in this class.
+ (CustomAnalysisTaskConfigurator):
+ (CustomAnalysisTaskConfigurator.prototype.tests): Added.
+ (CustomAnalysisTaskConfigurator.prototype.platform): Added.
+ (CustomAnalysisTaskConfigurator.prototype.commitSets): Added. Returns a pair of baseline and comparsion if both
+ have been configured by the user.
+ (CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): Added.
+ (CustomAnalysisTaskConfigurator.prototype._configureComparison): Added. Called when the user is to configu the
+ "comparison" configuration.
+ (CustomAnalysisTaskConfigurator.prototype.render): Added.
+ (CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests): Added. Renders the list of top-level tests
+ that can be scheduled by a triggerable.
+ (CustomAnalysisTaskConfigurator.prototype._renderTriggerablePlatforms): Added. Renders the list of platforms
+ that can be schedule with the currently selected list of tests by a triggerable. Note that the current UI only
+ lets the user select a single test but the intent is to allow multiple tests to be selected in the near future.
+ (CustomAnalysisTaskConfigurator.prototype._buildCheckboxList): Added. Creates a list of radio boxes to select
+ an item with a callback for each. It automatically sets "selected" class on the selected item. It's used to
+ render both the list of tests and platforms.
+ (CustomAnalysisTaskConfigurator.prototype._updateTriggerable): Added. Finds the triggerable for a given list of
+ tests and platforms. Returns an error when some tests belong to another triggearalbe.
+ (CustomAnalysisTaskConfigurator.prototype._updateRepositoryGroups): Added. Finds a repository group to use when
+ the current triggerable has changed. We try to use the repository group of the same name if there is any, and
+ defaults to the first repository group if there is none. This allows the set of repositories to be specified to
+ more or less persist across different triggerables. For example, if iOS platforms and Mac platforms use two
+ distinct triggerables , and both triggerables have two repository groups: one that only specify the OS and the
+ other that specifies both teh OS and WebKit revision, then this code allows the choice the user had made to
+ specify either just the OS or the OS and WebKit will be preserved when the user switches from an iOS platform
+ to a Mac platform.
+ (CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Added. Create a commit set map, the format that
+ TestGroup.createWithTask accepts given "baseline" and "comparison" commit sets. Pretend "comparison" is not set
+ if two sets are identical since it makes no sense to schedule an A/B testing job when A and B are identical.
+ (CustomAnalysisTaskConfigurator.prototype._computeCommitSet): Added. Creates a commit set using the revisions
+ and the csutom roots the user had specified.
+ (CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Added. Renders the pane to specify revisions
+ and custom roots for "baseline" and "comparison".
+ (CustomAnalysisTaskConfigurator.prototype._renderBaselineRevisionTable): Added.
+ (CustomAnalysisTaskConfigurator.prototype._renderComparisonRevisionTable): Added.
+ (CustomAnalysisTaskConfigurator.prototype._optionalRepositoryList): Added.
+ (CustomAnalysisTaskConfigurator.prototype._buildRevisionTable): Added. Creates a table for specifying revisions
+ and custom roots along with a list of repository groups to pick. The set of repositories and custom roots are
+ shown at the all if all repository groups require them. Otherwise, they are grouped at the bottom as optional.
+ (CustomAnalysisTaskConfigurator.prototype._buildRepositoryGroupList): Added.
+ (CustomAnalysisTaskConfigurator.prototype._selectRepositoryGroup): Added.
+ (CustomAnalysisTaskConfigurator.prototype._buildRevisionInput): Added. Creates an input element to specify
+ a revision for a given repository. Autofills it with the latest commit for the currently selected platform if
+ the user had not modified the field by the time the revisions are fetched.
+ (CustomAnalysisTaskConfigurator.htmlTemplate): Added.
+ (CustomAnalysisTaskConfigurator.cssTemplate): Added.
+
+ * public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"
+ or "comparison" configurations of CustomAnalysisTaskConfigurator. It's "instant" because it auto-detects when a
+ file to be uploaded had already been uploaded elsewhere by checking its SHA-256 hash.
+ (InstantFileUploader):
+ (InstantFileUploader.prototype.hasFileToUpload): Added.
+ (InstantFileUploader.prototype.uploadedFiles): Added.
+ (InstantFileUploader.prototype.addUploadedFile): Added. It's called on the uploader for "comparison"
+ configuration when the uploader for "baseline" configuration dipsatches "uploadedFile" action to automatically
+ mirror the newly uploaded custom root to "comparision" configuration.
+ (InstantFileUploader.prototype.didConstructShadowTree): Added.
+ (InstantFileUploader.prototype.render): Added.
+ (InstantFileUploader.prototype._renderUploadedFiles): Added. Renders the list of the uploaded files.
+ (InstantFileUploader.prototype._renderPreuploadFiles): Added. Renders the list of the files to be uploaded with
+ a progress bar.
+ (InstantFileUploader.prototype._updateUploadStatus): Added. Updates the progress bar for uploading the file.
+ (InstantFileUploader.prototype._formatUploadError): Added.
+ (InstantFileUploader.prototype._didFileInputChange): Added. Called when the user picks a file to uploaded on
+ the input element. Fetch the meta data for the uploaded file with the same SHA-256 hash if there is any, and
+ start uploading the file if there isn't one.
+ (InstantFileUploader.prototype._removeUploadedFile): Added.
+ (InstantFileUploader.prototype._didUploadFile): Added. Move a file from the list of files to be uploaded to
+ the list of uploaded files.
+ (InstantFileUploader.htmlTemplate): Added.
+ (InstantFileUploader.cssTemplate): Added.
+
+ * public/v3/index.html:
+
+ * public/v3/models/analysis-task.js:
+ (AnalysisTask): Made platform and metric optional as it is now.
+ (AnalysisTask.findByPlatformAndMetric): Skip analysis tasks without a platform or a metric.
+ (AnalysisTask.prototype.isCustom): Added. Returns true for a custom analysis task.
+ (AnalysisTask.fetchRelatedTasks): Skip custom analysis tasks.
+ (AnalysisTask._constructAnalysisTasksFromRawData): Construct analysis tasks even if they were missing a metric
+ or a platform instead of silently skipping them.
+
+ * public/v3/models/build-request.js:
+ (BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.
+
+ * public/v3/models/commit-log.js:
+ (CommitLog.fetchLatestCommitForPlatform): Added.
+
+ * public/v3/models/commit-set.js:
+ (CommitSet): Added this._customRoots.
+ (CommitSet.prototype.customRoots): Returns this._customRoots.
+ (CommitSet.prototype.equals): Returns false when the set of custom roots are not equal.
+ (CommitSet.areCustomRootsEqual): Added.
+ (CustomCommitSet):
+ (CustomCommitSet.prototype.equals): Added.
+ (CustomCommitSet.prototype.customRoots): Added.
+ (CustomCommitSet.prototype.addCustomRoot): Added.
+
+ * public/v3/models/manifest.js:
+ (Manifest._didFetchManifest): Store fileUploadSizeLimit in the manifest as UploadedFile.fileUploadSizeLimit.
+ This allows a file size check in the client size instead of uploading it to the server and receiving an error.
+
+ * public/v3/models/metric.js:
+ (Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.
+
+ * public/v3/models/test-group.js:
+ (TestGroup.prototype.createWithTask): Added.
+ (TestGroup.prototype.createAndRefetchTestGroups):
+ (TestGroup.prototype._revisionSetsFromCommitSets): Added. Extracted from createAndRefetchTestGroups.
+ (TestGroup.prototype._fetchTestGroupsForTask): Added. Extracted from createAndRefetchTestGroups.
+
+ * public/v3/models/triggerable.js:
+ (Triggerable.triggerablePlatformsForTests): Added.
+ (Triggerable.sortByNamePreferringSmallerRepositories): Added.
+
+ * public/v3/models/uploaded-file.js:
+ (UploadedFile.prototype.createdAt): Added.
+ (UploadedFile.prototype.filename): Added.
+ (UploadedFile.prototype.author): Added.
+ (UploadedFile.prototype.size): Added.
+ (UploadedFile.uploadFile): Added a client-side check for the file size using UploadedFile.fileUploadSizeLimit.
+ (UploadedFile.fetchUnloadedFileWithIdenticalHash): Ditto. Also fixed a bug that 404 was resulting in a rejected
+ promise instead of a resolved promise with null.
+
+ * public/v3/pages/analysis-category-page.js:
+ (AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
+ metric being null for some analysis tasks.
+
+ * public/v3/pages/analysis-task-page.js:
+ (AnalysisTaskPage.prototype._didFetchTask): Don't fetch the measurement set or create a chart for custom tasks.
+ (AnalysisTaskPage.prototype.render): Don't display the charts or the stacking table for custom tasks.
+ (AnalysisTaskPage.prototype._renderTaskNameAndStatus): Don't try to show the full test name for custom tasks
+ since it's not associated with exactly one pair.
+
+ * public/v3/pages/chart-pane-status-view.js:
+ (ChartPaneStatusView.prototype._renderBuildRevisionTable):
+ (ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.
+
+ * public/v3/pages/chart-pane.js:
+ (ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
+ CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.
+
+ * public/v3/pages/create-analysis-task-page.js:
+ (CreateAnalysisTaskPage): This page now shows CustomAnalysisTaskConfigurator by default, and lets a user create
+ a custom analysis task by picking a test, a platform, and a set of revisions and custom darwinup roots.
+ (CreateAnalysisTaskPage.prototype.updateFromSerializedState): Show a message when inProgress is set. This is
+ the old behavior of this page.
+ (CreateAnalysisTaskPage.prototype.didConstructShadowTree): Added.
+ (CreateAnalysisTaskPage.prototype._createAnalysisTaskWithGroup): Added.
+ (CreateAnalysisTaskPage.prototype.render):
+ (CreateAnalysisTaskPage.prototype._renderMessage): Added. Hides CustomAnalysisTaskConfigurator and the select
+ element to specify the numebr of iterations when a message is set.
+ (CreateAnalysisTaskPage.htmlTemplate):
+ (CreateAnalysisTaskPage.cssTemplate):
+
+ * public/v3/pages/page-router.js:
+ (PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.
+
+ * server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of
+ uploaded files associated with build requests.
+
+ * server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task
+ and a test group with custom roots.
+
+ * server-tests/resources/mock-data.js:
+ (MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table.
+
+ * tools/js/remote.js: Include global.FormData from form-data.js.
+
+ * unit-tests/build-request-tests.js:
+ (sampleBuildRequestData): Updated the mock response.
+ * unit-tests/buildbot-syncer-tests.js:
+ (createSampleBuildRequest): Ditto.
+ * unit-tests/test-groups-tests.js:
+ (sampleTestGroup): Ditto.
+
</ins><span class="cx"> 2017-04-10 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r215202.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgReadMemd"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ReadMe.md (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ReadMe.md 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/ReadMe.md 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -71,11 +71,11 @@
</span><span class="cx">
</span><span class="cx"> Use `pg_dump` and `pg_restore` to backup and restore the database. If you're replicating the production database for development purposes, you may consider excluding `run_iterations` table, which takes up 2/3 of the storage space, to reduce the size of the database for your local copy. Adjust the number of concurrent processes to use by `--jobs` and adjust the compression level by `--compress` (0 is no compression, 9 is most compressed).
</span><span class="cx">
</span><del>-- Making the fullbackup of the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --file=<path to backup directory> --jobs=4 --no-owner --compress=7`
</del><ins>+- Making the fullbackup of the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --jobs=4 --no-owner --compress=7 --file=<path to backup directory>`
</ins><span class="cx">
</span><del>-- Making an abridged backup without `run_iterations` table: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --file=<path to backup directory> --jobs=4 --no-owner --compress=7 --exclude-table=run_iterations`
</del><ins>+- Making an abridged backup without `run_iterations` table: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --jobs=4 --no-owner --compress=7 --exclude-table=run_iterations --file=<path to backup directory>`
</ins><span class="cx">
</span><del>-- Restoring the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_restore --format=directory --jobs=4 --no-owner --host localhost --username=webkit-perf-db-user <path to backup directory> --dbname=webkit-perf-db`
</del><ins>+- Restoring the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_restore --format=directory --jobs=4 --no-owner --host localhost --username=webkit-perf-db-user --dbname=webkit-perf-db <path to backup directory>`
</ins><span class="cx">
</span><span class="cx"> ## Configuring Apache
</span><span class="cx">
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx">
</span><span class="cx"> ### Instructions if you're not using Server.app
</span><span class="cx">
</span><del>- - Edit /private/etc/apache2/httpd.conf
</del><ins>+ - Edit `/private/etc/apache2/httpd.conf`
</ins><span class="cx">
</span><span class="cx"> 1. Change DocumentRoot to `/Volumes/Data/perf.webkit.org/public/`
</span><span class="cx"> 2. Uncomment `LoadModule php5_module libexec/apache2/libphp5.so`
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorginitdatabasesql"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/init-database.sql (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/init-database.sql 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/init-database.sql 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -204,8 +204,8 @@
</span><span class="cx"> task_segmentation integer REFERENCES analysis_strategies,
</span><span class="cx"> task_test_range integer REFERENCES analysis_strategies,
</span><span class="cx"> task_created_at timestamp NOT NULL DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC'),
</span><del>- task_platform integer REFERENCES platforms NOT NULL,
- task_metric integer REFERENCES test_metrics NOT NULL,
</del><ins>+ task_platform integer REFERENCES platforms,
+ task_metric integer REFERENCES test_metrics,
</ins><span class="cx"> task_start_run integer REFERENCES test_runs,
</span><span class="cx"> task_start_run_time timestamp,
</span><span class="cx"> task_end_run integer REFERENCES test_runs,
</span><span class="lines">@@ -213,8 +213,13 @@
</span><span class="cx"> task_result analysis_task_result_type,
</span><span class="cx"> task_needed boolean,
</span><span class="cx"> CONSTRAINT analysis_task_should_be_unique_for_range UNIQUE(task_start_run, task_end_run),
</span><del>- CONSTRAINT analysis_task_should_not_be_associated_with_single_run
- CHECK ((task_start_run IS NULL AND task_end_run IS NULL) OR (task_start_run IS NOT NULL AND task_end_run IS NOT NULL)));
</del><ins>+ CONSTRAINT analysis_task_must_be_associated_with_run_or_be_custom
+ CHECK ((task_start_run IS NULL AND task_start_run_time IS NULL
+ AND task_end_run IS NULL AND task_end_run_time IS NULL
+ AND task_platform IS NULL AND task_metric IS NULL)
+ OR (task_start_run IS NOT NULL AND task_start_run_time IS NOT NULL
+ AND task_end_run IS NOT NULL AND task_end_run_time IS NOT NULL
+ AND task_platform IS NOT NULL AND task_metric IS NOT NULL)));
</ins><span class="cx">
</span><span class="cx"> CREATE TABLE task_commits (
</span><span class="cx"> taskcommit_task integer NOT NULL REFERENCES analysis_tasks ON DELETE CASCADE,
</span><span class="lines">@@ -280,7 +285,9 @@
</span><span class="cx">
</span><span class="cx"> CREATE TABLE commit_set_relationships (
</span><span class="cx"> commitset_set integer REFERENCES commit_sets NOT NULL,
</span><del>- commitset_commit integer REFERENCES commits NOT NULL);
</del><ins>+ commitset_commit integer REFERENCES commits,
+ commitset_root_file integer REFERENCES uploaded_files,
+ CONSTRAINT commitset_must_have_commit_or_root CHECK (commitset_commit IS NOT NULL OR commitset_root_file IS NOT NULL));
</ins><span class="cx">
</span><span class="cx"> CREATE TYPE build_request_status_type as ENUM ('pending', 'scheduled', 'running', 'failed', 'completed', 'canceled');
</span><span class="cx"> CREATE TABLE build_requests (
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapibuildrequestsphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/build-requests.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/build-requests.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/api/build-requests.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> 'buildRequests' => $resolve_id ? $requests_fetcher->results_with_resolved_ids() : $requests_fetcher->results(),
</span><span class="cx"> 'commitSets' => $requests_fetcher->commit_sets(),
</span><span class="cx"> 'commits' => $requests_fetcher->commits(),
</span><ins>+ 'uploadedFiles' => $requests_fetcher->uploaded_files(),
</ins><span class="cx"> ));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapicommitsphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/commits.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/commits.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/api/commits.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -30,7 +30,14 @@
</span><span class="cx"> } else if ($filter == 'oldest') {
</span><span class="cx"> $commits = $fetcher->fetch_oldest($repository_id);
</span><span class="cx"> } else if ($filter == 'latest') {
</span><del>- $commits = $fetcher->fetch_latest($repository_id);
</del><ins>+ $platform_id = array_get($_GET, 'platform');
+ if ($platform_id) {
+ if (!is_numeric($platform_id))
+ exit_with_error('InvalidPlatform', array('platform' => $platform_id));
+ $platform_id = intval($platform_id);
+ $commits = $fetcher->fetch_latest_for_platform($repository_id, $platform_id);
+ } else
+ $commits = $fetcher->fetch_latest($repository_id);
</ins><span class="cx"> } else if ($filter == 'last-reported') {
</span><span class="cx"> $from = array_get($_GET, 'from');
</span><span class="cx"> $to = array_get($_GET, 'to');
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapitestgroupsphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/test-groups.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/test-groups.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/api/test-groups.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -55,7 +55,8 @@
</span><span class="cx"> exit_with_success(array('testGroups' => $test_groups,
</span><span class="cx"> 'buildRequests' => $build_requests,
</span><span class="cx"> 'commitSets' => $build_requests_fetcher->commit_sets(),
</span><del>- 'commits' => $build_requests_fetcher->commits()));
</del><ins>+ 'commits' => $build_requests_fetcher->commits(),
+ 'uploadedFiles' => $build_requests_fetcher->uploaded_files()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function format_test_group($group_row) {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludebuildrequestsfetcherphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -1,6 +1,7 @@
</span><span class="cx"> <?php
</span><span class="cx">
</span><span class="cx"> require_once('test-path-resolver.php');
</span><ins>+require_once('uploaded-file-helpers.php');
</ins><span class="cx">
</span><span class="cx"> class BuildRequestsFetcher {
</span><span class="cx"> function __construct($db) {
</span><span class="lines">@@ -10,6 +11,8 @@
</span><span class="cx"> $this->commits_by_id = array();
</span><span class="cx"> $this->commits = array();
</span><span class="cx"> $this->commit_sets_by_id = array();
</span><ins>+ $this->uploaded_files = array();
+ $this->uploaded_files_by_id = array();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function fetch_for_task($task_id) {
</span><span class="lines">@@ -83,27 +86,37 @@
</span><span class="cx"> return $requests;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function commit_sets() {
- return $this->commit_sets;
- }
</del><ins>+ function commit_sets() { return $this->commit_sets; }
+ function commits() { return $this->commits; }
+ function uploaded_files() { return $this->uploaded_files; }
</ins><span class="cx">
</span><del>- function commits() {
- return $this->commits;
- }
-
</del><span class="cx"> private function fetch_commits_for_set_if_needed($commit_set_id, $resolve_ids) {
</span><span class="cx"> if (array_key_exists($commit_set_id, $this->commit_sets_by_id))
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> $commit_rows = $this->db->query_and_fetch_all('SELECT *
</span><del>- FROM commit_set_relationships, commits LEFT OUTER JOIN repositories ON commit_repository = repository_id
- WHERE commitset_commit = commit_id AND commitset_set = $1', array($commit_set_id));
</del><ins>+ FROM commit_set_relationships LEFT OUTER JOIN commits ON commitset_commit = commit_id
+ LEFT OUTER JOIN repositories ON repository_id = commit_repository
+ WHERE commitset_set = $1', array($commit_set_id));
</ins><span class="cx">
</span><span class="cx"> $commit_ids = array();
</span><ins>+ $custom_roots = array();
+
</ins><span class="cx"> foreach ($commit_rows as $row) {
</span><span class="cx"> $repository_id = $resolve_ids ? $row['repository_name'] : $row['repository_id'];
</span><span class="cx"> $revision = $row['commit_revision'];
</span><span class="cx"> $commit_time = $row['commit_time'];
</span><ins>+
+ $root_file_id = $row['commitset_root_file'];
+ if ($root_file_id) {
+ if (!array_key_exists($root_file_id, $this->uploaded_files_by_id)) {
+ $uploaded_file_row = $this->db->select_first_row('uploaded_files', 'file', array('id' => $root_file_id));
+ array_push($this->uploaded_files, format_uploaded_file($uploaded_file_row));
+ }
+ array_push($custom_roots, $root_file_id);
+ continue;
+ }
+
</ins><span class="cx"> array_push($commit_ids, $row['commit_id']);
</span><span class="cx">
</span><span class="cx"> $commit_id = $row['commit_id'];
</span><span class="lines">@@ -121,7 +134,7 @@
</span><span class="cx">
</span><span class="cx"> $this->commit_sets_by_id[$commit_set_id] = TRUE;
</span><span class="cx">
</span><del>- array_push($this->commit_sets, array('id' => $commit_set_id, 'commits' => $commit_ids));
</del><ins>+ array_push($this->commit_sets, array('id' => $commit_set_id, 'commits' => $commit_ids, 'customRoots' => $custom_roots));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludecommitlogfetcherphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -118,6 +118,28 @@
</span><span class="cx"> return $this->format_single_commit($this->db->select_last_row('commits', 'commit', array('repository' => $repository_id), array('time', 'order')));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ function fetch_latest_for_platform($repository_id, $platform_id)
+ {
+ $query_result = $this->db->query_and_fetch_all("SELECT commits.* FROM test_runs, builds, build_commits, commits
+ WHERE run_build = build_id AND NOT EXISTS (SELECT * FROM build_requests WHERE request_build = build_id)
+ AND run_config IN (SELECT config_id FROM test_configurations
+ WHERE config_type = 'current' AND config_platform = $2 AND config_metric
+ IN (SELECT metric_id FROM test_metrics, tests WHERE metric_id = test_id and test_parent IS NULL))
+ AND run_build = build_id AND commit_build = build_id AND build_commit = commit_id AND commit_repository = $1
+ ORDER BY build_time DESC LIMIT 1;", array($repository_id, $platform_id));
+ /* This query is approximation. It finds the commit of the last build instead of the last commit.
+ We would ideally run the following query but it's much slower ~70s compared to 300ms.
+ SELECT commits.*, commit_build, run_id
+ FROM commits, build_commits, test_runs
+ WHERE commit_repository = 9 AND commit_id = build_commit AND commit_build = run_build
+ AND run_config IN (SELECT config_id FROM test_configurations WHERE config_platform = 38 AND config_type = 'current')
+ AND NOT EXISTS (SELECT * FROM build_requests WHERE request_build = commit_build)
+ ORDER BY commit_time DESC, commit_order DESC LIMIT 1; */
+ if (!$query_result)
+ return array();
+ return $this->format_single_commit($query_result[0]);
+ }
+
</ins><span class="cx"> function fetch_last_reported($repository_id) {
</span><span class="cx"> return $this->format_single_commit($this->db->select_last_row('commits', 'commit', array('repository' => $repository_id, 'reported' => true), array('time', 'order')));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicprivilegedapicreatetestgroupphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/privileged-api/create-test-group.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/privileged-api/create-test-group.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/privileged-api/create-test-group.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -11,16 +11,28 @@
</span><span class="cx">
</span><span class="cx"> $arguments = validate_arguments($data, array(
</span><span class="cx"> 'name' => '/.+/',
</span><del>- 'task' => 'int',
</del><ins>+ 'task' => 'int?',
</ins><span class="cx"> 'repetitionCount' => 'int?',
</span><span class="cx"> ));
</span><span class="cx"> $name = $arguments['name'];
</span><del>- $task_id = $arguments['task'];
</del><ins>+ $task_id = array_get($arguments, 'task');
+ $task_name = array_get($data, 'taskName');
</ins><span class="cx"> $repetition_count = $arguments['repetitionCount'];
</span><ins>+ $platform_id = array_get($data, 'platform');
+ $test_id = array_get($data, 'test');
</ins><span class="cx"> $revision_set_list = array_get($data, 'revisionSets');
</span><span class="cx"> $commit_sets_info = array_get($data, 'commitSets');
</span><span class="cx">
</span><del>- require_format('Task', $task_id, '/^\d+$/');
</del><ins>+ if (!$task_id == !$task_name)
+ exit_with_error('InvalidTask');
+
+ if ($task_id)
+ require_format('Task', $task_id, '/^\d+$/');
+ if ($task_name || $platform_id || $test_id) {
+ require_format('Platform', $platform_id, '/^\d+$/');
+ require_format('Test', $test_id, '/^\d+$/');
+ }
+
</ins><span class="cx"> if (!$revision_set_list && !$commit_sets_info)
</span><span class="cx"> exit_with_error('InvalidCommitSets');
</span><span class="cx">
</span><span class="lines">@@ -29,39 +41,65 @@
</span><span class="cx"> else if ($repetition_count < 1)
</span><span class="cx"> exit_with_error('InvalidRepetitionCount', array('repetitionCount' => $repetition_count));
</span><span class="cx">
</span><del>- $task = $db->select_first_row('analysis_tasks', 'task', array('id' => $task_id));
- if (!$task)
- exit_with_error('InvalidTask', array('task' => $task_id));
- $triggerable = find_triggerable_for_task($db, $task_id);
- if (!$triggerable)
- exit_with_error('TriggerableNotFoundForTask', array('task' => $task_id));
</del><ins>+ $triggerable_id = NULL;
+ if ($task_id) {
+ $task = $db->select_first_row('analysis_tasks', 'task', array('id' => $task_id));
+ if (!$task)
+ exit_with_error('InvalidTask', array('task' => $task_id));
+ $triggerable = find_triggerable_for_task($db, $task_id);
+ if ($triggerable) {
+ $triggerable_id = $triggerable['id'];
+ if (!$platform_id && !$test_id) {
+ $platform_id = $triggerable['platform'];
+ $test_id = $triggerable['test'];
+ } else {
+ if ($triggerable['platform'] && $platform_id != $triggerable['platform'])
+ exit_with_error('InconsistentPlatform', array('groupPlatform' => $platform_id, 'taskPlatform' => $triggerable['platform']));
+ if ($triggerable['test'] && $test_id != $triggerable['test'])
+ exit_with_error('InconsistentTest', array('groupTest' => $test_id, 'taskTest' => $triggerable['test']));
+ }
+ }
+ } else if ($platform_id && $test_id) {
+ $triggerable_configuration = $db->select_first_row('triggerable_configurations', 'trigconfig',
+ array('test' => $test_id, 'platform' => $platform_id));
+ if ($triggerable_configuration)
+ $triggerable_id = $triggerable_configuration['trigconfig_triggerable'];
+ }
</ins><span class="cx">
</span><ins>+ if (!$triggerable_id)
+ exit_with_error('TriggerableNotFoundForTask', array('task' => $task_id, 'platform' => $platform_id, 'test' => $test_id));
+
</ins><span class="cx"> if ($revision_set_list)
</span><del>- $commit_sets = commit_sets_from_revision_sets($db, $triggerable['id'], $revision_set_list);
</del><ins>+ $commit_sets = commit_sets_from_revision_sets($db, $triggerable_id, $revision_set_list);
</ins><span class="cx"> else // V2 UI compatibility
</span><del>- $commit_sets = ensure_commit_sets($db, $triggerable['id'], $commit_sets_info);
</del><ins>+ $commit_sets = ensure_commit_sets($db, $triggerable_id, $commit_sets_info);
</ins><span class="cx">
</span><span class="cx"> $db->begin_transaction();
</span><span class="cx">
</span><ins>+ if ($task_name)
+ $task_id = $db->insert_row('analysis_tasks', 'task', array('name' => $task_name, 'author' => $author));
+
</ins><span class="cx"> $configuration_list = array();
</span><span class="cx"> foreach ($commit_sets as $commit_list) {
</span><span class="cx"> $commit_set_id = $db->insert_row('commit_sets', 'commitset', array());
</span><del>- foreach ($commit_list['set'] as $commit)
- $db->insert_row('commit_set_relationships', 'commitset', array('set' => $commit_set_id, 'commit' => $commit), 'commit');
</del><ins>+ foreach ($commit_list['set'] as $commit_row) {
+ $commit_row['set'] = $commit_set_id;
+ $db->insert_row('commit_set_relationships', 'commitset', $commit_row, 'commit');
+ }
</ins><span class="cx"> array_push($configuration_list, array('commit_set' => $commit_set_id, 'repository_group' => $commit_list['repository_group']));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $group_id = $db->insert_row('analysis_test_groups', 'testgroup',
</span><del>- array('task' => $task['task_id'], 'name' => $name, 'author' => $author));
</del><ins>+ array('task' => $task_id, 'name' => $name, 'author' => $author));
</ins><span class="cx">
</span><span class="cx"> $order = 0;
</span><span class="cx"> for ($i = 0; $i < $repetition_count; $i++) {
</span><span class="cx"> foreach ($configuration_list as $config) {
</span><span class="cx"> $db->insert_row('build_requests', 'request', array(
</span><del>- 'triggerable' => $triggerable['id'],
</del><ins>+ 'triggerable' => $triggerable_id,
</ins><span class="cx"> 'repository_group' => $config['repository_group'],
</span><del>- 'platform' => $triggerable['platform'],
- 'test' => $triggerable['test'],
</del><ins>+ 'platform' => $platform_id,
+ 'test' => $test_id,
</ins><span class="cx"> 'group' => $group_id,
</span><span class="cx"> 'order' => $order,
</span><span class="cx"> 'commit_set' => $config['commit_set'],));
</span><span class="lines">@@ -71,7 +109,7 @@
</span><span class="cx">
</span><span class="cx"> $db->commit_transaction();
</span><span class="cx">
</span><del>- exit_with_success(array('testGroupId' => $group_id));
</del><ins>+ exit_with_success(array('taskId' => $task_id, 'testGroupId' => $group_id));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function commit_sets_from_revision_sets($db, $triggerable_id, $revision_set_list)
</span><span class="lines">@@ -87,8 +125,16 @@
</span><span class="cx">
</span><span class="cx"> $commit_set = array();
</span><span class="cx"> $repository_list = array();
</span><del>-
</del><span class="cx"> foreach ($revision_set as $repository_id => $revision) {
</span><ins>+ if ($repository_id == 'customRoots') {
+ $file_id_list = $revision;
+ foreach ($file_id_list as $file_id) {
+ if (!$db->select_first_row('uploaded_files', 'file', array('id' => $file_id)))
+ exit_with_error('InvalidUploadedFile', array('file' => $file_id));
+ array_push($commit_set, array('root_file' => $file_id));
+ }
+ continue;
+ }
</ins><span class="cx"> if (!is_numeric($repository_id))
</span><span class="cx"> exit_with_error('InvalidRepository', array('repository' => $repository_id));
</span><span class="cx"> $commit = $db->select_first_row('commits', 'commit',
</span><span class="lines">@@ -95,7 +141,7 @@
</span><span class="cx"> array('repository' => intval($repository_id), 'revision' => $revision));
</span><span class="cx"> if (!$commit)
</span><span class="cx"> exit_with_error('RevisionNotFound', array('repository' => $repository_id, 'revision' => $revision));
</span><del>- array_push($commit_set, $commit['commit_id']);
</del><ins>+ array_push($commit_set, array('commit' => $commit['commit_id']));
</ins><span class="cx"> array_push($repository_list, $repository_id);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -127,7 +173,7 @@
</span><span class="cx"> if (!$commit)
</span><span class="cx"> exit_with_error('RevisionNotFound', array('repository' => $repository_name, 'revision' => $revision));
</span><span class="cx"> array_set_default($commit_sets, $i, array('set' => array()));
</span><del>- array_push($commit_sets[$i]['set'], $commit['commit_id']);
</del><ins>+ array_push($commit_sets[$i]['set'], array('commit' => $commit['commit_id']));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicprivilegedapiuploadfilephp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -10,7 +10,7 @@
</span><span class="cx"> function main()
</span><span class="cx"> {
</span><span class="cx"> if (array_get($_SERVER, 'CONTENT_LENGTH') && empty($_POST) && empty($_FILES))
</span><del>- exit_with_error('FileSizeLimitExceeded2');
</del><ins>+ exit_with_error('FileSizeLimitExceeded');
</ins><span class="cx">
</span><span class="cx"> if (!verify_token(array_get($_POST, 'token')))
</span><span class="cx"> exit_with_error('InvalidToken');
</span><span class="lines">@@ -22,6 +22,9 @@
</span><span class="cx"> if (!$input_file)
</span><span class="cx"> exit_with_error('NoFileSpecified');
</span><span class="cx">
</span><ins>+ if ($input_file['error'] == UPLOAD_ERR_INI_SIZE || $input_file['error'] == UPLOAD_ERR_FORM_SIZE)
+ exit_with_error('FileSizeLimitExceeded');
+
</ins><span class="cx"> if ($input_file['error'] != UPLOAD_ERR_OK)
</span><span class="cx"> exit_with_error('FailedToUploadFile', array('name' => $input_file['name'], 'error' => $input_file['error']));
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentscustomanalysistaskconfiguratorjs"></a>
<div class="addfile"><h4>Added: trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js (0 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js (rev 0)
+++ trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -0,0 +1,543 @@
</span><ins>+class CustomAnalysisTaskConfigurator extends ComponentBase {
+
+ constructor()
+ {
+ super('custom-analysis-task-configurator');
+
+ this._selectedTests = [];
+ this._triggerablePlatforms = [];
+ this._selectedPlatform = null;
+ this._configurationNames = ['Baseline', 'Comparison'];
+ this._showComparison = false;
+ this._commitSetMap = {};
+ this._specifiedRevisions = {'Baseline': new Map, 'Comparison': new Map};
+ this._fetchedRevisions = {'Baseline': new Map, 'Comparison': new Map};
+ this._repositoryGroupByConfiguration = {'Baseline': null, 'Comparison': null};
+ this._updateTriggerableLazily = new LazilyEvaluatedFunction(this._updateTriggerable.bind(this));
+
+ this._renderTriggerableTestsLazily = new LazilyEvaluatedFunction(this._renderTriggerableTests.bind(this));
+ this._renderTriggerablePlatformsLazily = new LazilyEvaluatedFunction(this._renderTriggerablePlatforms.bind(this));
+ this._renderRepositoryPanesLazily = new LazilyEvaluatedFunction(this._renderRepositoryPanes.bind(this));
+
+ this._fileUploaders = {};
+ }
+
+ tests() { return this._selectedTests; }
+ platform() { return this._selectedPlatform; }
+ commitSets()
+ {
+ const map = this._commitSetMap;
+ if (!map['Baseline'] || !map['Comparison'])
+ return null;
+ return [map['Baseline'], map['Comparison']];
+ }
+
+ didConstructShadowTree()
+ {
+ this.content('specify-comparison-button').onclick = this.createEventHandler(() => this._configureComparison());
+
+ const baselineRootsUploader = new InstantFileUploader;
+ baselineRootsUploader.listenToAction('uploadedFile', (uploadedFile) => {
+ comparisonRootsUploader.addUploadedFile(uploadedFile);
+ this._updateCommitSetMap();
+ });
+ baselineRootsUploader.listenToAction('removedFile', () => this._updateCommitSetMap());
+ this._fileUploaders['Baseline'] = baselineRootsUploader;
+
+ const comparisonRootsUploader = new InstantFileUploader;
+ comparisonRootsUploader.listenToAction('uploadedFile', () => this._updateCommitSetMap());
+ comparisonRootsUploader.listenToAction('removedFile', () => this._updateCommitSetMap());
+ this._fileUploaders['Comparison'] = comparisonRootsUploader;
+ }
+
+ _configureComparison()
+ {
+ this._showComparison = true;
+ this._repositoryGroupByConfiguration['Comparison'] = this._repositoryGroupByConfiguration['Baseline'];
+
+ const specifiedBaselineRevisions = this._specifiedRevisions['Baseline'];
+ const specifiedComparisonRevisions = new Map;
+ for (let key of specifiedBaselineRevisions.keys())
+ specifiedComparisonRevisions.set(key, specifiedBaselineRevisions.get(key));
+ this._specifiedRevisions['Comparison'] = specifiedComparisonRevisions;
+
+ this.enqueueToRender();
+ }
+
+ render()
+ {
+ super.render();
+
+ this._renderTriggerableTestsLazily.evaluate();
+ this._renderTriggerablePlatformsLazily.evaluate(this._selectedTests, this._triggerablePlatforms);
+
+ const [triggerable, error] = this._updateTriggerableLazily.evaluate(this._selectedTests, this._selectedPlatform);
+
+ this._renderRepositoryPanesLazily.evaluate(triggerable, error, this._selectedPlatform, this._repositoryGroupByConfiguration, this._showComparison);
+ }
+
+ _renderTriggerableTests()
+ {
+ const enabledTriggerables = Triggerable.all().filter((triggerable) => !triggerable.isDisabled());
+
+ let tests = Test.topLevelTests().filter((test) => test.metrics().length && enabledTriggerables.some((triggerable) => triggerable.acceptsTest(test)));
+ this.renderReplace(this.content('test-list'), this._buildCheckboxList('test', tests, (selectedTests) => {
+ this._selectedTests = selectedTests;
+
+ this._triggerablePlatforms = Triggerable.triggerablePlatformsForTests(this._selectedTests);
+ if (this._selectedTests.length && !this._triggerablePlatforms.includes(this._selectedPlatform))
+ this._selectedPlatform = null;
+ }));
+ }
+
+ _renderTriggerablePlatforms(selectedTests, triggerablePlatforms)
+ {
+ if (!selectedTests.length) {
+ this.content('platform-pane').style.display = 'none';
+ return;
+ }
+ this.content('platform-pane').style.display = null;
+
+ this.renderReplace(this.content('platform-list'), this._buildCheckboxList('platform', triggerablePlatforms, (selectedPlatforms) => {
+ this._selectedPlatform = selectedPlatforms.length ? selectedPlatforms[0] : null;
+
+ const [triggerable, error] = this._updateTriggerableLazily.evaluate(this._selectedTests, this._selectedPlatform);
+ this._updateRepositoryGroups(triggerable);
+ this._updateCommitSetMap();
+
+ this.enqueueToRender();
+ }));
+ }
+
+ _buildCheckboxList(name, objects, callback)
+ {
+ const listItems = [];
+ let selectedListItems = [];
+ const element = ComponentBase.createElement;
+ return objects.map((object) => {
+ const checkbox = element('input', {type: 'radio', name: name, onchange: () => {
+ selectedListItems.forEach((item) => item.label.classList.remove('selected'));
+ selectedListItems = listItems.filter((item) => item.checkbox.checked);
+ selectedListItems.forEach((item) => item.label.classList.add('selected'));
+
+ callback(selectedListItems.map((item) => item.object));
+ this.enqueueToRender();
+ }});
+ const label = element('label', [checkbox, object.label()]);
+ listItems.push({checkbox, label, object});
+ return element('li', label);
+ })
+ }
+
+ _updateTriggerable(tests, platform)
+ {
+ let triggerable = null;
+ let error = null;
+ if (tests.length && platform) {
+ triggerable = Triggerable.findByTestConfiguration(tests[0], platform);
+ let matchingTests = new Set;
+ let mismatchingTests = new Set;
+ for (let test of tests) {
+ if (Triggerable.findByTestConfiguration(test, platform) == triggerable)
+ matchingTests.add(test);
+ else
+ mismatchingTests.add(test);
+ }
+ if (matchingTests.size < tests.length) {
+ const matchingTestNames = [...matchingTests].map((test) => test.fullName()).sort().join('", "');
+ const mismathingTestNames = [...mismatchingTests].map((test) => test.fullName()).sort().join('", "');
+ error = `Tests "${matchingTestNames}" and "${mismathingTestNames}" cannot be scheduled
+ simultenosuly on "${platform.name()}". Please select one of them at a time.`;
+ }
+ }
+
+ return [triggerable, error];
+ }
+
+ _updateRepositoryGroups(triggerable)
+ {
+ const repositoryGroups = triggerable ? TriggerableRepositoryGroup.sortByNamePreferringSmallerRepositories(triggerable.repositoryGroups()) : [];
+ for (let name in this._repositoryGroupByConfiguration) {
+ const currentGroup = this._repositoryGroupByConfiguration[name];
+ let matchingGroup = null;
+ if (currentGroup) {
+ if (repositoryGroups.includes(currentGroup))
+ matchingGroup = currentGroup;
+ else
+ matchingGroup = repositoryGroups.find((group) => group.name() == currentGroup.name());
+ }
+ if (!matchingGroup && repositoryGroups.length)
+ matchingGroup = repositoryGroups[0];
+ this._repositoryGroupByConfiguration[name] = matchingGroup;
+ }
+ }
+
+ _updateCommitSetMap()
+ {
+ const newBaseline = this._computeCommitSet('Baseline');
+ let newComparison = this._computeCommitSet('Comparison');
+ if (newBaseline && newComparison && newBaseline.equals(newComparison))
+ newComparison = null;
+
+ const currentBaseline = this._commitSetMap['Baseline'];
+ const currentComparison = this._commitSetMap['Baseline'];
+ if (newBaseline == currentBaseline && newComparison == currentComparison)
+ return; // Both of them are null.
+
+ if (newBaseline && currentBaseline && newBaseline.equals(currentBaseline)
+ && newComparison && currentComparison && newComparison.equals(currentComparison))
+ return;
+
+ this._commitSetMap = {'Baseline': newBaseline, 'Comparison': newComparison};
+
+ this.dispatchAction('commitSetChange');
+ this.enqueueToRender();
+ }
+
+ _computeCommitSet(configurationName)
+ {
+ const repositoryGroup = this._repositoryGroupByConfiguration[configurationName];
+ if (!repositoryGroup)
+ return null;
+
+ const fileUploader = this._fileUploaders[configurationName];
+ if (!fileUploader || fileUploader.hasFileToUpload())
+ return null;
+
+ const commitSet = new CustomCommitSet;
+ for (let repository of repositoryGroup.repositories()) {
+ let revision = this._specifiedRevisions[configurationName].get(repository);
+ if (!revision)
+ revision = this._fetchedRevisions[configurationName].get(repository);
+ if (!revision)
+ return null;
+ commitSet.setRevisionForRepository(repository, revision);
+ }
+
+ for (let uploadedFile of fileUploader.uploadedFiles())
+ commitSet.addCustomRoot(uploadedFile);
+
+ return commitSet;
+ }
+
+ _renderRepositoryPanes(triggerable, error, platform, repositoryGroupByConfiguration, showComparison)
+ {
+ this.content('repository-configuration-error-pane').style.display = error ? null : 'none';
+ this.content('error').textContent = error;
+
+ this.content('baseline-configuration-pane').style.display = triggerable ? null : 'none';
+ this.content('specify-comparison-pane').style.display = triggerable && !showComparison ? null : 'none';
+ this.content('comparison-configuration-pane').style.display = triggerable && showComparison ? null : 'none';
+
+ if (!triggerable)
+ return;
+
+ const repositoryGroups = TriggerableRepositoryGroup.sortByNamePreferringSmallerRepositories(triggerable.repositoryGroups());
+
+ const repositorySet = new Set;
+ for (let group of repositoryGroups) {
+ for (let repository of group.repositories())
+ repositorySet.add(repository);
+ }
+
+ const repositories = Repository.sortByNamePreferringOnesWithURL([...repositorySet]);
+ const requiredRepositories = repositories.filter((repository) => {
+ return repositoryGroups.every((group) => group.repositories().includes(repository));
+ });
+ const alwaysAcceptsCustomRoots = repositoryGroups.every((group) => group.acceptsCustomRoots());
+
+ this._renderBaselineRevisionTable(platform, repositoryGroups, requiredRepositories, repositoryGroupByConfiguration, alwaysAcceptsCustomRoots);
+
+ if (showComparison)
+ this._renderComparisonRevisionTable(platform, repositoryGroups, requiredRepositories, repositoryGroupByConfiguration, alwaysAcceptsCustomRoots);
+ }
+
+ _renderBaselineRevisionTable(platform, repositoryGroups, requiredRepositories, repositoryGroupByConfiguration, alwaysAcceptsCustomRoots)
+ {
+ let currentGroup = repositoryGroupByConfiguration['Baseline'];
+ const optionalRepositoryList = this._optionalRepositoryList(currentGroup, requiredRepositories);
+ this.renderReplace(this.content('baseline-revision-table'),
+ this._buildRevisionTable('Baseline', repositoryGroups, currentGroup, platform, requiredRepositories, optionalRepositoryList, alwaysAcceptsCustomRoots));
+ }
+
+ _renderComparisonRevisionTable(platform, repositoryGroups, requiredRepositories, repositoryGroupByConfiguration, alwaysAcceptsCustomRoots)
+ {
+ let currentGroup = repositoryGroupByConfiguration['Comparison'];
+ const optionalRepositoryList = this._optionalRepositoryList(currentGroup, requiredRepositories);
+ this.renderReplace(this.content('comparison-revision-table'),
+ this._buildRevisionTable('Comparison', repositoryGroups, currentGroup, platform, requiredRepositories, optionalRepositoryList, alwaysAcceptsCustomRoots));
+ }
+
+ _optionalRepositoryList(currentGroup, requiredRepositories)
+ {
+ if (!currentGroup)
+ return [];
+ return Repository.sortByNamePreferringOnesWithURL(currentGroup.repositories().filter((repository) => !requiredRepositories.includes(repository)));
+ }
+
+ _buildRevisionTable(configurationName, repositoryGroups, currentGroup, platform, requiredRepositories, optionalRepositoryList, alwaysAcceptsCustomRoots)
+ {
+ const element = ComponentBase.createElement;
+ const link = ComponentBase.createLink;
+
+ const customRootsTBody = element('tbody', [
+ element('tr', [
+ element('th', 'Roots'),
+ element('td', this._fileUploaders[configurationName]),
+ ]),
+ ]);
+
+ return [
+ element('tbody',
+ requiredRepositories.map((repository) => {
+ return element('tr', [
+ element('th', repository.name()),
+ element('td', this._buildRevisionInput(configurationName, repository, platform))
+ ]);
+ })),
+ alwaysAcceptsCustomRoots ? customRootsTBody : [],
+ element('tbody', [
+ element('tr', {'class': 'group-row'},
+ element('td', {colspan: 2}, this._buildRepositoryGroupList(repositoryGroups, currentGroup, configurationName))),
+ ]),
+ !alwaysAcceptsCustomRoots && currentGroup && currentGroup.acceptsCustomRoots() ? customRootsTBody : [],
+ element('tbody',
+ optionalRepositoryList.map((repository) => {
+ return element('tr',[
+ element('th', repository.name()),
+ element('td', this._buildRevisionInput(configurationName, repository, platform))
+ ]);
+ })
+ )];
+ }
+
+ _buildRepositoryGroupList(repositoryGroups, currentGroup, configurationName)
+ {
+ const element = ComponentBase.createElement;
+ return repositoryGroups.map((group) => {
+ const input = element('input', {
+ type: 'radio',
+ name: 'repositoryGroup-for-' + configurationName.toLowerCase(),
+ checked: currentGroup == group,
+ onchange: () => this._selectRepositoryGroup(configurationName, group)
+ });
+ return [element('label', [input, group.description()])];
+ });
+ }
+
+ _selectRepositoryGroup(configurationName, group)
+ {
+ const source = this._repositoryGroupByConfiguration;
+ const clone = {};
+ for (let key in source)
+ clone[key] = source[key];
+ clone[configurationName] = group;
+ this._repositoryGroupByConfiguration = clone;
+ this._updateCommitSetMap();
+ this.enqueueToRender();
+ }
+
+ _buildRevisionInput(configurationName, repository, platform)
+ {
+ const revision = this._specifiedRevisions[configurationName].get(repository) || '';
+ const element = ComponentBase.createElement;
+ const input = element('input', {value: revision, oninput: () => {
+ unmodifiedInput = null;
+ this._specifiedRevisions[configurationName].set(repository, input.value);
+ this._updateCommitSetMap();
+ }});
+ let unmodifiedInput = input;
+
+ if (!revision) {
+ CommitLog.fetchLatestCommitForPlatform(repository, platform).then((commit) => {
+ if (commit && unmodifiedInput) {
+ unmodifiedInput.value = commit.revision();
+ this._fetchedRevisions[configurationName].set(repository, commit.revision());
+ this._updateCommitSetMap();
+ }
+ });
+ }
+
+ return input;
+ }
+
+ static htmlTemplate()
+ {
+ return `
+ <section id="test-pane" class="pane">
+ <h2>1. Select a Test</h2>
+ <ul id="test-list" class="config-list"></ul>
+ </section>
+ <section id="platform-pane" class="pane">
+ <h2>2. Select a Platform</h2>
+ <ul id="platform-list" class="config-list"></ul>
+ </section>
+ <section id="repository-configuration-error-pane" class="pane">
+ <h2>Incompatible tests</h2>
+ <p id="error"></p>
+ </section>
+ <section id="baseline-configuration-pane" class="pane">
+ <h2>3. Configure Baseline</h2>
+ <table id="baseline-revision-table" class="revision-table"></table>
+ </section>
+ <section id="specify-comparison-pane" class="pane">
+ <button id="specify-comparison-button">Configure to Compare</button>
+ </section>
+ <section id="comparison-configuration-pane" class="pane">
+ <h2>4. Configure Comparison</h2>
+ <table id="comparison-revision-table" class="revision-table"></table>
+ </section>`;
+ }
+
+ static cssTemplate()
+ {
+ return `
+ :host {
+ display: flex !important;
+ flex-direction: row !important;
+ }
+ .pane {
+ margin-right: 1rem;
+ padding: 0;
+ }
+ .pane h2 {
+ padding: 0;
+ margin: 0;
+ margin-bottom: 0.5rem;
+ font-size: 1.2rem;
+ font-weight: inherit;
+ text-align: center;
+ white-space: nowrap;
+ }
+
+ .config-list {
+ height: 20rem;
+ overflow: scroll;
+ display: block;
+ margin: 0;
+ padding: 0;
+ list-style: none;
+ font-size: inherit;
+ font-weight: inherit;
+ border: none;
+ border-top: solid 1px #ddd;
+ border-bottom: solid 1px #ddd;
+ white-space: nowrap;
+ }
+
+ #platform-list:empty:before {
+ content: "No matching platform";
+ display: block;
+ margin: 1rem 0.5rem;
+ text-align: center;
+ }
+
+ .config-list label {
+ display: block;
+ padding: 0.1rem 0.2rem;
+ }
+
+ .config-list label:hover,
+ .config-list a:hover {
+ background: rgba(204, 153, 51, 0.1);
+ }
+
+ .config-list label.selected,
+ .config-list a.selected {
+ background: #eee;
+ }
+
+ .config-list a {
+ display: block;
+ padding: 0.1rem 0.2rem;
+ text-decoration: none;
+ color: inherit;
+ }
+
+ #repository-configuration-pane {
+ position: relative;
+ }
+
+ #repository-configuration-pane > button {
+ margin-left: 19.5rem;
+ }
+
+ .revision-table {
+ border: none;
+ border-collapse: collapse;
+ font-size: 1rem;
+ }
+
+ .revision-table thead {
+ font-size: 1.2rem;
+ }
+
+ .revision-table tbody:empty {
+ display: none;
+ }
+
+ .revision-table tbody tr:first-child td,
+ .revision-table tbody tr:first-child th {
+ border-top: solid 1px #ddd;
+ padding-top: 0.5rem;
+ }
+
+ .revision-table tbody tr:last-child td,
+ .revision-table tbody tr:last-child th {
+ padding-bottom: 0.5rem;
+ }
+
+ .revision-table td,
+ .revision-table th {
+ width: 15rem;
+ height: 1.8rem;
+ padding: 0 0.2rem;
+ border: none;
+ font-weight: inherit;
+ }
+
+ .revision-table thead th {
+ text-align: center;
+ }
+
+ .revision-table th close-button {
+ vertical-align: bottom;
+ }
+
+ .revision-table td:first-child,
+ .revision-table th:first-child {
+ width: 6rem;
+ }
+
+ .revision-table tr.group-row td {
+ padding-left: 5rem;
+ }
+
+ label {
+ white-space: nowrap;
+ display: block;
+ }
+
+ input:not([type=radio]) {
+ width: calc(100% - 0.6rem);
+ padding: 0.1rem 0.2rem;
+ font-size: 0.9rem;
+ font-weight: inherit;
+ }
+
+ #specify-comparison-pane button {
+ margin-top: 1.5rem;
+ font-size: 1.1rem;
+ font-weight: inherit;
+ }
+
+ #start-pane button {
+ margin-top: 1.5rem;
+ font-size: 1.2rem;
+ font-weight: inherit;
+ }
+`;
+ }
+}
+
+ComponentBase.defineElement('custom-analysis-task-configurator', CustomAnalysisTaskConfigurator);
</ins></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentsinstantfileuploaderjs"></a>
<div class="addfile"><h4>Added: trunk/Websites/perf.webkit.org/public/v3/components/instant-file-uploader.js (0 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/instant-file-uploader.js (rev 0)
+++ trunk/Websites/perf.webkit.org/public/v3/components/instant-file-uploader.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -0,0 +1,232 @@
</span><ins>+class InstantFileUploader extends ComponentBase {
+ constructor()
+ {
+ super('instant-file-uploader');
+ this._uploadedFiles = [];
+ this._preuploadFiles = [];
+ this._uploadProgress = new WeakMap;
+ this._fileSizeFormatter = Metric.makeFormatter('B', 3);
+
+ this._renderUploadedFilesLazily = new LazilyEvaluatedFunction(this._renderUploadedFiles.bind(this));
+ this._renderPreuploadFilesLazily = new LazilyEvaluatedFunction(this._renderPreuploadFiles.bind(this));
+ }
+
+ hasFileToUpload() { return !!this._preuploadFiles.length; }
+ uploadedFiles() { return this._uploadedFiles; }
+
+ addUploadedFile(uploadedFile)
+ {
+ console.assert(uploadedFile instanceof UploadedFile);
+ if (this._uploadedFiles.includes(uploadedFile))
+ return;
+ this._uploadedFiles.push(uploadedFile);
+ this.enqueueToRender();
+ }
+
+ didConstructShadowTree()
+ {
+ const input = this.content('file-input');
+ input.onchange = () => this._didFileInputChange(input);
+ }
+
+ render()
+ {
+ this._renderUploadedFilesLazily.evaluate(...this._uploadedFiles);
+ const uploadStatusElements = this._renderPreuploadFilesLazily.evaluate(...this._preuploadFiles);
+ this._updateUploadStatus(uploadStatusElements);
+ }
+
+ _renderUploadedFiles(...uploadedFiles)
+ {
+ const element = ComponentBase.createElement;
+ this.renderReplace(this.content('uploaded-files'), uploadedFiles.map((uploadedFile) => {
+ const authorInfo = uploadedFile.author() ? ' by ' + uploadedFile.author() : '';
+ const createdAt = Metric.formatTime(uploadedFile.createdAt());
+ const deleteButton = new CloseButton;
+ deleteButton.listenToAction('activate', () => this._removeUploadedFile(uploadedFile));
+ return element('li', [
+ deleteButton,
+ element('code', {class: 'filename'}, uploadedFile.filename()),
+ ' ',
+ element('small', {class: 'filesize'}, '(' + this._fileSizeFormatter(uploadedFile.size()) + ')'),
+ element('small', {class: 'meta'}, `Uploaded${authorInfo} on ${createdAt}`),
+ ]);
+ }));
+ }
+
+ _renderPreuploadFiles(...preuploadFiles)
+ {
+ const element = ComponentBase.createElement;
+ const uploadStatusElements = [];
+ this.renderReplace(this.content('preupload-files'), preuploadFiles.map((file) => {
+ const progressBar = element('progress');
+ const meta = element('small', {class: 'meta'}, progressBar);
+ uploadStatusElements.push({file, meta, progressBar});
+
+ return element('li', [
+ element('code', file.name),
+ ' ',
+ element('small', {class: 'filesize'}, '(' + this._fileSizeFormatter(file.size) + ')'),
+ meta,
+ ]);
+ }));
+ return uploadStatusElements;
+ }
+
+ _updateUploadStatus(uploadStatusElements)
+ {
+ for (let entry of uploadStatusElements) {
+ const progress = this._uploadProgress.get(entry.file);
+ const progressBar = entry.progressBar;
+ if (!progress) {
+ progressBar.removeAttribute('max');
+ progressBar.removeAttribute('value');
+ return;
+ }
+ if (progress.error) {
+ entry.meta.classList.add('hasError');
+ entry.meta.textContent = this._formatUploadError(progress.error);
+ } else {
+ progressBar.max = progress.total;
+ progressBar.value = progress.loaded;
+ }
+ }
+ }
+
+ _formatUploadError(error)
+ {
+ switch (error) {
+ case 'NotSupported':
+ return 'Failed: File uploading is disabled';
+ case 'FileSizeLimitExceeded':
+ return 'Failed: The uploaded file was too big';
+ case 'FileSizeQuotaExceeded':
+ return 'Failed: Exceeded file upload quota';
+ }
+ return 'Failed to upload the file';
+ }
+
+ _didFileInputChange(input)
+ {
+ if (!input.files.length)
+ return;
+ const limit = UploadedFile.fileUploadSizeLimit;
+ for (let file of input.files) {
+ if (file.size > limit) {
+ alert(`The specified file "${file.name}" is too big (${this._fileSizeFormatter(file.size)}). It must be smaller than ${this._fileSizeFormatter(limit)}`);
+ input.value = null;
+ return;
+ }
+ UploadedFile.fetchUnloadedFileWithIdenticalHash(file).then((uploadedFile) => {
+ if (uploadedFile) {
+ this._didUploadFile(file, uploadedFile);
+ return;
+ }
+
+ UploadedFile.uploadFile(file, (progress) => {
+ this._uploadProgress.set(file, progress);
+ this.enqueueToRender();
+ }).then((uploadedFile) => {
+ this._didUploadFile(file, uploadedFile);
+ }, (error) => {
+ this._uploadProgress.set(file, {error: error === 0 ? 'UnknownError' : error});
+ this.enqueueToRender();
+ });
+ });
+ }
+ this._preuploadFiles = Array.from(input.files);
+ input.value = null;
+
+ this.enqueueToRender();
+ }
+
+ _removeUploadedFile(uploadedFile)
+ {
+ // FIXME: Send a request to delete the file.
+ console.assert(uploadedFile instanceof UploadedFile);
+ const index = this._uploadedFiles.indexOf(uploadedFile);
+ if (index < 0)
+ return;
+ this._uploadedFiles.splice(index, 1);
+ this.dispatchAction('removedFile', uploadedFile);
+ this.enqueueToRender();
+ }
+
+ _didUploadFile(file, uploadedFile)
+ {
+ console.assert(file instanceof File);
+ const index = this._preuploadFiles.indexOf(file);
+ if (index >= 0)
+ this._preuploadFiles.splice(index, 1);
+ this._uploadedFiles.push(uploadedFile);
+ this.dispatchAction('uploadedFile', uploadedFile);
+ this.enqueueToRender();
+ }
+
+ static htmlTemplate()
+ {
+ return `<ul id="uploaded-files"></ul>
+ <ul id="preupload-files"></ul>
+ <input id="file-input" type="file" multiple="false">`;
+ }
+
+ static cssTemplate()
+ {
+ return `
+ ul:empty {
+ display: none;
+ }
+
+ ul, li {
+ margin: 0;
+ padding: 0;
+ list-style: none;
+ }
+
+ li {
+ position: relative;
+ margin-bottom: 0.25rem;
+ padding-left: 1.5rem;
+ padding-bottom: 0.25rem;
+ border-bottom: solid 1px #eee;
+ }
+
+ li:last-child {
+ border-bottom: none;
+ }
+
+ li > close-button {
+ position: absolute;
+ left: 0;
+ top: 50%;
+ margin-top: -0.5rem;
+ }
+
+ li > progress {
+ display: block;
+ }
+
+ code {
+ font-size: 1.1rem;
+ font-weight: inherit;
+ }
+
+ small {
+ font-size: 0.8rem;
+ font-weight: inherit;
+ color: #666;
+ }
+
+ small.meta {
+ display: block;
+ }
+
+ .hasError {
+ color: #c60;
+ font-weight: normal;
+ }
+ `;
+ }
+}
+
+ComponentBase.defineElement('instant-file-uploader', InstantFileUploader);
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/index.html (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/index.html 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/index.html 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -65,6 +65,7 @@
</span><span class="cx"> <script src="models/build-request.js"></script>
</span><span class="cx"> <script src="models/commit-set.js"></script>
</span><span class="cx"> <script src="models/triggerable.js"></script>
</span><ins>+ <script src="models/uploaded-file.js"></script>
</ins><span class="cx"> <script src="models/manifest.js"></script>
</span><span class="cx">
</span><span class="cx"> <script src="components/base.js"></script>
</span><span class="lines">@@ -91,6 +92,8 @@
</span><span class="cx"> <script src="components/mutable-list-view.js"></script>
</span><span class="cx"> <script src="components/analysis-task-bug-list.js"></script>
</span><span class="cx"> <script src="components/ratio-bar-graph.js"></script>
</span><ins>+ <script src="components/custom-analysis-task-configurator.js"></script>
+ <script src="components/instant-file-uploader.js"></script>
</ins><span class="cx">
</span><span class="cx"> <script src="pages/page.js"></script>
</span><span class="cx"> <script src="pages/page-router.js"></script>
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsanalysistaskjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -7,10 +7,10 @@
</span><span class="cx"> this._author = object.author;
</span><span class="cx"> this._createdAt = object.createdAt;
</span><span class="cx">
</span><del>- console.assert(object.platform instanceof Platform);
</del><ins>+ console.assert(!object.platform || object.platform instanceof Platform);
</ins><span class="cx"> this._platform = object.platform;
</span><span class="cx">
</span><del>- console.assert(object.metric instanceof Metric);
</del><ins>+ console.assert(!object.metric || object.metric instanceof Metric);
</ins><span class="cx"> this._metric = object.metric;
</span><span class="cx">
</span><span class="cx"> this._startMeasurementId = object.startRun;
</span><span class="lines">@@ -29,7 +29,11 @@
</span><span class="cx">
</span><span class="cx"> static findByPlatformAndMetric(platformId, metricId)
</span><span class="cx"> {
</span><del>- return this.all().filter(function (task) { return task._platform.id() == platformId && task._metric.id() == metricId; });
</del><ins>+ return this.all().filter((task) => {
+ const platform = task._platform;
+ const metric = task._metric;
+ return platform && metric && platform.id() == platformId && metric.id() == metricId;
+ });
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> updateSingleton(object)
</span><span class="lines">@@ -55,6 +59,7 @@
</span><span class="cx"> this._finishedBuildRequestCount = +object.finishedBuildRequestCount;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ isCustom() { return !this._platform; }
</ins><span class="cx"> hasResults() { return this._finishedBuildRequestCount; }
</span><span class="cx"> hasPendingRequests() { return this._finishedBuildRequestCount < this._buildRequestCount; }
</span><span class="cx"> requestLabel() { return `${this._finishedBuildRequestCount} of ${this._buildRequestCount}`; }
</span><span class="lines">@@ -201,6 +206,8 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> for (var otherTask of AnalysisTask.all()) {
</span><ins>+ if (task.isCustom())
+ continue;
</ins><span class="cx"> if (task.endTime() < otherTask.startTime()
</span><span class="cx"> || otherTask.endTime() < task.startTime()
</span><span class="cx"> || task.metric() != otherTask.metric())
</span><span class="lines">@@ -257,9 +264,6 @@
</span><span class="cx"> for (var rawData of data.analysisTasks) {
</span><span class="cx"> rawData.platform = Platform.findById(rawData.platform);
</span><span class="cx"> rawData.metric = Metric.findById(rawData.metric);
</span><del>- if (!rawData.platform || !rawData.metric)
- continue;
-
</del><span class="cx"> rawData.bugs = taskToBug[rawData.id];
</span><span class="cx"> rawData.causes = resolveCommits(rawData.causes);
</span><span class="cx"> rawData.fixes = resolveCommits(rawData.fixes);
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsbuildrequestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/build-request.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/build-request.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/build-request.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -127,6 +127,9 @@
</span><span class="cx"> commit.repository = Repository.findById(commit.repository);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ for (let uploadedFile of data['uploadedFiles'])
+ UploadedFile.ensureSingleton(uploadedFile.id, uploadedFile);
+
</ins><span class="cx"> const commitSets = data['commitSets'].map((row) => {
</span><span class="cx"> row.commits = row.commits.map((commitId) => commitIdMap[commitId]);
</span><span class="cx"> return CommitSet.ensureSingleton(row.id, row);
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelscommitlogjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -68,6 +68,20 @@
</span><span class="cx"> return {repository: repository, label: label, url: repository.urlForRevisionRange(from, to)};
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ static fetchLatestCommitForPlatform(repository, platform)
+ {
+ console.assert(repository instanceof Repository);
+ console.assert(platform instanceof Platform);
+ return this.cachedFetch(`/api/commits/${repository.id()}/latest`, {platform: platform.id()}).then((data) => {
+ const commits = data['commits'];
+ if (!commits || !commits.length)
+ return null;
+ const rawData = commits[0];
+ rawData.repository = repository;
+ return CommitLog.ensureSingleton(rawData.id, rawData);
+ });
+ }
+
</ins><span class="cx"> static fetchBetweenRevisions(repository, precedingRevision, lastRevision)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: The cache should be smarter about fetching a range within an already fetched range, etc...
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelscommitsetjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -8,6 +8,7 @@
</span><span class="cx"> this._repositories = [];
</span><span class="cx"> this._repositoryToCommitMap = {};
</span><span class="cx"> this._latestCommitTime = null;
</span><ins>+ this._customRoots = [];
</ins><span class="cx">
</span><span class="cx"> if (!object)
</span><span class="cx"> return;
</span><span class="lines">@@ -18,9 +19,14 @@
</span><span class="cx"> this._repositoryToCommitMap[repositoryId] = CommitLog.ensureSingleton(row.id, row);
</span><span class="cx"> this._repositories.push(row.repository);
</span><span class="cx"> }
</span><ins>+ for (let fileId of object.customRoots) {
+ const uploadedFile = UploadedFile.findById(fileId);
+ this._customRoots.push(uploadedFile);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> repositories() { return this._repositories; }
</span><ins>+ customRoots() { return this._customRoots; }
</ins><span class="cx"> commitForRepository(repository) { return this._repositoryToCommitMap[repository.id()]; }
</span><span class="cx">
</span><span class="cx"> revisionForRepository(repository)
</span><span class="lines">@@ -49,6 +55,18 @@
</span><span class="cx"> if (this._repositoryToCommitMap[repositoryId] != other._repositoryToCommitMap[repositoryId])
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><ins>+ return CommitSet.areCustomRootsEqual(this._customRoots, other._customRoots);
+ }
+
+ static areCustomRootsEqual(customRoots1, customRoots2)
+ {
+ if (customRoots1.length != customRoots2.length)
+ return false;
+ const set2 = new Set(customRoots2);
+ for (let file of customRoots1) {
+ if (!set2.has(file))
+ return false;
+ }
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -106,6 +124,7 @@
</span><span class="cx"> constructor()
</span><span class="cx"> {
</span><span class="cx"> this._revisionListByRepository = new Map;
</span><ins>+ this._customRoots = [];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> setRevisionForRepository(repository, revision)
</span><span class="lines">@@ -114,9 +133,29 @@
</span><span class="cx"> this._revisionListByRepository.set(repository, revision);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ equals(other)
+ {
+ console.assert(other instanceof CustomCommitSet);
+ if (this._revisionListByRepository.size != other._revisionListByRepository.size)
+ return false;
+ for (let repository of this._revisionListByRepository.keys()) {
+ const thisRevision = this._revisionListByRepository.get(repository);
+ const otherRevision = other._revisionListByRepository.get(repository);
+ if (thisRevision != otherRevision)
+ return false;
+ }
+ return CommitSet.areCustomRootsEqual(this._customRoots, other._customRoots);
+ }
+
</ins><span class="cx"> repositories() { return Array.from(this._revisionListByRepository.keys()); }
</span><span class="cx"> revisionForRepository(repository) { return this._revisionListByRepository.get(repository); }
</span><ins>+ customRoots() { return this._customRoots; }
</ins><span class="cx">
</span><ins>+ addCustomRoot(uploadedFile)
+ {
+ console.assert(uploadedFile instanceof UploadedFile);
+ this._customRoots.push(uploadedFile);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (typeof module != 'undefined') {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmanifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/manifest.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/manifest.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/manifest.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -57,6 +57,9 @@
</span><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ if (typeof(UploadedFile) != 'undefined')
+ UploadedFile.fileUploadSizeLimit = rawResponse.fileUploadSizeLimit || 0;
+
</ins><span class="cx"> Instrumentation.endMeasuringTime('Manifest', '_didFetchManifest');
</span><span class="cx">
</span><span class="cx"> return {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmetricjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/metric.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -119,6 +119,14 @@
</span><span class="cx"> formatter.divisor = divisor;
</span><span class="cx"> return formatter;
</span><span class="cx"> };
</span><ins>+
+ static formatTime(utcTime)
+ {
+ // FIXME: This is incorrect when the offset cross day-life-saving change. It's good enough for now.
+ const offsetInMinutes = (new Date(utcTime)).getTimezoneOffset();
+ const timeInLocalTimeZone = new Date(utcTime - offsetInMinutes * 60 * 1000);
+ return timeInLocalTimeZone.toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (typeof module != 'undefined')
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelstestgroupjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/test-group.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/test-group.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/test-group.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -178,26 +178,47 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ static createWithTask(taskName, platform, test, groupName, repetitionCount, commitSets)
+ {
+ console.assert(commitSets.length == 2);
+ const revisionSets = this._revisionSetsFromCommitSets(commitSets);
+ const params = {taskName, name: groupName, platform: platform.id(), test: test.id(), repetitionCount, revisionSets};
+ return PrivilegedAPI.sendRequest('create-test-group', params).then((data) => {
+ return AnalysisTask.fetchById(data['taskId']);
+ }).then((task) => {
+ return this._fetchTestGroupsForTask(task.id()).then(() => task);
+ });
+ }
+
</ins><span class="cx"> static createAndRefetchTestGroups(task, name, repetitionCount, commitSets)
</span><span class="cx"> {
</span><span class="cx"> console.assert(commitSets.length == 2);
</span><ins>+ const revisionSets = this._revisionSetsFromCommitSets(commitSets);
+ return PrivilegedAPI.sendRequest('create-test-group', {
+ task: task.id(),
+ name: name,
+ repetitionCount: repetitionCount,
+ revisionSets: revisionSets,
+ }).then((data) => this._fetchTestGroupsForTask(task.id()));
+ }
</ins><span class="cx">
</span><del>- const revisionSets = commitSets.map((commitSet) => {
</del><ins>+ static _revisionSetsFromCommitSets(commitSets)
+ {
+ return commitSets.map((commitSet) => {
</ins><span class="cx"> console.assert(commitSet instanceof CustomCommitSet || commitSet instanceof CommitSet);
</span><span class="cx"> const revisionSet = {};
</span><span class="cx"> for (let repository of commitSet.repositories())
</span><span class="cx"> revisionSet[repository.id()] = commitSet.revisionForRepository(repository);
</span><ins>+ const customRoots = commitSet.customRoots();
+ if (customRoots && customRoots.length)
+ revisionSet['customRoots'] = customRoots.map((uploadedFile) => uploadedFile.id());
</ins><span class="cx"> return revisionSet;
</span><span class="cx"> });
</span><ins>+ }
</ins><span class="cx">
</span><del>- return PrivilegedAPI.sendRequest('create-test-group', {
- task: task.id(),
- name: name,
- repetitionCount: repetitionCount,
- revisionSets: revisionSets,
- }).then((data) => {
- return this.cachedFetch('/api/test-groups', {task: task.id()}, true).then((data) => this._createModelsFromFetchedTestGroups(data));
- });
</del><ins>+ static _fetchTestGroupsForTask(taskId)
+ {
+ return this.cachedFetch('/api/test-groups', {task: taskId}, true).then((data) => this._createModelsFromFetchedTestGroups(data));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static fetchByTask(taskId)
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelstriggerablejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -37,6 +37,19 @@
</span><span class="cx"> }
</span><span class="cx"> return null;
</span><span class="cx"> }
</span><ins>+
+ static triggerablePlatformsForTests(tests)
+ {
+ console.assert(tests instanceof Array);
+ if (!tests.length)
+ return [];
+ return this.sortByName(Platform.all().filter((platform) => {
+ return tests.every((test) => {
+ const triggerable = Triggerable.findByTestConfiguration(test, platform);
+ return triggerable && !triggerable.isDisabled();
+ });
+ }));
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> class TriggerableRepositoryGroup extends LabeledObject {
</span><span class="lines">@@ -64,6 +77,21 @@
</span><span class="cx"> description() { return this._description || this.name(); }
</span><span class="cx"> acceptsCustomRoots() { return this._acceptsCustomRoots; }
</span><span class="cx"> repositories() { return this._repositories; }
</span><ins>+
+ static sortByNamePreferringSmallerRepositories(groupList)
+ {
+ return groupList.sort((a, b) => {
+ if (a.repositories().length < b.repositories().length)
+ return -1;
+ else if (a.repositories().length > b.repositories().length)
+ return 1;
+ if (a.name() < b.name())
+ return -1;
+ else if (a.name() > b.name())
+ return 1;
+ return 0;
+ });
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (typeof module != 'undefined') {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsuploadedfilejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/uploaded-file.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/uploaded-file.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/models/uploaded-file.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -12,8 +12,15 @@
</span><span class="cx"> this.ensureNamedStaticMap('sha256')[object.sha256] = this;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ createdAt() { return this._createdAt; }
+ filename() { return this._filename; }
+ author() { return this._author; }
+ size() { return this._size; }
+
</ins><span class="cx"> static uploadFile(file, uploadProgressCallback = null)
</span><span class="cx"> {
</span><ins>+ if (file.size > UploadedFile.fileUploadSizeLimit)
+ return Promise.reject('FileSizeLimitExceeded');
</ins><span class="cx"> return PrivilegedAPI.sendRequest('upload-file', {'newFile': file}, {useFormData: true, uploadProgressCallback}).then((rawData) => {
</span><span class="cx"> return UploadedFile.ensureSingleton(rawData['uploadedFile'].id, rawData['uploadedFile']);
</span><span class="cx"> });
</span><span class="lines">@@ -21,6 +28,8 @@
</span><span class="cx">
</span><span class="cx"> static fetchUnloadedFileWithIdenticalHash(file)
</span><span class="cx"> {
</span><ins>+ if (file.size > UploadedFile.fileUploadSizeLimit)
+ return Promise.reject('FileSizeLimitExceeded');
</ins><span class="cx"> return new Promise((resolve, reject) => {
</span><span class="cx"> const reader = new FileReader();
</span><span class="cx"> reader.onload = () => resolve(reader.result);
</span><span class="lines">@@ -32,9 +41,11 @@
</span><span class="cx"> const map = this.namedStaticMap('sha256');
</span><span class="cx"> if (map && sha256 in map)
</span><span class="cx"> return map[sha256];
</span><del>- return RemoteAPI.getJSONWithStatus(`../api/uploaded-file?sha256=${sha256}`).then((rawData) => {
- if (!rawData['uploadedFile'])
</del><ins>+ return RemoteAPI.getJSON(`../api/uploaded-file?sha256=${sha256}`).then((rawData) => {
+ if (rawData['status'] == 'NotFound' || !rawData['uploadedFile'])
</ins><span class="cx"> return null;
</span><ins>+ if (rawData['status'] != 'OK')
+ return Promise.reject(rawData['status']);
</ins><span class="cx"> return UploadedFile.ensureSingleton(rawData['uploadedFile'].id, rawData['uploadedFile']);
</span><span class="cx"> });
</span><span class="cx"> });
</span><span class="lines">@@ -52,3 +63,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span><ins>+
+UploadedFile.fileUploadSizeLimit = 0;
+
+if (typeof module != 'undefined')
+ module.exports.UploadedFile = UploadedFile;
</ins></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagesanalysiscategorypagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -123,11 +123,9 @@
</span><span class="cx"> Instrumentation.startMeasuringTime('AnalysisCategoryPage', 'reconstructTaskList');
</span><span class="cx">
</span><span class="cx"> console.assert(this.router());
</span><del>- var currentCategory = this._categoryToolbar.currentCategory();
</del><ins>+ const currentCategory = this._categoryToolbar.currentCategory();
</ins><span class="cx">
</span><del>- var tasks = AnalysisTask.all().filter(function (task) {
- return task.category() == currentCategory;
- }).sort(function (a, b) {
</del><ins>+ const tasks = AnalysisTask.all().filter((task) => task.category() == currentCategory).sort((a, b) => {
</ins><span class="cx"> if (a.hasPendingRequests() == b.hasPendingRequests())
</span><span class="cx"> return b.createdAt() - a.createdAt();
</span><span class="cx"> else if (a.hasPendingRequests()) // a < b
</span><span class="lines">@@ -137,25 +135,25 @@
</span><span class="cx"> return 0;
</span><span class="cx"> });
</span><span class="cx">
</span><del>- var element = ComponentBase.createElement;
- var link = ComponentBase.createLink;
- var router = this.router();
</del><ins>+ const element = ComponentBase.createElement;
+ const link = ComponentBase.createLink;
+ const router = this.router();
</ins><span class="cx"> this.renderReplace(this.content().querySelector('tbody.analysis-tasks'),
</span><del>- tasks.map(function (task) {
- var status = AnalysisCategoryPage._computeStatus(task);
</del><ins>+ tasks.map((task) => {
+ const status = AnalysisCategoryPage._computeStatus(task);
</ins><span class="cx"> return element('tr', [
</span><span class="cx"> element('td', {class: 'status'},
</span><span class="cx"> element('span', {class: status.class}, status.label)),
</span><span class="cx"> element('td', link(task.label(), router.url(`analysis/task/${task.id()}`))),
</span><span class="cx"> element('td', {class: 'bugs'},
</span><del>- element('ul', task.bugs().map(function (bug) {
- var url = bug.url();
- var title = bug.title();
</del><ins>+ element('ul', task.bugs().map((bug) => {
+ const url = bug.url();
+ const title = bug.title();
</ins><span class="cx"> return element('li', url ? link(bug.label(), title, url, true) : title);
</span><span class="cx"> }))),
</span><span class="cx"> element('td', {class: 'author'}, task.author()),
</span><del>- element('td', {class: 'platform'}, task.platform().label()),
- element('td', task.metric().fullName()),
</del><ins>+ element('td', {class: 'platform'}, task.platform() ? task.platform().label() : null),
+ element('td', task.metric() ? task.metric().fullName() : null),
</ins><span class="cx"> ]);
</span><span class="cx"> }));
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagesanalysistaskpagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -409,7 +409,13 @@
</span><span class="cx"> console.assert(!this._task);
</span><span class="cx">
</span><span class="cx"> this._task = task;
</span><ins>+ const bugList = this.part('bug-list');
+ this.part('bug-list').setTask(this._task);
+ this.enqueueToRender();
</ins><span class="cx">
</span><ins>+ if (task.isCustom())
+ return task;
+
</ins><span class="cx"> const platform = task.platform();
</span><span class="cx"> const metric = task.metric();
</span><span class="cx"> const lastModified = platform.lastModified(metric);
</span><span class="lines">@@ -426,11 +432,6 @@
</span><span class="cx"> chart.setOverviewDomain(domain[0], domain[1]);
</span><span class="cx"> chart.setMainDomain(domain[0], domain[1]);
</span><span class="cx">
</span><del>- const bugList = this.part('bug-list');
- this.part('bug-list').setTask(this._task);
-
- this.enqueueToRender();
-
</del><span class="cx"> return task;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -507,10 +508,10 @@
</span><span class="cx"> this._renderCauseAndFixesLazily.evaluate(this._startPoint, this._task);
</span><span class="cx"> this._renderRelatedTasksLazily.evaluate(this._task, this._relatedTasks);
</span><span class="cx">
</span><del>- this.content('chart-pane').style.display = this._task ? null : 'none';
</del><ins>+ this.content('chart-pane').style.display = this._task && !this._task.isCustom() ? null : 'none';
</ins><span class="cx"> this.part('chart-pane').setShowForm(!!this._triggerable);
</span><span class="cx">
</span><del>- this.content('results-pane').style.display = this._task ? null : 'none';
</del><ins>+ this.content('results-pane').style.display = this._task && !this._task.isCustom() ? null : 'none';
</ins><span class="cx"> this.part('results-pane').setShowForm(!!this._triggerable);
</span><span class="cx">
</span><span class="cx"> Instrumentation.endMeasuringTime('AnalysisTaskPage', 'render');
</span><span class="lines">@@ -519,7 +520,7 @@
</span><span class="cx"> _renderTaskNameAndStatus(task, taskName, changeType)
</span><span class="cx"> {
</span><span class="cx"> this.part('analysis-task-name').setText(taskName);
</span><del>- if (task) {
</del><ins>+ if (task && !task.isCustom()) {
</ins><span class="cx"> const link = ComponentBase.createLink;
</span><span class="cx"> const platform = task.platform();
</span><span class="cx"> const metric = task.metric();
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pageschartpanestatusviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane-status-view.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane-status-view.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane-status-view.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> element('td', 'Build'),
</span><span class="cx"> element('td', {colspan: 2}, [
</span><span class="cx"> url ? link(buildNumber, build.label(), url, true) : buildNumber,
</span><del>- ` (${this._formatTime(build.buildTime())})`
</del><ins>+ ` (${Metric.formatTime(build.buildTime())})`
</ins><span class="cx"> ]),
</span><span class="cx"> ]));
</span><span class="cx"> }
</span><span class="lines">@@ -72,12 +72,6 @@
</span><span class="cx"> this.renderReplace(this.content('build-revision'), tableContent);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- _formatTime(date)
- {
- console.assert(date instanceof Date);
- return date.toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
- }
-
</del><span class="cx"> setCurrentRepository(repository)
</span><span class="cx"> {
</span><span class="cx"> this._currentRepository = repository;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pageschartpanejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-var ChartTrendLineTypes = [
</del><ins>+const ChartTrendLineTypes = [
</ins><span class="cx"> {
</span><span class="cx"> id: 0,
</span><span class="cx"> label: 'None',
</span><span class="lines">@@ -196,15 +196,15 @@
</span><span class="cx">
</span><span class="cx"> _analyzeRange(startPoint, endPoint)
</span><span class="cx"> {
</span><del>- var router = this._chartsPage.router();
- var newWindow = window.open(router.url('analysis/task/create'), '_blank');
</del><ins>+ const router = this._chartsPage.router();
+ const newWindow = window.open(router.url('analysis/task/create', {inProgress: true}), '_blank');
</ins><span class="cx">
</span><del>- var analyzePopover = this.content().querySelector('.chart-pane-analyze-popover');
- var name = analyzePopover.querySelector('input').value;
</del><ins>+ const analyzePopover = this.content().querySelector('.chart-pane-analyze-popover');
+ const name = analyzePopover.querySelector('input').value;
</ins><span class="cx"> AnalysisTask.create(name, startPoint.id, endPoint.id).then((data) => {
</span><span class="cx"> newWindow.location.href = router.url('analysis/task/' + data['taskId']);
</span><span class="cx"> this.fetchAnalysisTasks(true);
</span><del>- }, function (error) {
</del><ins>+ }, (error) => {
</ins><span class="cx"> newWindow.location.href = router.url('analysis/task/create', {error: error});
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -272,7 +272,6 @@
</span><span class="cx"> if (hasSelectedPoints) {
</span><span class="cx"> actions.push(this._makePopoverActionItem(analyzePopover, 'Analyze', false));
</span><span class="cx"> analyzePopover.onsubmit = this.createEventHandler(() => {
</span><del>- console.log(selectedPoints.length());
</del><span class="cx"> this._analyzeRange(selectedPoints.firstPoint(), selectedPoints.lastPoint());
</span><span class="cx"> });
</span><span class="cx"> } else {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagescreateanalysistaskpagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -3,7 +3,8 @@
</span><span class="cx"> constructor()
</span><span class="cx"> {
</span><span class="cx"> super('Create Analysis Task');
</span><del>- this._errorMessage = null;
</del><ins>+ this._message = null;
+ this._renderMessageLazily = new LazilyEvaluatedFunction(this._renderMessage.bind(this));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> title() { return 'Creating a New Analysis Task'; }
</span><span class="lines">@@ -13,43 +14,111 @@
</span><span class="cx"> {
</span><span class="cx"> if (state.error instanceof Set)
</span><span class="cx"> state.error = Array.from(state.error.values())[0];
</span><ins>+ this._message = state.error || (state.inProgress ? 'Creating the analysis task page...' : '');
+ }
</ins><span class="cx">
</span><del>- this._errorMessage = state.error;
- if (!isOpen)
- this.enqueueToRender();
</del><ins>+ didConstructShadowTree()
+ {
+ this.part('configurator').listenToAction('commitSetChange', () => this.enqueueToRender());
+ this.content('start-button').onclick = this.createEventHandler(() => this._createAnalysisTaskWithGroup());
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ _createAnalysisTaskWithGroup()
+ {
+ const taskNameInput = this.content('task-name');
+ if (!taskNameInput.reportValidity())
+ return;
+
+ const testGroupInput = this.content('test-group-name');
+ if (!testGroupInput.reportValidity())
+ return;
+
+ const configurator = this.part('configurator');
+ const tests = configurator.tests();
+ if (tests.length != 1)
+ return alert('Exactly one test must be selected');
+
+ const taskName = taskNameInput.value;
+ const testGroupName = testGroupInput.value;
+ const iterationCount = this.content('iteration-count').value;
+ const platform = configurator.platform();
+ const commitSets = configurator.commitSets();
+
+ TestGroup.createWithTask(taskName, platform, tests[0], testGroupName, iterationCount, commitSets).then((task) => {
+ console.log('yay?', task);
+ const url = this.router().url(`analysis/task/${task.id()}`);
+ console.log('moving to ' + url);
+ location.href = this.router().url(`analysis/task/${task.id()}`);
+ }, (error) => {
+ alert('Failed to create a new test group: ' + error);
+ });
+ }
+
</ins><span class="cx"> render()
</span><span class="cx"> {
</span><span class="cx"> super.render();
</span><del>- if (this._errorMessage)
- this.content().querySelector('.message').textContent = this._errorMessage;
</del><ins>+ const configurator = this.part('configurator');
+ this._renderMessageLazily.evaluate(this._message, !!configurator.commitSets(), configurator.tests(), configurator.platform());
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ _renderMessage(message, hasValidCommitSets, tests, platform)
+ {
+ const messageContainer = this.content('message');
+ messageContainer.textContent = this._message;
+ messageContainer.style.display = this._message ? null : 'none';
+ this.content('new-task').style.display = this._message ? 'none' : null;
+ if (platform)
+ this.content('test-group-name').value = `${tests.map((test) => test.name()).join(', ')} on ${platform.name()}`;
+ this.content('iteration-start-pane').style.display = !this._message && hasValidCommitSets ? null : 'none';
+ }
+
</ins><span class="cx"> static htmlTemplate()
</span><span class="cx"> {
</span><span class="cx"> return `
</span><del>- <div class="create-analysis-task-container">
- <p class="message">Creating the analysis task page...</p>
- </div>
-`;
</del><ins>+ <p id="message"></p>
+ <div id="new-task">
+ <input id="task-name" type="text" placeholder="Name this task" required>
+ <custom-analysis-task-configurator id="configurator"></custom-analysis-task-configurator>
+ <div id="iteration-start-pane">
+ <input id="test-group-name" placeholder="Name this test group" required>
+ <label><select id="iteration-count">
+ <option>1</option>
+ <option>2</option>
+ <option>3</option>
+ <option selected>4</option>
+ <option>5</option>
+ <option>6</option>
+ </select> iterations per configuration</label>
+ <button id="start-button">Start</button>
+ </div>
+ </div>`;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static cssTemplate()
</span><span class="cx"> {
</span><span class="cx"> return `
</span><del>- .create-analysis-task-container {
- display: flex;
</del><ins>+ #message {
+ text-align: center;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- .create-analysis-task-container > * {
- margin: 1rem auto;
- display: inline-block;
</del><ins>+ #new-task > * {
+ display: block;
+ margin: 1rem;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- .create-analysis-task input {
- font-size: inherit;
</del><ins>+ #new-task input {
+ width: 30%;
+ min-width: 10rem;
+ font-size: 1rem;
+ font-weight: inherit;
</ins><span class="cx"> }
</span><ins>+
+ #start-button {
+ display: block;
+ margin-top: 0.5rem;
+ font-size: 1.2rem;
+ font-weight: inherit;
+ }
</ins><span class="cx"> `;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagespagerouterjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/page-router.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/page-router.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/page-router.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> destinationPage.open(parsed.state);
</span><span class="cx"> } else
</span><span class="cx"> destinationPage.updateFromSerializedState(parsed.state, false);
</span><ins>+ destinationPage.enqueueToRender();
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgservertestsapibuildrequeststestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> assert.deepEqual(content['buildRequests'], []);
</span><span class="cx"> assert.deepEqual(content['commitSets'], []);
</span><span class="cx"> assert.deepEqual(content['commits'], []);
</span><del>- assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status']);
</del><ins>+ assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status', 'uploadedFiles']);
</ins><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> return MockData.addMockData(TestServer.database()).then(() => {
</span><span class="cx"> return TestServer.remoteAPI().getJSONWithStatus('/api/build-requests/build-webkit');
</span><span class="cx"> }).then((content) => {
</span><del>- assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status']);
</del><ins>+ assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status', 'uploadedFiles']);
</ins><span class="cx">
</span><span class="cx"> assert.equal(content['commitSets'].length, 2);
</span><span class="cx"> assert.equal(content['commitSets'][0].id, 401);
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> return MockData.addMockData(TestServer.database()).then(() => {
</span><span class="cx"> return TestServer.remoteAPI().getJSONWithStatus('/api/build-requests/build-webkit?useLegacyIdResolution=true');
</span><span class="cx"> }).then((content) => {
</span><del>- assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status']);
</del><ins>+ assert.deepEqual(Object.keys(content).sort(), ['buildRequests', 'commitSets', 'commits', 'status', 'uploadedFiles']);
</ins><span class="cx">
</span><span class="cx"> assert.equal(content['commitSets'].length, 2);
</span><span class="cx"> assert.equal(content['commitSets'][0].id, 401);
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgservertestsprivilegedapicreatetestgrouptestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -1,9 +1,10 @@
</span><span class="cx"> 'use strict';
</span><span class="cx">
</span><del>-let assert = require('assert');
</del><ins>+const assert = require('assert');
</ins><span class="cx">
</span><del>-let MockData = require('./resources/mock-data.js');
-let TestServer = require('./resources/test-server.js');
</del><ins>+const MockData = require('./resources/mock-data.js');
+const TestServer = require('./resources/test-server.js');
+const TemporaryFile = require('./resources/temporary-file.js').TemporaryFile;
</ins><span class="cx"> const addSlaveForReport = require('./resources/common-operations.js').addSlaveForReport;
</span><span class="cx"> const prepareServerTest = require('./resources/common-operations.js').prepareServerTest;
</span><span class="cx">
</span><span class="lines">@@ -116,6 +117,7 @@
</span><span class="cx">
</span><span class="cx"> describe('/privileged-api/create-test-group', function () {
</span><span class="cx"> prepareServerTest(this);
</span><ins>+ TemporaryFile.inject();
</ins><span class="cx">
</span><span class="cx"> it('should return "InvalidName" on an empty request', () => {
</span><span class="cx"> return PrivilegedAPI.sendRequest('create-test-group', {}).then((content) => {
</span><span class="lines">@@ -262,6 +264,18 @@
</span><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ it('should return "InvalidUploadedFile" when revision sets contains an invalid file ID', () => {
+ return addTriggerableAndCreateTask('some task').then((taskId) => {
+ const webkit = Repository.all().find((repository) => repository.name() == 'WebKit');
+ const revisionSets = [{[webkit.id()]: '191622', 'customRoots': ['1']}, {[webkit.id()]: '1'}];
+ return PrivilegedAPI.sendRequest('create-test-group', {name: 'test', task: taskId, revisionSets}).then((content) => {
+ assert(false, 'should never be reached');
+ }, (error) => {
+ assert.equal(error, 'InvalidUploadedFile');
+ });
+ });
+ });
+
</ins><span class="cx"> it('should return "InvalidRepository" when a revision set uses a repository name instead of a repository id', () => {
</span><span class="cx"> return addTriggerableAndCreateTask('some task').then((taskId) => {
</span><span class="cx"> return PrivilegedAPI.sendRequest('create-test-group', {name: 'test', task: taskId, revisionSets: [{'WebKit': '191622'}, {}]}).then((content) => {
</span><span class="lines">@@ -433,4 +447,81 @@
</span><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ it('should create a test group with a custom root', () => {
+ return addTriggerableAndCreateTask('some task').then((taskId) => {
+ let insertedGroupId;
+ const webkit = Repository.all().filter((repository) => repository.name() == 'WebKit')[0];
+ const macos = Repository.all().filter((repository) => repository.name() == 'macOS')[0];
+ let uploadedFile;
+ return TemporaryFile.makeTemporaryFile('some.dat', 'some content').then((stream) => {
+ return PrivilegedAPI.sendRequest('upload-file', {newFile: stream}, {useFormData: true});
+ }).then((response) => {
+ uploadedFile = response['uploadedFile'];
+ const revisionSets = [{[webkit.id()]: '191622', [macos.id()]: '15A284'},
+ {[webkit.id()]: '191622', [macos.id()]: '15A284', 'customRoots': [uploadedFile['id']]}];
+ return PrivilegedAPI.sendRequest('create-test-group', {name: 'test', task: taskId, repetitionCount: 2, revisionSets}).then((content) => {
+ insertedGroupId = content['testGroupId'];
+ return TestGroup.fetchByTask(taskId);
+ });
+ }).then((testGroups) => {
+ assert.equal(testGroups.length, 1);
+ const group = testGroups[0];
+ assert.equal(group.id(), insertedGroupId);
+ assert.equal(group.repetitionCount(), 2);
+ const requests = group.buildRequests();
+ assert.equal(requests.length, 4);
+
+ const set0 = requests[0].commitSet();
+ const set1 = requests[1].commitSet();
+ assert.equal(requests[2].commitSet(), set0);
+ assert.equal(requests[3].commitSet(), set1);
+ assert.deepEqual(Repository.sortByNamePreferringOnesWithURL(set0.repositories()), [webkit, macos]);
+ assert.deepEqual(set0.customRoots(), []);
+ assert.deepEqual(Repository.sortByNamePreferringOnesWithURL(set1.repositories()), [webkit, macos]);
+ assert.deepEqual(set1.customRoots(), [UploadedFile.ensureSingleton(uploadedFile['id'], uploadedFile)]);
+ assert.equal(set0.revisionForRepository(webkit), '191622');
+ assert.equal(set0.revisionForRepository(webkit), set1.revisionForRepository(webkit));
+ assert.equal(set0.commitForRepository(webkit), set1.commitForRepository(webkit));
+ assert.equal(set0.revisionForRepository(macos), '15A284');
+ assert.equal(set0.commitForRepository(macos), set1.commitForRepository(macos));
+ assert.equal(set0.revisionForRepository(macos), set1.revisionForRepository(macos));
+ assert(!set0.equals(set1));
+ });
+ });
+ });
+
+ it('should create a test group with an analysis task', () => {
+ let insertedGroupId;
+ let webkit;
+ return addTriggerableAndCreateTask('some task').then(() => {
+ webkit = Repository.all().filter((repository) => repository.name() == 'WebKit')[0];
+ const revisionSets = [{[webkit.id()]: '191622'}, {[webkit.id()]: '191623'}];
+ return PrivilegedAPI.sendRequest('create-test-group',
+ {name: 'test', taskName: 'other task', platform: MockData.somePlatformId(), test: MockData.someTestId(), revisionSets});
+ }).then((result) => {
+ insertedGroupId = result['testGroupId'];
+ return Promise.all([AnalysisTask.fetchById(result['taskId']), TestGroup.fetchByTask(result['taskId'])]);
+ }).then((result) => {
+ const [analysisTask, testGroups] = result;
+
+ assert.equal(analysisTask.name(), 'other task');
+
+ assert.equal(testGroups.length, 1);
+ const group = testGroups[0];
+ assert.equal(group.id(), insertedGroupId);
+ assert.equal(group.repetitionCount(), 1);
+ const requests = group.buildRequests();
+ assert.equal(requests.length, 2);
+
+ const set0 = requests[0].commitSet();
+ const set1 = requests[1].commitSet();
+ assert.deepEqual(set0.repositories(), [webkit]);
+ assert.deepEqual(set0.customRoots(), []);
+ assert.deepEqual(set1.repositories(), [webkit]);
+ assert.deepEqual(set1.customRoots(), []);
+ assert.equal(set0.revisionForRepository(webkit), '191622');
+ assert.equal(set1.revisionForRepository(webkit), '191623');
+ });
+ });
+
</ins><span class="cx"> });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgservertestsresourcesmockdatajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -39,10 +39,12 @@
</span><span class="cx"> db.insert('commits', {id: 87832, repository: this.macosRepositoryId(), revision: '10.11 15A284'}),
</span><span class="cx"> db.insert('commits', {id: 93116, repository: this.webkitRepositoryId(), revision: '191622', time: (new Date(1445945816878)).toISOString()}),
</span><span class="cx"> db.insert('commits', {id: 96336, repository: this.webkitRepositoryId(), revision: '192736', time: (new Date(1448225325650)).toISOString()}),
</span><ins>+ db.insert('builds', {id: 901, number: '901', time: '2015-10-27T12:05:27.1Z'}),
</ins><span class="cx"> db.insert('platforms', {id: MockData.somePlatformId(), name: 'some platform'}),
</span><span class="cx"> db.insert('tests', {id: MockData.someTestId(), name: 'some test'}),
</span><span class="cx"> db.insert('test_metrics', {id: 300, test: 200, name: 'some metric'}),
</span><span class="cx"> db.insert('test_configurations', {id: 301, metric: 300, platform: 65, type: 'current'}),
</span><ins>+ db.insert('test_runs', {id: 801, config: 301, build: 901, mean_cache: 100}),
</ins><span class="cx"> db.insert('commit_sets', {id: 401}),
</span><span class="cx"> db.insert('commit_set_relationships', {set: 401, commit: 87832}),
</span><span class="cx"> db.insert('commit_set_relationships', {set: 401, commit: 93116}),
</span><span class="lines">@@ -49,7 +51,9 @@
</span><span class="cx"> db.insert('commit_sets', {id: 402}),
</span><span class="cx"> db.insert('commit_set_relationships', {set: 402, commit: 87832}),
</span><span class="cx"> db.insert('commit_set_relationships', {set: 402, commit: 96336}),
</span><del>- db.insert('analysis_tasks', {id: 500, platform: 65, metric: 300, name: 'some task'}),
</del><ins>+ db.insert('analysis_tasks', {id: 500, platform: 65, metric: 300, name: 'some task',
+ start_run: 801, start_run_time: '2015-10-27T12:05:27.1Z',
+ end_run: 801, end_run_time: '2015-10-27T12:05:27.1Z'}),
</ins><span class="cx"> db.insert('analysis_test_groups', {id: 600, task: 500, name: 'some test group'}),
</span><span class="cx"> db.insert('build_requests', {id: 700, status: statusList[0], triggerable: 1000, repository_group: 2001, platform: 65, test: 200, group: 600, order: 0, commit_set: 401}),
</span><span class="cx"> db.insert('build_requests', {id: 701, status: statusList[1], triggerable: 1000, repository_group: 2001, platform: 65, test: 200, group: 600, order: 1, commit_set: 402}),
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtoolsjsremotejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tools/js/remote.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tools/js/remote.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/tools/js/remote.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -1,11 +1,13 @@
</span><span class="cx"> 'use strict';
</span><span class="cx">
</span><del>-let assert = require('assert');
-let http = require('http');
-let https = require('https');
-let querystring = require('querystring');
-let CommonRemoteAPI = require('../../public/shared/common-remote.js').CommonRemoteAPI;
</del><ins>+const assert = require('assert');
+const http = require('http');
+const https = require('https');
+const querystring = require('querystring');
+const CommonRemoteAPI = require('../../public/shared/common-remote.js').CommonRemoteAPI;
</ins><span class="cx">
</span><ins>+global.FormData = require('form-data');
+
</ins><span class="cx"> class NodeRemoteAPI extends CommonRemoteAPI {
</span><span class="cx"> constructor(server)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgunittestsbuildrequesttestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/unit-tests/build-request-tests.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/unit-tests/build-request-tests.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/unit-tests/build-request-tests.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -23,10 +23,12 @@
</span><span class="cx"> }],
</span><span class="cx"> "commitSets": [{
</span><span class="cx"> "id": "4255",
</span><del>- "commits": ["87832", "93116"]
</del><ins>+ "commits": ["87832", "93116"],
+ "customRoots": [],
</ins><span class="cx"> }, {
</span><span class="cx"> "id": "4256",
</span><del>- "commits": ["87832", "96336"]
</del><ins>+ "commits": ["87832", "96336"],
+ "customRoots": [],
</ins><span class="cx"> }],
</span><span class="cx"> "commits": [{
</span><span class="cx"> "id": "87832",
</span><span class="lines">@@ -49,6 +51,7 @@
</span><span class="cx"> "revision": "192736",
</span><span class="cx"> "time": 1448225325650
</span><span class="cx"> }],
</span><ins>+ "uploadedFiles": [],
</ins><span class="cx"> "status": "OK"
</span><span class="cx"> };
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgunittestsbuildbotsyncertestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx"> assert(platform instanceof Platform);
</span><span class="cx"> assert(test instanceof Test);
</span><span class="cx">
</span><del>- let commitSet = CommitSet.ensureSingleton('4197', {commits: [
</del><ins>+ let commitSet = CommitSet.ensureSingleton('4197', {customRoots: [], commits: [
</ins><span class="cx"> {'id': '111127', 'time': 1456955807334, 'repository': MockModels.webkit, 'revision': '197463'},
</span><span class="cx"> {'id': '111237', 'time': 1456931874000, 'repository': MockModels.sharedRepository, 'revision': '80229'},
</span><span class="cx"> {'id': '88930', 'time': 0, 'repository': MockModels.ios, 'revision': '13A452'},
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgunitteststestgroupstestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/unit-tests/test-groups-tests.js (215204 => 215205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/unit-tests/test-groups-tests.js 2017-04-10 21:44:20 UTC (rev 215204)
+++ trunk/Websites/perf.webkit.org/unit-tests/test-groups-tests.js 2017-04-10 21:45:11 UTC (rev 215205)
</span><span class="lines">@@ -15,9 +15,8 @@
</span><span class="cx"> "createdAt": 1458688514000,
</span><span class="cx"> "hidden": false,
</span><span class="cx"> "buildRequests": ["16985", "16986", "16987", "16988", "16989", "16990", "16991", "16992"],
</span><del>- "commitSets": ["4255", "4256", "4255", "4256", "4255", "4256", "4255", "4256"]
- }
- ],
</del><ins>+ "commitSets": ["4255", "4256"],
+ }],
</ins><span class="cx"> "buildRequests": [{
</span><span class="cx"> "id": "16985",
</span><span class="cx"> "triggerable": "3",
</span><span class="lines">@@ -67,16 +66,16 @@
</span><span class="cx"> "url": null,
</span><span class="cx"> "build": null,
</span><span class="cx"> "createdAt": 1458688514000
</span><del>- }
- ],
</del><ins>+ }],
</ins><span class="cx"> "commitSets": [{
</span><span class="cx"> "id": "4255",
</span><del>- "commits": ["87832", "93116"]
</del><ins>+ "commits": ["87832", "93116"],
+ "customRoots": [],
</ins><span class="cx"> }, {
</span><span class="cx"> "id": "4256",
</span><del>- "commits": ["87832", "96336"]
- }
- ],
</del><ins>+ "commits": ["87832", "96336"],
+ "customRoots": [],
+ }],
</ins><span class="cx"> "commits": [{
</span><span class="cx"> "id": "87832",
</span><span class="cx"> "repository": "9",
</span><span class="lines">@@ -97,8 +96,8 @@
</span><span class="cx"> "repository": "11",
</span><span class="cx"> "revision": "192736",
</span><span class="cx"> "time": 1448225325650
</span><del>- }
- ],
</del><ins>+ }],
+ "uploadedFiles": [],
</ins><span class="cx"> "status": "OK"
</span><span class="cx"> };
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>