<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215182] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215182">215182</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2017-04-10 09:05:16 -0700 (Mon, 10 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update localizable strings to "full screen" from "fullscreen"
https://bugs.webkit.org/show_bug.cgi?id=170675
rdar://problem/28207034
Reviewed by Antoine Quint.
Source/WebCore:
For localizable strings, it should consistently be "full screen" instead of "fullscreen".
* English.lproj/Localizable.strings:
* English.lproj/modern-media-controls-localized-strings.js:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagExitVideoFullscreen):
(WebCore::localizedMediaControlElementString):
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::exitFullScreenButtonAccessibilityTitle):
Source/WebInspectorUI:
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName): For localizable strings, it should consistently be
"full screen" instead of "fullscreen".</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreEnglishlprojLocalizablestrings">trunk/Source/WebCore/English.lproj/Localizable.strings</a></li>
<li><a href="#trunkSourceWebCoreEnglishlprojmodernmediacontrolslocalizedstringsjs">trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js</a></li>
<li><a href="#trunkSourceWebCoreplatformLocalizedStringscpp">trunk/Source/WebCore/platform/LocalizedStrings.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformcocoaLocalizedStringsCocoamm">trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsScriptTimelineRecordjs">trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2017-04-10 Jon Lee <jonlee@apple.com>
+
+ Update localizable strings to "full screen" from "fullscreen"
+ https://bugs.webkit.org/show_bug.cgi?id=170675
+ rdar://problem/28207034
+
+ Reviewed by Antoine Quint.
+
+ For localizable strings, it should consistently be "full screen" instead of "fullscreen".
+
+ * English.lproj/Localizable.strings:
+ * English.lproj/modern-media-controls-localized-strings.js:
+ * platform/LocalizedStrings.cpp:
+ (WebCore::contextMenuItemTagExitVideoFullscreen):
+ (WebCore::localizedMediaControlElementString):
+ * platform/cocoa/LocalizedStringsCocoa.mm:
+ (WebCore::exitFullScreenButtonAccessibilityTitle):
+
</ins><span class="cx"> 2017-04-10 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't generate extra scrolling tiles for non-visible pages.
</span></span></pre></div>
<a id="trunkSourceWebCoreEnglishlprojLocalizablestrings"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -247,11 +247,11 @@
</span><span class="cx"> /* Validation message for input form controls of type 'email' that have an invalid value */
</span><span class="cx"> "Enter an email address" = "Enter an email address";
</span><span class="cx">
</span><del>-/* Video Exit Fullscreen context menu item */
</del><ins>+/* Button for exiting full screen when in full screen media playback */
</ins><span class="cx"> "Exit Full Screen" = "Exit Full Screen";
</span><span class="cx">
</span><del>-/* Button for exiting fullscreen when in fullscreen media playback */
-"Exit Fullscreen" = "Exit Fullscreen";
</del><ins>+/* Video Exit Fullscreen context menu item */
+"Exit Full Screen (context menu)" = "Exit Full Screen";
</ins><span class="cx">
</span><span class="cx"> /* menu item */
</span><span class="cx"> "Exit Picture in Picture" = "Exit Picture in Picture";
</span><span class="lines">@@ -883,11 +883,11 @@
</span><span class="cx"> /* accessibility role description for an email field. */
</span><span class="cx"> "email field" = "email field";
</span><span class="cx">
</span><del>-/* accessibility label for enter fullscreen button */
-"enter fullscreen" = "enter fullscreen";
</del><ins>+/* accessibility label for enter full screen button */
+"enter full screen" = "enter full screen";
</ins><span class="cx">
</span><del>-/* accessibility label for exit fullscreen button */
-"exit fullscreen" = "exit fullscreen";
</del><ins>+/* accessibility label for exit full screen button */
+"exit full screen" = "exit full screen";
</ins><span class="cx">
</span><span class="cx"> /* HTTP result code string */
</span><span class="cx"> "expectation failed" = "expectation failed";
</span></span></pre></div>
<a id="trunkSourceWebCoreEnglishlprojmodernmediacontrolslocalizedstringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> const UIStrings = {
</span><span class="cx"> "AirPlay": "AirPlay",
</span><span class="cx"> "Audio": "Audio",
</span><del>- "Enter Fullscreen": "Enter Fullscreen",
</del><ins>+ "Enter Full Screen": "Enter Full Screen",
</ins><span class="cx"> "Enter Picture in Picture": "Enter Picture in Picture",
</span><span class="cx"> "Exit Full Screen": "Exit Full Screen",
</span><span class="cx"> "Error": "Error",
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLocalizedStringscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -388,7 +388,7 @@
</span><span class="cx">
</span><span class="cx"> String contextMenuItemTagExitVideoFullscreen()
</span><span class="cx"> {
</span><del>- return WEB_UI_STRING("Exit Full Screen", "Video Exit Fullscreen context menu item");
</del><ins>+ return WEB_UI_STRING_KEY("Exit Full Screen", "Exit Full Screen (context menu)", "Video Exit Fullscreen context menu item");
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -712,9 +712,9 @@
</span><span class="cx"> if (name == "StatusDisplay")
</span><span class="cx"> return WEB_UI_STRING("status", "accessibility label for movie status");
</span><span class="cx"> if (name == "EnterFullscreenButton")
</span><del>- return WEB_UI_STRING("enter fullscreen", "accessibility label for enter fullscreen button");
</del><ins>+ return WEB_UI_STRING("enter full screen", "accessibility label for enter full screen button");
</ins><span class="cx"> if (name == "ExitFullscreenButton")
</span><del>- return WEB_UI_STRING("exit fullscreen", "accessibility label for exit fullscreen button");
</del><ins>+ return WEB_UI_STRING("exit full screen", "accessibility label for exit full screen button");
</ins><span class="cx"> if (name == "SeekForwardButton")
</span><span class="cx"> return WEB_UI_STRING("fast forward", "accessibility label for fast forward button");
</span><span class="cx"> if (name == "SeekBackButton")
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformcocoaLocalizedStringsCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -350,7 +350,7 @@
</span><span class="cx">
</span><span class="cx"> String exitFullScreenButtonAccessibilityTitle()
</span><span class="cx"> {
</span><del>- return WEB_UI_STRING("Exit Fullscreen", "Button for exiting fullscreen when in fullscreen media playback");
</del><ins>+ return WEB_UI_STRING("Exit Full Screen", "Button for exiting full screen when in full screen media playback");
</ins><span class="cx"> }
</span><span class="cx"> #endif // PLATFORM(MAC)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-04-10 Jon Lee <jonlee@apple.com>
+
+ Update localizable strings to "full screen" from "fullscreen"
+ https://bugs.webkit.org/show_bug.cgi?id=170675
+ rdar://problem/28207034
+
+ Reviewed by Antoine Quint.
+
+ * UserInterface/Models/ScriptTimelineRecord.js:
+ (WebInspector.ScriptTimelineRecord.EventType.displayName): For localizable strings, it should consistently be
+ "full screen" instead of "fullscreen".
+
</ins><span class="cx"> 2017-04-09 Devin Rousso <webkit@devinrousso.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: tabbing in Styles sidebar is broken when additional ":" and ";" are in the property value
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsScriptTimelineRecordjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (215181 => 215182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js 2017-04-10 16:05:16 UTC (rev 215182)
</span><span class="lines">@@ -329,12 +329,12 @@
</span><span class="cx"> nameMap.set("webkitEditableContentChanged", "Editable Content Changed");
</span><span class="cx"> nameMap.set("webkitTransitionEnd", "Transition End");
</span><span class="cx"> nameMap.set("webkitaddsourcebuffer", "Add Source Buffer");
</span><del>- nameMap.set("webkitbeginfullscreen", "Begin Fullscreen");
</del><ins>+ nameMap.set("webkitbeginfullscreen", "Begin Full Screen");
</ins><span class="cx"> nameMap.set("webkitcurrentplaybacktargetiswirelesschanged", "Current Playback Target Is Wireless Changed");
</span><span class="cx"> nameMap.set("webkitdeviceproximity", "Device Proximity");
</span><del>- nameMap.set("webkitendfullscreen", "End Fullscreen");
- nameMap.set("webkitfullscreenchange", "Fullscreen Change");
- nameMap.set("webkitfullscreenerror", "Fullscreen Error");
</del><ins>+ nameMap.set("webkitendfullscreen", "End Full Screen");
+ nameMap.set("webkitfullscreenchange", "Full Screen Change");
+ nameMap.set("webkitfullscreenerror", "Full Screen Error");
</ins><span class="cx"> nameMap.set("webkitkeyadded", "Key Added");
</span><span class="cx"> nameMap.set("webkitkeyerror", "Key Error");
</span><span class="cx"> nameMap.set("webkitkeymessage", "Key Message");
</span></span></pre>
</div>
</div>
</body>
</html>