<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215161] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215161">215161</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-09 08:27:08 -0700 (Sun, 09 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>test262: test262/test/annexB/language/literals/regexp/identity-escape.js
https://bugs.webkit.org/show_bug.cgi?id=170651
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-04-09
Reviewed by Saam Barati.
JSTests:
* test262.yaml:
Source/JavaScriptCore:
* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseEscape):
For \8 and \9 match just the number "8" or "9" instead of both "\\" and the number.
See: https://tc39.github.io/ecma262/#sec-decimalescape
LayoutTests:
* js/regexp-no-extensions-expected.txt:
* js/script-tests/regexp-no-extensions.js:
Update existing test for these edge cases.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTeststest262yaml">trunk/JSTests/test262.yaml</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsregexpnoextensionsexpectedtxt">trunk/LayoutTests/js/regexp-no-extensions-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsregexpnoextensionsjs">trunk/LayoutTests/js/script-tests/regexp-no-extensions.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreyarrYarrParserh">trunk/Source/JavaScriptCore/yarr/YarrParser.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/JSTests/ChangeLog 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2017-04-09 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: test262/test/annexB/language/literals/regexp/identity-escape.js
+ https://bugs.webkit.org/show_bug.cgi?id=170651
+
+ Reviewed by Saam Barati.
+
+ * test262.yaml:
+
</ins><span class="cx"> 2017-04-07 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix and enable ChakraCore/test/es6/ES6Function_bugs.js after r215072
</span></span></pre></div>
<a id="trunkJSTeststest262yaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/test262.yaml (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/test262.yaml 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/JSTests/test262.yaml 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -2402,9 +2402,9 @@
</span><span class="cx"> - path: test262/test/annexB/language/literals/regexp/extended-pattern-char.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
</span><span class="cx"> - path: test262/test/annexB/language/literals/regexp/identity-escape.js
</span><del>- cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
</del><ins>+ cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
</ins><span class="cx"> - path: test262/test/annexB/language/literals/regexp/identity-escape.js
</span><del>- cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
</del><ins>+ cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
</ins><span class="cx"> - path: test262/test/annexB/language/literals/regexp/legacy-octal-escape.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
</span><span class="cx"> - path: test262/test/annexB/language/literals/regexp/legacy-octal-escape.js
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/LayoutTests/ChangeLog 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-04-09 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: test262/test/annexB/language/literals/regexp/identity-escape.js
+ https://bugs.webkit.org/show_bug.cgi?id=170651
+
+ Reviewed by Saam Barati.
+
+ * js/regexp-no-extensions-expected.txt:
+ * js/script-tests/regexp-no-extensions.js:
+ Update existing test for these edge cases.
+
</ins><span class="cx"> 2017-04-08 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [Variation Fonts] Width values of GX fonts are not mapped correctly
</span></span></pre></div>
<a id="trunkLayoutTestsjsregexpnoextensionsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/regexp-no-extensions-expected.txt (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regexp-no-extensions-expected.txt 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/LayoutTests/js/regexp-no-extensions-expected.txt 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -10,7 +10,8 @@
</span><span class="cx"> PASS /[\x1g]/.exec("1").toString() is "1"
</span><span class="cx"> PASS /\2147483648/.exec(String.fromCharCode(140) + "7483648").toString() is String.fromCharCode(140) + "7483648"
</span><span class="cx"> PASS /\4294967296/.exec("\"94967296").toString() is "\"94967296"
</span><del>-PASS /\8589934592/.exec("\\8589934592").toString() is "\\8589934592"
</del><ins>+PASS /\8589934592/.exec("\\8589934592").toString() is "8589934592"
+PASS /\9589934592/.exec("\\9589934592").toString() is "9589934592"
</ins><span class="cx"> PASS "\nAbc\n".replace(/(\n)[^\n]+$/, "$1") is "\nAbc\n"
</span><span class="cx"> PASS /x$/.exec("x\n") is null
</span><span class="cx"> PASS /x++/ threw exception SyntaxError: Invalid regular expression: nothing to repeat.
</span><span class="lines">@@ -33,9 +34,12 @@
</span><span class="cx"> PASS /\1q/.exec("y" + String.fromCharCode(1) + "q").toString() is String.fromCharCode(1) + "q"
</span><span class="cx"> PASS /[\1q]/.exec("y" + String.fromCharCode(1) + "q").toString() is String.fromCharCode(1)
</span><span class="cx"> PASS /[\1q]/.exec("yq").toString() is "q"
</span><del>-PASS /\8q/.exec("\\8q").toString() is "\\8q"
</del><ins>+PASS /\8q/.exec("\\8q").toString() is "8q"
</ins><span class="cx"> PASS /[\8q]/.exec("y8q").toString() is "8"
</span><span class="cx"> PASS /[\8q]/.exec("yq").toString() is "q"
</span><ins>+PASS /\9q/.exec("\\9q").toString() is "9q"
+PASS /[\9q]/.exec("y9q").toString() is "9"
+PASS /[\9q]/.exec("yq").toString() is "q"
</ins><span class="cx"> PASS /(x)\1q/.exec("xxq").toString() is "xxq,x"
</span><span class="cx"> PASS /(x)[\1q]/.exec("xxq").toString() is "xq,x"
</span><span class="cx"> PASS /(x)[\1q]/.exec("xx" + String.fromCharCode(1)).toString() is "x" + String.fromCharCode(1) + ",x"
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsregexpnoextensionsjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/regexp-no-extensions.js (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/regexp-no-extensions.js 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/LayoutTests/js/script-tests/regexp-no-extensions.js 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -11,7 +11,8 @@
</span><span class="cx"> shouldBe('/[\\x1g]/.exec("1").toString()', '"1"');
</span><span class="cx"> shouldBe('/\\2147483648/.exec(String.fromCharCode(140) + "7483648").toString()', 'String.fromCharCode(140) + "7483648"');
</span><span class="cx"> shouldBe('/\\4294967296/.exec("\\"94967296").toString()', '"\\"94967296"');
</span><del>-shouldBe('/\\8589934592/.exec("\\\\8589934592").toString()', '"\\\\8589934592"');
</del><ins>+shouldBe('/\\8589934592/.exec("\\\\8589934592").toString()', '"8589934592"');
+shouldBe('/\\9589934592/.exec("\\\\9589934592").toString()', '"9589934592"');
</ins><span class="cx"> shouldBe('"\\nAbc\\n".replace(/(\\n)[^\\n]+$/, "$1")', '"\\nAbc\\n"');
</span><span class="cx"> shouldBe('/x$/.exec("x\\n")', 'null');
</span><span class="cx"> shouldThrow('/x++/');
</span><span class="lines">@@ -36,9 +37,12 @@
</span><span class="cx"> shouldBe('/\\1q/.exec("y" + String.fromCharCode(1) + "q").toString()', 'String.fromCharCode(1) + "q"');
</span><span class="cx"> shouldBe('/[\\1q]/.exec("y" + String.fromCharCode(1) + "q").toString()', 'String.fromCharCode(1)');
</span><span class="cx"> shouldBe('/[\\1q]/.exec("yq").toString()', '"q"');
</span><del>-shouldBe('/\\8q/.exec("\\\\8q").toString()', '"\\\\8q"');
</del><ins>+shouldBe('/\\8q/.exec("\\\\8q").toString()', '"8q"');
</ins><span class="cx"> shouldBe('/[\\8q]/.exec("y8q").toString()', '"8"');
</span><span class="cx"> shouldBe('/[\\8q]/.exec("yq").toString()', '"q"');
</span><ins>+shouldBe('/\\9q/.exec("\\\\9q").toString()', '"9q"');
+shouldBe('/[\\9q]/.exec("y9q").toString()', '"9"');
+shouldBe('/[\\9q]/.exec("yq").toString()', '"q"');
</ins><span class="cx"> shouldBe('/(x)\\1q/.exec("xxq").toString()', '"xxq,x"');
</span><span class="cx"> shouldBe('/(x)[\\1q]/.exec("xxq").toString()', '"xq,x"');
</span><span class="cx"> shouldBe('/(x)[\\1q]/.exec("xx" + String.fromCharCode(1)).toString()', '"x" + String.fromCharCode(1) + ",x"');
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-04-09 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: test262/test/annexB/language/literals/regexp/identity-escape.js
+ https://bugs.webkit.org/show_bug.cgi?id=170651
+
+ Reviewed by Saam Barati.
+
+ * yarr/YarrParser.h:
+ (JSC::Yarr::Parser::parseEscape):
+ For \8 and \9 match just the number "8" or "9" instead of both "\\" and the number.
+ See: https://tc39.github.io/ecma262/#sec-decimalescape
+
</ins><span class="cx"> 2017-04-08 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> WebRTC tests gardening
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreyarrYarrParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/yarr/YarrParser.h (215160 => 215161)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/yarr/YarrParser.h 2017-04-09 14:49:14 UTC (rev 215160)
+++ trunk/Source/JavaScriptCore/yarr/YarrParser.h 2017-04-09 15:27:08 UTC (rev 215161)
</span><span class="lines">@@ -344,9 +344,9 @@
</span><span class="cx"> restoreState(state);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Not a backreference, and not octal.
</del><ins>+ // Not a backreference, and not octal. Just a number.
</ins><span class="cx"> if (peek() >= '8') {
</span><del>- delegate.atomPatternCharacter('\\');
</del><ins>+ delegate.atomPatternCharacter(consume());
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>