<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215151] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215151">215151</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-04-08 16:03:16 -0700 (Sat, 08 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
https://bugs.webkit.org/show_bug.cgi?id=170643
Reviewed by Chris Dumez.
Source/WebCore:
Structural changes:
- move implementation-related "comment" blocks into "codegen-properties"
- move status-related "comment" blocks into "status"
Add the concept of "obsolete-category" and "obsolete-url" for properties
like the text-fill-and-stroke properties that used to be specified in SVG but
now have their own module shared with CSS.
Update the status of paint-order, stroke-linecap, stroke-linejoin, stroke-miterlimit
and stroke-width to "supported", overriding the default for css-text-fill-and-stroke which
is "under consideration".
Add display values "flow" and "flow-root" but mark them as unimplemented.
Fix makeprop.pl to ignore comments inside codegen-properties.
* css/CSSProperties.json:
* css/makeprop.pl:
(addProperty):
Tools:
Update the CSSProperties.json style checker to allow:
- comments in codegen_properties
- obsolete-category and obsolete-url in specification blocks
- renamed "done" to "supported"
Fix some references to codegen_properties to be codegen-properties.
* Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.validate_status_type):
(JSONCSSPropertiesChecker.validate_property_specification):
(JSONCSSPropertiesChecker.check_codegen_properties):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSPropertiesjson">trunk/Source/WebCore/css/CSSProperties.json</a></li>
<li><a href="#trunkSourceWebCorecssmakeproppl">trunk/Source/WebCore/css/makeprop.pl</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckersjsoncheckerpy">trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (215150 => 215151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-04-08 22:44:39 UTC (rev 215150)
+++ trunk/Source/WebCore/ChangeLog 2017-04-08 23:03:16 UTC (rev 215151)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2017-04-08 Simon Fraser <simon.fraser@apple.com>
+
+ Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=170643
+
+ Reviewed by Chris Dumez.
+
+ Structural changes:
+ - move implementation-related "comment" blocks into "codegen-properties"
+ - move status-related "comment" blocks into "status"
+
+ Add the concept of "obsolete-category" and "obsolete-url" for properties
+ like the text-fill-and-stroke properties that used to be specified in SVG but
+ now have their own module shared with CSS.
+
+ Update the status of paint-order, stroke-linecap, stroke-linejoin, stroke-miterlimit
+ and stroke-width to "supported", overriding the default for css-text-fill-and-stroke which
+ is "under consideration".
+
+ Add display values "flow" and "flow-root" but mark them as unimplemented.
+
+ Fix makeprop.pl to ignore comments inside codegen-properties.
+
+ * css/CSSProperties.json:
+ * css/makeprop.pl:
+ (addProperty):
+
</ins><span class="cx"> 2017-04-08 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream iOS] Update muted state when interrupted
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPropertiesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSProperties.json (215150 => 215151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSProperties.json 2017-04-08 22:44:39 UTC (rev 215150)
+++ trunk/Source/WebCore/css/CSSProperties.json 2017-04-08 23:03:16 UTC (rev 215151)
</span><span class="lines">@@ -177,10 +177,12 @@
</span><span class="cx"> "no-default-color": true,
</span><span class="cx"> "high-priority": true
</span><span class="cx"> },
</span><ins>+ "status": {
+ "comment": "All the values from CSS Color Level 3 are supported, as well as the 8- and 4-digit forms of hex color, and the color() function."
+ },
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css-color",
</span><del>- "url": "https://www.w3.org/TR/css-color-4/#the-color-property",
- "comment": "All the values from CSS Color Level 3 are supported, as well as the 8- and 4-digit forms of hex color, and the color() function."
</del><ins>+ "url": "https://www.w3.org/TR/css-color-4/#the-color-property"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "direction": {
</span><span class="lines">@@ -202,6 +204,16 @@
</span><span class="cx"> "values": [
</span><span class="cx"> "inline",
</span><span class="cx"> "block",
</span><ins>+ {
+ "value": "flow",
+ "status": "not implemented",
+ "url": "https://www.w3.org/TR/css-display-3/#valdef-display-flow"
+ },
+ {
+ "value": "flow-root",
+ "status": "not implemented",
+ "url": "https://www.w3.org/TR/css-display-3/#valdef-display-flow-root"
+ },
</ins><span class="cx"> "list-item",
</span><span class="cx"> {
</span><span class="cx"> "value": "compact",
</span><span class="lines">@@ -210,7 +222,7 @@
</span><span class="cx"> "inline-block",
</span><span class="cx"> {
</span><span class="cx"> "value": "run-in",
</span><del>- "status": "Removed",
</del><ins>+ "status": "removed",
</ins><span class="cx"> "url": "https://www.w3.org/TR/css-display-3/#valdef-display-run-in",
</span><span class="cx"> "comment": "Removed in https://trac.webkit.org/r163560"
</span><span class="cx"> },
</span><span class="lines">@@ -740,8 +752,8 @@
</span><span class="cx"> "status": "unimplemented"
</span><span class="cx"> }
</span><span class="cx"> ],
</span><del>- "status": {
- "comment": "This is the highest priority property and 'is resolved before all other properties, to ensure that its value can be checked when determining a smart default font size', (<https://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=172861>)."
</del><ins>+ "codegen-properties": {
+ "comment": "This is the highest priority property and 'is resolved before all other properties, to ensure that its value can be checked when determining a smart default font size', (<https://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=172861>)."
</ins><span class="cx"> },
</span><span class="cx"> "specification": {
</span><span class="cx"> "category": "css-ruby",
</span><span class="lines">@@ -2780,9 +2792,11 @@
</span><span class="cx"> "codegen-properties": {
</span><span class="cx"> "converter": "PaintOrder"
</span><span class="cx"> },
</span><ins>+ "status": "supported",
</ins><span class="cx"> "specification": {
</span><del>- "category": "svg",
- "url": "https://www.w3.org/TR/SVG2/painting.html#PaintOrderProperty"
</del><ins>+ "category": "css-text-fill-and-stroke",
+ "obsolete-category": "svg",
+ "obsolete-url": "https://www.w3.org/TR/SVG2/painting.html#PaintOrderProperty"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "pointer-events": {
</span><span class="lines">@@ -2987,9 +3001,12 @@
</span><span class="cx"> "codegen-properties": {
</span><span class="cx"> "name-for-methods": "CapStyle"
</span><span class="cx"> },
</span><ins>+ "status": "supported",
</ins><span class="cx"> "specification": {
</span><del>- "category": "svg",
- "url": "https://www.w3.org/TR/SVG11/painting.html#StrokeLinecapProperty"
</del><ins>+ "category": "css-text-fill-and-stroke",
+ "url": "https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-linecap",
+ "obsolete-category": "svg",
+ "obsolete-url": "https://www.w3.org/TR/SVG11/painting.html#StrokeLinecapProperty"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "stroke-linejoin": {
</span><span class="lines">@@ -3002,9 +3019,12 @@
</span><span class="cx"> "codegen-properties": {
</span><span class="cx"> "name-for-methods": "JoinStyle"
</span><span class="cx"> },
</span><ins>+ "status": "supported",
</ins><span class="cx"> "specification": {
</span><del>- "category": "svg",
- "url": "https://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty"
</del><ins>+ "category": "css-text-fill-and-stroke",
+ "url": "https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-linejoin",
+ "obsolete-category": "svg",
+ "obsolete-url": "https://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "stroke-miterlimit": {
</span><span class="lines">@@ -3013,9 +3033,12 @@
</span><span class="cx"> "name-for-methods": "StrokeMiterLimit",
</span><span class="cx"> "converter": "Number<float>"
</span><span class="cx"> },
</span><ins>+ "status": "supported",
</ins><span class="cx"> "specification": {
</span><del>- "category": "svg",
- "url": "https://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty"
</del><ins>+ "category": "css-text-fill-and-stroke",
+ "url": "https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-miterlimit",
+ "obsolete-category": "svg",
+ "obsolete-url": "https://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "stroke-opacity": {
</span><span class="lines">@@ -3036,9 +3059,12 @@
</span><span class="cx"> "initial": "initialOneLength",
</span><span class="cx"> "converter": "Length"
</span><span class="cx"> },
</span><ins>+ "status": "supported",
</ins><span class="cx"> "specification": {
</span><del>- "category": "svg",
- "url": "https://www.w3.org/TR/SVG11/painting.html#StrokeWidthProperty"
</del><ins>+ "category": "css-text-fill-and-stroke",
+ "url": "https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-width",
+ "obsolete-category": "svg",
+ "obsolete-url": "https://www.w3.org/TR/SVG11/painting.html#StrokeWidthProperty"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "speak": {
</span><span class="lines">@@ -3606,11 +3632,13 @@
</span><span class="cx"> "codegen-properties": {
</span><span class="cx"> "name-for-methods": "OverflowWrap"
</span><span class="cx"> },
</span><del>- "status": "obsolete",
</del><ins>+ "status": {
+ "status": "obsolete",
+ "comment": "Replaced by overflow-wrap"
+ },
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css-text",
</span><del>- "url": "https://www.w3.org/TR/css-text-3/#overflow-wrap",
- "comment": "Replaced by overflow-wrap"
</del><ins>+ "url": "https://www.w3.org/TR/css-text-3/#overflow-wrap"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "x": {
</span><span class="lines">@@ -3783,9 +3811,7 @@
</span><span class="cx"> "fill-layer-property": true
</span><span class="cx"> },
</span><span class="cx"> "status": {
</span><del>- "status": "experimental"
- },
- "specification": {
</del><ins>+ "status": "experimental",
</ins><span class="cx"> "comment": "Partially subsumed by background-blend-mode."
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="lines">@@ -4973,11 +4999,13 @@
</span><span class="cx"> "none",
</span><span class="cx"> "edges"
</span><span class="cx"> ],
</span><del>- "status": "obsolete",
</del><ins>+ "status": {
+ "status": "obsolete",
+ "comment": "Added in https://trac.webkit.org/changeset/108133"
+ },
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css-line-grid",
</span><del>- "url": "https://www.w3.org/TR/css-line-grid-1/",
- "comment": "Added in https://trac.webkit.org/changeset/108133"
</del><ins>+ "url": "https://www.w3.org/TR/css-line-grid-1/"
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> "line-break": {
</span><span class="lines">@@ -5961,9 +5989,7 @@
</span><span class="cx"> "preserve-3d"
</span><span class="cx"> ],
</span><span class="cx"> "codegen-properties": {
</span><del>- "name-for-methods": "TransformStyle3D"
- },
- "status": {
</del><ins>+ "name-for-methods": "TransformStyle3D",
</ins><span class="cx"> "comment": "Keeping -webkit-transform-style around is how we'll detect legacy content. At that point, we'll have to add a custom builder and a new ETransformStyle3D type. FIXME: this never happened."
</span><span class="cx"> }
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebCorecssmakeproppl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/makeprop.pl (215150 => 215151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/makeprop.pl 2017-04-08 22:44:39 UTC (rev 215150)
+++ trunk/Source/WebCore/css/makeprop.pl 2017-04-08 23:03:16 UTC (rev 215151)
</span><span class="lines">@@ -188,6 +188,8 @@
</span><span class="cx"> next;
</span><span class="cx"> } elsif ($codegenOptionName eq "skip-codegen") {
</span><span class="cx"> next;
</span><ins>+ } elsif ($codegenOptionName eq "comment") {
+ next;
</ins><span class="cx"> } elsif ($codegenOptionName eq "high-priority") {
</span><span class="cx"> $nameIsHighPriority{$name} = 1;
</span><span class="cx"> } elsif ($codegenOptionName eq "aliases") {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (215150 => 215151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-04-08 22:44:39 UTC (rev 215150)
+++ trunk/Tools/ChangeLog 2017-04-08 23:03:16 UTC (rev 215151)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-04-08 Simon Fraser <simon.fraser@apple.com>
+
+ Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=170643
+
+ Reviewed by Chris Dumez.
+
+ Update the CSSProperties.json style checker to allow:
+ - comments in codegen_properties
+ - obsolete-category and obsolete-url in specification blocks
+ - renamed "done" to "supported"
+
+ Fix some references to codegen_properties to be codegen-properties.
+
+ * Scripts/webkitpy/style/checkers/jsonchecker.py:
+ (JSONCSSPropertiesChecker.validate_status_type):
+ (JSONCSSPropertiesChecker.validate_property_specification):
+ (JSONCSSPropertiesChecker.check_codegen_properties):
+
</ins><span class="cx"> 2017-04-08 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> WebRTC tests gardening
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckersjsoncheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py (215150 => 215151)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2017-04-08 22:44:39 UTC (rev 215150)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2017-04-08 23:03:16 UTC (rev 215151)
</span><span class="lines">@@ -177,7 +177,7 @@
</span><span class="cx"> self.validate_string(property_name, property_key, key, value)
</span><span class="cx">
</span><span class="cx"> allowed_statuses = {
</span><del>- 'done',
</del><ins>+ 'supported',
</ins><span class="cx"> 'in development',
</span><span class="cx"> 'under consideration',
</span><span class="cx"> 'experimental',
</span><span class="lines">@@ -229,6 +229,8 @@
</span><span class="cx"> keys_and_validators = {
</span><span class="cx"> 'category': self.validate_property_category,
</span><span class="cx"> 'url': self.validate_url,
</span><ins>+ 'obsolete-category': self.validate_property_category,
+ 'obsolete-url': self.validate_url,
</ins><span class="cx"> 'documentation-url': self.validate_url,
</span><span class="cx"> 'keywords': self.validate_array,
</span><span class="cx"> 'description': self.validate_string,
</span><span class="lines">@@ -265,12 +267,13 @@
</span><span class="cx">
</span><span class="cx"> def check_codegen_properties(self, property_name, codegen_properties):
</span><span class="cx"> if not isinstance(codegen_properties, (dict, list)):
</span><del>- self._handle_style_error(0, 'json/syntax', 5, '"codegen_properties" for property "%s" is not a dictionary or array.' % property_name)
</del><ins>+ self._handle_style_error(0, 'json/syntax', 5, '"codegen-properties" for property "%s" is not a dictionary or array.' % property_name)
</ins><span class="cx"> return
</span><span class="cx">
</span><span class="cx"> keys_and_validators = {
</span><span class="cx"> 'aliases': self.validate_array,
</span><span class="cx"> 'auto-functions': self.validate_boolean,
</span><ins>+ 'comment': self.validate_string,
</ins><span class="cx"> 'conditional-converter': self.validate_string,
</span><span class="cx"> 'converter': self.validate_string,
</span><span class="cx"> 'custom': self.validate_string,
</span><span class="lines">@@ -293,7 +296,7 @@
</span><span class="cx">
</span><span class="cx"> for key, value in codegen_properties.items():
</span><span class="cx"> if key not in keys_and_validators:
</span><del>- self._handle_style_error(0, 'json/syntax', 5, 'codegen_properties for property "%s" has unexpected key "%s".' % (property_name, key))
</del><ins>+ self._handle_style_error(0, 'json/syntax', 5, 'codegen-properties for property "%s" has unexpected key "%s".' % (property_name, key))
</ins><span class="cx"> return
</span><span class="cx">
</span><del>- keys_and_validators[key](property_name, 'codegen_properties', key, value)
</del><ins>+ keys_and_validators[key](property_name, 'codegen-properties', key, value)
</ins></span></pre>
</div>
</div>
</body>
</html>