<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215118] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215118">215118</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-07 14:45:45 -0700 (Fri, 07 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make cycler page scroll down when a dashboard is too tall for the current viewport size
https://bugs.webkit.org/show_bug.cgi?id=170588
Rubber-stamped by Chris Dumez.
Updated the cycler page to scroll down smoothly over 500ms and scroll up again before moving to the next page
when a dashboard page is too tall to be shown at once. For now, we assume that each dashboard's height is no
more than 2x the height of the viewport.
* public/cycler.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpubliccyclerhtml">trunk/Websites/perf.webkit.org/public/cycler.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (215117 => 215118)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2017-04-07 21:37:57 UTC (rev 215117)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-04-07 21:45:45 UTC (rev 215118)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-04-07 Ryosuke Niwa <rniwa@webkit.org>
+
+ Make cycler page scroll down when a dashboard is too tall for the current viewport size
+ https://bugs.webkit.org/show_bug.cgi?id=170588
+
+ Rubber-stamped by Chris Dumez.
+
+ Updated the cycler page to scroll down smoothly over 500ms and scroll up again before moving to the next page
+ when a dashboard page is too tall to be shown at once. For now, we assume that each dashboard's height is no
+ more than 2x the height of the viewport.
+
+ * public/cycler.html:
+
</ins><span class="cx"> 2017-04-06 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Each build request should be associated with a repository group
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpubliccyclerhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/cycler.html (215117 => 215118)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/cycler.html 2017-04-07 21:37:57 UTC (rev 215117)
+++ trunk/Websites/perf.webkit.org/public/cycler.html 2017-04-07 21:45:45 UTC (rev 215118)
</span><span class="lines">@@ -9,10 +9,10 @@
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span><span class="cx">
</span><del>-var urls = [];
-var CycleSeconds = 30;
</del><ins>+const urls = [];
+const CycleSeconds = 30;
</ins><span class="cx">
</span><del>-var request = new XMLHttpRequest();
</del><ins>+const request = new XMLHttpRequest();
</ins><span class="cx"> request.open('GET', '/data/manifest.json', true);
</span><span class="cx"> request.send(null);
</span><span class="cx"> request.onreadystatechange = function () {
</span><span class="lines">@@ -23,26 +23,33 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var manifest = JSON.parse(request.responseText);
- var dashboards = [];
- for (var dashboardName in manifest.dashboards)
</del><ins>+ const manifest = JSON.parse(request.responseText);
+ const dashboards = [];
+ for (const dashboardName in manifest.dashboards)
</ins><span class="cx"> dashboards.push(dashboardName);
</span><span class="cx">
</span><del>- for (var dashboardName of dashboards)
</del><ins>+ for (const dashboardName of dashboards)
</ins><span class="cx"> urls.push('/v3/#/dashboard/' + dashboardName);
</span><span class="cx">
</span><span class="cx"> loadURLAt(0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-var oldIframe = null;
-function loadURLAt(i) {
- var newIframe = document.createElement('iframe');
</del><ins>+let oldIframe = null;
+function loadURLAt(i)
+{
+ const newIframe = document.createElement('iframe');
</ins><span class="cx"> document.body.appendChild(newIframe);
</span><span class="cx"> newIframe.src = urls[i];
</span><del>- newIframe.onload = showNewFrame.bind(window, i, newIframe);
</del><ins>+ newIframe.onload = () => {
+ scrollUpIfNeeded(oldIframe).then(() => {
+ showNewFrame(i, newIframe);
+ setTimeout(() => scrollDownIfNeeded(newIframe), CycleSeconds * 1000 / 2);
+ });
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function showNewFrame(i, iframe) {
</del><ins>+function showNewFrame(i, iframe)
+{
</ins><span class="cx"> if (oldIframe)
</span><span class="cx"> document.body.removeChild(oldIframe);
</span><span class="cx"> oldIframe = iframe;
</span><span class="lines">@@ -51,6 +58,28 @@
</span><span class="cx"> setTimeout(loadURLAt.bind(window, i), CycleSeconds * 1000);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function scrollUpIfNeeded(iframe)
+{
+ const diff = iframe ? iframe.scrollDiff : 0;
+ if (!diff)
+ return Promise.resolve();
+ for (let i = 0; i < 500; i++)
+ setTimeout(() => iframe.contentWindow.scrollTo(0, oldIframe.scrollDiff / 500 * (500 - i)), i);
+ return new Promise((resolve) => setTimeout(resolve, 800));
+}
+
+function scrollDownIfNeeded(iframe)
+{
+ const viewportHeight = iframe.contentWindow.innerHeight;
+ const contentHeight = iframe.contentDocument.body.offsetHeight;
+ if (viewportHeight >= contentHeight)
+ return;
+ const diff = contentHeight - viewportHeight;
+ for (let i = 0; i < 500; i++)
+ setTimeout(() => iframe.contentWindow.scrollTo(0, diff / 500 * i), i);
+ iframe.scrollDiff = diff;
+}
+
</ins><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre>
</div>
</div>
</body>
</html>