<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[215063] trunk/Source/WebKit/mac</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215063">215063</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2017-04-06 15:38:04 -0700 (Thu, 06 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
https://bugs.webkit.org/show_bug.cgi?id=170566
Reviewed by Simon Fraser.
* DOM/DOMCSS.mm:
(kitClass):
Use the WebCore-side enum for this, since that's actually what we're switching over.
This allows us to handle values here without adding them to the API header.
All of the other kitClass() functions work the same way.
Also, unindent for style purposes.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDOMDOMCSSmm">trunk/Source/WebKit/mac/DOM/DOMCSS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (215062 => 215063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2017-04-06 22:02:04 UTC (rev 215062)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-04-06 22:38:04 UTC (rev 215063)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-04-06 Tim Horton <timothy_horton@apple.com>
+
+ Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
+ https://bugs.webkit.org/show_bug.cgi?id=170566
+
+ Reviewed by Simon Fraser.
+
+ * DOM/DOMCSS.mm:
+ (kitClass):
+ Use the WebCore-side enum for this, since that's actually what we're switching over.
+ This allows us to handle values here without adding them to the API header.
+ All of the other kitClass() functions work the same way.
+ Also, unindent for style purposes.
+
</ins><span class="cx"> 2017-04-06 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> WebRTC tests gardening
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMDOMCSSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/DOMCSS.mm (215062 => 215063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/DOMCSS.mm 2017-04-06 22:02:04 UTC (rev 215062)
+++ trunk/Source/WebKit/mac/DOM/DOMCSS.mm 2017-04-06 22:38:04 UTC (rev 215063)
</span><span class="lines">@@ -61,31 +61,31 @@
</span><span class="cx"> Class kitClass(WebCore::CSSRule* impl)
</span><span class="cx"> {
</span><span class="cx"> switch (impl->type()) {
</span><del>- case DOM_UNKNOWN_RULE:
- return [DOMCSSUnknownRule class];
- case DOM_STYLE_RULE:
- return [DOMCSSStyleRule class];
- case DOM_CHARSET_RULE:
- return [DOMCSSCharsetRule class];
- case DOM_IMPORT_RULE:
- return [DOMCSSImportRule class];
- case DOM_MEDIA_RULE:
- return [DOMCSSMediaRule class];
- case DOM_FONT_FACE_RULE:
- return [DOMCSSFontFaceRule class];
- case DOM_PAGE_RULE:
- return [DOMCSSPageRule class];
- case DOM_KEYFRAMES_RULE:
- case DOM_NAMESPACE_RULE:
- case DOM_KEYFRAME_RULE:
- case DOM_SUPPORTS_RULE:
</del><ins>+ case WebCore::CSSRule::UNKNOWN_RULE:
+ return [DOMCSSUnknownRule class];
+ case WebCore::CSSRule::STYLE_RULE:
+ return [DOMCSSStyleRule class];
+ case WebCore::CSSRule::CHARSET_RULE:
+ return [DOMCSSCharsetRule class];
+ case WebCore::CSSRule::IMPORT_RULE:
+ return [DOMCSSImportRule class];
+ case WebCore::CSSRule::MEDIA_RULE:
+ return [DOMCSSMediaRule class];
+ case WebCore::CSSRule::FONT_FACE_RULE:
+ return [DOMCSSFontFaceRule class];
+ case WebCore::CSSRule::PAGE_RULE:
+ return [DOMCSSPageRule class];
+ case WebCore::CSSRule::KEYFRAMES_RULE:
+ case WebCore::CSSRule::NAMESPACE_RULE:
+ case WebCore::CSSRule::KEYFRAME_RULE:
+ case WebCore::CSSRule::SUPPORTS_RULE:
</ins><span class="cx"> #if ENABLE(CSS_DEVICE_ADAPTATION)
</span><del>- case DOM_WEBKIT_VIEWPORT_RULE:
</del><ins>+ case WebCore::CSSRule::WEBKIT_VIEWPORT_RULE:
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><del>- case DOM_WEBKIT_REGION_RULE:
</del><ins>+ case WebCore::CSSRule::WEBKIT_REGION_RULE:
</ins><span class="cx"> #endif
</span><del>- return [DOMCSSRule class];
</del><ins>+ return [DOMCSSRule class];
</ins><span class="cx"> }
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> return nil;
</span></span></pre>
</div>
</div>
</body>
</html>