<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[215072] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/215072">215072</a></dd>

<dt>Author</dt> <dd>msaboff@apple.com</dd>

<dt>Date</dt> <dd>2017-04-06 17:16:18 -0700 (Thu, 06 Apr 2017)</dd>

</dl>

<h3>Log Message</h3>

<pre>Cannot Object.seal() or Object.freeze() global &quot;this&quot;

https://bugs.webkit.org/show_bug.cgi?id=170549

Reviewed by Mark Lam.

JSTests:

Enabled failing tests fixed by the corresponding code change:

    ChakraCore/test/LetConst/delete.js

    ChakraCore/test/LetConst/dop.js

    ChakraCore/test/LetConst/dop1.js

* ChakraCore.yaml:

* ChakraCore/test/LetConst/dop.baseline-jsc: Added JSC specific expected output.

* ChakraCore/test/LetConst/dop1.baseline-jsc: Added JSC specific expected output.

Source/JavaScriptCore:

Needed to implement JSProxy::isExtensible() which returns the results of calling

the same on wrapped object.

Implemented step 11 of Runtime Semantics: EvalDeclarationInstantiation from the ECMAScript

spec to properly return a TypeError object when attempting to add properties to a

non-extensible global object.

* interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

* runtime/JSProxy.cpp:

(JSC::JSProxy::isExtensible):

* runtime/JSProxy.h:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkJSTestsChakraCoreyaml">trunk/JSTests/ChakraCore.yaml</a></li>

<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>

<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>

<li><a href="#trunkSourceJavaScriptCoreinterpreterInterpretercpp">trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp</a></li>

<li><a href="#trunkSourceJavaScriptCoreruntimeJSProxycpp">trunk/Source/JavaScriptCore/runtime/JSProxy.cpp</a></li>

<li><a href="#trunkSourceJavaScriptCoreruntimeJSProxyh">trunk/Source/JavaScriptCore/runtime/JSProxy.h</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li><a href="#trunkJSTestsChakraCoretestLetConstdopbaselinejsc">trunk/JSTests/ChakraCore/test/LetConst/dop.baseline-jsc</a></li>

<li><a href="#trunkJSTestsChakraCoretestLetConstdop1baselinejsc">trunk/JSTests/ChakraCore/test/LetConst/dop1.baseline-jsc</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkJSTestsChakraCoretestLetConstdopbaselinejsc"></a>

<div class="addfile"><h4>Added: trunk/JSTests/ChakraCore/test/LetConst/dop.baseline-jsc (0 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/JSTests/ChakraCore/test/LetConst/dop.baseline-jsc                                (rev 0)

+++ trunk/JSTests/ChakraCore/test/LetConst/dop.baseline-jsc        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -0,0 +1,4 @@

<ins>+exception: TypeError: Attempting to define property on object that is not extensible.

+let x

+undefined

+true

</ins></span></pre></div>

<a id="trunkJSTestsChakraCoretestLetConstdop1baselinejsc"></a>

<div class="addfile"><h4>Added: trunk/JSTests/ChakraCore/test/LetConst/dop1.baseline-jsc (0 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/JSTests/ChakraCore/test/LetConst/dop1.baseline-jsc                                (rev 0)

+++ trunk/JSTests/ChakraCore/test/LetConst/dop1.baseline-jsc        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -0,0 +1,4 @@

<ins>+exception: TypeError: Attempting to define property on object that is not extensible.

+let x

+undefined

+true

</ins></span></pre></div>

<a id="trunkJSTestsChakraCoreyaml"></a>

<div class="modfile"><h4>Modified: trunk/JSTests/ChakraCore.yaml (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/JSTests/ChakraCore.yaml        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/JSTests/ChakraCore.yaml        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -809,14 +809,11 @@

</span><span class="cx"> - path: ChakraCore/test/LetConst/defer5.js

</span><span class="cx">   cmd: runChakra :baseline, &quot;ReferenceError&quot;, &quot;defer5.baseline-jsc&quot;, []

</span><span class="cx"> - path: ChakraCore/test/LetConst/delete.js

<del>-  # Differences in Object.seal().

-  cmd: runChakra :skip, &quot;NoException&quot;, &quot;delete.baseline&quot;, []

</del><ins>+  cmd: runChakra :baseline, &quot;NoException&quot;, &quot;delete.baseline&quot;, []

</ins><span class="cx"> - path: ChakraCore/test/LetConst/dop.js

<del>-  # Differences in Object.seal().

-  cmd: runChakra :skip, &quot;NoException&quot;, &quot;dop.baseline&quot;, []

</del><ins>+  cmd: runChakra :baseline, &quot;NoException&quot;, &quot;dop.baseline-jsc&quot;, []

</ins><span class="cx"> - path: ChakraCore/test/LetConst/dop1.js

<del>-  # Differences in Object.seal().

-  cmd: runChakra :skip, &quot;NoException&quot;, &quot;dop1.baseline&quot;, []

</del><ins>+  cmd: runChakra :baseline, &quot;NoException&quot;, &quot;dop1.baseline-jsc&quot;, []

</ins><span class="cx"> - path: ChakraCore/test/LetConst/eval_fncdecl.js

<span class="cx">   # Seems like a bug.  We try to define a function in a false &quot;then&quot; block.

</span><span class="cx">   cmd: runChakra :skip, &quot;NoException&quot;, &quot;eval_fncdecl.baseline&quot;, []

</span></span></pre></div>

<a id="trunkJSTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/JSTests/ChangeLog        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/JSTests/ChangeLog        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -1,3 +1,19 @@

</span><ins>+2017-04-06  Michael Saboff  &lt;msaboff@apple.com&gt;

+

+        Cannot Object.seal() or Object.freeze() global &quot;this&quot;

+        https://bugs.webkit.org/show_bug.cgi?id=170549

+

+        Reviewed by Mark Lam.

+

+        Enabled failing tests fixed by the corresponding code change:

+            ChakraCore/test/LetConst/delete.js

+            ChakraCore/test/LetConst/dop.js

+            ChakraCore/test/LetConst/dop1.js

+

+        * ChakraCore.yaml:

+        * ChakraCore/test/LetConst/dop.baseline-jsc: Added JSC specific expected output.

+        * ChakraCore/test/LetConst/dop1.baseline-jsc: Added JSC specific expected output.

+

</ins><span class="cx"> 2017-04-05  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         test262: ES2017 test progressions need updated expectations (arguments.caller removed)

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/Source/JavaScriptCore/ChangeLog        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -1,3 +1,23 @@

</span><ins>+2017-04-06  Michael Saboff  &lt;msaboff@apple.com&gt;

+

+        Cannot Object.seal() or Object.freeze() global &quot;this&quot;

+        https://bugs.webkit.org/show_bug.cgi?id=170549

+

+        Reviewed by Mark Lam.

+

+        Needed to implement JSProxy::isExtensible() which returns the results of calling

+        the same on wrapped object.

+

+        Implemented step 11 of Runtime Semantics: EvalDeclarationInstantiation from the ECMAScript

+        spec to properly return a TypeError object when attempting to add properties to a

+        non-extensible global object.

+

+        * interpreter/Interpreter.cpp:

+        (JSC::Interpreter::execute):

+        * runtime/JSProxy.cpp:

+        (JSC::JSProxy::isExtensible):

+        * runtime/JSProxy.h:

+

</ins><span class="cx"> 2017-04-06  Filip Pizlo  &lt;fpizlo@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Linear scan should run liveness only once

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreinterpreterInterpretercpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -1158,6 +1158,8 @@

</span><span class="cx">             RETURN_IF_EXCEPTION(throwScope, checkedReturn(throwScope.exception()));

</span><span class="cx">             if (!hasProperty) {

</span><span class="cx">                 PutPropertySlot slot(variableObject);

</span><ins>+                if (!variableObject-&gt;isExtensible(callFrame))

+                    return checkedReturn(throwTypeError(callFrame, throwScope, ASCIILiteral(NonExtensibleObjectPropertyDefineError)));

</ins><span class="cx">                 variableObject-&gt;methodTable()-&gt;put(variableObject, callFrame, ident, jsUndefined(), slot);

</span><span class="cx">                 RETURN_IF_EXCEPTION(throwScope, checkedReturn(throwScope.exception()));

</span><span class="cx">             }

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreruntimeJSProxycpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSProxy.cpp (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSProxy.cpp        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/Source/JavaScriptCore/runtime/JSProxy.cpp        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -115,6 +115,12 @@

</span><span class="cx">     return thisObject-&gt;target()-&gt;methodTable(exec-&gt;vm())-&gt;deleteProperty(thisObject-&gt;target(), exec, propertyName);

</span><span class="cx"> }

</span><span class="cx"> 

</span><ins>+bool JSProxy::isExtensible(JSObject* object, ExecState* exec)

+{

+    JSProxy* thisObject = jsCast&lt;JSProxy*&gt;(object);

+    return thisObject-&gt;target()-&gt;methodTable(exec-&gt;vm())-&gt;isExtensible(thisObject-&gt;target(), exec);

+}

+

</ins><span class="cx"> bool JSProxy::preventExtensions(JSObject* object, ExecState* exec)

</span><span class="cx"> {

</span><span class="cx">     JSProxy* thisObject = jsCast&lt;JSProxy*&gt;(object);

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreruntimeJSProxyh"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSProxy.h (215071 => 215072)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSProxy.h        2017-04-07 00:11:16 UTC (rev 215071)

+++ trunk/Source/JavaScriptCore/runtime/JSProxy.h        2017-04-07 00:16:18 UTC (rev 215072)

</span><span class="lines">@@ -96,6 +96,7 @@

</span><span class="cx">     JS_EXPORT_PRIVATE static bool defineOwnProperty(JSObject*, ExecState*, PropertyName, const PropertyDescriptor&amp;, bool shouldThrow);

</span><span class="cx">     JS_EXPORT_PRIVATE static bool setPrototype(JSObject*, ExecState*, JSValue, bool shouldThrowIfCantSet);

</span><span class="cx">     JS_EXPORT_PRIVATE static JSValue getPrototype(JSObject*, ExecState*);

</span><ins>+    JS_EXPORT_PRIVATE static bool isExtensible(JSObject*, ExecState*);

</ins><span class="cx">     JS_EXPORT_PRIVATE static bool preventExtensions(JSObject*, ExecState*);

</span><span class="cx"> 

</span><span class="cx"> private:

</span></span></pre>

</div>

</div>

</body>

</html>