<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214942] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214942">214942</a></dd>
<dt>Author</dt> <dd>utatane.tea@gmail.com</dd>
<dt>Date</dt> <dd>2017-04-05 06:07:09 -0700 (Wed, 05 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] Suppress warnings in GCC
https://bugs.webkit.org/show_bug.cgi?id=170501
Reviewed by Keith Miller.
Source/JavaScriptCore:
Should use ASSERT_NOT_REACHED since return-type pragma is only
enabled under ASSERT_DISABLED environment. We shoud use
ASSERT_NOTREACHED to emit assertions in debug build. It effectively
catches bugs while keeping performance in release build.
* b3/B3Opcode.cpp:
(JSC::B3::storeOpcode):
* b3/B3Width.h:
(JSC::B3::mask):
* runtime/Options.cpp:
(JSC::parse):
* wasm/WasmSections.h:
(JSC::Wasm::makeString):
* wasm/WasmSignature.cpp:
(JSC::Wasm::SignatureInformation::tryCleanup):
* wasm/generateWasmValidateInlinesHeader.py:
Source/WTF:
Add a new macro UNUSED_FUNCTION to annotate unused static functions.
#pragma GCC diagnostic ignored "-Wunused-function" does not work.
* wtf/Compiler.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3B3Opcodecpp">trunk/Source/JavaScriptCore/b3/B3Opcode.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3B3Widthh">trunk/Source/JavaScriptCore/b3/B3Width.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionscpp">trunk/Source/JavaScriptCore/runtime/Options.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmWasmSectionsh">trunk/Source/JavaScriptCore/wasm/WasmSections.h</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmWasmSignaturecpp">trunk/Source/JavaScriptCore/wasm/WasmSignature.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmgenerateWasmValidateInlinesHeaderpy">trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfCompilerh">trunk/Source/WTF/wtf/Compiler.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2017-04-05 Yusuke Suzuki <utatane.tea@gmail.com>
+
+ [JSC] Suppress warnings in GCC
+ https://bugs.webkit.org/show_bug.cgi?id=170501
+
+ Reviewed by Keith Miller.
+
+ Should use ASSERT_NOT_REACHED since return-type pragma is only
+ enabled under ASSERT_DISABLED environment. We shoud use
+ ASSERT_NOTREACHED to emit assertions in debug build. It effectively
+ catches bugs while keeping performance in release build.
+
+ * b3/B3Opcode.cpp:
+ (JSC::B3::storeOpcode):
+ * b3/B3Width.h:
+ (JSC::B3::mask):
+ * runtime/Options.cpp:
+ (JSC::parse):
+ * wasm/WasmSections.h:
+ (JSC::Wasm::makeString):
+ * wasm/WasmSignature.cpp:
+ (JSC::Wasm::SignatureInformation::tryCleanup):
+ * wasm/generateWasmValidateInlinesHeader.py:
+
</ins><span class="cx"> 2017-04-05 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Implement PromiseDeferredTimer for non CF based ports
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3B3Opcodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/B3Opcode.cpp (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/B3Opcode.cpp 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/b3/B3Opcode.cpp 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -88,6 +88,7 @@
</span><span class="cx"> case FP:
</span><span class="cx"> return Store;
</span><span class="cx"> }
</span><ins>+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::B3
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3B3Widthh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/B3Width.h (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/B3Width.h 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/b3/B3Width.h 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -130,6 +130,7 @@
</span><span class="cx"> case Width64:
</span><span class="cx"> return 0xffffffffffffffffllu;
</span><span class="cx"> }
</span><ins>+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::B3
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.cpp (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.cpp 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/runtime/Options.cpp 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -89,18 +89,15 @@
</span><span class="cx"> return sscanf(string, "%u", &value) == 1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wunused-function"
</del><span class="cx"> static bool parse(const char* string, unsigned long& value)
</span><span class="cx"> {
</span><span class="cx"> return sscanf(string, "%lu", &value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool parse(const char* string, unsigned long long& value)
</del><ins>+static bool UNUSED_FUNCTION parse(const char* string, unsigned long long& value)
</ins><span class="cx"> {
</span><span class="cx"> return sscanf(string, "%llu", &value);
</span><span class="cx"> }
</span><del>-#pragma GCC diagnostic pop
</del><span class="cx">
</span><span class="cx"> static bool parse(const char* string, double& value)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmWasmSectionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/WasmSections.h (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/WasmSections.h 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/wasm/WasmSections.h 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -82,6 +82,7 @@
</span><span class="cx"> FOR_EACH_WASM_SECTION(STRINGIFY_SECTION_NAME)
</span><span class="cx"> #undef STRINGIFY_SECTION_NAME
</span><span class="cx"> }
</span><ins>+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::Wasm
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmWasmSignaturecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/WasmSignature.cpp (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/WasmSignature.cpp 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/wasm/WasmSignature.cpp 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -152,9 +152,9 @@
</span><span class="cx"> }
</span><span class="cx"> for (const auto& pair : toRemove) {
</span><span class="cx"> bool removed = info.m_signatureMap.remove(SignatureHash { pair.second });
</span><del>- ASSERT(removed);
</del><ins>+ ASSERT_UNUSED(removed, removed);
</ins><span class="cx"> removed = info.m_indexMap.remove(pair.first);
</span><del>- ASSERT(removed);
</del><ins>+ ASSERT_UNUSED(removed, removed);
</ins><span class="cx"> }
</span><span class="cx"> if (info.m_signatureMap.isEmpty()) {
</span><span class="cx"> ASSERT(info.m_indexMap.isEmpty());
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmgenerateWasmValidateInlinesHeaderpy"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -144,6 +144,7 @@
</span><span class="cx"> switch (op) {
</span><span class="cx"> """ + loadCases + """
</span><span class="cx"> }
</span><ins>+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> auto Validate::store(StoreOpType op, ExpressionType pointer, ExpressionType value, uint32_t) -> Result
</span><span class="lines">@@ -154,6 +155,7 @@
</span><span class="cx"> switch (op) {
</span><span class="cx"> """ + storeCases + """
</span><span class="cx"> }
</span><ins>+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::Wasm
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/WTF/ChangeLog 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-04-05 Yusuke Suzuki <utatane.tea@gmail.com>
+
+ [JSC] Suppress warnings in GCC
+ https://bugs.webkit.org/show_bug.cgi?id=170501
+
+ Reviewed by Keith Miller.
+
+ Add a new macro UNUSED_FUNCTION to annotate unused static functions.
+ #pragma GCC diagnostic ignored "-Wunused-function" does not work.
+
+ * wtf/Compiler.h:
+
</ins><span class="cx"> 2017-04-04 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Air::eliminateDeadCode() should not use a HashSet
</span></span></pre></div>
<a id="trunkSourceWTFwtfCompilerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Compiler.h (214941 => 214942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Compiler.h 2017-04-05 10:41:09 UTC (rev 214941)
+++ trunk/Source/WTF/wtf/Compiler.h 2017-04-05 13:07:09 UTC (rev 214942)
</span><span class="lines">@@ -280,6 +280,16 @@
</span><span class="cx"> #define PURE_FUNCTION
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+/* UNUSED_FUNCTION */
+
+#if !defined(UNUSED_FUNCTION) && COMPILER(GCC_OR_CLANG)
+#define UNUSED_FUNCTION __attribute__((unused))
+#endif
+
+#if !defined(UNUSED_FUNCTION)
+#define UNUSED_FUNCTION
+#endif
+
</ins><span class="cx"> /* REFERENCED_FROM_ASM */
</span><span class="cx">
</span><span class="cx"> #if !defined(REFERENCED_FROM_ASM) && COMPILER(GCC_OR_CLANG)
</span></span></pre>
</div>
</div>
</body>
</html>