<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214985] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214985">214985</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-05 21:42:33 -0700 (Wed, 05 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>test262: module test progressions need updated expectations (@@iterator changes)
https://bugs.webkit.org/show_bug.cgi?id=170535
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-04-05
Reviewed by Saam Barati.
JSTests:
* test262.yaml:
After <a href="http://trac.webkit.org/projects/webkit/changeset/212430">r212430</a> the tests are out of date and are now expected to fail.
Tools:
* Scripts/run-jsc-stress-tests:
Add :failDueToOutdatedOrBadTest to distinguish between a test failure
in JavaScriptCore or an outdated or incorrect test262 test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTeststest262yaml">trunk/JSTests/test262.yaml</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjscstresstests">trunk/Tools/Scripts/run-jsc-stress-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (214984 => 214985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/JSTests/ChangeLog 2017-04-06 04:42:33 UTC (rev 214985)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-04-05 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: module test progressions need updated expectations (@@iterator changes)
+ https://bugs.webkit.org/show_bug.cgi?id=170535
+
+ Reviewed by Saam Barati.
+
+ * test262.yaml:
+ After r212430 the tests are out of date and are now expected to fail.
+
</ins><span class="cx"> 2017-04-05 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed rollout of r214642 as the test still intermittently fails.
</span></span></pre></div>
<a id="trunkJSTeststest262yaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/test262.yaml (214984 => 214985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/test262.yaml 2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/JSTests/test262.yaml 2017-04-06 04:42:33 UTC (rev 214985)
</span><span class="lines">@@ -71908,27 +71908,27 @@
</span><span class="cx"> - path: test262/test/language/module-code/instn-uniq-env-rec.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/length.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-length.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-name.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-prop-desc.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/name.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/prop-desc.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/this-val-not-ns.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/values-binding-types.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/values-binding-types_.js
</span><span class="cx"> cmd: prepareTest262Fixture
</span><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.iterator/values-order.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/Symbol.toStringTag.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/define-own-property.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/delete-exported-init.js
</span><span class="lines">@@ -71936,7 +71936,7 @@
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/delete-exported-uninit.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/delete-non-exported.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-own-property-str-found-init.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-own-property-str-found-uninit.js
</span><span class="lines">@@ -71944,7 +71944,7 @@
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-own-property-str-not-found.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-own-property-sym.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-prototype-of.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-str-found-init.js
</span><span class="lines">@@ -71958,7 +71958,7 @@
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-str-update.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-sym-found.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/get-sym-not-found.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/has-property-str-found-init.js
</span><span class="lines">@@ -71968,17 +71968,17 @@
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/has-property-str-not-found.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/has-property-sym-found.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/has-property-sym-not-found.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/is-extensible.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/own-property-keys-binding-types.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/own-property-keys-binding-types_FIXTURE.js
</span><span class="cx"> cmd: prepareTest262Fixture
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/own-property-keys-sort.js
</span><del>- cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</del><ins>+ cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</ins><span class="cx"> - path: test262/test/language/module-code/namespace/internals/prevent-extensions.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
</span><span class="cx"> - path: test262/test/language/module-code/namespace/internals/set-prototype-of.js
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (214984 => 214985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/Tools/ChangeLog 2017-04-06 04:42:33 UTC (rev 214985)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2017-04-05 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ test262: module test progressions need updated expectations (@@iterator changes)
+ https://bugs.webkit.org/show_bug.cgi?id=170535
+
+ Reviewed by Saam Barati.
+
+ * Scripts/run-jsc-stress-tests:
+ Add :failDueToOutdatedOrBadTest to distinguish between a test failure
+ in JavaScriptCore or an outdated or incorrect test262 test.
+
+2017-04-05 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Remove run-jsc-stress-tests benign warning about otool '-S' switch
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=170527
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptsrunjscstresstests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-jsc-stress-tests (214984 => 214985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-jsc-stress-tests 2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2017-04-06 04:42:33 UTC (rev 214985)
</span><span class="lines">@@ -1128,6 +1128,9 @@
</span><span class="cx"> when :fail
</span><span class="cx"> errorHandler = expectedFailErrorHandler
</span><span class="cx"> outputHandler = noisyOutputHandler
</span><ins>+ when :failDueToOutdatedOrBadTest
+ errorHandler = expectedFailErrorHandler
+ outputHandler = noisyOutputHandler
</ins><span class="cx"> else
</span><span class="cx"> raise "Invalid mode: #{mode}"
</span><span class="cx"> end
</span></span></pre>
</div>
</div>
</body>
</html>