<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214913] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214913">214913</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-04 16:37:55 -0700 (Tue, 04 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=169481
Patch by Youenn Fablet <youenn@apple.com> on 2017-04-04
Reviewed by Eric Carlson.
Source/WebCore:
No need to enumerate all network interfaces in most layout tests.
Adding an Internals API for that in case we want to use TCP localhost candidates.
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setEnumeratingAllNetworkInterfacesEnabled):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* platform/mac-wk2/TestExpectations: Removing flaky expectation.
* webrtc/datachannel/basic.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestswebrtcdatachannelbasichtml">trunk/LayoutTests/webrtc/datachannel/basic.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsh">trunk/Source/WebCore/testing/Internals.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsidl">trunk/Source/WebCore/testing/Internals.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/ChangeLog        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-04-04 Youenn Fablet <youenn@apple.com>
+
+ LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=169481
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac-wk2/TestExpectations: Removing flaky expectation.
+ * webrtc/datachannel/basic.html:
+
</ins><span class="cx"> 2017-04-04 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Add back results that were accidentally removed with r214848.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -641,8 +641,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/168346 [ Sierra Debug ] editing/selection/move-by-word-visually-multi-space.html [ Pass Timeout ]
</span><span class="cx">
</span><del>-webkit.org/b/169481 [ Debug ] webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
-
</del><span class="cx"> webkit.org/b/169621 imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/169760 imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html [ Pass Failure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestswebrtcdatachannelbasichtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webrtc/datachannel/basic.html (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webrtc/datachannel/basic.html        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/webrtc/datachannel/basic.html        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -102,8 +102,10 @@
</span><span class="cx"> promise_test((test) => {
</span><span class="cx"> counter = 0;
</span><span class="cx"> return new Promise((resolve, reject) => {
</span><del>- if (window.internals)
</del><ins>+ if (window.internals) {
</ins><span class="cx"> internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
</span><ins>+ internals.setEnumeratingAllNetworkInterfacesEnabled(true);
+ }
</ins><span class="cx">
</span><span class="cx"> finishTest = resolve;
</span><span class="cx"> createConnections((localConnection) => {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/ChangeLog        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-04-04 Youenn Fablet <youenn@apple.com>
+
+ LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=169481
+
+ Reviewed by Eric Carlson.
+
+ No need to enumerate all network interfaces in most layout tests.
+ Adding an Internals API for that in case we want to use TCP localhost candidates.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::Internals):
+ (WebCore::Internals::setEnumeratingAllNetworkInterfacesEnabled):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
+
</ins><span class="cx"> 2017-04-04 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix: fix compilation error on Sierra.
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.cpp        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -470,10 +470,8 @@
</span><span class="cx"> enableMockMediaEndpoint();
</span><span class="cx"> useMockRTCPeerConnectionFactory(String());
</span><span class="cx"> #if USE(LIBWEBRTC)
</span><del>- if (document.page()) {
- document.page()->libWebRTCProvider().enableEnumeratingAllNetworkInterfaces();
</del><ins>+ if (document.page())
</ins><span class="cx"> document.page()->rtcController().disableICECandidateFiltering();
</span><del>- }
</del><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -1253,8 +1251,25 @@
</span><span class="cx"> rtcController.disableICECandidateFiltering();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Internals::setEnumeratingAllNetworkInterfacesEnabled(bool enabled)
+{
+#if USE(LIBWEBRTC)
+ Document* document = contextDocument();
+ auto* page = document->page();
+ if (!page)
+ return;
+ auto& rtcProvider = page->libWebRTCProvider();
+ if (enabled)
+ rtcProvider.enableEnumeratingAllNetworkInterfaces();
+ else
+ rtcProvider.disableEnumeratingAllNetworkInterfaces();
+#else
+ UNUSED_PARAM(enabled);
</ins><span class="cx"> #endif
</span><ins>+}
</ins><span class="cx">
</span><ins>+#endif
+
</ins><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx">
</span><span class="cx"> void Internals::setMockMediaCaptureDevicesEnabled(bool enabled)
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.h (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.h        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.h        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -422,6 +422,7 @@
</span><span class="cx"> void emulateRTCPeerConnectionPlatformEvent(RTCPeerConnection&, const String& action);
</span><span class="cx"> void useMockRTCPeerConnectionFactory(const String&);
</span><span class="cx"> void setICECandidateFiltering(bool);
</span><ins>+ void setEnumeratingAllNetworkInterfacesEnabled(bool);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> String getImageSourceURL(Element&);
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.idl (214912 => 214913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.idl        2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.idl        2017-04-04 23:37:55 UTC (rev 214913)
</span><span class="lines">@@ -458,6 +458,7 @@
</span><span class="cx"> [Conditional=WEB_RTC] void emulateRTCPeerConnectionPlatformEvent(RTCPeerConnection connection, DOMString action);
</span><span class="cx"> [Conditional=WEB_RTC] void useMockRTCPeerConnectionFactory(DOMString testCase);
</span><span class="cx"> [Conditional=WEB_RTC] void setICECandidateFiltering(boolean enabled);
</span><ins>+ [Conditional=WEB_RTC] void setEnumeratingAllNetworkInterfacesEnabled(boolean enabled);
</ins><span class="cx">
</span><span class="cx"> [Conditional=VIDEO] void simulateSystemSleep();
</span><span class="cx"> [Conditional=VIDEO] void simulateSystemWake();
</span></span></pre>
</div>
</div>
</body>
</html>