<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214796] releases/WebKitGTK/webkit-2.16</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214796">214796</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-03 08:58:46 -0700 (Mon, 03 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/214340">r214340</a> - Text stroke is sometimes clipped on video captions.
https://bugs.webkit.org/show_bug.cgi?id=170006
Reviewed by Eric Carlson.
Source/WebCore:
Set 'overflow' property to 'visible' on cue element to avoid clipping of text stroke.
Updated test media/track/track-css-stroke-cues.html.
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
* html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
LayoutTests:
* media/track/track-css-stroke-cues-expected.txt:
* media/track/track-css-stroke-cues.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsmediatracktrackcssstrokecuesexpectedtxt">releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsmediatracktrackcssstrokecueshtml">releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues.html</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCorehtmltrackTextTrackCueGenericcpp">releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/TextTrackCueGeneric.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCorehtmltrackVTTCuecpp">releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/VTTCue.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit216LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-03-24 Per Arne Vollan <pvollan@apple.com>
+
+ Text stroke is sometimes clipped on video captions.
+ https://bugs.webkit.org/show_bug.cgi?id=170006
+
+ Reviewed by Eric Carlson.
+
+ * media/track/track-css-stroke-cues-expected.txt:
+ * media/track/track-css-stroke-cues.html:
+
</ins><span class="cx"> 2017-03-23 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> WebSQL databases should not openable in private browsing.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsmediatracktrackcssstrokecuesexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues-expected.txt (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues-expected.txt 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues-expected.txt 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -7,5 +7,6 @@
</span><span class="cx"> EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).paintOrder == 'stroke') OK
</span><span class="cx"> EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin == 'round') OK
</span><span class="cx"> EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap == 'round') OK
</span><ins>+EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).overflow == 'visible') OK
</ins><span class="cx"> END OF TEST
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsmediatracktrackcssstrokecueshtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues.html (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues.html 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues.html 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -22,6 +22,7 @@
</span><span class="cx"> testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).paintOrder", "stroke");
</span><span class="cx"> testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin", "round");
</span><span class="cx"> testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap", "round");
</span><ins>+ testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).overflow", "visible");
</ins><span class="cx"> endTest();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-24 Per Arne Vollan <pvollan@apple.com>
+
+ Text stroke is sometimes clipped on video captions.
+ https://bugs.webkit.org/show_bug.cgi?id=170006
+
+ Reviewed by Eric Carlson.
+
+ Set 'overflow' property to 'visible' on cue element to avoid clipping of text stroke.
+
+ Updated test media/track/track-css-stroke-cues.html.
+
+ * html/track/TextTrackCueGeneric.cpp:
+ (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
+ * html/track/VTTCue.cpp:
+ (WebCore::VTTCueBox::applyCSSProperties):
+
</ins><span class="cx"> 2017-03-23 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> WebSQL databases should not openable in private browsing.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCorehtmltrackTextTrackCueGenericcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/TextTrackCueGeneric.cpp (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -141,6 +141,10 @@
</span><span class="cx"> setInlineStyleProperty(CSSPropertyBackgroundColor, cue->backgroundColor().serialized());
</span><span class="cx"> setInlineStyleProperty(CSSPropertyWritingMode, cue->getCSSWritingMode(), false);
</span><span class="cx"> setInlineStyleProperty(CSSPropertyWhiteSpace, CSSValuePreWrap);
</span><ins>+
+ // Make sure shadow or stroke is not clipped.
+ setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
+ cueElement->setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TextTrackCueGeneric::TextTrackCueGeneric(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCorehtmltrackVTTCuecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/VTTCue.cpp (214795 => 214796)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/VTTCue.cpp 2017-04-03 15:56:17 UTC (rev 214795)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/VTTCue.cpp 2017-04-03 15:58:46 UTC (rev 214796)
</span><span class="lines">@@ -223,6 +223,10 @@
</span><span class="cx">
</span><span class="cx"> setInlineStyleProperty(CSSPropertyWhiteSpace, CSSValuePre);
</span><span class="cx"> }
</span><ins>+
+ // Make sure shadow or stroke is not clipped.
+ setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
+ m_cue.element().setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const AtomicString& VTTCueBox::vttCueBoxShadowPseudoId()
</span></span></pre>
</div>
</div>
</body>
</html>