<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214820] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214820">214820</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-03 11:00:06 -0700 (Mon, 03 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167965
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-04-03
Reviewed by Jon Lee.
Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
can therefore be delivered later than expected by the test. This is already done for the first one,
do this for the second one also.
* platform/mac-wk2/TestExpectations:
* pointer-lock/mouse-event-delivery.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestspointerlockmouseeventdeliveryhtml">trunk/LayoutTests/pointer-lock/mouse-event-delivery.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214819 => 214820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/ChangeLog 2017-04-03 18:00:06 UTC (rev 214820)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-04-03 Jeremy Jones <jeremyj@apple.com>
+
+ LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=167965
+
+ Reviewed by Jon Lee.
+
+ Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
+ can therefore be delivered later than expected by the test. This is already done for the first one,
+ do this for the second one also.
+
+ * platform/mac-wk2/TestExpectations:
+ * pointer-lock/mouse-event-delivery.html:
+
</ins><span class="cx"> 2017-04-01 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Clean up touch event handler registration when moving nodes between documents
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (214819 => 214820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-03 18:00:06 UTC (rev 214820)
</span><span class="lines">@@ -619,8 +619,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/167965 pointer-lock/mouse-event-delivery.html [ Pass Failure ]
-
</del><span class="cx"> webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestspointerlockmouseeventdeliveryhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/pointer-lock/mouse-event-delivery.html (214819 => 214820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/mouse-event-delivery.html 2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/pointer-lock/mouse-event-delivery.html 2017-04-03 18:00:06 UTC (rev 214820)
</span><span class="lines">@@ -96,13 +96,12 @@
</span><span class="cx"> function () {
</span><span class="cx"> debug(" With a lock in place send a wheel event.")
</span><span class="cx"> targetdiv1.onwheel = eventNotExpected;
</span><del>- targetdiv2.onwheel = eventExpected;
</del><ins>+ targetdiv2.onwheel = eventExpectedThenNextStep;
</ins><span class="cx"> document.body.onwheel = eventExpected;
</span><span class="cx"> if (window.eventSender) {
</span><span class="cx"> window.eventSender.leapForward(1000);
</span><span class="cx"> window.eventSender.mouseScrollBy(0,10);
</span><span class="cx"> }
</span><del>- doNextStep();
</del><span class="cx"> },
</span><span class="cx"> function () {
</span><span class="cx"> debug(" With a lock in place send a click.")
</span></span></pre>
</div>
</div>
</body>
</html>