<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214808] releases/WebKitGTK/webkit-2.16</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214808">214808</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2017-04-03 10:09:21 -0700 (Mon, 03 Apr 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/214510">r214510</a> - Only attach Attributes to a given element one time
https://bugs.webkit.org/show_bug.cgi?id=170125
<rdar://problem/31279676>
Reviewed by Chris Dumez.
Source/WebCore:
Attach the attribute node to the Element before calling 'setAttributeInternal', since that method may cause
arbitrary JavaScript events to fire.
Test: fast/dom/Attr/only-attach-attr-once.html
* dom/Element.cpp:
(WebCore::Element::attachAttributeNodeIfNeeded): Added.
(WebCore::Element::setAttributeNode): Use new method. Revise to attach attribute before calling 'setAttributeInternal'.
(WebCore::Element::setAttributeNodeNS): Ditto.
* dom/Element.h:
LayoutTests:
* fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt: Rebaselined.
* fast/dom/Attr/make-unique-element-data-while-replacing-attr.html: Add check before setting new value.
* fast/dom/Attr/only-attach-attr-once-expected.txt: Added.
* fast/dom/Attr/only-attach-attr-once.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsfastdomAttrmakeuniqueelementdatawhilereplacingattrexpectedtxt">releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsfastdomAttrmakeuniqueelementdatawhilereplacingattrhtml">releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr.html</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCoredomElementcpp">releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceWebCoredomElementh">releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsfastdomAttronlyattachattronceexpectedtxt">releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit216LayoutTestsfastdomAttronlyattachattroncehtml">releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit216LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-27 Brent Fulgham <bfulgham@apple.com>
+
+ Only attach Attributes to a given element one time
+ https://bugs.webkit.org/show_bug.cgi?id=170125
+ <rdar://problem/31279676>
+
+ Reviewed by Chris Dumez.
+
+ * fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt: Rebaselined.
+ * fast/dom/Attr/make-unique-element-data-while-replacing-attr.html: Add check before setting new value.
+ * fast/dom/Attr/only-attach-attr-once-expected.txt: Added.
+ * fast/dom/Attr/only-attach-attr-once.html: Added.
+
</ins><span class="cx"> 2017-03-28 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Missing render tree position invalidation when tearing down renderers for display:contents subtree
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsfastdomAttrmakeuniqueelementdatawhilereplacingattrexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><ins>+PASS element.getAttribute("width") is "a"
</ins><span class="cx"> PASS element.getAttribute("width") is "b"
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsfastdomAttrmakeuniqueelementdatawhilereplacingattrhtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr.html (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr.html 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr.html 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -13,6 +13,8 @@
</span><span class="cx"> oldAttr.value = 'a';
</span><span class="cx"> element.setAttributeNode(oldAttr);
</span><span class="cx">
</span><ins>+shouldBeEqualToString('element.getAttribute("width")', 'a');
+
</ins><span class="cx"> element.addEventListener('DOMSubtreeModified', () => { element.cloneNode(); }, true);
</span><span class="cx">
</span><span class="cx"> let newAttr = document.createAttributeNS('http://www.w3.org/1999/xhtml','width');
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsfastdomAttronlyattachattronceexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once-expected.txt (0 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once-expected.txt 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Test that we properly handle attempts to attach an Attribute to the same node multiple times. Test passes if there is no Debug ASSERT.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS div.setAttributeNodeNS(src) threw exception InUseAttributeError (DOM Exception 10): The attribute is in use..
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit216LayoutTestsfastdomAttronlyattachattroncehtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once.html (0 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once.html (rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/dom/Attr/only-attach-attr-once.html 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+<script src="../../../resources/js-test.js"></script>
+</head>
+<body>
+<script>
+description("Test that we properly handle attempts to attach an Attribute to the same node multiple times. Test passes if there is no Debug ASSERT.");
+
+window.callback = () => {
+ window.callback = null;
+
+ shouldThrow("div.setAttributeNodeNS(src)", "'InUseAttributeError (DOM Exception 10): The attribute is in use.'");
+ frame.setAttributeNodeNS(document.createAttribute('src'));
+};
+
+let src = document.createAttribute('src');
+src.value = 'javascript:parent.callback()';
+
+let div = document.createElement('div');
+let frame = document.body.appendChild(document.createElement('iframe'));
+frame.setAttributeNodeNS(src);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-03-27 Brent Fulgham <bfulgham@apple.com>
+
+ Only attach Attributes to a given element one time
+ https://bugs.webkit.org/show_bug.cgi?id=170125
+ <rdar://problem/31279676>
+
+ Reviewed by Chris Dumez.
+
+ Attach the attribute node to the Element before calling 'setAttributeInternal', since that method may cause
+ arbitrary JavaScript events to fire.
+
+ Test: fast/dom/Attr/only-attach-attr-once.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::attachAttributeNodeIfNeeded): Added.
+ (WebCore::Element::setAttributeNode): Use new method. Revise to attach attribute before calling 'setAttributeInternal'.
+ (WebCore::Element::setAttributeNodeNS): Ditto.
+ * dom/Element.h:
+
</ins><span class="cx"> 2017-03-28 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Missing render tree position invalidation when tearing down renderers for display:contents subtree
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.cpp (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.cpp 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.cpp 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -2121,6 +2121,19 @@
</span><span class="cx"> return *attrNodeListForElement(*this);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Element::attachAttributeNodeIfNeeded(Attr& attrNode)
+{
+ ASSERT(!attrNode.ownerElement() || attrNode.ownerElement() == this);
+ if (attrNode.ownerElement() == this)
+ return;
+
+ NoEventDispatchAssertion assertNoEventDispatch;
+
+ attrNode.attachToElement(*this);
+ treeScope().adoptIfNeeded(attrNode);
+ ensureAttrNodeListForElement(*this).append(&attrNode);
+}
+
</ins><span class="cx"> ExceptionOr<RefPtr<Attr>> Element::setAttributeNode(Attr& attrNode)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<Attr> oldAttrNode = attrIfExists(attrNode.localName(), shouldIgnoreAttributeCase(*this));
</span><span class="lines">@@ -2132,13 +2145,23 @@
</span><span class="cx"> if (attrNode.ownerElement() && attrNode.ownerElement() != this)
</span><span class="cx"> return Exception { INUSE_ATTRIBUTE_ERR };
</span><span class="cx">
</span><ins>+ {
+ NoEventDispatchAssertion assertNoEventDispatch;
</ins><span class="cx"> synchronizeAllAttributes();
</span><ins>+ }
+
</ins><span class="cx"> auto& elementData = ensureUniqueElementData();
</span><span class="cx">
</span><span class="cx"> auto existingAttributeIndex = elementData.findAttributeIndexByName(attrNode.localName(), shouldIgnoreAttributeCase(*this));
</span><del>- if (existingAttributeIndex == ElementData::attributeNotFound)
- setAttributeInternal(elementData.findAttributeIndexByName(attrNode.qualifiedName()), attrNode.qualifiedName(), attrNode.value(), NotInSynchronizationOfLazyAttribute);
- else {
</del><ins>+
+ // Attr::value() will return its 'm_standaloneValue' member any time its Element is set to nullptr. We need to cache this value
+ // before making changes to attrNode's Element connections.
+ auto attrNodeValue = attrNode.value();
+
+ if (existingAttributeIndex == ElementData::attributeNotFound) {
+ attachAttributeNodeIfNeeded(attrNode);
+ setAttributeInternal(elementData.findAttributeIndexByName(attrNode.qualifiedName()), attrNode.qualifiedName(), attrNodeValue, NotInSynchronizationOfLazyAttribute);
+ } else {
</ins><span class="cx"> const Attribute& attribute = attributeAt(existingAttributeIndex);
</span><span class="cx"> if (oldAttrNode)
</span><span class="cx"> detachAttrNodeFromElementWithValue(oldAttrNode.get(), attribute.value());
</span><span class="lines">@@ -2145,18 +2168,16 @@
</span><span class="cx"> else
</span><span class="cx"> oldAttrNode = Attr::create(document(), attrNode.qualifiedName(), attribute.value());
</span><span class="cx">
</span><ins>+ attachAttributeNodeIfNeeded(attrNode);
+
</ins><span class="cx"> if (attribute.name().matches(attrNode.qualifiedName()))
</span><del>- setAttributeInternal(existingAttributeIndex, attrNode.qualifiedName(), attrNode.value(), NotInSynchronizationOfLazyAttribute);
</del><ins>+ setAttributeInternal(existingAttributeIndex, attrNode.qualifiedName(), attrNodeValue, NotInSynchronizationOfLazyAttribute);
</ins><span class="cx"> else {
</span><span class="cx"> removeAttributeInternal(existingAttributeIndex, NotInSynchronizationOfLazyAttribute);
</span><del>- setAttributeInternal(ensureUniqueElementData().findAttributeIndexByName(attrNode.qualifiedName()), attrNode.qualifiedName(), attrNode.value(), NotInSynchronizationOfLazyAttribute);
</del><ins>+ setAttributeInternal(ensureUniqueElementData().findAttributeIndexByName(attrNode.qualifiedName()), attrNode.qualifiedName(), attrNodeValue, NotInSynchronizationOfLazyAttribute);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><del>- if (attrNode.ownerElement() != this) {
- attrNode.attachToElement(*this);
- treeScope().adoptIfNeeded(attrNode);
- ensureAttrNodeListForElement(*this).append(&attrNode);
- }
</del><ins>+
</ins><span class="cx"> return WTFMove(oldAttrNode);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2171,10 +2192,19 @@
</span><span class="cx"> if (attrNode.ownerElement() && attrNode.ownerElement() != this)
</span><span class="cx"> return Exception { INUSE_ATTRIBUTE_ERR };
</span><span class="cx">
</span><ins>+ unsigned index = 0;
+
+ // Attr::value() will return its 'm_standaloneValue' member any time its Element is set to nullptr. We need to cache this value
+ // before making changes to attrNode's Element connections.
+ auto attrNodeValue = attrNode.value();
+
+ {
+ NoEventDispatchAssertion assertNoEventDispatch;
</ins><span class="cx"> synchronizeAllAttributes();
</span><span class="cx"> auto& elementData = ensureUniqueElementData();
</span><span class="cx">
</span><del>- auto index = elementData.findAttributeIndexByName(attrNode.qualifiedName());
</del><ins>+ index = elementData.findAttributeIndexByName(attrNode.qualifiedName());
+
</ins><span class="cx"> if (index != ElementData::attributeNotFound) {
</span><span class="cx"> if (oldAttrNode)
</span><span class="cx"> detachAttrNodeFromElementWithValue(oldAttrNode.get(), elementData.attributeAt(index).value());
</span><span class="lines">@@ -2181,13 +2211,11 @@
</span><span class="cx"> else
</span><span class="cx"> oldAttrNode = Attr::create(document(), attrNode.qualifiedName(), elementData.attributeAt(index).value());
</span><span class="cx"> }
</span><ins>+ }
</ins><span class="cx">
</span><del>- setAttributeInternal(index, attrNode.qualifiedName(), attrNode.value(), NotInSynchronizationOfLazyAttribute);
</del><ins>+ attachAttributeNodeIfNeeded(attrNode);
+ setAttributeInternal(index, attrNode.qualifiedName(), attrNodeValue, NotInSynchronizationOfLazyAttribute);
</ins><span class="cx">
</span><del>- attrNode.attachToElement(*this);
- treeScope().adoptIfNeeded(attrNode);
- ensureAttrNodeListForElement(*this).append(&attrNode);
-
</del><span class="cx"> return WTFMove(oldAttrNode);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.h (214807 => 214808)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.h 2017-04-03 17:08:12 UTC (rev 214807)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/Element.h 2017-04-03 17:09:21 UTC (rev 214808)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> * (C) 1999 Antti Koivisto (koivisto@kde.org)
</span><span class="cx"> * (C) 2001 Peter Kelly (pmk@post.com)
</span><span class="cx"> * (C) 2001 Dirk Mueller (mueller@kde.org)
</span><del>- * Copyright (C) 2003-2016 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2003-2017 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * This library is free software; you can redistribute it and/or
</span><span class="cx"> * modify it under the terms of the GNU Library General Public
</span><span class="lines">@@ -679,6 +679,8 @@
</span><span class="cx">
</span><span class="cx"> // Anyone thinking of using this should call document instead of ownerDocument.
</span><span class="cx"> void ownerDocument() const = delete;
</span><ins>+
+ void attachAttributeNodeIfNeeded(Attr&);
</ins><span class="cx">
</span><span class="cx"> QualifiedName m_tagName;
</span><span class="cx"> RefPtr<ElementData> m_elementData;
</span></span></pre>
</div>
</div>
</body>
</html>