<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214706] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214706">214706</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-31 17:31:34 -0700 (Fri, 31 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=162510
<rdar://problem/31380650>
Reviewed by Alexey Proskuryakov.
The test restores a page from PageCache and wants to check that an animated
GIF is properly animating. To do so, it store the data of the current image
frame, and then checks in a 100ms timer that the current image frame is
different. This is flaky by nature since the image only has 10 frames and
you therefore have a 1/10 chance that the new frame will be the same as the
previous one, even if the image is properly animating.
To address the problem, do a setInterval instead of a setTimeout and check
until the frame becomes different.
* fast/images/animated-gif-restored-from-bfcache.html:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastimagesanimatedgifrestoredfrombfcachehtml">trunk/LayoutTests/fast/images/animated-gif-restored-from-bfcache.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214705 => 214706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-04-01 00:24:48 UTC (rev 214705)
+++ trunk/LayoutTests/ChangeLog 2017-04-01 00:31:34 UTC (rev 214706)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2017-03-31 Chris Dumez <cdumez@apple.com>
+
+ LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=162510
+ <rdar://problem/31380650>
+
+ Reviewed by Alexey Proskuryakov.
+
+ The test restores a page from PageCache and wants to check that an animated
+ GIF is properly animating. To do so, it store the data of the current image
+ frame, and then checks in a 100ms timer that the current image frame is
+ different. This is flaky by nature since the image only has 10 frames and
+ you therefore have a 1/10 chance that the new frame will be the same as the
+ previous one, even if the image is properly animating.
+
+ To address the problem, do a setInterval instead of a setTimeout and check
+ until the frame becomes different.
+
+ * fast/images/animated-gif-restored-from-bfcache.html:
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2017-03-31 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> [WK2] Tapping away to dismiss the selection does not update the selected DOM range using character granularity
</span></span></pre></div>
<a id="trunkLayoutTestsfastimagesanimatedgifrestoredfrombfcachehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/images/animated-gif-restored-from-bfcache.html (214705 => 214706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/images/animated-gif-restored-from-bfcache.html 2017-04-01 00:24:48 UTC (rev 214705)
+++ trunk/LayoutTests/fast/images/animated-gif-restored-from-bfcache.html 2017-04-01 00:31:34 UTC (rev 214706)
</span><span class="lines">@@ -17,7 +17,7 @@
</span><span class="cx"> context.drawImage(image, 0, 0);
</span><span class="cx"> var frameOne = context.getImageData(0, 0, 1, 1).data;
</span><span class="cx">
</span><del>- window.setTimeout(function() {
</del><ins>+ handle = window.setInterval(function() {
</ins><span class="cx"> context.drawImage(image, 0, 0);
</span><span class="cx"> var frameTwo = context.getImageData(0, 0, 1, 1).data;
</span><span class="cx">
</span><span class="lines">@@ -26,13 +26,13 @@
</span><span class="cx"> && frameOne[1] == frameTwo[1]
</span><span class="cx"> && frameOne[2] == frameTwo[2]
</span><span class="cx"> && frameOne[3] == frameTwo[3])
</span><del>- console.innerHTML = "<span style='color:red'>FAIL</span>";
- else
- console.innerHTML = "<span style='color:green'>PASS</span>";
</del><ins>+ return;
</ins><span class="cx">
</span><ins>+ window.clearInterval(handle);
+ console.innerHTML = "<span style='color:green'>PASS</span>";
</ins><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><del>- }, 100);
</del><ins>+ }, 10);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> window.onpageshow = function(event) {
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (214705 => 214706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2017-04-01 00:24:48 UTC (rev 214705)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-04-01 00:31:34 UTC (rev 214706)
</span><span class="lines">@@ -1516,8 +1516,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/162507 http/tests/media/hls/hls-video-resize.html [ Pass Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/162510 [ Debug ] fast/images/animated-gif-restored-from-bfcache.html [ Pass Failure ]
-
</del><span class="cx"> webkit.org/b/167642 imported/w3c/web-platform-tests/shadow-dom/slotchange.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/167757 [ Sierra Release ] workers/bomb.html [ Pass Timeout ]
</span></span></pre>
</div>
</div>
</body>
</html>