<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214612] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214612">214612</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2017-03-30 10:06:59 -0700 (Thu, 30 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[mac-wk1 debug] LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=170188
Reviewed by Eric Carlson.
The textTrackDisplayElement call will fail and throw an exception if the text track display element
has not yet been added to the text track container element. We wait until it has been added.
* media/track/track-cue-rendering-with-padding.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediatracktrackcuerenderingwithpaddinghtml">trunk/LayoutTests/media/track/track-cue-rendering-with-padding.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214611 => 214612)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-30 17:06:21 UTC (rev 214611)
+++ trunk/LayoutTests/ChangeLog 2017-03-30 17:06:59 UTC (rev 214612)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-30 Per Arne Vollan <pvollan@apple.com>
+
+ [mac-wk1 debug] LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=170188
+
+ Reviewed by Eric Carlson.
+
+ The textTrackDisplayElement call will fail and throw an exception if the text track display element
+ has not yet been added to the text track container element. We wait until it has been added.
+
+ * media/track/track-cue-rendering-with-padding.html:
+
</ins><span class="cx"> 2017-03-30 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> [Modern Media Controls] Invalid placard icon is not visible for short video
</span></span></pre></div>
<a id="trunkLayoutTestsmediatracktrackcuerenderingwithpaddinghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/track/track-cue-rendering-with-padding.html (214611 => 214612)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/track/track-cue-rendering-with-padding.html 2017-03-30 17:06:21 UTC (rev 214611)
+++ trunk/LayoutTests/media/track/track-cue-rendering-with-padding.html 2017-03-30 17:06:59 UTC (rev 214612)
</span><span class="lines">@@ -16,6 +16,8 @@
</span><span class="cx"> <script>
</span><span class="cx"> var cueContainerBottomPoint;
</span><span class="cx"> var cueDisplayBottomPoint;
</span><ins>+ var retries = 0;
+ var maxRetries = 256;
</ins><span class="cx">
</span><span class="cx"> function startTest()
</span><span class="cx"> {
</span><span class="lines">@@ -24,8 +26,22 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // The textTrackDisplayElement call will fail and throw an exception if the text track display element
+ // has not yet been added to the text track container element. We wait until it has been added.
+ try {
+ var cueDisplayElement = textTrackDisplayElement(video, 'display', 0);
+ } catch (exception) {
+ retries++;
+ if (retries > maxRetries) {
+ consoleWrite("The test failed because the text track display element was not found.");
+ endTest();
+ }
+ else
+ setTimeout(startTest, 100);
+ return;
+ }
+
</ins><span class="cx"> var cueContainerElement = textTrackDisplayElement(video);
</span><del>- var cueDisplayElement = textTrackDisplayElement(video, 'display', 0);
</del><span class="cx">
</span><span class="cx"> cueDisplayBottomPoint = cueDisplayElement.offsetTop + cueDisplayElement.offsetHeight;
</span><span class="cx"> cueContainerBottomPoint = cueContainerElement.offsetTop + cueContainerElement.offsetHeight;
</span></span></pre>
</div>
</div>
</body>
</html>