<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214622] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214622">214622</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2017-03-30 14:10:54 -0700 (Thu, 30 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Win] Pass close_fds = True in Python popen call.
https://bugs.webkit.org/show_bug.cgi?id=170172
Reviewed by Brent Fulgham.
This was previously not supported on Windows, but in Python 2.7.10 it is.
* Scripts/webkitpy/common/system/executive.py:
(Executive._should_close_fds):
* Scripts/webkitpy/port/server_process.py:
(ServerProcess._start):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonsystemexecutivepy">trunk/Tools/Scripts/webkitpy/common/system/executive.py</a></li>
<li><a href="#trunkToolsScriptswebkitpyportserver_processpy">trunk/Tools/Scripts/webkitpy/port/server_process.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (214621 => 214622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/ChangeLog 2017-03-30 21:10:54 UTC (rev 214622)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-03-30 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Pass close_fds = True in Python popen call.
+ https://bugs.webkit.org/show_bug.cgi?id=170172
+
+ Reviewed by Brent Fulgham.
+
+ This was previously not supported on Windows, but in Python 2.7.10 it is.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive._should_close_fds):
+ * Scripts/webkitpy/port/server_process.py:
+ (ServerProcess._start):
+
</ins><span class="cx"> 2017-03-30 Aakash Jain <aakash_jain@apple.com>
</span><span class="cx">
</span><span class="cx"> Change my status to be a WebKit reviewer.
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonsystemexecutivepy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (214621 => 214622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-03-30 21:10:54 UTC (rev 214622)
</span><span class="lines">@@ -91,9 +91,8 @@
</span><span class="cx"> # We need to pass close_fds=True to work around Python bug #2320
</span><span class="cx"> # (otherwise we can hang when we kill DumpRenderTree when we are running
</span><span class="cx"> # multiple threads). See http://bugs.python.org/issue2320 .
</span><del>- # Note that close_fds isn't supported on Windows, but this bug only
- # shows up on Mac and Linux.
- return not (sys.platform == 'cygwin' or sys.platform.startswith('win'))
</del><ins>+ # In Python 2.7.10, close_fds is also supported on Windows.
+ return True
</ins><span class="cx">
</span><span class="cx"> def _run_command_with_teed_output(self, args, teed_output, **kwargs):
</span><span class="cx"> child_process = self.popen(args,
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportserver_processpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/server_process.py (214621 => 214622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/server_process.py 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/Scripts/webkitpy/port/server_process.py 2017-03-30 21:10:54 UTC (rev 214622)
</span><span class="lines">@@ -114,7 +114,8 @@
</span><span class="cx"> raise ValueError("%s already running" % self._name)
</span><span class="cx"> self._reset()
</span><span class="cx"> # close_fds is a workaround for http://bugs.python.org/issue2320
</span><del>- close_fds = not self._host.platform.is_win()
</del><ins>+ # In Python 2.7.10, close_fds is also supported on Windows.
+ close_fds = True
</ins><span class="cx"> self._proc = self._host.executive.popen(self._cmd, stdin=self._host.executive.PIPE,
</span><span class="cx"> stdout=self._host.executive.PIPE,
</span><span class="cx"> stderr=self._host.executive.PIPE,
</span></span></pre>
</div>
</div>
</body>
</html>