<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214443] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214443">214443</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2017-03-27 17:06:28 -0700 (Mon, 27 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move visibleInViewportStateChanged callback from Element to render tree
https://bugs.webkit.org/show_bug.cgi?id=170039
Reviewed by Zalan Bujtas.
Make it easier to use from the render tree.
Also for simplicity move the bits from RenderObject rare data to RenderElement.
There is plenty of space there.
* dom/Element.h:
(WebCore::Element::isVisibleInViewportChanged): Deleted.
* html/HTMLMediaElement.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::registerForVisibleInViewportCallback):
(WebCore::RenderElement::unregisterForVisibleInViewportCallback):
(WebCore::RenderElement::setVisibleInViewportState):
(WebCore::RenderElement::visibleInViewportStateChanged):
* rendering/RenderElement.h:
(WebCore::RenderElement::visibleInViewportState):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setIsRegisteredForVisibleInViewportCallback): Deleted.
(WebCore::RenderObject::setVisibleInViewportState): Deleted.
* rendering/RenderObject.h:
(WebCore::RenderObject::hasOutlineAutoAncestor):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
(WebCore::RenderObject::isRegisteredForVisibleInViewportCallback): Deleted.
(WebCore::RenderObject::visibleInViewportState): Deleted.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::visibleInViewportStateChanged):
* rendering/RenderVideo.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::updateVisibleViewportRect):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderElementcpp">trunk/Source/WebCore/rendering/RenderElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderElementh">trunk/Source/WebCore/rendering/RenderElement.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderVideocpp">trunk/Source/WebCore/rendering/RenderVideo.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderVideoh">trunk/Source/WebCore/rendering/RenderVideo.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/ChangeLog 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2017-03-27 Antti Koivisto <antti@apple.com>
+
+ Move visibleInViewportStateChanged callback from Element to render tree
+ https://bugs.webkit.org/show_bug.cgi?id=170039
+
+ Reviewed by Zalan Bujtas.
+
+ Make it easier to use from the render tree.
+
+ Also for simplicity move the bits from RenderObject rare data to RenderElement.
+ There is plenty of space there.
+
+ * dom/Element.h:
+ (WebCore::Element::isVisibleInViewportChanged): Deleted.
+ * html/HTMLMediaElement.h:
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::RenderElement):
+ (WebCore::RenderElement::willBeDestroyed):
+ (WebCore::RenderElement::registerForVisibleInViewportCallback):
+ (WebCore::RenderElement::unregisterForVisibleInViewportCallback):
+ (WebCore::RenderElement::setVisibleInViewportState):
+ (WebCore::RenderElement::visibleInViewportStateChanged):
+ * rendering/RenderElement.h:
+ (WebCore::RenderElement::visibleInViewportState):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setIsRegisteredForVisibleInViewportCallback): Deleted.
+ (WebCore::RenderObject::setVisibleInViewportState): Deleted.
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::hasOutlineAutoAncestor):
+ (WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
+ (WebCore::RenderObject::isRegisteredForVisibleInViewportCallback): Deleted.
+ (WebCore::RenderObject::visibleInViewportState): Deleted.
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::visibleInViewportStateChanged):
+ * rendering/RenderVideo.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::updateVisibleViewportRect):
+
</ins><span class="cx"> 2017-03-27 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> addIceCandidate should not throw if passed null or undefined
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/dom/Element.h 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -550,8 +550,6 @@
</span><span class="cx"> bool hasDisplayContents() const;
</span><span class="cx"> void setHasDisplayContents(bool);
</span><span class="cx">
</span><del>- virtual void isVisibleInViewportChanged() { }
-
</del><span class="cx"> using ContainerNode::setAttributeEventListener;
</span><span class="cx"> void setAttributeEventListener(const AtomicString& eventType, const QualifiedName& attributeName, const AtomicString& value);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -497,6 +497,8 @@
</span><span class="cx">
</span><span class="cx"> bool isTemporarilyAllowingInlinePlaybackAfterFullscreen() const {return m_temporarilyAllowingInlinePlaybackAfterFullscreen; }
</span><span class="cx">
</span><ins>+ void isVisibleInViewportChanged();
+
</ins><span class="cx"> protected:
</span><span class="cx"> HTMLMediaElement(const QualifiedName&, Document&, bool createdByParser);
</span><span class="cx"> virtual ~HTMLMediaElement();
</span><span class="lines">@@ -813,7 +815,6 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> bool isVideoTooSmallForInlinePlayback();
</span><del>- void isVisibleInViewportChanged() final;
</del><span class="cx"> void updateShouldAutoplay();
</span><span class="cx">
</span><span class="cx"> void pauseAfterDetachedTask();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderElement.cpp 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -114,6 +114,8 @@
</span><span class="cx"> , m_renderBlockShouldForceRelayoutChildren(false)
</span><span class="cx"> , m_renderBlockFlowHasMarkupTruncation(false)
</span><span class="cx"> , m_renderBlockFlowLineLayoutPath(RenderBlockFlow::UndeterminedPath)
</span><ins>+ , m_isRegisteredForVisibleInViewportCallback(false)
+ , m_visibleInViewportState(VisibilityUnknown)
</ins><span class="cx"> , m_firstChild(nullptr)
</span><span class="cx"> , m_lastChild(nullptr)
</span><span class="cx"> , m_style(WTFMove(style))
</span><span class="lines">@@ -1106,8 +1108,7 @@
</span><span class="cx">
</span><span class="cx"> destroyLeftoverChildren();
</span><span class="cx">
</span><del>- if (isRegisteredForVisibleInViewportCallback())
- unregisterForVisibleInViewportCallback();
</del><ins>+ unregisterForVisibleInViewportCallback();
</ins><span class="cx">
</span><span class="cx"> if (hasCounterNodeMap())
</span><span class="cx"> RenderCounter::destroyCounterNodes(*this);
</span><span class="lines">@@ -1145,9 +1146,6 @@
</span><span class="cx"> }
</span><span class="cx"> if (m_hasPausedImageAnimations)
</span><span class="cx"> view().removeRendererWithPausedImageAnimations(*this);
</span><del>-
- if (isRegisteredForVisibleInViewportCallback())
- view().unregisterForVisibleInViewportCallback(*this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderElement::setNeedsPositionedMovementLayout(const RenderStyle* oldStyle)
</span><span class="lines">@@ -1467,9 +1465,9 @@
</span><span class="cx">
</span><span class="cx"> void RenderElement::registerForVisibleInViewportCallback()
</span><span class="cx"> {
</span><del>- if (isRegisteredForVisibleInViewportCallback())
</del><ins>+ if (m_isRegisteredForVisibleInViewportCallback)
</ins><span class="cx"> return;
</span><del>- setIsRegisteredForVisibleInViewportCallback(true);
</del><ins>+ m_isRegisteredForVisibleInViewportCallback = true;
</ins><span class="cx">
</span><span class="cx"> view().registerForVisibleInViewportCallback(*this);
</span><span class="cx"> }
</span><span class="lines">@@ -1476,21 +1474,24 @@
</span><span class="cx">
</span><span class="cx"> void RenderElement::unregisterForVisibleInViewportCallback()
</span><span class="cx"> {
</span><del>- if (!isRegisteredForVisibleInViewportCallback())
</del><ins>+ if (!m_isRegisteredForVisibleInViewportCallback)
</ins><span class="cx"> return;
</span><del>- setIsRegisteredForVisibleInViewportCallback(false);
</del><ins>+ m_isRegisteredForVisibleInViewportCallback = false;
</ins><span class="cx">
</span><span class="cx"> view().unregisterForVisibleInViewportCallback(*this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderElement::visibleInViewportStateChanged(VisibleInViewportState state)
</del><ins>+void RenderElement::setVisibleInViewportState(VisibleInViewportState state)
</ins><span class="cx"> {
</span><del>- if (state == visibleInViewportState())
</del><ins>+ if (state == m_visibleInViewportState)
</ins><span class="cx"> return;
</span><del>- setVisibleInViewportState(state);
</del><ins>+ m_visibleInViewportState = state;
+ visibleInViewportStateChanged();
+}
</ins><span class="cx">
</span><del>- if (element())
- element()->isVisibleInViewportChanged();
</del><ins>+void RenderElement::visibleInViewportStateChanged()
+{
+ ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderElement::newImageAnimationFrameAvailable(CachedImage& image)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderElement.h (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderElement.h 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderElement.h 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -185,8 +185,16 @@
</span><span class="cx">
</span><span class="cx"> void registerForVisibleInViewportCallback();
</span><span class="cx"> void unregisterForVisibleInViewportCallback();
</span><del>- void visibleInViewportStateChanged(VisibleInViewportState);
</del><span class="cx">
</span><ins>+ enum VisibleInViewportState {
+ VisibilityUnknown,
+ VisibleInViewport,
+ NotVisibleInViewport,
+ };
+ VisibleInViewportState visibleInViewportState() const { return static_cast<VisibleInViewportState>(m_visibleInViewportState); }
+ void setVisibleInViewportState(VisibleInViewportState);
+ virtual void visibleInViewportStateChanged();
+
</ins><span class="cx"> bool repaintForPausedImageAnimationsIfNeeded(const IntRect& visibleRect);
</span><span class="cx"> bool hasPausedImageAnimations() const { return m_hasPausedImageAnimations; }
</span><span class="cx"> void setHasPausedImageAnimations(bool b) { m_hasPausedImageAnimations = b; }
</span><span class="lines">@@ -337,6 +345,9 @@
</span><span class="cx"> unsigned m_renderBlockFlowHasMarkupTruncation : 1;
</span><span class="cx"> unsigned m_renderBlockFlowLineLayoutPath : 2;
</span><span class="cx">
</span><ins>+ unsigned m_isRegisteredForVisibleInViewportCallback : 1;
+ unsigned m_visibleInViewportState : 2;
+
</ins><span class="cx"> RenderObject* m_firstChild;
</span><span class="cx"> RenderObject* m_lastChild;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -1985,18 +1985,6 @@
</span><span class="cx"> ensureRareData().setHasOutlineAutoAncestor(hasOutlineAutoAncestor);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderObject::setIsRegisteredForVisibleInViewportCallback(bool registered)
-{
- if (registered || hasRareData())
- ensureRareData().setIsRegisteredForVisibleInViewportCallback(registered);
-}
-
-void RenderObject::setVisibleInViewportState(VisibleInViewportState visible)
-{
- if (visible != VisibilityUnknown || hasRareData())
- ensureRareData().setVisibleInViewportState(visible);
-}
-
</del><span class="cx"> RenderObject::RareDataMap& RenderObject::rareDataMap()
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<RareDataMap> map;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -446,19 +446,11 @@
</span><span class="cx"> bool hasReflection() const { return m_bitfields.hasRareData() && rareData().hasReflection(); }
</span><span class="cx"> bool isRenderFlowThread() const { return m_bitfields.hasRareData() && rareData().isRenderFlowThread(); }
</span><span class="cx"> bool hasOutlineAutoAncestor() const { return m_bitfields.hasRareData() && rareData().hasOutlineAutoAncestor(); }
</span><del>- bool isRegisteredForVisibleInViewportCallback() { return m_bitfields.hasRareData() && rareData().isRegisteredForVisibleInViewportCallback(); }
</del><span class="cx">
</span><span class="cx"> bool isExcludedFromNormalLayout() const { return m_bitfields.isExcludedFromNormalLayout(); }
</span><span class="cx"> void setIsExcludedFromNormalLayout(bool excluded) { m_bitfields.setIsExcludedFromNormalLayout(excluded); }
</span><span class="cx"> bool isExcludedAndPlacedInBorder() const { return isExcludedFromNormalLayout() && isLegend(); }
</span><span class="cx">
</span><del>- enum VisibleInViewportState {
- VisibilityUnknown,
- VisibleInViewport,
- NotVisibleInViewport,
- };
- VisibleInViewportState visibleInViewportState() { return m_bitfields.hasRareData() ? rareData().visibleInViewportState() : VisibilityUnknown; }
-
</del><span class="cx"> bool hasLayer() const { return m_bitfields.hasLayer(); }
</span><span class="cx">
</span><span class="cx"> enum BoxDecorationState {
</span><span class="lines">@@ -567,8 +559,6 @@
</span><span class="cx"> void setHasReflection(bool = true);
</span><span class="cx"> void setIsRenderFlowThread(bool = true);
</span><span class="cx"> void setHasOutlineAutoAncestor(bool = true);
</span><del>- void setIsRegisteredForVisibleInViewportCallback(bool);
- void setVisibleInViewportState(VisibleInViewportState);
</del><span class="cx">
</span><span class="cx"> // Hook so that RenderTextControl can return the line height of its inner renderer.
</span><span class="cx"> // For other renderers, the value is the same as lineHeight(false).
</span><span class="lines">@@ -982,8 +972,6 @@
</span><span class="cx"> , m_hasReflection(false)
</span><span class="cx"> , m_isRenderFlowThread(false)
</span><span class="cx"> , m_hasOutlineAutoAncestor(false)
</span><del>- , m_isRegisteredForVisibleInViewportCallback(false)
- , m_visibleInViewportState(VisibilityUnknown)
</del><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> ADD_BOOLEAN_BITFIELD(isDragging, IsDragging);
</span><span class="lines">@@ -992,8 +980,6 @@
</span><span class="cx"> ADD_BOOLEAN_BITFIELD(hasOutlineAutoAncestor, HasOutlineAutoAncestor);
</span><span class="cx">
</span><span class="cx"> // From RenderElement
</span><del>- ADD_BOOLEAN_BITFIELD(isRegisteredForVisibleInViewportCallback, IsRegisteredForVisibleInViewportCallback);
- ADD_ENUM_BITFIELD(visibleInViewportState, VisibleInViewportState, VisibleInViewportState, 2);
</del><span class="cx"> std::unique_ptr<RenderStyle> cachedFirstLineStyle;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderVideocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderVideo.cpp (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderVideo.cpp 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderVideo.cpp 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -67,6 +67,11 @@
</span><span class="cx"> RenderMedia::willBeDestroyed();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void RenderVideo::visibleInViewportStateChanged()
+{
+ videoElement().isVisibleInViewportChanged();
+}
+
</ins><span class="cx"> IntSize RenderVideo::defaultSize()
</span><span class="cx"> {
</span><span class="cx"> // These values are specified in the spec.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderVideoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderVideo.h (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderVideo.h 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderVideo.h 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -71,6 +71,8 @@
</span><span class="cx">
</span><span class="cx"> void layout() final;
</span><span class="cx">
</span><ins>+ void visibleInViewportStateChanged() final;
+
</ins><span class="cx"> LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const final;
</span><span class="cx"> LayoutUnit minimumReplacedHeight() const final;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.cpp (214442 => 214443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.cpp 2017-03-27 23:37:40 UTC (rev 214442)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2017-03-28 00:06:28 UTC (rev 214443)
</span><span class="lines">@@ -1389,8 +1389,10 @@
</span><span class="cx"> {
</span><span class="cx"> resumePausedImageAnimationsIfNeeded(visibleRect);
</span><span class="cx">
</span><del>- for (auto* renderer : m_visibleInViewportRenderers)
- renderer->visibleInViewportStateChanged(visibleRect.intersects(enclosingIntRect(renderer->absoluteClippedOverflowRect())) ? RenderElement::VisibleInViewport : RenderElement::NotVisibleInViewport);
</del><ins>+ for (auto* renderer : m_visibleInViewportRenderers) {
+ auto state = visibleRect.intersects(enclosingIntRect(renderer->absoluteClippedOverflowRect())) ? RenderElement::VisibleInViewport : RenderElement::NotVisibleInViewport;
+ renderer->setVisibleInViewportState(state);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderView::addRendererWithPausedImageAnimations(RenderElement& renderer)
</span></span></pre>
</div>
</div>
</body>
</html>