<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214327] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214327">214327</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-23 16:51:20 -0700 (Thu, 23 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>SVG animations are not paused when their <svg> element is removed from the document
https://bugs.webkit.org/show_bug.cgi?id=170030
<rdar://problem/31230252>
Reviewed by Dean Jackson.
Source/WebCore:
SVG animations were not paused when their <svg> element was removed from the document.
This patch fixes the issue.
Test: svg/animations/animations-paused-when-removed-from-document.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
LayoutTests:
Add layout test coverage.
* svg/animations/animations-paused-when-removed-from-document-expected.txt: Added.
* svg/animations/animations-paused-when-removed-from-document.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGSVGElementcpp">trunk/Source/WebCore/svg/SVGSVGElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvganimationsanimationspausedwhenremovedfromdocumentexpectedtxt">trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvganimationsanimationspausedwhenremovedfromdocumenthtml">trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214326 => 214327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-03-23 23:42:41 UTC (rev 214326)
+++ trunk/LayoutTests/ChangeLog        2017-03-23 23:51:20 UTC (rev 214327)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-23 Chris Dumez <cdumez@apple.com>
+
+ SVG animations are not paused when their <svg> element is removed from the document
+ https://bugs.webkit.org/show_bug.cgi?id=170030
+ <rdar://problem/31230252>
+
+ Reviewed by Dean Jackson.
+
+ Add layout test coverage.
+
+ * svg/animations/animations-paused-when-removed-from-document-expected.txt: Added.
+ * svg/animations/animations-paused-when-removed-from-document.html: Added.
+
</ins><span class="cx"> 2017-03-22 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> font shorthand should accept variation values
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsanimationspausedwhenremovedfromdocumentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document-expected.txt (0 => 214327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document-expected.txt         (rev 0)
+++ trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document-expected.txt        2017-03-23 23:51:20 UTC (rev 214327)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+Tests that SVG animations are properly paused when removed from the document.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.areSVGAnimationsPaused is false
+PASS svgElement.animationsPaused() is false
+Removing SVG element from the document
+PASS svgElement.animationsPaused() is true
+Adding SVG element back into the document
+PASS internals.areSVGAnimationsPaused is false
+PASS svgElement.animationsPaused() is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestssvganimationsanimationspausedwhenremovedfromdocumenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document.html (0 => 214327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document.html         (rev 0)
+++ trunk/LayoutTests/svg/animations/animations-paused-when-removed-from-document.html        2017-03-23 23:51:20 UTC (rev 214327)
</span><span class="lines">@@ -0,0 +1,42 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that SVG animations are properly paused when removed from the document.");
+jsTestIsAsync = true;
+
+window.onload = function() {
+ testDiv = document.getElementById("testDiv");
+ svgElement = document.querySelector("svg");
+ shouldBeFalse("internals.areSVGAnimationsPaused");
+ shouldBeFalse("svgElement.animationsPaused()");
+
+ debug("Removing SVG element from the document");
+ testDiv.remove();
+
+ setTimeout(function() {
+ shouldBeTrue("svgElement.animationsPaused()");
+
+ debug("Adding SVG element back into the document");
+ document.body.appendChild(testDiv);
+
+ setTimeout(function() {
+ shouldBeFalse("internals.areSVGAnimationsPaused");
+ shouldBeFalse("svgElement.animationsPaused()");
+ finishJSTest();
+ }, 0);
+ }, 0);
+}
+</script>
+<div id="testDiv">
+<svg width="300px" height="100px">
+ <rect x="0" y="0" width="300" height="100" stroke="black" stroke-width="1" />
+ <circle cx="0" cy="50" r="15" fill="blue" stroke="black" stroke-width="1">
+ <animate attributeName="cx" from="0" to="100" dur="5s" repeatCount="indefinite" />
+ </circle>
+</svg>
+</div>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214326 => 214327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-03-23 23:42:41 UTC (rev 214326)
+++ trunk/Source/WebCore/ChangeLog        2017-03-23 23:51:20 UTC (rev 214327)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-03-23 Chris Dumez <cdumez@apple.com>
+
+ SVG animations are not paused when their <svg> element is removed from the document
+ https://bugs.webkit.org/show_bug.cgi?id=170030
+ <rdar://problem/31230252>
+
+ Reviewed by Dean Jackson.
+
+ SVG animations were not paused when their <svg> element was removed from the document.
+ This patch fixes the issue.
+
+ Test: svg/animations/animations-paused-when-removed-from-document.html
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::insertedInto):
+ (WebCore::SVGSVGElement::removedFrom):
+
</ins><span class="cx"> 2017-03-22 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> font shorthand should accept variation values
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGElement.cpp (214326 => 214327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGSVGElement.cpp        2017-03-23 23:42:41 UTC (rev 214326)
+++ trunk/Source/WebCore/svg/SVGSVGElement.cpp        2017-03-23 23:51:20 UTC (rev 214327)
</span><span class="lines">@@ -469,6 +469,8 @@
</span><span class="cx"> {
</span><span class="cx"> if (rootParent.isConnected()) {
</span><span class="cx"> document().accessSVGExtensions().addTimeContainer(this);
</span><ins>+ if (!document().accessSVGExtensions().areAnimationsPaused())
+ unpauseAnimations();
</ins><span class="cx">
</span><span class="cx"> // Animations are started at the end of document parsing and after firing the load event,
</span><span class="cx"> // but if we miss that train (deferred programmatic element insertion for example) we need
</span><span class="lines">@@ -481,8 +483,10 @@
</span><span class="cx">
</span><span class="cx"> void SVGSVGElement::removedFrom(ContainerNode& rootParent)
</span><span class="cx"> {
</span><del>- if (rootParent.isConnected())
</del><ins>+ if (rootParent.isConnected()) {
</ins><span class="cx"> document().accessSVGExtensions().removeTimeContainer(this);
</span><ins>+ pauseAnimations();
+ }
</ins><span class="cx"> SVGGraphicsElement::removedFrom(rootParent);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>