<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214311] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214311">214311</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-23 12:56:46 -0700 (Thu, 23 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/214047">r214047</a>): LayoutTest fast/events/pageshow-pagehide-on-back-cached-with-frames.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=169834
Reviewed by Alexey Proskuryakov.
Ensure that the subframes are loaded in a consistent order between test runs.
Currently the test fast/events/pageshow-pagehide-on-back-cached-with-frames.html assumes
that subframes will load in tree order. This assumption is incorrect. Therefore, we need
to explicitly manage the loading of the subframes to ensure this invariant.
* fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
* fast/events/pageshow-pagehide-on-back-cached-with-frames.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventspageshowpagehideonbackcachedwithframesexpectedtxt">trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspageshowpagehideonbackcachedwithframeshtml">trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214310 => 214311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-23 19:53:02 UTC (rev 214310)
+++ trunk/LayoutTests/ChangeLog 2017-03-23 19:56:46 UTC (rev 214311)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-23 Daniel Bates <dabates@apple.com>
+
+ REGRESSION (r214047): LayoutTest fast/events/pageshow-pagehide-on-back-cached-with-frames.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=169834
+
+ Reviewed by Alexey Proskuryakov.
+
+ Ensure that the subframes are loaded in a consistent order between test runs.
+
+ Currently the test fast/events/pageshow-pagehide-on-back-cached-with-frames.html assumes
+ that subframes will load in tree order. This assumption is incorrect. Therefore, we need
+ to explicitly manage the loading of the subframes to ensure this invariant.
+
+ * fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
+ * fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
+
</ins><span class="cx"> 2017-03-23 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> WebSQL databases should not openable in private browsing.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspageshowpagehideonbackcachedwithframesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt (214310 => 214311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt 2017-03-23 19:53:02 UTC (rev 214310)
+++ trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt 2017-03-23 19:56:46 UTC (rev 214311)
</span><span class="lines">@@ -1,24 +1,24 @@
</span><del>-CONSOLE MESSAGE: line 21: ***Top level frame being parsed for the initial page load***
-CONSOLE MESSAGE: line 21: Subsubframe window.onload
-CONSOLE MESSAGE: line 21: Subsubframe window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Subframe window.onload
-CONSOLE MESSAGE: line 21: Subframe window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onload
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Subframe2 window.onload
-CONSOLE MESSAGE: line 21: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Main frame window.onload
-CONSOLE MESSAGE: line 21: Main frame window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: ***Navigating top-level frame to a page that will immediately navigate back to this one***
-CONSOLE MESSAGE: line 21: Main frame window.onpagehide, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subframe window.onpagehide, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subsubframe window.onpagehide, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subframe2 window.onpagehide, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onpagehide, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subsubframe window.onpageshow, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subframe window.onpageshow, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = true
-CONSOLE MESSAGE: line 21: Main frame window.onpageshow, target = [object HTMLDocument], persisted = true
</del><ins>+CONSOLE MESSAGE: line 33: ***Top level frame being parsed for the initial page load***
+CONSOLE MESSAGE: line 33: Subsubframe window.onload
+CONSOLE MESSAGE: line 33: Subsubframe window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 33: Subframe window.onload
+CONSOLE MESSAGE: line 33: Subframe window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 33: Subsubframe2 window.onload
+CONSOLE MESSAGE: line 33: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 33: Subframe2 window.onload
+CONSOLE MESSAGE: line 33: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 33: Main frame window.onload
+CONSOLE MESSAGE: line 33: Main frame window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 33: ***Navigating top-level frame to a page that will immediately navigate back to this one***
+CONSOLE MESSAGE: line 33: Main frame window.onpagehide, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subframe window.onpagehide, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subsubframe window.onpagehide, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subframe2 window.onpagehide, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subsubframe2 window.onpagehide, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subsubframe window.onpageshow, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subframe window.onpageshow, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = true
+CONSOLE MESSAGE: line 33: Main frame window.onpageshow, target = [object HTMLDocument], persisted = true
</ins><span class="cx"> Test pageshow/pagehide event behavior when navigating away from a page with frames, putting the page in the page cache, then back to it.
</span><del>-
</del><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventspageshowpagehideonbackcachedwithframeshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames.html (214310 => 214311)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames.html 2017-03-23 19:53:02 UTC (rev 214310)
+++ trunk/LayoutTests/fast/events/pageshow-pagehide-on-back-cached-with-frames.html 2017-03-23 19:56:46 UTC (rev 214311)
</span><span class="lines">@@ -2,8 +2,6 @@
</span><span class="cx"> <body>
</span><span class="cx"> Test pageshow/pagehide event behavior when navigating away from a page with frames, putting the page in the page cache, then back to it.
</span><span class="cx"> <pre id="log"></pre>
</span><del>-<iframe src="resources/pageshow-pagehide-subframe-cachable.html"></iframe>
-<iframe src="resources/pageshow-pagehide-subframe-cachable-2.html"></iframe>
</del><span class="cx"> </body>
</span><span class="cx"> <script>
</span><span class="cx">
</span><span class="lines">@@ -13,6 +11,20 @@
</span><span class="cx"> testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+// We explicitly chain the loading of the subframes to ensure consistent test results between runs.
+var didLoadSubframes = appendIframe("resources/pageshow-pagehide-subframe-cachable.html").then(() => appendIframe("resources/pageshow-pagehide-subframe-cachable-2.html"));
+
+function appendIframe(url)
+{
+ var promise = new Promise((resolve, reject) => {
+ var iframe = document.createElement("iframe");
+ iframe.onload = resolve;
+ iframe.src = url;
+ document.body.appendChild(iframe);
+ });
+ return promise;
+}
+
</ins><span class="cx"> function log(message)
</span><span class="cx"> {
</span><span class="cx"> // Logging to the console instead of the "log" DIV in the DOM because
</span><span class="lines">@@ -34,8 +46,10 @@
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> } else {
</span><span class="cx"> log("***Navigating top-level frame to a page that will immediately navigate back to this one***");
</span><del>- // Location changes need to happen outside the onload handler to generate history entries.
- setTimeout(function() {window.location.href = "data:text/html,<script>history.back();</scr" + "ipt>";}, 0);
</del><ins>+ didLoadSubframes.then(() => {
+ // Location changes need to happen outside the onload handler to generate history entries.
+ setTimeout(() => { window.location.href = "data:text/html,<script>history.back();</scr" + "ipt>"; }, 0);
+ });
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>