<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214204] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214204">214204</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-03-20 19:04:59 -0700 (Mon, 20 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a system trace point for memory warning handling
https://bugs.webkit.org/show_bug.cgi?id=169893
Reviewed by Zalan Bujtas.
Source/WebCore:
Add a TraceScope for low memory handling, which logs 'critical' and 'synchronous'.
* page/MemoryRelease.cpp:
(WebCore::releaseMemory):
Source/WTF:
Make it possible to pass data to the Begin trace point.
* wtf/SystemTracing.h:
(WTF::TraceScope::TraceScope):
Tools:
Describe the new trace points.
* Tracing/SystemTracePoints.plist:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfSystemTracingh">trunk/Source/WTF/wtf/SystemTracing.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageMemoryReleasecpp">trunk/Source/WebCore/page/MemoryRelease.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTracingSystemTracePointsplist">trunk/Tools/Tracing/SystemTracePoints.plist</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Source/WTF/ChangeLog 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-20 Simon Fraser <simon.fraser@apple.com>
+
+ Add a system trace point for memory warning handling
+ https://bugs.webkit.org/show_bug.cgi?id=169893
+
+ Reviewed by Zalan Bujtas.
+
+ Make it possible to pass data to the Begin trace point.
+
+ * wtf/SystemTracing.h:
+ (WTF::TraceScope::TraceScope):
+
</ins><span class="cx"> 2017-03-17 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Time channel attack on SVG Filters
</span></span></pre></div>
<a id="trunkSourceWTFwtfSystemTracingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/SystemTracing.h (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/SystemTracing.h 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Source/WTF/wtf/SystemTracing.h 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -67,6 +67,8 @@
</span><span class="cx"> AsyncImageDecodeEnd,
</span><span class="cx"> RAFCallbackStart,
</span><span class="cx"> RAFCallbackEnd,
</span><ins>+ MemoryPressureHandlerStart,
+ MemoryPressureHandlerEnd,
</ins><span class="cx">
</span><span class="cx"> WebKitRange = 10000,
</span><span class="cx"> WebHTMLViewPaintStart,
</span><span class="lines">@@ -107,10 +109,10 @@
</span><span class="cx"> class TraceScope {
</span><span class="cx"> public:
</span><span class="cx">
</span><del>- TraceScope(TracePointCode entryCode, TracePointCode exitCode)
</del><ins>+ TraceScope(TracePointCode entryCode, TracePointCode exitCode, uint64_t data1 = 0, uint64_t data2 = 0, uint64_t data3 = 0, uint64_t data4 = 0)
</ins><span class="cx"> : m_exitCode(exitCode)
</span><span class="cx"> {
</span><del>- TracePoint(entryCode);
</del><ins>+ TracePoint(entryCode, data1, data2, data3, data4);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~TraceScope()
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Source/WebCore/ChangeLog 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2017-03-20 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Add a system trace point for memory warning handling
+ https://bugs.webkit.org/show_bug.cgi?id=169893
+
+ Reviewed by Zalan Bujtas.
+
+ Add a TraceScope for low memory handling, which logs 'critical' and 'synchronous'.
+
+ * page/MemoryRelease.cpp:
+ (WebCore::releaseMemory):
+
+2017-03-20 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Optimize packing of Document and superclass data members
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169880
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageMemoryReleasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/MemoryRelease.cpp (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/MemoryRelease.cpp 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Source/WebCore/page/MemoryRelease.cpp 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -47,6 +47,7 @@
</span><span class="cx"> #include "StyledElement.h"
</span><span class="cx"> #include "WorkerThread.h"
</span><span class="cx"> #include <wtf/FastMalloc.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> #include "ResourceUsageThread.h"
</span><span class="lines">@@ -112,6 +113,8 @@
</span><span class="cx">
</span><span class="cx"> void releaseMemory(Critical critical, Synchronous synchronous)
</span><span class="cx"> {
</span><ins>+ TraceScope scope(MemoryPressureHandlerStart, MemoryPressureHandlerEnd, static_cast<uint64_t>(critical), static_cast<uint64_t>(synchronous));
+
</ins><span class="cx"> if (critical == Critical::Yes)
</span><span class="cx"> releaseCriticalMemory(synchronous);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Tools/ChangeLog 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-20 Simon Fraser <simon.fraser@apple.com>
+
+ Add a system trace point for memory warning handling
+ https://bugs.webkit.org/show_bug.cgi?id=169893
+
+ Reviewed by Zalan Bujtas.
+
+ Describe the new trace points.
+
+ * Tracing/SystemTracePoints.plist:
+
</ins><span class="cx"> 2017-03-20 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
</span></span></pre></div>
<a id="trunkToolsTracingSystemTracePointsplist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Tracing/SystemTracePoints.plist (214203 => 214204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Tracing/SystemTracePoints.plist 2017-03-21 02:04:55 UTC (rev 214203)
+++ trunk/Tools/Tracing/SystemTracePoints.plist 2017-03-21 02:04:59 UTC (rev 214204)
</span><span class="lines">@@ -153,6 +153,25 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><ins>+ <string>Memory pressure handler</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>5019</string>
+ <key>CodeEnd</key>
+ <string>5020</string>
+ <key>ArgNamesBegin</key>
+ <dict>
+ <key>Arg1</key>
+ <string>Critical</string>
+ <key>Arg2</key>
+ <string>Synchronous</string>
+ </dict>
+ </dict>
+ <dict>
+ <key>Name</key>
</ins><span class="cx"> <string>Paint WebHTMLView</string>
</span><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span></span></pre>
</div>
</div>
</body>
</html>