<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214177] trunk/Source/WebKit</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214177">214177</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2017-03-20 10:51:45 -0700 (Mon, 20 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
https://bugs.webkit.org/show_bug.cgi?id=169861
Reviewed by Sam Weinig.
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj: Specified that the Postprocess Headers script build
phase has the Headers and PrivateHeaders directories as its inputs and a timestamp file as
its output.
Source/WebKit/mac:
* MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
* postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
timestamp file used by the Xcode project to determine whether to run the script.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitWebKitxcodeprojprojectpbxproj">trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacMigrateHeadersmake">trunk/Source/WebKit/mac/MigrateHeaders.make</a></li>
<li><a href="#trunkSourceWebKitmacpostprocessheaderssh">trunk/Source/WebKit/mac/postprocess-headers.sh</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (214176 => 214177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog 2017-03-20 17:49:36 UTC (rev 214176)
+++ trunk/Source/WebKit/ChangeLog 2017-03-20 17:51:45 UTC (rev 214177)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-20 Dan Bernstein <mitz@apple.com>
+
+ [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
+ https://bugs.webkit.org/show_bug.cgi?id=169861
+
+ Reviewed by Sam Weinig.
+
+ * WebKit.xcodeproj/project.pbxproj: Specified that the Postprocess Headers script build
+ phase has the Headers and PrivateHeaders directories as its inputs and a timestamp file as
+ its output.
+
</ins><span class="cx"> 2017-03-15 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Sort Xcode project files
</span></span></pre></div>
<a id="trunkSourceWebKitWebKitxcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (214176 => 214177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2017-03-20 17:49:36 UTC (rev 214176)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2017-03-20 17:51:45 UTC (rev 214177)
</span><span class="lines">@@ -3377,9 +3377,12 @@
</span><span class="cx"> files = (
</span><span class="cx"> );
</span><span class="cx"> inputPaths = (
</span><ins>+ "$(TARGET_BUILD_DIR)/$(PRIVATE_HEADERS_FOLDER_PATH)",
+ "$(TARGET_BUILD_DIR)/$(HEADERS_FOLDER_PATH)",
</ins><span class="cx"> );
</span><span class="cx"> name = "Postprocess Headers";
</span><span class="cx"> outputPaths = (
</span><ins>+ "$(DERIVED_FILE_DIR)/postprocess-headers.timestamp",
</ins><span class="cx"> );
</span><span class="cx"> runOnlyForDeploymentPostprocessing = 0;
</span><span class="cx"> shellPath = /bin/sh;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (214176 => 214177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2017-03-20 17:49:36 UTC (rev 214176)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-03-20 17:51:45 UTC (rev 214177)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-20 Dan Bernstein <mitz@apple.com>
+
+ [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
+ https://bugs.webkit.org/show_bug.cgi?id=169861
+
+ Reviewed by Sam Weinig.
+
+ * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
+ * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
+ timestamp file used by the Xcode project to determine whether to run the script.
+
</ins><span class="cx"> 2017-03-19 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> WebHTMLView is useless as WebResourceHandler
</span></span></pre></div>
<a id="trunkSourceWebKitmacMigrateHeadersmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (214176 => 214177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/MigrateHeaders.make 2017-03-20 17:49:36 UTC (rev 214176)
+++ trunk/Source/WebKit/mac/MigrateHeaders.make 2017-03-20 17:51:45 UTC (rev 214177)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> all : $(HEADERS)
</span><span class="cx">
</span><span class="cx"> WEBCORE_HEADER_REPLACE_RULES = -e 's/<WebCore\//<WebKitLegacy\//' -e "s/(^ *)WEBCORE_EXPORT /\1/"
</span><del>-WEBCORE_HEADER_MIGRATE_CMD = sed -E $(WEBCORE_HEADER_REPLACE_RULES) $< > $@
</del><ins>+WEBCORE_HEADER_MIGRATE_CMD = sed -E $(WEBCORE_HEADER_REPLACE_RULES) $< > $@; touch $(PRIVATE_HEADERS_DIR)
</ins><span class="cx">
</span><span class="cx"> $(PRIVATE_HEADERS_DIR)/% : % MigrateHeaders.make
</span><span class="cx"> $(WEBCORE_HEADER_MIGRATE_CMD)
</span></span></pre></div>
<a id="trunkSourceWebKitmacpostprocessheaderssh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/postprocess-headers.sh (214176 => 214177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/postprocess-headers.sh 2017-03-20 17:49:36 UTC (rev 214176)
+++ trunk/Source/WebKit/mac/postprocess-headers.sh 2017-03-20 17:51:45 UTC (rev 214177)
</span><span class="lines">@@ -2,6 +2,8 @@
</span><span class="cx">
</span><span class="cx"> postProcessInDirectory()
</span><span class="cx"> {
</span><ins>+ touch -r "$1" "${TARGET_TEMP_DIR}/postprocess-headers-saved.timestamp"
+
</ins><span class="cx"> cd "$1"
</span><span class="cx">
</span><span class="cx"> local unifdefOptions sedExpression
</span><span class="lines">@@ -65,7 +67,11 @@
</span><span class="cx"> mv ${header}.sed ${header}
</span><span class="cx"> fi
</span><span class="cx"> done
</span><ins>+
+ touch -r "${TARGET_TEMP_DIR}/postprocess-headers-saved.timestamp" "$1"
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> postProcessInDirectory "${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}"
</span><span class="cx"> postProcessInDirectory "${TARGET_BUILD_DIR}/${PRIVATE_HEADERS_FOLDER_PATH}"
</span><ins>+
+touch "${DERIVED_FILE_DIR}/postprocess-headers.timestamp"
</ins></span></pre>
</div>
</div>
</body>
</html>