<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214195] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214195">214195</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-20 16:47:35 -0700 (Mon, 20 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Suspend media playback in background tabs
https://bugs.webkit.org/show_bug.cgi?id=169883
<rdar://problem/28056151>
Reviewed by Eric Carlson.
Source/WebCore:
Suspend media playback in background tabs to save battery
except in cases where we cannot (e.g. PiP, AirPlay).
Test: media/media-playback-page-visibility.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::visibilityStateChanged):
When page visibility state changes, begin / end media session
interruption with reason PlatformMediaSession::EnteringBackground.
This reason was already used on iOS when the application enters
or exist background. HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction()
takes care of preventing interruption in case of AirPlay or PiP.
LayoutTests:
Add layout test coverage.
* media/media-playback-page-visibility-expected.txt: Added.
* media/media-playback-page-visibility.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamediaplaybackpagevisibilityexpectedtxt">trunk/LayoutTests/media/media-playback-page-visibility-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamediaplaybackpagevisibilityhtml">trunk/LayoutTests/media/media-playback-page-visibility.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214194 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-20 23:07:50 UTC (rev 214194)
+++ trunk/LayoutTests/ChangeLog 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-20 Chris Dumez <cdumez@apple.com>
+
+ Suspend media playback in background tabs
+ https://bugs.webkit.org/show_bug.cgi?id=169883
+ <rdar://problem/28056151>
+
+ Reviewed by Eric Carlson.
+
+ Add layout test coverage.
+
+ * media/media-playback-page-visibility-expected.txt: Added.
+ * media/media-playback-page-visibility.html: Added.
+
</ins><span class="cx"> 2017-03-20 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Prevent new navigations from onbeforeunload handler
</span></span></pre></div>
<a id="trunkLayoutTestsmediamediaplaybackpagevisibilityexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-playback-page-visibility-expected.txt (0 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-playback-page-visibility-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-playback-page-visibility-expected.txt 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+Media elements should be paused while in the background.
+
+
+Waiting for Content media to begin playing.
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (video.volume == '0') OK
+* Setting page visibility to hidden
+EXPECTED (video.paused == 'true') OK
+EXPECTED (video.paused == 'true') OK
+* Setting page visibility to visible
+EXPECTED (video.paused == 'false') OK
+END OF TEST
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamediaplaybackpagevisibilityhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-playback-page-visibility.html (0 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-playback-page-visibility.html (rev 0)
+++ trunk/LayoutTests/media/media-playback-page-visibility.html 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -0,0 +1,67 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+ <script src="media-file.js"></script>
+ <script src="video-test.js"></script>
+ <script>
+ var video;
+
+ function runTest()
+ {
+ consoleWrite("Waiting for Content media to begin playing.")
+ video = document.getElementById("video");
+ video.addEventListener("canplaythrough", beginPlaying);
+ video.addEventListener("playing", beganPlaying);
+ video.src = findMediaFile("video", "content/test");
+ video.volume = 0;
+ }
+
+ function beginPlaying(event)
+ {
+ video.play();
+ }
+
+ function onVisibilityChange()
+ {
+ if (document.hidden) {
+ setTimeout(function() {
+ testExpected('video.paused', true);
+ setTimeout(function() {
+ testExpected('video.paused', true);
+ consoleWrite("* Setting page visibility to visible");
+ if (window.testRunner)
+ testRunner.setPageVisibility("visible");
+ }, 10);
+ }, 0);
+ } else {
+ setTimeout(function() {
+ testExpected('video.paused', false);
+ endTest();
+ }, 0);
+ }
+ }
+
+ function beganPlaying(event)
+ {
+ video.removeEventListener("playing", beganPlaying);
+
+ consoleWrite("Media began playing.");
+
+ if (window.internals) {
+ testExpected('video.paused', false);
+ testExpected('video.volume', 0);
+
+ document.addEventListener("visibilitychange", onVisibilityChange, false);
+
+ consoleWrite("* Setting page visibility to hidden");
+ if (window.testRunner)
+ testRunner.setPageVisibility("hidden");
+ }
+ }
+ </script>
+</head>
+<body onload="runTest()">
+ <p>Media elements should be paused while in the background.</p>
+ <video id="video" />
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (214194 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-20 23:07:50 UTC (rev 214194)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -307,6 +307,7 @@
</span><span class="cx"> webkit.org/b/165799 fast/dom/timer-throttling-hidden-page.html [ Skip ]
</span><span class="cx"> webkit.org/b/165799 fast/dom/timer-throttling-hidden-page-non-nested.html [ Skip ]
</span><span class="cx"> webkit.org/b/165799 fast/events/page-visibility-onvisibilitychange.html [ Skip ]
</span><ins>+webkit.org/b/165799 media/media-playback-page-visibility.html [ Skip ]
</ins><span class="cx"> webkit.org/b/165799 svg/animations/animations-paused-page-non-visible.html [ Skip ]
</span><span class="cx">
</span><span class="cx"> # AutoFill button is not supported
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214194 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-20 23:07:50 UTC (rev 214194)
+++ trunk/Source/WebCore/ChangeLog 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2017-03-20 Chris Dumez <cdumez@apple.com>
+
+ Suspend media playback in background tabs
+ https://bugs.webkit.org/show_bug.cgi?id=169883
+ <rdar://problem/28056151>
+
+ Reviewed by Eric Carlson.
+
+ Suspend media playback in background tabs to save battery
+ except in cases where we cannot (e.g. PiP, AirPlay).
+
+ Test: media/media-playback-page-visibility.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::visibilityStateChanged):
+ When page visibility state changes, begin / end media session
+ interruption with reason PlatformMediaSession::EnteringBackground.
+ This reason was already used on iOS when the application enters
+ or exist background. HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction()
+ takes care of preventing interruption in case of AirPlay or PiP.
+
</ins><span class="cx"> 2017-03-20 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Prevent new navigations from onbeforeunload handler
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (214194 => 214195)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-03-20 23:07:50 UTC (rev 214194)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-03-20 23:47:35 UTC (rev 214195)
</span><span class="lines">@@ -159,6 +159,8 @@
</span><span class="cx"> #include "NotImplemented.h"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(document().page() && document().page()->isAlwaysOnLoggingAllowed(), Media, "%p - HTMLMediaElement::" fmt, this, ##__VA_ARGS__)
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> static const double SeekRepeatDelay = 0.1;
</span><span class="lines">@@ -5327,6 +5329,17 @@
</span><span class="cx"> LOG(Media, "HTMLMediaElement::visibilityStateChanged(%p) - visible = %s", this, boolString(!m_elementIsHidden));
</span><span class="cx"> updateSleepDisabling();
</span><span class="cx"> m_mediaSession->visibilityChanged();
</span><ins>+
+ bool isPlayingAudio = isPlaying() && hasAudio() && !muted() && volume();
+ if (!isPlayingAudio) {
+ if (m_elementIsHidden) {
+ RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Suspending playback after going to the background");
+ m_mediaSession->beginInterruption(PlatformMediaSession::EnteringBackground);
+ } else {
+ RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Resuming playback after entering foreground");
+ m_mediaSession->endInterruption(PlatformMediaSession::MayResumePlaying);
+ }
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span></span></pre>
</div>
</div>
</body>
</html>