<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214119] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214119">214119</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2017-03-17 14:12:47 -0700 (Fri, 17 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix the flow thread state on the descendants of out of flow positioned replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=169821
<rdar://problem/30964017>
Reviewed by Simon Fraser.
Source/WebCore:
Descendants of a replaced out of flow elmement should inherit the flowthread state
from the replaced element and not from the replaced element's parent.
Test: fast/multicol/fix-inherit-when-container-is-replaced.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computedFlowThreadState):
LayoutTests:
* fast/multicol/fix-inherit-when-container-is-replaced-expected.txt: Added.
* fast/multicol/fix-inherit-when-container-is-replaced.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmulticolfixinheritwhencontainerisreplacedexpectedtxt">trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmulticolfixinheritwhencontainerisreplacedhtml">trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214118 => 214119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-17 20:59:35 UTC (rev 214118)
+++ trunk/LayoutTests/ChangeLog 2017-03-17 21:12:47 UTC (rev 214119)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-17 Zalan Bujtas <zalan@apple.com>
+
+ Fix the flow thread state on the descendants of out of flow positioned replaced elements.
+ https://bugs.webkit.org/show_bug.cgi?id=169821
+ <rdar://problem/30964017>
+
+ Reviewed by Simon Fraser.
+
+ * fast/multicol/fix-inherit-when-container-is-replaced-expected.txt: Added.
+ * fast/multicol/fix-inherit-when-container-is-replaced.html: Added.
+
</ins><span class="cx"> 2017-03-17 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Update webrtc tests expectations
</span></span></pre></div>
<a id="trunkLayoutTestsfastmulticolfixinheritwhencontainerisreplacedexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced-expected.txt (0 => 214119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced-expected.txt 2017-03-17 21:12:47 UTC (rev 214119)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+PASS if no crash or assert.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastmulticolfixinheritwhencontainerisreplacedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced.html (0 => 214119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/fix-inherit-when-container-is-replaced.html 2017-03-17 21:12:47 UTC (rev 214119)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that we set the correct flow states for positioned inline descendants.</title>
+<style>
+div {
+ column-count: 2;
+}
+
+video {
+ position: fixed;
+}
+</style>
+<script>
+function runTest() {
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+ document.body.offsetHeight;
+ setTimeout(function() {
+ div.style.columnCount = "auto";
+ document.body.offsetHeight;
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 0);
+}
+</script>
+</head>
+<body onload="runTest()">
+PASS if no crash or assert.
+<div id=div><video><track></video></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214118 => 214119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-17 20:59:35 UTC (rev 214118)
+++ trunk/Source/WebCore/ChangeLog 2017-03-17 21:12:47 UTC (rev 214119)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-17 Zalan Bujtas <zalan@apple.com>
+
+ Fix the flow thread state on the descendants of out of flow positioned replaced elements.
+ https://bugs.webkit.org/show_bug.cgi?id=169821
+ <rdar://problem/30964017>
+
+ Reviewed by Simon Fraser.
+
+ Descendants of a replaced out of flow elmement should inherit the flowthread state
+ from the replaced element and not from the replaced element's parent.
+
+ Test: fast/multicol/fix-inherit-when-container-is-replaced.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::computedFlowThreadState):
+
</ins><span class="cx"> 2017-03-17 Jon Davis <jond@apple.com>
</span><span class="cx">
</span><span class="cx"> Update feature status for outdated entries: CSS Shapes, Force Click Events
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (214118 => 214119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2017-03-17 20:59:35 UTC (rev 214118)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2017-03-17 21:12:47 UTC (rev 214119)
</span><span class="lines">@@ -197,8 +197,8 @@
</span><span class="cx"> // containingBlock() skips svg boundary (SVG root is a RenderReplaced).
</span><span class="cx"> if (auto* svgRoot = SVGRenderSupport::findTreeRootObject(downcast<RenderElement>(renderer)))
</span><span class="cx"> inheritedFlowState = svgRoot->flowThreadState();
</span><del>- } else if (auto* containingBlock = renderer.containingBlock())
- inheritedFlowState = containingBlock->flowThreadState();
</del><ins>+ } else if (auto* container = renderer.container())
+ inheritedFlowState = container->flowThreadState();
</ins><span class="cx"> else {
</span><span class="cx"> // Splitting lines or doing continuation, so just keep the current state.
</span><span class="cx"> inheritedFlowState = renderer.flowThreadState();
</span></span></pre>
</div>
</div>
</body>
</html>