<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214129] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214129">214129</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2017-03-17 16:40:22 -0700 (Fri, 17 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>MediaQueryList instances do not update for `prefers-reduced-motion`
https://bugs.webkit.org/show_bug.cgi?id=169835
<rdar://problem/30339378>
Reviewed by Anders Carlsson.
Source/WebCore:
Tell the document it needs to evaluate the MediaQueryLists
if accessibility settings change.
Test: fast/media/mq-prefers-reduced-motion-matchMedia.html
* page/Page.cpp:
(WebCore::Page::accessibilitySettingsDidChange):
LayoutTests:
* fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt: Added.
* fast/media/mq-prefers-reduced-motion-matchMedia.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmediamqprefersreducedmotionmatchMediaexpectedtxt">trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediamqprefersreducedmotionmatchMediahtml">trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (214128 => 214129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-03-17 23:33:11 UTC (rev 214128)
+++ trunk/LayoutTests/ChangeLog        2017-03-17 23:40:22 UTC (rev 214129)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-17 Dean Jackson <dino@apple.com>
+
+ MediaQueryList instances do not update for `prefers-reduced-motion`
+ https://bugs.webkit.org/show_bug.cgi?id=169835
+ <rdar://problem/30339378>
+
+ Reviewed by Anders Carlsson.
+
+ * fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt: Added.
+ * fast/media/mq-prefers-reduced-motion-matchMedia.html: Added.
+
</ins><span class="cx"> 2017-03-17 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Mark media/modern-media-controls/airplay-placard/airplay-placard-text-section.html as flaky.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediamqprefersreducedmotionmatchMediaexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt (0 => 214129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt        2017-03-17 23:40:22 UTC (rev 214129)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+Initial value of motionQuery.matches: false - should be false
+
+Updated value of motionQuery.matches: true - should be true
+
+Note the updated value will only be filled if the listener fires.
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/plain
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestsfastmediamqprefersreducedmotionmatchMediahtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html (0 => 214129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html         (rev 0)
+++ trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html        2017-03-17 23:40:22 UTC (rev 214129)
</span><span class="lines">@@ -0,0 +1,41 @@
</span><ins>+<html>
+<head>
+<title>CSS4 media query test: prefers-reduced-motion using matchMedia and addListener.</title>
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+function runTest()
+{
+ if (!window.internals)
+ return;
+
+ var motionQuery = window.matchMedia("(prefers-reduced-motion)");
+ motionQuery.addListener(() => {
+ document.getElementById("after").textContent = motionQuery.matches ? "true" : "false";
+ testRunner.notifyDone();
+ });
+
+ document.getElementById("before").textContent = motionQuery.matches ? "true" : "false";
+ window.internals.settings.forcedPrefersReducedMotionAccessibilityValue = "on";
+ if (testRunner.runUIScript) {
+ testRunner.runUIScript(`
+ (function() {
+ uiController.simulateAccessibilitySettingsChangeNotification(function() {
+ uiController.uiScriptComplete("Done");
+ });
+ })();`);
+ }
+}
+
+window.addEventListener("load", runTest, false);
+</script>
+</head>
+<body>
+ <p>Initial value of motionQuery.matches: <span id="before">unknown</span> - should be false</p>
+ <p>Updated value of motionQuery.matches: <span id="after">unknown</span> - should be true</p>
+ <p>Note the updated value will only be filled if the listener fires.</p>
+</body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/html
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214128 => 214129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-03-17 23:33:11 UTC (rev 214128)
+++ trunk/Source/WebCore/ChangeLog        2017-03-17 23:40:22 UTC (rev 214129)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-17 Dean Jackson <dino@apple.com>
+
+ MediaQueryList instances do not update for `prefers-reduced-motion`
+ https://bugs.webkit.org/show_bug.cgi?id=169835
+ <rdar://problem/30339378>
+
+ Reviewed by Anders Carlsson.
+
+ Tell the document it needs to evaluate the MediaQueryLists
+ if accessibility settings change.
+
+ Test: fast/media/mq-prefers-reduced-motion-matchMedia.html
+
+ * page/Page.cpp:
+ (WebCore::Page::accessibilitySettingsDidChange):
+
</ins><span class="cx"> 2017-03-17 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Make HTTPCookieStorage operate in the UIProcess in absence of a WebProcessPool.
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (214128 => 214129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp        2017-03-17 23:33:11 UTC (rev 214128)
+++ trunk/Source/WebCore/page/Page.cpp        2017-03-17 23:40:22 UTC (rev 214129)
</span><span class="lines">@@ -2217,6 +2217,7 @@
</span><span class="cx"> auto* styleResolver = document->styleScope().resolverIfExists();
</span><span class="cx"> if (styleResolver && styleResolver->hasMediaQueriesAffectedByAccessibilitySettingsChange()) {
</span><span class="cx"> document->styleScope().didChangeStyleSheetEnvironment();
</span><ins>+ document->evaluateMediaQueryList();
</ins><span class="cx"> neededRecalc = true;
</span><span class="cx"> // FIXME: This instrumentation event is not strictly accurate since cached media query results do not persist across StyleResolver rebuilds.
</span><span class="cx"> InspectorInstrumentation::mediaQueryResultChanged(*document);
</span></span></pre>
</div>
</div>
</body>
</html>