<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214084] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214084">214084</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-03-16 17:47:16 -0700 (Thu, 16 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve the system tracing points
https://bugs.webkit.org/show_bug.cgi?id=169790
Reviewed by Zalan Bujtas.
Use a more cohesive set of system trace points that give a good overview of what
WebKit is doing. Added points for resource loading, render tree building, sync messages
to the web process, async image decode, WASM and fetching cookies.
Source/JavaScriptCore:
* wasm/WasmPlan.cpp:
(JSC::Wasm::Plan::run):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::callWebAssemblyFunction):
Source/WebCore:
* loader/CookieJar.cpp:
(WebCore::cookies):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::logResourceLoaded):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
* platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):
Source/WebKit/mac:
* WebView/WebHTMLView.mm:
(-[WebHTMLView drawRect:]):
Source/WebKit2:
* UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendSync):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEventSynchronously):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
Source/WTF:
* wtf/SystemTracing.h:
Tools:
* Tracing/SystemTracePoints.plist:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmWasmPlancpp">trunk/Source/JavaScriptCore/wasm/WasmPlan.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmjsWebAssemblyFunctioncpp">trunk/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfSystemTracingh">trunk/Source/WTF/wtf/SystemTracing.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderCookieJarcpp">trunk/Source/WebCore/loader/CookieJar.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderSubresourceLoadercpp">trunk/Source/WebCore/loader/SubresourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsImageFrameCachecpp">trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsiosDisplayRefreshMonitorIOSmm">trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm</a></li>
<li><a href="#trunkSourceWebCorestyleRenderTreeUpdatercpp">trunk/Source/WebCore/style/RenderTreeUpdater.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLViewmm">trunk/Source/WebKit/mac/WebView/WebHTMLView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessChildProcessProxyh">trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeContextmm">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreamm">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTracingSystemTracePointsplist">trunk/Tools/Tracing/SystemTracePoints.plist</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * wasm/WasmPlan.cpp:
+ (JSC::Wasm::Plan::run):
+ * wasm/js/WebAssemblyFunction.cpp:
+ (JSC::callWebAssemblyFunction):
+
</ins><span class="cx"> 2017-03-16 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Array concat operation should check for length overflows.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmWasmPlancpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/WasmPlan.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/WasmPlan.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/JavaScriptCore/wasm/WasmPlan.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> #include <wtf/MonotonicTime.h>
</span><span class="cx"> #include <wtf/NumberOfCores.h>
</span><span class="cx"> #include <wtf/StdLibExtras.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> #include <wtf/text/StringBuilder.h>
</span><span class="cx">
</span><span class="cx"> namespace JSC { namespace Wasm {
</span><span class="lines">@@ -114,6 +115,9 @@
</span><span class="cx"> {
</span><span class="cx"> if (!parseAndValidateModule(recompileMode))
</span><span class="cx"> return;
</span><ins>+
+ TraceScope traceScope(WebAssemblyCompileStart, WebAssemblyCompileEnd);
+
</ins><span class="cx"> if (recompileMode)
</span><span class="cx"> ASSERT(m_moduleInformation->memory.mode() == recompileMode);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmjsWebAssemblyFunctioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -41,6 +41,7 @@
</span><span class="cx"> #include "VM.h"
</span><span class="cx"> #include "WasmFormat.h"
</span><span class="cx"> #include "WasmMemory.h"
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="lines">@@ -76,6 +77,8 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ TraceScope traceScope(WebAssemblyExecuteStart, WebAssemblyExecuteEnd);
+
</ins><span class="cx"> Vector<JSValue> boxedArgs;
</span><span class="cx"> for (unsigned argIndex = 0; argIndex < signature->argumentCount(); ++argIndex) {
</span><span class="cx"> JSValue arg = exec->argument(argIndex);
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WTF/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * wtf/SystemTracing.h:
+
</ins><span class="cx"> 2017-03-16 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()
</span></span></pre></div>
<a id="trunkSourceWTFwtfSystemTracingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/SystemTracing.h (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/SystemTracing.h 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WTF/wtf/SystemTracing.h 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -43,37 +43,48 @@
</span><span class="cx"> JavaScriptRange = 2500,
</span><span class="cx"> VMEntryScopeStart,
</span><span class="cx"> VMEntryScopeEnd,
</span><ins>+ WebAssemblyCompileStart,
+ WebAssemblyCompileEnd,
+ WebAssemblyExecuteStart,
+ WebAssemblyExecuteEnd,
</ins><span class="cx">
</span><span class="cx"> WebCoreRange = 5000,
</span><ins>+ MainResourceLoadDidStartProvisional,
+ MainResourceLoadDidEnd,
+ SubresourceLoadWillStart,
+ SubresourceLoadDidEnd,
+ FetchCookiesStart,
+ FetchCookiesEnd,
</ins><span class="cx"> StyleRecalcStart,
</span><span class="cx"> StyleRecalcEnd,
</span><ins>+ RenderTreeBuildStart,
+ RenderTreeBuildEnd,
</ins><span class="cx"> LayoutStart,
</span><span class="cx"> LayoutEnd,
</span><del>- PaintViewStart,
- PaintViewEnd,
</del><span class="cx"> PaintLayerStart,
</span><span class="cx"> PaintLayerEnd,
</span><del>- RAFDisplayLinkScheduled,
- RAFDisplayLinkFired,
</del><ins>+ AsyncImageDecodeStart,
+ AsyncImageDecodeEnd,
</ins><span class="cx"> RAFCallbackStart,
</span><span class="cx"> RAFCallbackEnd,
</span><span class="cx">
</span><span class="cx"> WebKitRange = 10000,
</span><ins>+ WebHTMLViewPaintStart,
+ WebHTMLViewPaintEnd,
+
</ins><span class="cx"> WebKit2Range = 12000,
</span><ins>+ BackingStoreFlushStart,
+ BackingStoreFlushEnd,
+ BuildTransactionStart,
+ BuildTransactionEnd,
+ SyncMessageStart,
+ SyncMessageEnd,
+ SyncTouchEventStart,
+ SyncTouchEventEnd,
</ins><span class="cx">
</span><del>- RAFDidUpdateStart,
- RAFDidUpdateEnd,
- RAFBackingStoreFlushStart,
- RAFBackingStoreFlushEnd,
- RAFBuildTransactionStart,
- RAFBuildTransactionEnd,
-
</del><span class="cx"> UIProcessRange = 14000,
</span><del>-
- RAFCommitLayerTreeStart,
- RAFCommitLayerTreeEnd,
- RAFDidRefreshDisplayStart,
- RAFDidRefreshDisplayEnd,
</del><ins>+ CommitLayerTreeStart,
+ CommitLayerTreeEnd,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #ifdef __cplusplus
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,5 +1,37 @@
</span><span class="cx"> 2017-03-16 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * loader/CookieJar.cpp:
+ (WebCore::cookies):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::provisionalLoadStarted):
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::willSendRequestInternal):
+ (WebCore::logResourceLoaded):
+ (WebCore::SubresourceLoader::didFinishLoading):
+ (WebCore::SubresourceLoader::didFail):
+ (WebCore::SubresourceLoader::didCancel):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+ * platform/graphics/ImageFrameCache.cpp:
+ (WebCore::ImageFrameCache::startAsyncDecodingQueue):
+ * platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
+ (WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
+ (WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
+ * style/RenderTreeUpdater.cpp:
+ (WebCore::RenderTreeUpdater::commit):
+
+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> RenderView::documentBeingDestroyed() needs a new name.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=166727
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderCookieJarcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/CookieJar.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/CookieJar.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/loader/CookieJar.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "NetworkingContext.h"
</span><span class="cx"> #include "PlatformCookieJar.h"
</span><span class="cx"> #include "PlatformStrategies.h"
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -55,6 +56,8 @@
</span><span class="cx">
</span><span class="cx"> String cookies(const Document& document, const URL& url)
</span><span class="cx"> {
</span><ins>+ TraceScope scope(FetchCookiesStart, FetchCookiesEnd);
+
</ins><span class="cx"> return platformStrategies()->cookiesStrategy()->cookiesForDOM(storageSession(document), document.firstPartyForCookies(), url);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -122,6 +122,7 @@
</span><span class="cx"> #include <wtf/CurrentTime.h>
</span><span class="cx"> #include <wtf/Ref.h>
</span><span class="cx"> #include <wtf/StdLibExtras.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="lines">@@ -991,6 +992,8 @@
</span><span class="cx"> m_client.provisionalLoadStarted();
</span><span class="cx">
</span><span class="cx"> if (m_frame.isMainFrame()) {
</span><ins>+ TracePoint(MainResourceLoadDidStartProvisional);
+
</ins><span class="cx"> if (auto* page = m_frame.page())
</span><span class="cx"> page->didStartProvisionalLoad();
</span><span class="cx"> }
</span><span class="lines">@@ -2322,8 +2325,10 @@
</span><span class="cx"> m_progressTracker->progressCompleted();
</span><span class="cx"> Page* page = m_frame.page();
</span><span class="cx"> if (page) {
</span><del>- if (m_frame.isMainFrame())
</del><ins>+ if (m_frame.isMainFrame()) {
+ TracePoint(MainResourceLoadDidEnd);
</ins><span class="cx"> page->didFinishLoad();
</span><ins>+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const ResourceError& error = dl->mainDocumentError();
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderSubresourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -48,6 +48,7 @@
</span><span class="cx"> #include <wtf/Ref.h>
</span><span class="cx"> #include <wtf/RefCountedLeakCounter.h>
</span><span class="cx"> #include <wtf/StdLibExtras.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="lines">@@ -176,8 +177,10 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (newRequest.requester() != ResourceRequestBase::Requester::Main)
</del><ins>+ if (newRequest.requester() != ResourceRequestBase::Requester::Main) {
+ TracePoint(SubresourceLoadWillStart);
</ins><span class="cx"> ResourceLoadObserver::sharedObserver().logSubresourceLoading(m_frame.get(), newRequest, redirectResponse);
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> ASSERT(!newRequest.isNull());
</span><span class="cx"> if (!redirectResponse.isNull()) {
</span><span class="lines">@@ -462,6 +465,7 @@
</span><span class="cx"> resourceType = DiagnosticLoggingKeys::otherKey();
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> frame->page()->diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::resourceLoadedKey(), resourceType, ShouldSample::Yes);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -552,15 +556,20 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ if (m_resource->type() != CachedResource::MainResource)
+ TracePoint(SubresourceLoadDidEnd);
+
</ins><span class="cx"> m_state = Finishing;
</span><span class="cx"> m_resource->finishLoading(resourceData());
</span><span class="cx">
</span><span class="cx"> if (wasCancelled())
</span><span class="cx"> return;
</span><ins>+
</ins><span class="cx"> m_resource->finish();
</span><span class="cx"> ASSERT(!reachedTerminalState());
</span><span class="cx"> didFinishLoadingOnePart(networkLoadMetrics);
</span><span class="cx"> notifyDone();
</span><ins>+
</ins><span class="cx"> if (reachedTerminalState())
</span><span class="cx"> return;
</span><span class="cx"> releaseResources();
</span><span class="lines">@@ -581,6 +590,10 @@
</span><span class="cx"> Ref<SubresourceLoader> protectedThis(*this);
</span><span class="cx"> CachedResourceHandle<CachedResource> protectResource(m_resource);
</span><span class="cx"> m_state = Finishing;
</span><ins>+
+ if (m_resource->type() != CachedResource::MainResource)
+ TracePoint(SubresourceLoadDidEnd);
+
</ins><span class="cx"> if (m_resource->resourceToRevalidate())
</span><span class="cx"> MemoryCache::singleton().revalidationFailed(*m_resource);
</span><span class="cx"> m_resource->setResourceError(error);
</span><span class="lines">@@ -626,6 +639,9 @@
</span><span class="cx"> if (m_state == Uninitialized)
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ if (m_resource->type() != CachedResource::MainResource)
+ TracePoint(SubresourceLoadDidEnd);
+
</ins><span class="cx"> m_resource->cancelLoad();
</span><span class="cx"> notifyDone();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -4430,8 +4430,6 @@
</span><span class="cx"> if (m_layoutPhase == InViewSizeAdjust)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- TraceScope tracingScope(PaintViewStart, PaintViewEnd);
-
</del><span class="cx"> ASSERT(m_layoutPhase == InPostLayerPositionsUpdatedAfterLayout || m_layoutPhase == OutsideLayout);
</span><span class="cx">
</span><span class="cx"> RenderView* renderView = this->renderView();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsImageFrameCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #include "Image.h"
</span><span class="cx"> #include "ImageObserver.h"
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> #if USE(CG)
</span><span class="cx"> #include "ImageDecoderCG.h"
</span><span class="lines">@@ -294,6 +295,8 @@
</span><span class="cx"> ImageFrameRequest frameRequest;
</span><span class="cx">
</span><span class="cx"> while (m_frameRequestQueue.dequeue(frameRequest)) {
</span><ins>+ TraceScope tracingScope(AsyncImageDecodeStart, AsyncImageDecodeEnd);
+
</ins><span class="cx"> // Get the frame NativeImage on the decoding thread.
</span><span class="cx"> NativeImagePtr nativeImage = protectedDecoder->createFrameImageAtIndex(frameRequest.index, frameRequest.subsamplingLevel, frameRequest.sizeForDrawing);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsiosDisplayRefreshMonitorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -32,7 +32,6 @@
</span><span class="cx"> #import <QuartzCore/QuartzCore.h>
</span><span class="cx"> #import <wtf/CurrentTime.h>
</span><span class="cx"> #import <wtf/MainThread.h>
</span><del>-#import <wtf/SystemTracing.h>
</del><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -100,8 +99,6 @@
</span><span class="cx"> if (!isActive())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- TracePoint(RAFDisplayLinkScheduled);
-
</del><span class="cx"> if (!m_handler) {
</span><span class="cx"> m_handler = adoptNS([[WebDisplayLinkHandler alloc] initWithMonitor:this]);
</span><span class="cx"> setIsActive(true);
</span><span class="lines">@@ -118,8 +115,6 @@
</span><span class="cx">
</span><span class="cx"> setIsPreviousFrameDone(false);
</span><span class="cx"> handleDisplayRefreshedNotificationOnMainThread(this);
</span><del>-
- TracePoint(RAFDisplayLinkFired);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorestyleRenderTreeUpdatercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/RenderTreeUpdater.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> #include "RenderNamedFlowThread.h"
</span><span class="cx"> #include "StyleResolver.h"
</span><span class="cx"> #include "StyleTreeResolver.h"
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> #include "WKContentObservation.h"
</span><span class="lines">@@ -112,6 +113,8 @@
</span><span class="cx">
</span><span class="cx"> if (!m_document.shouldCreateRenderers() || !m_document.renderView())
</span><span class="cx"> return;
</span><ins>+
+ TraceScope scope(RenderTreeBuildStart, RenderTreeBuildEnd);
</ins><span class="cx">
</span><span class="cx"> Style::PostResolutionCallbackDisabler callbackDisabler(m_document);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView drawRect:]):
+
</ins><span class="cx"> 2017-03-16 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Wrap legacy WebRTC API in runtime flag
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -138,6 +138,7 @@
</span><span class="cx"> #import <wtf/MathExtras.h>
</span><span class="cx"> #import <wtf/ObjcRuntimeExtras.h>
</span><span class="cx"> #import <wtf/RunLoop.h>
</span><ins>+#import <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> #import "WebNSEventExtras.h"
</span><span class="lines">@@ -4194,6 +4195,8 @@
</span><span class="cx"> - (void)drawRect:(NSRect)rect
</span><span class="cx"> {
</span><span class="cx"> LOG(View, "%@ drawing", self);
</span><ins>+
+ TraceScope scope(WebHTMLViewPaintStart, WebHTMLViewPaintEnd);
</ins><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> const NSRect *rects;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * UIProcess/ChildProcessProxy.h:
+ (WebKit::ChildProcessProxy::sendSync):
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::handleTouchEventSynchronously):
+ * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
+ * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
+ (WebKit::RemoteLayerTreeContext::buildTransaction):
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+ (WebKit::RemoteLayerTreeDrawingArea::didUpdate):
+ (WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
+
</ins><span class="cx"> 2017-03-16 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Wrap legacy WebRTC API in runtime flag
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessChildProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "MessageReceiverMap.h"
</span><span class="cx"> #include "ProcessLauncher.h"
</span><span class="cx">
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> #include <wtf/ThreadSafeRefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="lines">@@ -117,6 +118,8 @@
</span><span class="cx"> if (!m_connection)
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ TraceScope scope(SyncMessageStart, SyncMessageEnd);
+
</ins><span class="cx"> return connection()->sendSync(std::forward<U>(message), WTFMove(reply), destinationID, timeout, sendSyncOptions);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -133,6 +133,7 @@
</span><span class="cx"> #include <WebCore/WindowFeatures.h>
</span><span class="cx"> #include <stdio.h>
</span><span class="cx"> #include <wtf/NeverDestroyed.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> #include <wtf/text/StringBuilder.h>
</span><span class="cx"> #include <wtf/text/StringView.h>
</span><span class="cx">
</span><span class="lines">@@ -2179,6 +2180,8 @@
</span><span class="cx"> if (!isValid())
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ TraceScope scope(SyncTouchEventStart, SyncTouchEventEnd);
+
</ins><span class="cx"> if (event.type() == WebEvent::TouchStart)
</span><span class="cx"> updateTouchEventTracking(event);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -177,7 +177,7 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeDrawingAreaProxy::commitLayerTree(const RemoteLayerTreeTransaction& layerTreeTransaction, const RemoteScrollingCoordinatorTransaction& scrollingTreeTransaction)
</span><span class="cx"> {
</span><del>- TraceScope tracingScope(RAFCommitLayerTreeStart, RAFCommitLayerTreeEnd);
</del><ins>+ TraceScope tracingScope(CommitLayerTreeStart, CommitLayerTreeEnd);
</ins><span class="cx">
</span><span class="cx"> LOG(RemoteLayerTree, "%s", layerTreeTransaction.description().data());
</span><span class="cx"> LOG(RemoteLayerTree, "%s", scrollingTreeTransaction.description().data());
</span><span class="lines">@@ -410,8 +410,6 @@
</span><span class="cx">
</span><span class="cx"> m_didUpdateMessageState = DoesNotNeedDidUpdate;
</span><span class="cx">
</span><del>- TraceScope tracingScope(RAFDidRefreshDisplayStart, RAFDidRefreshDisplayEnd);
-
</del><span class="cx"> // Waiting for CA to commit is insufficient, because the render server can still be
</span><span class="cx"> // using our backing store. We can improve this by waiting for the render server to commit
</span><span class="cx"> // if we find API to do so, but for now we will make extra buffers if need be.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeContextmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeContext::buildTransaction(RemoteLayerTreeTransaction& transaction, PlatformCALayer& rootLayer)
</span><span class="cx"> {
</span><del>- TraceScope tracingScope(RAFBuildTransactionStart, RAFBuildTransactionEnd);
</del><ins>+ TraceScope tracingScope(BuildTransactionStart, BuildTransactionEnd);
</ins><span class="cx">
</span><span class="cx"> PlatformCALayerRemote& rootLayerRemote = downcast<PlatformCALayerRemote>(rootLayer);
</span><span class="cx"> transaction.setRootLayerID(rootLayerRemote.layerID());
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -437,8 +437,6 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeDrawingArea::didUpdate()
</span><span class="cx"> {
</span><del>- TraceScope tracingScope(RAFDidUpdateStart, RAFDidUpdateEnd);
-
</del><span class="cx"> // FIXME: This should use a counted replacement for setLayerTreeStateIsFrozen, but
</span><span class="cx"> // the callers of that function are not strictly paired.
</span><span class="cx">
</span><span class="lines">@@ -488,7 +486,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_hasFlushed);
</span><span class="cx">
</span><del>- TraceScope tracingScope(RAFBackingStoreFlushStart, RAFBackingStoreFlushEnd);
</del><ins>+ TraceScope tracingScope(BackingStoreFlushStart, BackingStoreFlushEnd);
</ins><span class="cx">
</span><span class="cx"> for (auto& context : m_contextsToFlush)
</span><span class="cx"> CGContextFlush(context.get());
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Tools/ChangeLog 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Improve the system tracing points
+ https://bugs.webkit.org/show_bug.cgi?id=169790
+
+ Reviewed by Zalan Bujtas.
+
+ Use a more cohesive set of system trace points that give a good overview of what
+ WebKit is doing. Added points for resource loading, render tree building, sync messages
+ to the web process, async image decode, WASM and fetching cookies.
+
+ * Tracing/SystemTracePoints.plist:
+
</ins><span class="cx"> 2017-03-16 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Wrap legacy WebRTC API in runtime flag
</span></span></pre></div>
<a id="trunkToolsTracingSystemTracePointsplist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Tracing/SystemTracePoints.plist (214083 => 214084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Tracing/SystemTracePoints.plist 2017-03-17 00:23:45 UTC (rev 214083)
+++ trunk/Tools/Tracing/SystemTracePoints.plist 2017-03-17 00:47:16 UTC (rev 214084)
</span><span class="lines">@@ -21,12 +21,36 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>Document::recalcStyle()</string>
</del><ins>+ <string>Compile WebAssembly</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="cx"> <string>47</string>
</span><span class="cx"> <key>CodeBegin</key>
</span><ins>+ <string>2503</string>
+ <key>CodeEnd</key>
+ <string>2504</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>Execute WebAssembly</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>2505</string>
+ <key>CodeEnd</key>
+ <string>2506</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>Main Resource Load</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
</ins><span class="cx"> <string>5001</string>
</span><span class="cx"> <key>CodeEnd</key>
</span><span class="cx"> <string>5002</string>
</span><span class="lines">@@ -33,7 +57,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>FrameView::layout()</string>
</del><ins>+ <string>Subresource Load</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -45,7 +69,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>FrameView::paintContents()</string>
</del><ins>+ <string>Fetch Cookies</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -57,7 +81,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>GraphicsLayerCA::paintLayerContents()</string>
</del><ins>+ <string>Style recalc</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -69,7 +93,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>DisplayRefreshMonitor</string>
</del><ins>+ <string>Build render tree</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -81,7 +105,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>ScriptedAnimationController::serviceScriptedAnimations()</string>
</del><ins>+ <string>Layout</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -93,12 +117,60 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>RemoteLayerTreeDrawingArea::didUpdate()</string>
</del><ins>+ <string>Paint layer</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="cx"> <string>47</string>
</span><span class="cx"> <key>CodeBegin</key>
</span><ins>+ <string>5013</string>
+ <key>CodeEnd</key>
+ <string>5014</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>Async Image Decode</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>5015</string>
+ <key>CodeEnd</key>
+ <string>5016</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>requestAnimationFrame</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>5017</string>
+ <key>CodeEnd</key>
+ <string>5018</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>Paint WebHTMLView</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>10001</string>
+ <key>CodeEnd</key>
+ <string>10002</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>Flush backing store drawing</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
</ins><span class="cx"> <string>12001</string>
</span><span class="cx"> <key>CodeEnd</key>
</span><span class="cx"> <string>12002</string>
</span><span class="lines">@@ -105,7 +177,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush()</string>
</del><ins>+ <string>Build RemoteLayerTree transaction</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -117,7 +189,7 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>RemoteLayerTreeContext::buildTransaction()</string>
</del><ins>+ <string>Sync message</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="lines">@@ -129,27 +201,27 @@
</span><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>RemoteLayerTreeDrawingAreaProxy::commitLayerTree()</string>
</del><ins>+ <string>Sync touch event</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="cx"> <string>47</string>
</span><span class="cx"> <key>CodeBegin</key>
</span><del>- <string>14001</string>
</del><ins>+ <string>12007</string>
</ins><span class="cx"> <key>CodeEnd</key>
</span><del>- <string>14002</string>
</del><ins>+ <string>12008</string>
</ins><span class="cx"> </dict>
</span><span class="cx"> <dict>
</span><span class="cx"> <key>Name</key>
</span><del>- <string>RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay()</string>
</del><ins>+ <string>Commit RemoteLayerTree transaction</string>
</ins><span class="cx"> <key>Type</key>
</span><span class="cx"> <string>Interval</string>
</span><span class="cx"> <key>Component</key>
</span><span class="cx"> <string>47</string>
</span><span class="cx"> <key>CodeBegin</key>
</span><del>- <string>14003</string>
</del><ins>+ <string>14001</string>
</ins><span class="cx"> <key>CodeEnd</key>
</span><del>- <string>14004</string>
</del><ins>+ <string>14002</string>
</ins><span class="cx"> </dict>
</span><span class="cx"> </array>
</span><span class="cx"> </dict>
</span></span></pre>
</div>
</div>
</body>
</html>