<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[214034] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214034">214034</a></dd>
<dt>Author</dt> <dd>tpopela@redhat.com</dd>
<dt>Date</dt> <dd>2017-03-16 01:40:29 -0700 (Thu, 16 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix uninitialized public members in Webkit2/UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=169602
Reviewed by Michael Catanzaro.
Found by Coverity scan.
* UIProcess/API/gtk/WebKitMimeInfo.cpp:
* UIProcess/API/gtk/WebKitSettings.cpp:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitMimeInfocpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitMimeInfo.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitSettingscpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitWebViewBasecpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (214033 => 214034)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-16 07:51:41 UTC (rev 214033)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-16 08:40:29 UTC (rev 214034)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-16 Tomas Popela <tpopela@redhat.com>
+
+ Fix uninitialized public members in Webkit2/UIProcess/API/gtk
+ https://bugs.webkit.org/show_bug.cgi?id=169602
+
+ Reviewed by Michael Catanzaro.
+
+ Found by Coverity scan.
+
+ * UIProcess/API/gtk/WebKitMimeInfo.cpp:
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+
</ins><span class="cx"> 2017-03-16 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed follow-up to r213787. Move the DatabaseProcess build targets
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitMimeInfocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitMimeInfo.cpp (214033 => 214034)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitMimeInfo.cpp 2017-03-16 07:51:41 UTC (rev 214033)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitMimeInfo.cpp 2017-03-16 08:40:29 UTC (rev 214034)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> CString description;
</span><span class="cx"> GRefPtr<GPtrArray> extensions;
</span><span class="cx">
</span><del>- int referenceCount;
</del><ins>+ int referenceCount { 0 };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> G_DEFINE_BOXED_TYPE(WebKitMimeInfo, webkit_mime_info, webkit_mime_info_ref, webkit_mime_info_unref)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (214033 => 214034)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2017-03-16 07:51:41 UTC (rev 214033)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2017-03-16 08:40:29 UTC (rev 214034)
</span><span class="lines">@@ -71,8 +71,8 @@
</span><span class="cx"> CString pictographFontFamily;
</span><span class="cx"> CString defaultCharset;
</span><span class="cx"> CString userAgent;
</span><del>- bool allowModalDialogs;
- bool zoomTextOnly;
</del><ins>+ bool allowModalDialogs { false };
+ bool zoomTextOnly { false };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitWebViewBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (214033 => 214034)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-03-16 07:51:41 UTC (rev 214033)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-03-16 08:40:29 UTC (rev 214034)
</span><span class="lines">@@ -161,42 +161,42 @@
</span><span class="cx"> WebKitWebViewChildrenMap children;
</span><span class="cx"> std::unique_ptr<PageClientImpl> pageClient;
</span><span class="cx"> RefPtr<WebPageProxy> pageProxy;
</span><del>- bool shouldForwardNextKeyEvent;
- bool shouldForwardNextWheelEvent;
</del><ins>+ bool shouldForwardNextKeyEvent { false };
+ bool shouldForwardNextWheelEvent { false };
</ins><span class="cx"> ClickCounter clickCounter;
</span><span class="cx"> CString tooltipText;
</span><span class="cx"> IntRect tooltipArea;
</span><span class="cx"> GRefPtr<AtkObject> accessible;
</span><del>- GtkWidget* authenticationDialog;
- GtkWidget* inspectorView;
- AttachmentSide inspectorAttachmentSide;
- unsigned inspectorViewSize;
</del><ins>+ GtkWidget* authenticationDialog { nullptr };
+ GtkWidget* inspectorView { nullptr };
+ AttachmentSide inspectorAttachmentSide { AttachmentSide::Bottom };
+ unsigned inspectorViewSize { 0 };
</ins><span class="cx"> GUniquePtr<GdkEvent> contextMenuEvent;
</span><del>- WebContextMenuProxyGtk* activeContextMenuProxy;
</del><ins>+ WebContextMenuProxyGtk* activeContextMenuProxy { nullptr };
</ins><span class="cx"> InputMethodFilter inputMethodFilter;
</span><span class="cx"> KeyBindingTranslator keyBindingTranslator;
</span><span class="cx"> TouchEventsMap touchEvents;
</span><span class="cx"> IntSize contentsSize;
</span><span class="cx">
</span><del>- GtkWindow* toplevelOnScreenWindow;
- unsigned long toplevelFocusInEventID;
- unsigned long toplevelFocusOutEventID;
- unsigned long toplevelWindowStateEventID;
- unsigned long toplevelWindowRealizedID;
</del><ins>+ GtkWindow* toplevelOnScreenWindow { nullptr };
+ unsigned long toplevelFocusInEventID { 0 };
+ unsigned long toplevelFocusOutEventID { 0 };
+ unsigned long toplevelWindowStateEventID { 0 };
+ unsigned long toplevelWindowRealizedID { 0 };
</ins><span class="cx">
</span><span class="cx"> // View State.
</span><del>- ActivityState::Flags activityState;
- ActivityState::Flags activityStateFlagsToUpdate;
</del><ins>+ ActivityState::Flags activityState { 0 };
+ ActivityState::Flags activityStateFlagsToUpdate { 0 };
</ins><span class="cx"> RunLoop::Timer<WebKitWebViewBasePrivate> updateActivityStateTimer;
</span><span class="cx">
</span><del>- WebKitWebViewBaseDownloadRequestHandler downloadHandler;
</del><ins>+ WebKitWebViewBaseDownloadRequestHandler downloadHandler { 0 };
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><del>- bool fullScreenModeActive;
</del><ins>+ bool fullScreenModeActive { false };
</ins><span class="cx"> WebFullScreenClientGtk fullScreenClient;
</span><span class="cx"> GRefPtr<GDBusProxy> screenSaverProxy;
</span><span class="cx"> GRefPtr<GCancellable> screenSaverInhibitCancellable;
</span><del>- unsigned screenSaverCookie;
</del><ins>+ unsigned screenSaverCookie { 0 };
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<AcceleratedBackingStore> acceleratedBackingStore;
</span></span></pre>
</div>
</div>
</body>
</html>