<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[214045] trunk/Source</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/214045">214045</a></dd>

<dt>Author</dt> <dd>jonlee@apple.com</dd>

<dt>Date</dt> <dd>2017-03-16 09:49:13 -0700 (Thu, 16 Mar 2017)</dd>

</dl>

<h3>Log Message</h3>

<pre>Add FIXMEs to update WebRTC

https://bugs.webkit.org/show_bug.cgi?id=169735

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

* runtime/CommonIdentifiers.h: Add RTCIceTransport.

Source/WebCore:

Rearrange order of methods and properties based on the 13 March 2017

version of the WebRTC spec.

* CMakeLists.txt: Add RTCIceTransport and RTCIceTransportState.

* DerivedSources.make:

* Modules/mediastream/RTCDTMFSender.idl:

* Modules/mediastream/RTCDTMFToneChangeEvent.idl:

* Modules/mediastream/RTCDataChannelEvent.idl:

* Modules/mediastream/RTCIceCandidate.idl:

* Modules/mediastream/RTCIceCandidateEvent.idl:

* Modules/mediastream/RTCIceServer.idl:

* Modules/mediastream/RTCIceTransport.cpp: Added.

* Modules/mediastream/RTCIceTransport.idl: Added.

* Modules/mediastream/RTCIceTransport.h: Minor update to rename state to transportState.

(WebCore::RTCIceTransport::state):

(WebCore::RTCIceTransport::setState):

(WebCore::RTCIceTransport::transportState): Deleted.

(WebCore::RTCIceTransport::setTransportState): Deleted.

* Modules/mediastream/RTCIceTransportState.h: Added.

* Modules/mediastream/RTCIceTransportState.idl: Added.

* Modules/mediastream/RTCPeerConnection.h:

* Modules/mediastream/RTCPeerConnection.idl:

* Modules/mediastream/RTCRtpReceiver.idl:

* Modules/mediastream/RTCRtpSender.idl:

* Modules/mediastream/RTCRtpTransceiver.idl:

* Modules/mediastream/RTCStatsReport.idl:

* WebCore.xcodeproj/project.pbxproj:

* Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Refactor.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>

<li><a href="#trunkSourceJavaScriptCoreruntimeCommonIdentifiersh">trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h</a></li>

<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreDerivedSourcesmake">trunk/Source/WebCore/DerivedSources.make</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamMediaEndpointPeerConnectioncpp">trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFSenderidl">trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventidl">trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDataChannelEventidl">trunk/Source/WebCore/Modules/mediastream/RTCDataChannelEvent.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceCandidateidl">trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceCandidateEventidl">trunk/Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceServeridl">trunk/Source/WebCore/Modules/mediastream/RTCIceServer.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransporth">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectionh">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectionidl">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCRtpReceiveridl">trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCRtpSenderidl">trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCRtpTransceiveridl">trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCStatsReportidl">trunk/Source/WebCore/Modules/mediastream/RTCStatsReport.idl</a></li>

<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportcpp">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportidl">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportStateh">trunk/Source/WebCore/Modules/mediastream/RTCIceTransportState.h</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportStateidl">trunk/Source/WebCore/Modules/mediastream/RTCIceTransportState.idl</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceJavaScriptCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/JavaScriptCore/ChangeLog        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -1,3 +1,12 @@

</span><ins>+2017-03-16  Jon Lee  &lt;jonlee@apple.com&gt;

+

+        Add FIXMEs to update WebRTC

+        https://bugs.webkit.org/show_bug.cgi?id=169735

+

+        Reviewed by Youenn Fablet.

+

+        * runtime/CommonIdentifiers.h: Add RTCIceTransport.

+

</ins><span class="cx"> 2017-03-16  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Unreviewed, copy m_numberOfArgumentsToSkip

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreruntimeCommonIdentifiersh"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -104,6 +104,7 @@

</span><span class="cx">     macro(Request) \

</span><span class="cx">     macro(RTCDTMFToneChangeEvent) \

</span><span class="cx">     macro(RTCIceCandidate) \

</span><ins>+    macro(RTCIceTransport) \

</ins><span class="cx">     macro(RTCPeerConnection) \

</span><span class="cx">     macro(RTCRtpReceiver) \

</span><span class="cx">     macro(RTCRtpSender) \

</span></span></pre></div>

<a id="trunkSourceWebCoreCMakeListstxt"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/CMakeLists.txt        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/WebCore/CMakeLists.txt        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -244,6 +244,8 @@

</span><span class="cx">     Modules/mediastream/RTCIceConnectionState.idl

</span><span class="cx">     Modules/mediastream/RTCIceGatheringState.idl

</span><span class="cx">     Modules/mediastream/RTCIceServer.idl

</span><ins>+    Modules/mediastream/RTCIceTransport.idl

+    Modules/mediastream/RTCIceTransportState.idl

</ins><span class="cx">     Modules/mediastream/RTCOfferAnswerOptions.idl

</span><span class="cx">     Modules/mediastream/RTCOfferOptions.idl

</span><span class="cx">     Modules/mediastream/RTCPeerConnection.idl

</span></span></pre></div>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/WebCore/ChangeLog        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -1,3 +1,40 @@

</span><ins>+2017-03-16  Jon Lee  &lt;jonlee@apple.com&gt;

+

+        Add FIXMEs to update WebRTC

+        https://bugs.webkit.org/show_bug.cgi?id=169735

+

+        Reviewed by Youenn Fablet.

+

+        Rearrange order of methods and properties based on the 13 March 2017

+        version of the WebRTC spec.

+

+        * CMakeLists.txt: Add RTCIceTransport and RTCIceTransportState.

+        * DerivedSources.make:

+        * Modules/mediastream/RTCDTMFSender.idl:

+        * Modules/mediastream/RTCDTMFToneChangeEvent.idl:

+        * Modules/mediastream/RTCDataChannelEvent.idl:

+        * Modules/mediastream/RTCIceCandidate.idl:

+        * Modules/mediastream/RTCIceCandidateEvent.idl:

+        * Modules/mediastream/RTCIceServer.idl:

+        * Modules/mediastream/RTCIceTransport.cpp: Added.

+        * Modules/mediastream/RTCIceTransport.idl: Added.

+        * Modules/mediastream/RTCIceTransport.h: Minor update to rename state to transportState.

+        (WebCore::RTCIceTransport::state):

+        (WebCore::RTCIceTransport::setState):

+        (WebCore::RTCIceTransport::transportState): Deleted.

+        (WebCore::RTCIceTransport::setTransportState): Deleted.

+        * Modules/mediastream/RTCIceTransportState.h: Added.

+        * Modules/mediastream/RTCIceTransportState.idl: Added.

+        * Modules/mediastream/RTCPeerConnection.h:

+        * Modules/mediastream/RTCPeerConnection.idl:

+        * Modules/mediastream/RTCRtpReceiver.idl:

+        * Modules/mediastream/RTCRtpSender.idl:

+        * Modules/mediastream/RTCRtpTransceiver.idl:

+        * Modules/mediastream/RTCStatsReport.idl:

+        * WebCore.xcodeproj/project.pbxproj:

+        * Modules/mediastream/MediaEndpointPeerConnection.cpp:

+        (WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Refactor.

+

</ins><span class="cx"> 2017-03-16  Youenn Fablet  &lt;youenn@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Improve WebRTC track enabled support

</span></span></pre></div>

<a id="trunkSourceWebCoreDerivedSourcesmake"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/DerivedSources.make (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/DerivedSources.make        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/WebCore/DerivedSources.make        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -188,6 +188,8 @@

</span><span class="cx">     $(WebCore)/Modules/mediastream/RTCIceConnectionState.idl \

</span><span class="cx">     $(WebCore)/Modules/mediastream/RTCIceGatheringState.idl \

</span><span class="cx">     $(WebCore)/Modules/mediastream/RTCIceServer.idl \

</span><ins>+    $(WebCore)/Modules/mediastream/RTCIceTransport.idl \

+    $(WebCore)/Modules/mediastream/RTCIceTransportState.idl \

</ins><span class="cx">     $(WebCore)/Modules/mediastream/RTCOfferAnswerOptions.idl \

</span><span class="cx">     $(WebCore)/Modules/mediastream/RTCOfferOptions.idl \

</span><span class="cx">     $(WebCore)/Modules/mediastream/RTCPeerConnection.idl \

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamMediaEndpointPeerConnectioncpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -873,12 +873,12 @@

</span><span class="cx">     ASSERT(transceiver);

</span><span class="cx"> 

</span><span class="cx">     RTCIceTransportState transportState = static_cast&lt;RTCIceTransportState&gt;(mediaEndpointIceTransportState);

</span><del>-    transceiver-&gt;iceTransport().setTransportState(transportState);

</del><ins>+    transceiver-&gt;iceTransport().setState(transportState);

</ins><span class="cx"> 

<span class="cx">     // Determine if the script needs to be notified.

</span><span class="cx">     Vector&lt;RTCIceTransportState&gt; transportStates;

</span><span class="cx">     for (auto&amp; transceiver : m_peerConnection.getTransceivers())

</span><del>-        transportStates.append(transceiver-&gt;iceTransport().transportState());

</del><ins>+        transportStates.append(transceiver-&gt;iceTransport().state());

</ins><span class="cx"> 

</span><span class="cx">     RTCIceTransportState derivedState = deriveAggregatedIceConnectionState(transportStates);

</span><span class="cx">     m_peerConnection.updateIceConnectionState(static_cast&lt;RTCIceConnectionState&gt;(derivedState));

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamRTCDTMFSenderidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl (214044 => 214045)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl        2017-03-16 16:09:50 UTC (rev 214044)

+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl        2017-03-16 16:49:13 UTC (rev 214045)

</span><span class="lines">@@ -1,5 +1,6 @@

</span><span class="cx"> /*

<span class="cx">  * Copyright (C) 2013 Google Inc. All rights reserved.