<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213927] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213927">213927</a></dd>
<dt>Author</dt> <dd>ryanhaddad@apple.com</dd>
<dt>Date</dt> <dd>2017-03-14 12:16:43 -0700 (Tue, 14 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/213915">r213915</a>.
Caused WK2 LayoutTests to exit early with timeouts.
Reverted changeset:
"Fix uninitialized public members in NetworkProcess"
https://bugs.webkit.org/show_bug.cgi?id=169598
http://trac.webkit.org/changeset/213915</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcessCreationParametersh">trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscacheNetworkCacheStoragecpp">trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolcpp">trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcesssoupWebProcessPoolSoupcpp">trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-14 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r213915.
+
+ Caused WK2 LayoutTests to exit early with timeouts.
+
+ Reverted changeset:
+
+ "Fix uninitialized public members in NetworkProcess"
+ https://bugs.webkit.org/show_bug.cgi?id=169598
+ http://trac.webkit.org/changeset/213915
+
</ins><span class="cx"> 2017-03-14 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r213877): WebKit2.CookieManager fails.
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -97,6 +97,7 @@
</span><span class="cx"> : m_hasSetCacheModel(false)
</span><span class="cx"> , m_cacheModel(CacheModelDocumentViewer)
</span><span class="cx"> , m_diskCacheIsDisabledForTesting(false)
</span><ins>+ , m_canHandleHTTPSServerTrustEvaluation(true)
</ins><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> , m_clearCacheDispatchGroup(0)
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcessCreationParametersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -49,18 +49,18 @@
</span><span class="cx"> void encode(IPC::Encoder&) const;
</span><span class="cx"> static bool decode(IPC::Decoder&, NetworkProcessCreationParameters&);
</span><span class="cx">
</span><del>- bool privateBrowsingEnabled { false };
- CacheModel cacheModel { CacheModelDocumentViewer };
</del><ins>+ bool privateBrowsingEnabled;
+ CacheModel cacheModel;
</ins><span class="cx"> int64_t diskCacheSizeOverride { -1 };
</span><del>- bool canHandleHTTPSServerTrustEvaluation { true };
</del><ins>+ bool canHandleHTTPSServerTrustEvaluation;
</ins><span class="cx">
</span><span class="cx"> String diskCacheDirectory;
</span><span class="cx"> SandboxExtension::Handle diskCacheDirectoryExtensionHandle;
</span><span class="cx"> #if ENABLE(NETWORK_CACHE)
</span><del>- bool shouldEnableNetworkCache { false };
- bool shouldEnableNetworkCacheEfficacyLogging { false };
</del><ins>+ bool shouldEnableNetworkCache;
+ bool shouldEnableNetworkCacheEfficacyLogging;
</ins><span class="cx"> #if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
</span><del>- bool shouldEnableNetworkCacheSpeculativeRevalidation { false };
</del><ins>+ bool shouldEnableNetworkCacheSpeculativeRevalidation;
</ins><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx"> #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> SandboxExtension::Handle parentBundleDirectoryExtensionHandle;
</span><span class="cx"> #endif
</span><span class="cx"> bool shouldSuppressMemoryPressureHandler { false };
</span><del>- bool shouldUseTestingNetworkSession { false };
</del><ins>+ bool shouldUseTestingNetworkSession;
</ins><span class="cx"> std::chrono::milliseconds loadThrottleLatency { 0ms };
</span><span class="cx">
</span><span class="cx"> Vector<String> urlSchemesRegisteredForCustomProtocols;
</span><span class="lines">@@ -98,9 +98,9 @@
</span><span class="cx">
</span><span class="cx"> #if USE(SOUP)
</span><span class="cx"> String cookiePersistentStoragePath;
</span><del>- uint32_t cookiePersistentStorageType { 0 };
- HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 };
- bool ignoreTLSErrors { true };
</del><ins>+ uint32_t cookiePersistentStorageType;
+ HTTPCookieAcceptPolicy cookieAcceptPolicy;
+ bool ignoreTLSErrors;
</ins><span class="cx"> Vector<String> languages;
</span><span class="cx"> WebCore::SoupNetworkProxySettings proxySettings;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscacheNetworkCacheStoragecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -367,13 +367,13 @@
</span><span class="cx"> Key key;
</span><span class="cx"> std::chrono::system_clock::time_point timeStamp;
</span><span class="cx"> SHA1::Digest headerHash;
</span><del>- uint64_t headerSize { 0 };
</del><ins>+ uint64_t headerSize;
</ins><span class="cx"> SHA1::Digest bodyHash;
</span><del>- uint64_t bodySize { 0 };
- bool isBodyInline { false };
</del><ins>+ uint64_t bodySize;
+ bool isBodyInline;
</ins><span class="cx">
</span><span class="cx"> // Not encoded as a field. Header starts immediately after meta data.
</span><del>- uint64_t headerOffset { 0 };
</del><ins>+ uint64_t headerOffset;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> static bool decodeRecordMetaData(RecordMetaData& metaData, const Data& fileData)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -180,6 +180,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> , m_shouldUseTestingNetworkSession(false)
</span><span class="cx"> , m_processTerminationEnabled(true)
</span><ins>+ , m_canHandleHTTPSServerTrustEvaluation(true)
</ins><span class="cx"> , m_didNetworkProcessCrash(false)
</span><span class="cx"> , m_memoryCacheDisabled(false)
</span><span class="cx"> , m_alwaysRunsAtBackgroundPriority(m_configuration->alwaysRunsAtBackgroundPriority())
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesssoupWebProcessPoolSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp (213926 => 213927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 19:16:43 UTC (rev 213927)
</span><span class="lines">@@ -42,6 +42,7 @@
</span><span class="cx"> parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
</span><span class="cx"> parameters.ignoreTLSErrors = m_ignoreTLSErrors;
</span><span class="cx"> parameters.languages = WebCore::userPreferredLanguages();
</span><ins>+ parameters.shouldEnableNetworkCacheEfficacyLogging = false;
</ins><span class="cx"> parameters.proxySettings = m_networkProxySettings;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>