<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213787] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213787">213787</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2017-03-13 01:01:16 -0700 (Mon, 13 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[WK2][CMake] Remove the intermediate NetworkProcess_COMMON_SOURCES variable
https://bugs.webkit.org/show_bug.cgi?id=169524
Reviewed by Michael Catanzaro.
The NetworkProcess-specific source files listed in the
NetworkProcess_COMMON_SOURCES variable definition should be directly
inlined into the list with which the WebKit2_SOURCE variable is defined.
The NetworkProcess_COMMON_SOURCES variable is appended to the
WebKit2_SOURCES variable anyway, and is not used anywhere else. The
separate variable was previously use to support configurations that
allowed disabling NetworkProcess.
* CMakeLists.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2CMakeListstxt">trunk/Source/WebKit2/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2CMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/CMakeLists.txt (213786 => 213787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/CMakeLists.txt 2017-03-13 07:54:43 UTC (rev 213786)
+++ trunk/Source/WebKit2/CMakeLists.txt 2017-03-13 08:01:16 UTC (rev 213787)
</span><span class="lines">@@ -94,20 +94,27 @@
</span><span class="cx"> )
</span><span class="cx"> endif ()
</span><span class="cx">
</span><del>-set(NetworkProcess_COMMON_SOURCES
</del><ins>+set(WebKit2_SOURCES
</ins><span class="cx"> NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp
</span><span class="cx">
</span><ins>+ NetworkProcess/Downloads/BlobDownloadClient.cpp
+ NetworkProcess/Downloads/Download.cpp
+ NetworkProcess/Downloads/DownloadManager.cpp
+ NetworkProcess/Downloads/PendingDownload.cpp
+
+ NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
+
</ins><span class="cx"> NetworkProcess/NetworkConnectionToWebProcess.cpp
</span><span class="cx"> NetworkProcess/NetworkDataTask.cpp
</span><span class="cx"> NetworkProcess/NetworkDataTaskBlob.cpp
</span><span class="cx"> NetworkProcess/NetworkLoad.cpp
</span><span class="cx"> NetworkProcess/NetworkProcess.cpp
</span><ins>+ NetworkProcess/NetworkProcessCreationParameters.cpp
</ins><span class="cx"> NetworkProcess/NetworkProcessPlatformStrategies.cpp
</span><ins>+ NetworkProcess/NetworkResourceLoadParameters.cpp
</ins><span class="cx"> NetworkProcess/NetworkResourceLoader.cpp
</span><span class="cx"> NetworkProcess/NetworkSession.cpp
</span><span class="cx">
</span><del>- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
-
</del><span class="cx"> NetworkProcess/cache/NetworkCache.cpp
</span><span class="cx"> NetworkProcess/cache/NetworkCacheBlobStorage.cpp
</span><span class="cx"> NetworkProcess/cache/NetworkCacheCoders.cpp
</span><span class="lines">@@ -127,22 +134,12 @@
</span><span class="cx"> NetworkProcess/capture/NetworkCaptureReplayer.cpp
</span><span class="cx"> NetworkProcess/capture/NetworkCaptureResource.cpp
</span><span class="cx"> NetworkProcess/capture/NetworkDataTaskReplay.cpp
</span><del>-)
</del><span class="cx">
</span><del>-set(WebKit2_SOURCES
</del><span class="cx"> DatabaseProcess/DatabaseProcess.cpp
</span><span class="cx"> DatabaseProcess/DatabaseToWebProcessConnection.cpp
</span><span class="cx">
</span><span class="cx"> DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp
</span><span class="cx">
</span><del>- NetworkProcess/NetworkProcessCreationParameters.cpp
- NetworkProcess/NetworkResourceLoadParameters.cpp
-
- NetworkProcess/Downloads/BlobDownloadClient.cpp
- NetworkProcess/Downloads/Download.cpp
- NetworkProcess/Downloads/DownloadManager.cpp
- NetworkProcess/Downloads/PendingDownload.cpp
-
</del><span class="cx"> Platform/Logging.cpp
</span><span class="cx"> Platform/Module.cpp
</span><span class="cx">
</span><span class="lines">@@ -585,8 +582,6 @@
</span><span class="cx"> WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp
</span><span class="cx"> WebProcess/WebPage/WebURLSchemeHandlerTaskProxy.cpp
</span><span class="cx"> WebProcess/WebPage/WebUndoStep.cpp
</span><del>-
- ${NetworkProcess_COMMON_SOURCES}
</del><span class="cx"> )
</span><span class="cx">
</span><span class="cx"> set(WebKit2_MESSAGES_IN_FILES
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (213786 => 213787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-13 07:54:43 UTC (rev 213786)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-13 08:01:16 UTC (rev 213787)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-03-13 Zan Dobersek <zdobersek@igalia.com>
+
+ [WK2][CMake] Remove the intermediate NetworkProcess_COMMON_SOURCES variable
+ https://bugs.webkit.org/show_bug.cgi?id=169524
+
+ Reviewed by Michael Catanzaro.
+
+ The NetworkProcess-specific source files listed in the
+ NetworkProcess_COMMON_SOURCES variable definition should be directly
+ inlined into the list with which the WebKit2_SOURCE variable is defined.
+ The NetworkProcess_COMMON_SOURCES variable is appended to the
+ WebKit2_SOURCES variable anyway, and is not used anywhere else. The
+ separate variable was previously use to support configurations that
+ allowed disabling NetworkProcess.
+
+ * CMakeLists.txt:
+
</ins><span class="cx"> 2017-03-13 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> WebGPU remote layer hosting
</span></span></pre>
</div>
</div>
</body>
</html>