<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213885] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213885">213885</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-13 23:51:23 -0700 (Mon, 13 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused methods of ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=169579
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-13
Reviewed by Youenn Fablet.
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::reportUploadProgress): Deleted.
(WebCore::ResourceRequestBase::setReportUploadProgress): Deleted.
(WebCore::ResourceRequestBase::reportLoadTiming): Deleted.
(WebCore::ResourceRequestBase::setReportLoadTiming): Deleted.
(WebCore::ResourceRequestBase::reportRawHeaders): Deleted.
(WebCore::ResourceRequestBase::setReportRawHeaders): Deleted.
Remove unused code.
* inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::willSendRequest):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Remove callers of setters that did nothing.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorNetworkAgentcpp">trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderResourceLoadNotifiercpp">trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkResourceRequestBaseh">trunk/Source/WebCore/platform/network/ResourceRequestBase.h</a></li>
<li><a href="#trunkSourceWebCorexmlXMLHttpRequestcpp">trunk/Source/WebCore/xml/XMLHttpRequest.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213884 => 213885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-14 05:58:27 UTC (rev 213884)
+++ trunk/Source/WebCore/ChangeLog 2017-03-14 06:51:23 UTC (rev 213885)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2017-03-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Remove unused methods of ResourceRequestBase
+ https://bugs.webkit.org/show_bug.cgi?id=169579
+
+ Reviewed by Youenn Fablet.
+
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::reportUploadProgress): Deleted.
+ (WebCore::ResourceRequestBase::setReportUploadProgress): Deleted.
+ (WebCore::ResourceRequestBase::reportLoadTiming): Deleted.
+ (WebCore::ResourceRequestBase::setReportLoadTiming): Deleted.
+ (WebCore::ResourceRequestBase::reportRawHeaders): Deleted.
+ (WebCore::ResourceRequestBase::setReportRawHeaders): Deleted.
+ Remove unused code.
+
+ * inspector/InspectorNetworkAgent.cpp:
+ (WebCore::InspectorNetworkAgent::willSendRequest):
+ * loader/ResourceLoadNotifier.cpp:
+ (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::createRequest):
+ Remove callers of setters that did nothing.
+
</ins><span class="cx"> 2017-03-13 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Make RealtimeMediaSource::type an enum class
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorNetworkAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp (213884 => 213885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp 2017-03-14 05:58:27 UTC (rev 213884)
+++ trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp 2017-03-14 06:51:23 UTC (rev 213885)
</span><span class="lines">@@ -342,9 +342,6 @@
</span><span class="cx"> for (auto& entry : m_extraRequestHeaders)
</span><span class="cx"> request.setHTTPHeaderField(entry.key, entry.value);
</span><span class="cx">
</span><del>- request.setReportLoadTiming(true);
- request.setReportRawHeaders(true);
-
</del><span class="cx"> if (m_cacheDisabled) {
</span><span class="cx"> request.setHTTPHeaderField(HTTPHeaderName::Pragma, "no-cache");
</span><span class="cx"> request.setCachePolicy(ReloadIgnoringCacheData);
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderResourceLoadNotifiercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp (213884 => 213885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp 2017-03-14 05:58:27 UTC (rev 213884)
+++ trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp 2017-03-14 06:51:23 UTC (rev 213885)
</span><span class="lines">@@ -133,13 +133,6 @@
</span><span class="cx"> m_frame.loader().documentLoader()->didTellClientAboutLoad(request.url());
</span><span class="cx">
</span><span class="cx"> InspectorInstrumentation::willSendRequest(&m_frame, identifier, loader, request, redirectResponse);
</span><del>-
- if (RuntimeEnabledFeatures::sharedFeatures().resourceTimingEnabled())
- request.setReportLoadTiming(true);
- else if (loader && !request.isNull() && request.url() == loader->url()) {
- // Report WebTiming for all frames.
- request.setReportLoadTiming(true);
- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ResourceLoadNotifier::dispatchDidReceiveResponse(DocumentLoader* loader, unsigned long identifier, const ResourceResponse& r, ResourceLoader* resourceLoader)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkResourceRequestBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.h (213884 => 213885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2017-03-14 05:58:27 UTC (rev 213884)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2017-03-14 06:51:23 UTC (rev 213885)
</span><span class="lines">@@ -144,19 +144,6 @@
</span><span class="cx"> WEBCORE_EXPORT bool isConditional() const;
</span><span class="cx"> WEBCORE_EXPORT void makeUnconditional();
</span><span class="cx">
</span><del>- // Whether the associated ResourceHandleClient needs to be notified of
- // upload progress made for that resource.
- bool reportUploadProgress() const { return m_reportUploadProgress; }
- void setReportUploadProgress(bool reportUploadProgress) { m_reportUploadProgress = reportUploadProgress; }
-
- // Whether the timing information should be collected for the request.
- bool reportLoadTiming() const { return m_reportLoadTiming; }
- void setReportLoadTiming(bool reportLoadTiming) { m_reportLoadTiming = reportLoadTiming; }
-
- // Whether actual headers being sent/received should be collected and reported for the request.
- bool reportRawHeaders() const { return m_reportRawHeaders; }
- void setReportRawHeaders(bool reportRawHeaders) { m_reportRawHeaders = reportRawHeaders; }
-
</del><span class="cx"> // Whether this request should be hidden from the Inspector.
</span><span class="cx"> bool hiddenFromInspector() const { return m_hiddenFromInspector; }
</span><span class="cx"> void setHiddenFromInspector(bool hiddenFromInspector) { m_hiddenFromInspector = hiddenFromInspector; }
</span><span class="lines">@@ -234,9 +221,6 @@
</span><span class="cx"> mutable bool m_platformRequestUpdated { false };
</span><span class="cx"> mutable bool m_resourceRequestBodyUpdated { false };
</span><span class="cx"> mutable bool m_platformRequestBodyUpdated { false };
</span><del>- bool m_reportUploadProgress { false };
- bool m_reportLoadTiming { false };
- bool m_reportRawHeaders { false };
</del><span class="cx"> bool m_hiddenFromInspector { false };
</span><span class="cx"> bool m_ignoreForRequestCount { false };
</span><span class="cx"> ResourceLoadPriority m_priority { ResourceLoadPriority::Low };
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLHttpRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (213884 => 213885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-03-14 05:58:27 UTC (rev 213884)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-03-14 06:51:23 UTC (rev 213885)
</span><span class="lines">@@ -746,9 +746,6 @@
</span><span class="cx"> m_error = false;
</span><span class="cx">
</span><span class="cx"> if (m_async) {
</span><del>- if (m_upload)
- request.setReportUploadProgress(true);
-
</del><span class="cx"> // ThreadableLoader::create can return null here, for example if we're no longer attached to a page or if a content blocker blocks the load.
</span><span class="cx"> // This is true while running onunload handlers.
</span><span class="cx"> // FIXME: Maybe we need to be able to send XMLHttpRequests from onunload, <http://bugs.webkit.org/show_bug.cgi?id=10904>.
</span></span></pre>
</div>
</div>
</body>
</html>