<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213792] releases/WebKitGTK/webkit-2.16</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213792">213792</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-13 02:37:14 -0700 (Mon, 13 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/213165">r213165</a> - Use of arguments in arrow function is slow
https://bugs.webkit.org/show_bug.cgi?id=168829
Reviewed by Saam Barati.
JSTests:
* microbenchmarks/arrowfunciton-direct-arguments.js: Added.
(fn):
* microbenchmarks/arrowfunciton-reference-arguments.js: Added.
(fn):
Source/JavaScriptCore:
Current patch improves performance access to arguments within arrow functuion
by preventing create arguments variable within arrow function, also allow to cache
arguments variable. Before arguments variable always have Dynamic resolve type, after
patch it can be ClosureVar, that increase performance of access to arguments variable
in 9 times inside of the arrow function.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* runtime/JSScope.cpp:
(JSC::abstractAccess):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit216JSTestsChangeLog">releases/WebKitGTK/webkit-2.16/JSTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceJavaScriptCoreChangeLog">releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceJavaScriptCorebytecompilerBytecodeGeneratorcpp">releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit216SourceJavaScriptCoreruntimeJSScopecpp">releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/runtime/JSScope.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit216JSTestsmicrobenchmarksarrowfuncitondirectargumentsjs">releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-direct-arguments.js</a></li>
<li><a href="#releasesWebKitGTKwebkit216JSTestsmicrobenchmarksarrowfuncitonreferenceargumentsjs">releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-reference-arguments.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit216JSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/JSTests/ChangeLog (213791 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/JSTests/ChangeLog 2017-03-13 09:33:36 UTC (rev 213791)
+++ releases/WebKitGTK/webkit-2.16/JSTests/ChangeLog 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-28 Oleksandr Skachkov <gskachkov@gmail.com>
+
+ Use of arguments in arrow function is slow
+ https://bugs.webkit.org/show_bug.cgi?id=168829
+
+ Reviewed by Saam Barati.
+
+ * microbenchmarks/arrowfunciton-direct-arguments.js: Added.
+ (fn):
+ * microbenchmarks/arrowfunciton-reference-arguments.js: Added.
+ (fn):
+
</ins><span class="cx"> 2017-03-08 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [GTK] JSC test stress/arity-check-ftl-throw.js.ftl-no-cjit-validate-sampling-profiler crashing on GTK bot
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216JSTestsmicrobenchmarksarrowfuncitondirectargumentsjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-direct-arguments.js (0 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-direct-arguments.js (rev 0)
+++ releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-direct-arguments.js 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+var fn = function() {
+ return () => arguments[0];
+}(1);
+
+for (var i = 0; i < 100000; i++) {
+ if(fn(2) !== 1) throw 0;
+}
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit216JSTestsmicrobenchmarksarrowfuncitonreferenceargumentsjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-reference-arguments.js (0 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-reference-arguments.js (rev 0)
+++ releases/WebKitGTK/webkit-2.16/JSTests/microbenchmarks/arrowfunciton-reference-arguments.js 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+var fn = function() {
+ var args = arguments;
+ return () => args[0];
+}(1);
+
+noInline(fn);
+
+for (var i = 0; i < 10000; i++) {
+ if(fn(2) !== 1) throw 0;
+}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/ChangeLog (213791 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/ChangeLog 2017-03-13 09:33:36 UTC (rev 213791)
+++ releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/ChangeLog 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2017-02-28 Oleksandr Skachkov <gskachkov@gmail.com>
+
+ Use of arguments in arrow function is slow
+ https://bugs.webkit.org/show_bug.cgi?id=168829
+
+ Reviewed by Saam Barati.
+
+ Current patch improves performance access to arguments within arrow functuion
+ by preventing create arguments variable within arrow function, also allow to cache
+ arguments variable. Before arguments variable always have Dynamic resolve type, after
+ patch it can be ClosureVar, that increase performance of access to arguments variable
+ in 9 times inside of the arrow function.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ * runtime/JSScope.cpp:
+ (JSC::abstractAccess):
+
</ins><span class="cx"> 2017-03-08 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [GTK] JSC test stress/arity-check-ftl-throw.js.ftl-no-cjit-validate-sampling-profiler crashing on GTK bot
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceJavaScriptCorebytecompilerBytecodeGeneratorcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (213791 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2017-03-13 09:33:36 UTC (rev 213791)
+++ releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> bool shouldCaptureSomeOfTheThings = m_shouldEmitDebugHooks || functionNode->needsActivation() || containsArrowOrEvalButNotInArrowBlock;
</span><span class="cx">
</span><span class="cx"> bool shouldCaptureAllOfTheThings = m_shouldEmitDebugHooks || codeBlock->usesEval();
</span><del>- bool needsArguments = (functionNode->usesArguments() || codeBlock->usesEval() || (functionNode->usesArrowFunction() && !codeBlock->isArrowFunction() && isArgumentsUsedInInnerArrowFunction()));
</del><ins>+ bool needsArguments = ((functionNode->usesArguments() && !codeBlock->isArrowFunction()) || codeBlock->usesEval() || (functionNode->usesArrowFunction() && !codeBlock->isArrowFunction() && isArgumentsUsedInInnerArrowFunction()));
</ins><span class="cx">
</span><span class="cx"> if (isGeneratorOrAsyncFunctionBodyParseMode(parseMode)) {
</span><span class="cx"> // Generator and AsyncFunction never provides "arguments". "arguments" reference will be resolved in an upper generator function scope.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit216SourceJavaScriptCoreruntimeJSScopecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/runtime/JSScope.cpp (213791 => 213792)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/runtime/JSScope.cpp 2017-03-13 09:33:36 UTC (rev 213791)
+++ releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore/runtime/JSScope.cpp 2017-03-13 09:37:14 UTC (rev 213792)
</span><span class="lines">@@ -52,11 +52,6 @@
</span><span class="cx"> {
</span><span class="cx"> if (scope->isJSLexicalEnvironment()) {
</span><span class="cx"> JSLexicalEnvironment* lexicalEnvironment = jsCast<JSLexicalEnvironment*>(scope);
</span><del>- if (ident == exec->propertyNames().arguments) {
- // We know the property will be at this lexical environment scope, but we don't know how to cache it.
- op = ResolveOp(Dynamic, 0, 0, 0, 0, 0);
- return true;
- }
</del><span class="cx">
</span><span class="cx"> SymbolTable* symbolTable = lexicalEnvironment->symbolTable();
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>