<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213856] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213856">213856</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2017-03-13 11:00:25 -0700 (Mon, 13 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>FTL should not flush strict arguments unless it really needs to
https://bugs.webkit.org/show_bug.cgi?id=169519
Reviewed by Mark Lam.
JSTests:
This benchmark runs 3.5x faster thanks to this patch.
* microbenchmarks/strict-arguments-no-escape.js: Added.
(foo):
(bar):
(baz):
Source/JavaScriptCore:
This is a refinement that we should have done ages ago. This kills some pointless PutStacks
in DFG SSA IR. It can sometimes unlock other optimizations.
* dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGPreciseLocalClobberizeh">trunk/Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkJSTestsmicrobenchmarksstrictargumentsnoescapejs">trunk/JSTests/microbenchmarks/strict-arguments-no-escape.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (213855 => 213856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2017-03-13 17:54:21 UTC (rev 213855)
+++ trunk/JSTests/ChangeLog 2017-03-13 18:00:25 UTC (rev 213856)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-03-11 Filip Pizlo <fpizlo@apple.com>
+
+ FTL should not flush strict arguments unless it really needs to
+ https://bugs.webkit.org/show_bug.cgi?id=169519
+
+ Reviewed by Mark Lam.
+
+ This benchmark runs 3.5x faster thanks to this patch.
+
+ * microbenchmarks/strict-arguments-no-escape.js: Added.
+ (foo):
+ (bar):
+ (baz):
+
</ins><span class="cx"> 2017-03-13 Caio Lima <ticaiolima@gmail.com>
</span><span class="cx">
</span><span class="cx"> [JSC] It should be possible create a label named let when parsing Statement in non strict mode
</span></span></pre></div>
<a id="trunkJSTestsmicrobenchmarksstrictargumentsnoescapejs"></a>
<div class="addfile"><h4>Added: trunk/JSTests/microbenchmarks/strict-arguments-no-escape.js (0 => 213856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/microbenchmarks/strict-arguments-no-escape.js (rev 0)
+++ trunk/JSTests/microbenchmarks/strict-arguments-no-escape.js 2017-03-13 18:00:25 UTC (rev 213856)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+"use strict";
+
+function foo()
+{
+}
+
+noInline(foo);
+
+function bar(o)
+{
+ foo();
+ return o.f.f.f.f.f;
+}
+
+function baz()
+{
+ for (var i = 0; i < 100; ++i) {
+ if (bar({f: {f: {f: {f: {f: 42}}}}}) != 42)
+ throw "Error: bad result: " + result;
+ }
+}
+
+noInline(baz);
+
+for (var i = 0; i < 20000; ++i)
+ baz();
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (213855 => 213856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-03-13 17:54:21 UTC (rev 213855)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-03-13 18:00:25 UTC (rev 213856)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-11 Filip Pizlo <fpizlo@apple.com>
+
+ FTL should not flush strict arguments unless it really needs to
+ https://bugs.webkit.org/show_bug.cgi?id=169519
+
+ Reviewed by Mark Lam.
+
+ This is a refinement that we should have done ages ago. This kills some pointless PutStacks
+ in DFG SSA IR. It can sometimes unlock other optimizations.
+
+ * dfg/DFGPreciseLocalClobberize.h:
+ (JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
+
</ins><span class="cx"> 2017-03-13 Caio Lima <ticaiolima@gmail.com>
</span><span class="cx">
</span><span class="cx"> [JSC] It should be possible create a label named let when parsing Statement in non strict mode
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGPreciseLocalClobberizeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h (213855 => 213856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h 2017-03-13 17:54:21 UTC (rev 213855)
+++ trunk/Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h 2017-03-13 18:00:25 UTC (rev 213856)
</span><span class="lines">@@ -197,9 +197,11 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> default: {
</span><del>- // All of the outermost arguments, except this, are definitely read.
- for (unsigned i = m_graph.m_codeBlock->numParameters(); i-- > 1;)
- m_read(virtualRegisterForArgument(i));
</del><ins>+ // All of the outermost arguments, except this, are read in sloppy mode.
+ if (!m_graph.m_codeBlock->isStrictMode()) {
+ for (unsigned i = m_graph.m_codeBlock->numParameters(); i-- > 1;)
+ m_read(virtualRegisterForArgument(i));
+ }
</ins><span class="cx">
</span><span class="cx"> // The stack header is read.
</span><span class="cx"> for (unsigned i = 0; i < CallFrameSlot::thisArgument; ++i)
</span><span class="lines">@@ -207,8 +209,10 @@
</span><span class="cx">
</span><span class="cx"> // Read all of the inline arguments and call frame headers that we didn't already capture.
</span><span class="cx"> for (InlineCallFrame* inlineCallFrame = m_node->origin.semantic.inlineCallFrame; inlineCallFrame; inlineCallFrame = inlineCallFrame->getCallerInlineFrameSkippingTailCalls()) {
</span><del>- for (unsigned i = inlineCallFrame->arguments.size(); i-- > 1;)
- m_read(VirtualRegister(inlineCallFrame->stackOffset + virtualRegisterForArgument(i).offset()));
</del><ins>+ if (!inlineCallFrame->isStrictMode()) {
+ for (unsigned i = inlineCallFrame->arguments.size(); i-- > 1;)
+ m_read(VirtualRegister(inlineCallFrame->stackOffset + virtualRegisterForArgument(i).offset()));
+ }
</ins><span class="cx"> if (inlineCallFrame->isClosureCall)
</span><span class="cx"> m_read(VirtualRegister(inlineCallFrame->stackOffset + CallFrameSlot::callee));
</span><span class="cx"> if (inlineCallFrame->isVarargs())
</span></span></pre>
</div>
</div>
</body>
</html>