<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213770] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213770">213770</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-12 10:27:48 -0700 (Sun, 12 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)
https://bugs.webkit.org/show_bug.cgi?id=168781
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-03-12
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Updated WPT expectations for readable byte streams tests.
* web-platform-tests/streams/readable-byte-streams/general-expected.txt:
* web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
Source/WebCore:
Implemented ReadableStreamBYOBRequest respond() method in the case of a closed stream.
Added tests related to respond() method and updated WPT imported tests expectations.
* Modules/streams/ReadableByteStreamInternals.js:
(readableByteStreamControllerRespond): Added.
(readableByteStreamControllerRespondInternal): Added.
(readableByteStreamControllerRespondInClosedState): Added.
(readableByteStreamControllerShiftPendingPullInto): Added.
(readableByteStreamControllerInvalidateBYOBRequest): Added.
(readableByteStreamControllerCommitPullIntoDescriptor): Added.
(readableByteStreamControllerConvertPullIntoDescriptor): Added.
(readableStreamFulfillReadIntoRequest): Added.
* Modules/streams/ReadableStreamBYOBRequest.js:
(respond): Implemented.
LayoutTests:
Added new tests related to ReadableStreamBYOBRequeset respond() method.
* streams/readable-stream-byob-request-expected.txt:
* streams/readable-stream-byob-request.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneralexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneraldedicatedworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreadablestreambyobrequestexpectedtxt">trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreadablestreambyobrequestjs">trunk/LayoutTests/streams/readable-stream-byob-request.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableByteStreamInternalsjs">trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamBYOBRequestjs">trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/ChangeLog 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-12 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)
+ https://bugs.webkit.org/show_bug.cgi?id=168781
+
+ Reviewed by Youenn Fablet.
+
+ Added new tests related to ReadableStreamBYOBRequeset respond() method.
+
+ * streams/readable-stream-byob-request-expected.txt:
+ * streams/readable-stream-byob-request.js:
+
</ins><span class="cx"> 2017-03-11 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> XMLHttpRequest: make setRequestHeader() use `, ` as separator (including a space)
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-12 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)
+ https://bugs.webkit.org/show_bug.cgi?id=168781
+
+ Reviewed by Youenn Fablet.
+
+ Updated WPT expectations for readable byte streams tests.
+
+ * web-platform-tests/streams/readable-byte-streams/general-expected.txt:
+ * web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
+
</ins><span class="cx"> 2017-03-11 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> XMLHttpRequest: make setRequestHeader() use `, ` as separator (including a space)
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneralexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start()
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read()
</span><span class="cx"> FAIL ReadableStream with byte source: autoAllocateChunkSize assert_equals: pull() must have been invoked once expected 1 but got 0
</span><del>-FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableStreamBYOBRequest respond() is not implemented"
</del><ins>+FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: Readable state is not yet supported"
</ins><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read(view)
</span><span class="cx"> PASS ReadableStream with byte source: enqueue(), getReader(), then read()
</span><span class="cx"> PASS ReadableStream with byte source: Push source that doesn't understand pull signal
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneraldedicatedworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start()
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read()
</span><span class="cx"> FAIL ReadableStream with byte source: autoAllocateChunkSize assert_equals: pull() must have been invoked once expected 1 but got 0
</span><del>-FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableStreamBYOBRequest respond() is not implemented"
</del><ins>+FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: Readable state is not yet supported"
</ins><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read(view)
</span><span class="cx"> PASS ReadableStream with byte source: enqueue(), getReader(), then read()
</span><span class="cx"> PASS ReadableStream with byte source: Push source that doesn't understand pull signal
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreadablestreambyobrequestexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -2,7 +2,19 @@
</span><span class="cx"> PASS ReadableStreamBYOBRequest instances should have the correct list of properties
</span><span class="cx"> PASS By default, byobRequest should be undefined
</span><span class="cx"> PASS byobRequest.view length should be equal to autoAllocateChunkSize
</span><ins>+PASS Calling respond() with a this object different from ReadableStreamBYOBRequest should throw a TypeError
+PASS Calling respond() with a negative bytesWritten value should throw a RangeError
+PASS Calling respond() with a bytesWritten value which is not a number should throw a RangeError
+PASS Calling respond() with a positive infinity bytesWritten value should throw a RangeError
+PASS Calling respond() with a bytesWritten value different from 0 when stream is closed should throw a TypeError
+PASS Calling respond() with a bytesWritten value of 0 when stream is closed should succeed
</ins><span class="cx"> PASS ReadableStreamBYOBRequest instances should have the correct list of properties
</span><span class="cx"> PASS By default, byobRequest should be undefined
</span><span class="cx"> PASS byobRequest.view length should be equal to autoAllocateChunkSize
</span><ins>+PASS Calling respond() with a this object different from ReadableStreamBYOBRequest should throw a TypeError
+PASS Calling respond() with a negative bytesWritten value should throw a RangeError
+PASS Calling respond() with a bytesWritten value which is not a number should throw a RangeError
+PASS Calling respond() with a positive infinity bytesWritten value should throw a RangeError
+PASS Calling respond() with a bytesWritten value different from 0 when stream is closed should throw a TypeError
+PASS Calling respond() with a bytesWritten value of 0 when stream is closed should succeed
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreadablestreambyobrequestjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/readable-stream-byob-request.js (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/readable-stream-byob-request.js 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/LayoutTests/streams/readable-stream-byob-request.js 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -85,4 +85,117 @@
</span><span class="cx">
</span><span class="cx"> }, "byobRequest.view length should be equal to autoAllocateChunkSize")
</span><span class="cx">
</span><ins>+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+
+ assert_throws(new TypeError("Can only call ReadableStreamBYOBRequest.respond on instances of ReadableStreamBYOBRequest"),
+ function() { byobReq.respond.apply(rs, 1); });
+
+}, "Calling respond() with a this object different from ReadableStreamBYOBRequest should throw a TypeError");
+
+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+
+ assert_throws(new RangeError("bytesWritten has an incorrect value"),
+ function() { byobReq.respond(-1); });
+}, "Calling respond() with a negative bytesWritten value should throw a RangeError");
+
+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+
+ assert_throws(new RangeError("bytesWritten has an incorrect value"),
+ function() { byobReq.respond("abc"); });
+}, "Calling respond() with a bytesWritten value which is not a number should throw a RangeError");
+
+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+
+ assert_throws(new RangeError("bytesWritten has an incorrect value"),
+ function() { byobReq.respond(Number.POSITIVE_INFINITY); });
+}, "Calling respond() with a positive infinity bytesWritten value should throw a RangeError");
+
+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+ controller.close();
+
+ assert_throws(new TypeError("bytesWritten is different from 0 even though stream is closed"),
+ function() { byobReq.respond(1); });
+}, "Calling respond() with a bytesWritten value different from 0 when stream is closed should throw a TypeError");
+
+test(function() {
+
+ let controller;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize: 16,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ // FIXME: When ReadableStreamBYOBReader is implemented, another test (or even several ones)
+ // based on this one should be added so that reader's readIntoRequests attribute is not empty
+ // and currently unreachable code is reached.
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+ controller.close();
+ byobReq.respond(0);
+
+}, "Calling respond() with a bytesWritten value of 0 when stream is closed should succeed");
+
</ins><span class="cx"> done();
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/Source/WebCore/ChangeLog 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2017-03-12 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)
+ https://bugs.webkit.org/show_bug.cgi?id=168781
+
+ Reviewed by Youenn Fablet.
+
+ Implemented ReadableStreamBYOBRequest respond() method in the case of a closed stream.
+
+ Added tests related to respond() method and updated WPT imported tests expectations.
+
+ * Modules/streams/ReadableByteStreamInternals.js:
+ (readableByteStreamControllerRespond): Added.
+ (readableByteStreamControllerRespondInternal): Added.
+ (readableByteStreamControllerRespondInClosedState): Added.
+ (readableByteStreamControllerShiftPendingPullInto): Added.
+ (readableByteStreamControllerInvalidateBYOBRequest): Added.
+ (readableByteStreamControllerCommitPullIntoDescriptor): Added.
+ (readableByteStreamControllerConvertPullIntoDescriptor): Added.
+ (readableStreamFulfillReadIntoRequest): Added.
+ * Modules/streams/ReadableStreamBYOBRequest.js:
+ (respond): Implemented.
+
</ins><span class="cx"> 2017-03-11 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix memory estimate for layers supporting subpixel-antialised text
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableByteStreamInternalsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -345,3 +345,111 @@
</span><span class="cx"> });
</span><span class="cx"> controller.@totalQueuedBytes += byteLength;
</span><span class="cx"> }
</span><ins>+
+function readableByteStreamControllerRespond(controller, bytesWritten)
+{
+ "use strict";
+
+ bytesWritten = @Number(bytesWritten);
+
+ if (@isNaN(bytesWritten) || bytesWritten === @Number.POSITIVE_INFINITY || bytesWritten < 0 )
+ @throwRangeError("bytesWritten has an incorrect value");
+
+ @assert(controller.@pendingPullIntos.length > 0);
+
+ @readableByteStreamControllerRespondInternal(controller, bytesWritten);
+}
+
+function readableByteStreamControllerRespondInternal(controller, bytesWritten)
+{
+ "use strict";
+
+ let firstDescriptor = controller.@pendingPullIntos[0];
+ let stream = controller.@controlledReadableStream;
+
+ if (stream.@state === @streamClosed) {
+ if (bytesWritten !== 0)
+ @throwTypeError("bytesWritten is different from 0 even though stream is closed");
+ @readableByteStreamControllerRespondInClosedState(controller, firstDescriptor);
+ } else {
+ // FIXME: Also implement case of readable state (distinct patch to avoid adding too many different cases
+ // in a single patch).
+ @throwTypeError("Readable state is not yet supported");
+ }
+}
+
+function readableByteStreamControllerRespondInClosedState(controller, firstDescriptor)
+{
+ "use strict";
+
+ firstDescriptor.buffer = @transferBufferToCurrentRealm(firstDescriptor.buffer);
+ @assert(firstDescriptor.bytesFilled === 0);
+
+ // FIXME: Spec does not describe below test. However, only ReadableStreamBYOBReader has a readIntoRequests
+ // property. This issue has been reported through WHATWG/streams GitHub
+ // (https://github.com/whatwg/streams/issues/686), but no solution has been provided for the moment.
+ // Therefore, below test is added as a temporary fix.
+ if (!@isReadableStreamBYOBReader(controller.@reader))
+ return;
+
+ while (controller.@reader.@readIntoRequests.length > 0) {
+ let pullIntoDescriptor = @readableByteStreamControllerShiftPendingPullInto(controller);
+ @readableByteStreamControllerCommitPullIntoDescriptor(controller.@controlledReadableStream, pullIntoDescriptor);
+ }
+}
+
+function readableByteStreamControllerShiftPendingPullInto(controller)
+{
+ "use strict";
+
+ let descriptor = controller.@pendingPullIntos.@shift();
+ @readableByteStreamControllerInvalidateBYOBRequest(controller);
+ return descriptor;
+}
+
+function readableByteStreamControllerInvalidateBYOBRequest(controller)
+{
+ "use strict";
+
+ if (controller.@byobRequest === @undefined)
+ return;
+ controller.@byobRequest.@associatedReadableByteStreamController = @undefined;
+ controller.@byobRequest.@view = @undefined;
+ controller.@byobRequest = @undefined;
+}
+
+function readableByteStreamControllerCommitPullIntoDescriptor(stream, pullIntoDescriptor)
+{
+ "use strict";
+
+ @assert(stream.@state !== @streamErrored);
+ let done = false;
+ if (stream.@state === @streamClosed) {
+ @assert(!pullIntoDescriptor.bytesFilled);
+ done = true;
+ }
+ let filledView = @readableByteStreamControllerConvertPullIntoDescriptor(pullIntoDescriptor);
+ if (pullIntoDescriptor.readerType === "default")
+ @readableStreamFulfillReadRequest(stream, filledView, done);
+ else {
+ @assert(pullIntoDescriptor.readerType === "byob");
+ @readableStreamFulfillReadIntoRequest(stream, filledView, done);
+ }
+}
+
+function readableByteStreamControllerConvertPullIntoDescriptor(pullIntoDescriptor)
+{
+ "use strict";
+
+ @assert(pullIntoDescriptor.bytesFilled <= pullIntoDescriptor.bytesLength);
+ @assert(pullIntoDescriptor.bytesFilled % pullIntoDescriptor.elementSize === 0);
+
+ return new pullIntoDescriptor.ctor(pullIntoDescriptor.buffer, pullIntoDescriptor.byteOffset, pullIntoDescriptor.bytesFilled / pullIntoDescriptor.elementSize);
+}
+
+function readableStreamFulfillReadIntoRequest(stream, chunk, done)
+{
+ "use strict";
+
+ stream.@reader.@readIntoRequests.@shift().@resolve.@call(@undefined, {value: chunk, done: done});
+}
</ins></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamBYOBRequestjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js (213769 => 213770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js 2017-03-12 07:54:19 UTC (rev 213769)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js 2017-03-12 17:27:48 UTC (rev 213770)
</span><span class="lines">@@ -29,8 +29,13 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- // FIXME: Implement appropriate behavior.
- @throwTypeError("ReadableStreamBYOBRequest respond() is not implemented");
</del><ins>+ if (!@isReadableStreamBYOBRequest(this))
+ throw @makeThisTypeError("ReadableStreamBYOBRequest", "respond");
+
+ if (this.@associatedReadableByteStreamController === @undefined)
+ @throwTypeError("ReadableStreamBYOBRequest.associatedReadableByteStreamController is undefined");
+
+ return @readableByteStreamControllerRespond(this.@associatedReadableByteStreamController, bytesWritten);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function respondWithNewView(view)
</span></span></pre>
</div>
</div>
</body>
</html>