<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213771] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213771">213771</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2017-03-12 11:47:35 -0700 (Sun, 12 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] Some more -respondsToSelector: checks are unnecessary
https://bugs.webkit.org/show_bug.cgi?id=169525
Reviewed by Tim Horton.
* Platform/spi/ios/UIKitSPI.h: Moved redeclarations of methods that are declared in the
Apple internal SDK into the #if !USE(APPLE_INTERNAL_SDK) section.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Replaced unnecessary -respondsToSelector:
check with compile-time check for the deployment target.
(-[WKWebView _computedContentInset]): Ditto.
(activeMinimumLayoutSize): Ditto.
(-[WKWebView safeAreaInsetsDidChange]): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformspiiosUIKitSPIh">trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKWebViewmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (213770 => 213771)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-12 17:27:48 UTC (rev 213770)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-12 18:47:35 UTC (rev 213771)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-03-12 Dan Bernstein <mitz@apple.com>
+
+ [iOS] Some more -respondsToSelector: checks are unnecessary
+ https://bugs.webkit.org/show_bug.cgi?id=169525
+
+ Reviewed by Tim Horton.
+
+ * Platform/spi/ios/UIKitSPI.h: Moved redeclarations of methods that are declared in the
+ Apple internal SDK into the #if !USE(APPLE_INTERNAL_SDK) section.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _initializeWithConfiguration:]): Replaced unnecessary -respondsToSelector:
+ check with compile-time check for the deployment target.
+ (-[WKWebView _computedContentInset]): Ditto.
+ (activeMinimumLayoutSize): Ditto.
+ (-[WKWebView safeAreaInsetsDidChange]): Ditto.
+
</ins><span class="cx"> 2017-03-11 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable async image decoding for large images
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformspiiosUIKitSPIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h (213770 => 213771)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h 2017-03-12 17:27:48 UTC (rev 213770)
+++ trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h 2017-03-12 18:47:35 UTC (rev 213771)
</span><span class="lines">@@ -314,6 +314,10 @@
</span><span class="cx"> @property (nonatomic) CGFloat horizontalScrollDecelerationFactor;
</span><span class="cx"> @property (nonatomic) CGFloat verticalScrollDecelerationFactor;
</span><span class="cx"> @property (nonatomic, readonly) BOOL _isInterruptingDeceleration;
</span><ins>+#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000
+@property (nonatomic, setter=_setEdgesScrollingContentIntoSafeArea:) UIRectEdge _edgesScrollingContentIntoSafeArea;
+@property (nonatomic, readonly) UIEdgeInsets _systemContentInset;
+#endif
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @interface NSString (UIKitDetails)
</span><span class="lines">@@ -455,6 +459,9 @@
</span><span class="cx"> - (void)setSize:(CGSize)size;
</span><span class="cx"> @property (nonatomic, assign, setter=_setBackdropMaskViewFlags:) NSInteger _backdropMaskViewFlags;
</span><span class="cx"> - (void)_populateArchivedSubviews:(NSMutableSet *)encodedViews;
</span><ins>+#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000
+- (void)safeAreaInsetsDidChange;
+#endif
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @interface UIWebSelectionView : UIView
</span><span class="lines">@@ -873,15 +880,6 @@
</span><span class="cx"> - (UIResponder *)firstResponder;
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@interface UIView ()
-- (void)safeAreaInsetsDidChange;
-@end
-
-@interface UIScrollView ()
-@property (nonatomic, setter=_setEdgesScrollingContentIntoSafeArea:) UIRectEdge _edgesScrollingContentIntoSafeArea;
-@property (nonatomic, readonly) UIEdgeInsets _systemContentInset;
-@end
-
</del><span class="cx"> WTF_EXTERN_C_BEGIN
</span><span class="cx">
</span><span class="cx"> BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (213770 => 213771)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-12 17:27:48 UTC (rev 213770)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-12 18:47:35 UTC (rev 213771)
</span><span class="lines">@@ -508,8 +508,9 @@
</span><span class="cx"> [_scrollView setInternalDelegate:self];
</span><span class="cx"> [_scrollView setBouncesZoom:YES];
</span><span class="cx">
</span><del>- if ([_scrollView respondsToSelector:@selector(_setEdgesScrollingContentIntoSafeArea:)])
- [_scrollView _setEdgesScrollingContentIntoSafeArea:UIRectEdgeAll];
</del><ins>+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+ [_scrollView _setEdgesScrollingContentIntoSafeArea:UIRectEdgeAll];
+#endif
</ins><span class="cx">
</span><span class="cx"> [self addSubview:_scrollView.get()];
</span><span class="cx">
</span><span class="lines">@@ -1352,13 +1353,13 @@
</span><span class="cx">
</span><span class="cx"> UIEdgeInsets insets = [_scrollView contentInset];
</span><span class="cx">
</span><del>- if ([_scrollView respondsToSelector:@selector(_systemContentInset)]) {
- UIEdgeInsets systemInsets = [_scrollView _systemContentInset];
- insets.top += systemInsets.top;
- insets.bottom += systemInsets.bottom;
- insets.left += systemInsets.left;
- insets.right += systemInsets.right;
- }
</del><ins>+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+ UIEdgeInsets systemInsets = [_scrollView _systemContentInset];
+ insets.top += systemInsets.top;
+ insets.bottom += systemInsets.bottom;
+ insets.left += systemInsets.left;
+ insets.right += systemInsets.right;
+#endif
</ins><span class="cx">
</span><span class="cx"> return insets;
</span><span class="cx"> }
</span><span class="lines">@@ -2215,12 +2216,12 @@
</span><span class="cx"> if (webView->_overridesMinimumLayoutSize)
</span><span class="cx"> return WebCore::FloatSize(webView->_minimumLayoutSizeOverride);
</span><span class="cx">
</span><del>- if ([webView->_scrollView respondsToSelector:@selector(_systemContentInset)]) {
- UIEdgeInsets systemContentInset = [webView->_scrollView _systemContentInset];
- return WebCore::FloatSize(UIEdgeInsetsInsetRect(CGRectMake(0, 0, bounds.size.width, bounds.size.height), systemContentInset).size);
- }
-
</del><ins>+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+ UIEdgeInsets systemContentInset = [webView->_scrollView _systemContentInset];
+ return WebCore::FloatSize(UIEdgeInsetsInsetRect(CGRectMake(0, 0, bounds.size.width, bounds.size.height), systemContentInset).size);
+#else
</ins><span class="cx"> return WebCore::FloatSize(bounds.size);
</span><ins>+#endif
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)_frameOrBoundsChanged
</span><span class="lines">@@ -2266,13 +2267,14 @@
</span><span class="cx"> return !pointsEqualInDevicePixels(contentOffset, boundedOffset, deviceScaleFactor);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
</ins><span class="cx"> - (void)safeAreaInsetsDidChange
</span><span class="cx"> {
</span><del>- if ([super respondsToSelector:@selector(safeAreaInsetsDidChange)])
- [super safeAreaInsetsDidChange];
</del><ins>+ [super safeAreaInsetsDidChange];
</ins><span class="cx">
</span><span class="cx"> [self _scheduleVisibleContentRectUpdate];
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> - (void)_scheduleVisibleContentRectUpdate
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>