<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213706] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213706">213706</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-10 03:31:56 -0800 (Fri, 10 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168409
Unreviewed.
Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.
Patch by Antoine Quint <graouts@apple.com> on 2017-03-10
Source/WebCore:
* Modules/modern-media-controls/controls/scheduler.js:
(const.scheduler.new.prototype.scheduleLayout):
(const.scheduler.new.prototype.unscheduleLayout):
(const.scheduler.new.prototype._requestFrameIfNeeded):
(const.scheduler.new.prototype._frameDidFire):
(const.scheduler.new.prototype._layout):
LayoutTests:
* media/modern-media-controls/airplay-button/airplay-button-expected.txt:
* media/modern-media-controls/airplay-button/airplay-button.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsairplaybuttonairplaybuttonexpectedtxt">trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsairplaybuttonairplaybuttonhtml">trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsschedulerjs">trunk/Source/WebCore/Modules/modern-media-controls/controls/scheduler.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213705 => 213706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-10 10:30:30 UTC (rev 213705)
+++ trunk/LayoutTests/ChangeLog 2017-03-10 11:31:56 UTC (rev 213706)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-10 Antoine Quint <graouts@apple.com>
+
+ [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=168409
+
+ Unreviewed.
+
+ Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.
+
+ * media/modern-media-controls/airplay-button/airplay-button-expected.txt:
+ * media/modern-media-controls/airplay-button/airplay-button.html:
+
</ins><span class="cx"> 2017-03-09 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r213633.
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsairplaybuttonairplaybuttonexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt (213705 => 213706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt 2017-03-10 10:30:30 UTC (rev 213705)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt 2017-03-10 11:31:56 UTC (rev 213706)
</span><span class="lines">@@ -3,15 +3,30 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><ins>+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - registered rAF, _frameID = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = 1, _layoutCallbacks.size = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = 1, _layoutCallbacks.size = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
</ins><span class="cx"> PASS airplayButton.element.localName is "button"
</span><span class="cx"> PASS airplayButton.element.classList.contains("icon") is true
</span><span class="cx"> PASS airplayButton.element.classList.contains("airplay") is true
</span><span class="cx"> PASS airplayButton.iconName is "airplay"
</span><del>-PASS airplayButton.width is 0
-PASS airplayButton.height is 0
</del><ins>+FAIL airplayButton.width should be 0. Was 25.
+FAIL airplayButton.height should be 0. Was 22.
</ins><span class="cx"> PASS airplayButton._image is iconService.imageForIconNameAndLayoutTraits(Icons.Airplay, LayoutTraits.macOS)
</span><span class="cx"> PASS airplayButton._image.src is not ""
</span><del>-PASS airplayButton._image.complete is false
</del><ins>+FAIL airplayButton._image.complete should be false. Was true.
</ins><span class="cx"> PASS airplayButton.width is not 0
</span><span class="cx"> PASS airplayButton.height is not 0
</span><span class="cx"> PASS airplayButton.needsLayout is true
</span><span class="lines">@@ -19,12 +34,19 @@
</span><span class="cx"> PASS scheduler._layoutCallbacks.size is 1
</span><span class="cx"> PASS scheduler._frameID is not -1
</span><span class="cx"> PASS dirtyNodes.has(airplayButton) is true
</span><ins>+_frameDidFire() - start
</ins><span class="cx"> frameWillFire()
</span><span class="cx"> PASS dirtyNodes.has(airplayButton) is true
</span><span class="cx"> PASS airplayButton.needsLayout is true
</span><ins>+_layout() - start
+_layout() - layoutCallbacks.size = 1
+_layout() - end
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = -1, _layoutCallbacks.size = 0
</ins><span class="cx"> frameDidFire()
</span><span class="cx"> PASS dirtyNodes.has(airplayButton) is false
</span><span class="cx"> PASS airplayButton.needsLayout is false
</span><ins>+_frameDidFire() - end
</ins><span class="cx"> PASS airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@") became true
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsairplaybuttonairplaybuttonhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html (213705 => 213706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2017-03-10 10:30:30 UTC (rev 213705)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2017-03-10 11:31:56 UTC (rev 213706)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<meta charset="utf-8">
</ins><span class="cx"> <script src="../../../resources/js-test-pre.js"></script>
</span><span class="cx"> <script src="../resources/media-controls-utils.js" type="text/javascript"></script>
</span><span class="cx"> <script src="../resources/media-controls-loader.js" type="text/javascript"></script>
</span><span class="lines">@@ -5,6 +6,7 @@
</span><span class="cx"> <script type="text/javascript">
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span><ins>+scheduler.debug = debug;
</ins><span class="cx">
</span><span class="cx"> description("Testing the <code>AirplayButton</code> class.");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213705 => 213706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-10 10:30:30 UTC (rev 213705)
+++ trunk/Source/WebCore/ChangeLog 2017-03-10 11:31:56 UTC (rev 213706)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-10 Antoine Quint <graouts@apple.com>
+
+ [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=168409
+
+ Unreviewed.
+
+ Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.
+
+ * Modules/modern-media-controls/controls/scheduler.js:
+ (const.scheduler.new.prototype.scheduleLayout):
+ (const.scheduler.new.prototype.unscheduleLayout):
+ (const.scheduler.new.prototype._requestFrameIfNeeded):
+ (const.scheduler.new.prototype._frameDidFire):
+ (const.scheduler.new.prototype._layout):
+
</ins><span class="cx"> 2017-03-09 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r213633.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsschedulerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/scheduler.js (213705 => 213706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/scheduler.js 2017-03-10 10:30:30 UTC (rev 213705)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/scheduler.js 2017-03-10 11:31:56 UTC (rev 213706)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> {
</span><span class="cx"> this._frameID = -1;
</span><span class="cx"> this._layoutCallbacks = new Set;
</span><ins>+ this.debug = new Function;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Public
</span><span class="lines">@@ -17,19 +18,29 @@
</span><span class="cx">
</span><span class="cx"> scheduleLayout(callback)
</span><span class="cx"> {
</span><del>- if (typeof callback !== "function")
</del><ins>+ this.debug("scheduleLayout() - start");
+ if (typeof callback !== "function") {
+ this.debug("scheduleLayout() - end - callback was not a function");
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> this._layoutCallbacks.add(callback);
</span><span class="cx"> this._requestFrameIfNeeded();
</span><ins>+ this.debug(`scheduleLayout() - _layoutCallbacks.size = ${this._layoutCallbacks.size}`);
+ this.debug("scheduleLayout() - end");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unscheduleLayout(callback)
</span><span class="cx"> {
</span><del>- if (typeof callback !== "function")
</del><ins>+ this.debug("unscheduleLayout() - start");
+ if (typeof callback !== "function") {
+ this.debug("unscheduleLayout() - end - callback was not a function");
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> this._layoutCallbacks.delete(callback);
</span><ins>+ this.debug(`unscheduleLayout() - this._layoutCallbacks.size = ${this._layoutCallbacks.size}`);
+ this.debug("unscheduleLayout() - end");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="lines">@@ -36,12 +47,17 @@
</span><span class="cx">
</span><span class="cx"> _requestFrameIfNeeded()
</span><span class="cx"> {
</span><del>- if (this._frameID === -1 && this._layoutCallbacks.size > 0)
</del><ins>+ this.debug("_requestFrameIfNeeded()");
+ if (this._frameID === -1 && this._layoutCallbacks.size > 0) {
</ins><span class="cx"> this._frameID = window.requestAnimationFrame(this._frameDidFire.bind(this));
</span><ins>+ this.debug(`_requestFrameIfNeeded() - registered rAF, _frameID = ${this._frameID}`);
+ } else
+ this.debug(`_requestFrameIfNeeded() - failed to register rAF call, _frameID = ${this._frameID}, _layoutCallbacks.size = ${this._layoutCallbacks.size}`);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _frameDidFire()
</span><span class="cx"> {
</span><ins>+ this.debug("_frameDidFire() - start");
</ins><span class="cx"> if (typeof scheduler.frameWillFire === "function")
</span><span class="cx"> scheduler.frameWillFire();
</span><span class="cx">
</span><span class="lines">@@ -51,16 +67,21 @@
</span><span class="cx">
</span><span class="cx"> if (typeof scheduler.frameDidFire === "function")
</span><span class="cx"> scheduler.frameDidFire();
</span><ins>+ this.debug("_frameDidFire() - end");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _layout()
</span><span class="cx"> {
</span><ins>+ this.debug("_layout() - start");
</ins><span class="cx"> // Layouts are not re-entrant.
</span><span class="cx"> const layoutCallbacks = this._layoutCallbacks;
</span><span class="cx"> this._layoutCallbacks = new Set;
</span><span class="cx">
</span><ins>+ this.debug(`_layout() - layoutCallbacks.size = ${layoutCallbacks.size}`);
+
</ins><span class="cx"> for (let callback of layoutCallbacks)
</span><span class="cx"> callback();
</span><ins>+ this.debug("_layout() - end");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>