<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213670] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213670">213670</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-09 14:17:57 -0800 (Thu, 09 Mar 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Modern Media Controls] iOS: long press on play button shows the Copy menu
https://bugs.webkit.org/show_bug.cgi?id=169355
&lt;rdar://problem/30928998&gt;

Patch by Antoine Quint &lt;graouts@apple.com&gt; on 2017-03-09
Reviewed by Dean Jackson.

Source/WebCore:

Disable built-in UI behavior that shows a magnifier or a copy callout when pressing
on an element for a long time. These do not make sense for media controls.

Test: media/modern-media-controls/audio/audio-controls-styles.html

* Modules/modern-media-controls/controls/media-controls.css:
(:host):

LayoutTests:

Add a test to check that the expected properties are set as they should to disable
built-in UI behavior that shows a magnifier or a copy callout when pressing on an
element for a long time.

* media/modern-media-controls/audio/audio-controls-styles-expected.txt: Added.
* media/modern-media-controls/audio/audio-controls-styles.html: Added.
* platform/mac/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsmediacontrolscss">trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsaudioaudiocontrolsstylesexpectedtxt">trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsaudioaudiocontrolsstyleshtml">trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213669 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-03-09 22:17:13 UTC (rev 213669)
+++ trunk/LayoutTests/ChangeLog        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-09  Antoine Quint  &lt;graouts@apple.com&gt;
+
+        [Modern Media Controls] iOS: long press on play button shows the Copy menu
+        https://bugs.webkit.org/show_bug.cgi?id=169355
+        &lt;rdar://problem/30928998&gt;
+
+        Reviewed by Dean Jackson.
+
+        Add a test to check that the expected properties are set as they should to disable
+        built-in UI behavior that shows a magnifier or a copy callout when pressing on an
+        element for a long time.
+
+        * media/modern-media-controls/audio/audio-controls-styles-expected.txt: Added.
+        * media/modern-media-controls/audio/audio-controls-styles.html: Added.
+        * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2017-03-09  Ryan Haddad  &lt;ryanhaddad@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Rebaseline js/dom/global-constructors-attributes.html.
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsaudioaudiocontrolsstylesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles-expected.txt (0 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles-expected.txt                                (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles-expected.txt        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Testing media elements disable built-in browser UI features to copy content.
+
+On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
+
+
+PASS getComputedStyle(audio).WebkitUserSelect is &quot;none&quot;
+PASS getComputedStyle(audio).WebkitTouchCallout is &quot;none&quot;
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsaudioaudiocontrolsstyleshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles.html (0 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles.html                                (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles.html        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;script src=&quot;../../../resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+&lt;body&gt;
+&lt;script type=&quot;text/javascript&quot;&gt;
+
+description(&quot;Testing media elements disable built-in browser UI features to copy content.&quot;);
+
+const audio = document.body.appendChild(document.createElement(&quot;audio&quot;));
+audio.controls = true;
+
+shouldBeEqualToString(&quot;getComputedStyle(audio).WebkitUserSelect&quot;, &quot;none&quot;);
+shouldBeEqualToString(&quot;getComputedStyle(audio).WebkitTouchCallout&quot;, &quot;none&quot;);
+
+debug(&quot;&quot;);
+audio.remove();
+
+&lt;/script&gt;
+&lt;script src=&quot;../../../resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+&lt;/body&gt;
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (213669 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations        2017-03-09 22:17:13 UTC (rev 213669)
+++ trunk/LayoutTests/platform/mac/TestExpectations        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -1481,6 +1481,7 @@
</span><span class="cx"> media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
</span><ins>+media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
</ins><span class="cx"> 
</span><span class="cx"> webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213669 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-03-09 22:17:13 UTC (rev 213669)
+++ trunk/Source/WebCore/ChangeLog        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-03-09  Antoine Quint  &lt;graouts@apple.com&gt;
+
+        [Modern Media Controls] iOS: long press on play button shows the Copy menu
+        https://bugs.webkit.org/show_bug.cgi?id=169355
+        &lt;rdar://problem/30928998&gt;
+
+        Reviewed by Dean Jackson.
+
+        Disable built-in UI behavior that shows a magnifier or a copy callout when pressing
+        on an element for a long time. These do not make sense for media controls.
+
+        Test: media/modern-media-controls/audio/audio-controls-styles.html
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (:host):
+
</ins><span class="cx"> 2017-03-09  Alex Christensen  &lt;achristensen@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         [Content Extensions] Introduce if-top-url and unless-top-url
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsmediacontrolscss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (213669 => 213670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css        2017-03-09 22:17:13 UTC (rev 213669)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css        2017-03-09 22:17:57 UTC (rev 213670)
</span><span class="lines">@@ -23,6 +23,12 @@
</span><span class="cx">  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><ins>+:host {
+    /* We always want to prevent iOS dialogs and the magnifier UI to be shown. */
+    -webkit-user-select: none !important;
+    -webkit-touch-callout: none !important;
+}
+
</ins><span class="cx"> :host(audio) {
</span><span class="cx">     width: 200px;
</span><span class="cx">     min-width: 200px !important;
</span></span></pre>
</div>
</div>

</body>
</html>