<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213641] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213641">213641</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-09 08:10:50 -0800 (Thu, 09 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Modern Media Controls] Fullscreen controls are difficult to drag around
https://bugs.webkit.org/show_bug.cgi?id=169412
<rdar://problem/30931892>
Patch by Antoine Quint <graouts@apple.com> on 2017-03-09
Reviewed by Eric Carlson.
Source/WebCore:
Up until now, we would simply check that the event target when attempting to
initiate a drag would be the controls bar and not any of its children. This
was not so great as this would encompass also a large margin around the left,
center and right button containers as well as the time labels. We now check
that the event target is anything but an interactive element (<button> or <input>).
The existing test at media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html
has been updated to initiate dragging right between the rewind and play/pause button,
which would fail prior to this patch since this would have hit-tested within the center
button container and thus prevent dragging.
* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
(.media-controls.mac.fullscreen button.volume-down):
(.media-controls.mac.fullscreen button.volume-up):
(.media-controls.mac.fullscreen button.rewind):
(.media-controls.mac.fullscreen button.play-pause):
(.media-controls.mac.fullscreen button.forward):
(.media-controls.mac.fullscreen .buttons-container.right button):
* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype._handleMousedown):
* Modules/modern-media-controls/controls/macos-inline-media-controls.css:
(.media-controls.mac.inline > .controls-bar button):
* Modules/modern-media-controls/controls/macos-media-controls.css:
(.media-controls.mac > .controls-bar button):
LayoutTests:
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
Rebaseline test to account for CSS changes.
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html:
Change drag start coordinate to be right over a button so that it is prevented. Starting with this patch,
a drag at this coordinate would have been tolerated as being part of the left buttons container but not
part of a button in that container.
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
Change drag start coordinate to be right between two buttons so that it would have failed prior to this
patch.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsbuttonsstylesexpectedtxt">trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsbuttonsstyleshtml">trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsdragispreventedoverbuttonhtml">trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsdraghtml">trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosfullscreenmediacontrolscss">trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosfullscreenmediacontrolsjs">trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosinlinemediacontrolscss">trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosmediacontrolscss">trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/LayoutTests/ChangeLog 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2017-03-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] Fullscreen controls are difficult to drag around
+ https://bugs.webkit.org/show_bug.cgi?id=169412
+ <rdar://problem/30931892>
+
+ Reviewed by Eric Carlson.
+
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
+ Rebaseline test to account for CSS changes.
+
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html:
+ Change drag start coordinate to be right over a button so that it is prevented. Starting with this patch,
+ a drag at this coordinate would have been tolerated as being part of the left buttons container but not
+ part of a button in that container.
+
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
+ Change drag start coordinate to be right between two buttons so that it would have failed prior to this
+ patch.
+
+2017-03-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] Controls are not visible in fullscreen without the controls attribute
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169411
</span><span class="cx"> <rdar://problem/30931724>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsbuttonsstylesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -5,39 +5,39 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> RewindButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "17px"
</del><ins>+PASS getComputedStyle(button.element).top became "17px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "27px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "16px"
</ins><span class="cx">
</span><span class="cx"> PlayPauseButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "12px"
</del><ins>+PASS getComputedStyle(button.element).top became "12px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "78px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "26px"
</ins><span class="cx">
</span><span class="cx"> ForwardButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "17px"
</del><ins>+PASS getComputedStyle(button.element).top became "17px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "127px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "16px"
</ins><span class="cx">
</span><span class="cx"> AirplayButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "18px"
</del><ins>+PASS getComputedStyle(button.element).top became "18px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "12px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "14px"
</ins><span class="cx">
</span><span class="cx"> PiPButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "18px"
</del><ins>+PASS getComputedStyle(button.element).top became "18px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "44px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "16px"
</ins><span class="cx">
</span><span class="cx"> TracksButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "18px"
</del><ins>+PASS getComputedStyle(button.element).top became "18px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "79px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "14px"
</ins><span class="cx">
</span><span class="cx"> FullscreenButton
</span><del>-PASS getComputedStyle(button.element).webkitMaskPositionY became "18px"
</del><ins>+PASS getComputedStyle(button.element).top became "18px"
</ins><span class="cx"> PASS getComputedStyle(button.element).left is "111px"
</span><del>-PASS getComputedStyle(button.element).height is "44px"
</del><ins>+PASS getComputedStyle(button.element).height is "18px"
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsbuttonsstyleshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -12,24 +12,24 @@
</span><span class="cx"> document.body.appendChild(mediaControls.element);
</span><span class="cx">
</span><span class="cx"> const buttonPositions = [
</span><del>- [mediaControls.rewindButton, 27, 17],
- [mediaControls.playPauseButton, 78, 12],
- [mediaControls.forwardButton, 127, 17],
- [mediaControls.airplayButton, 12, 18],
- [mediaControls.pipButton, 44, 18],
- [mediaControls.tracksButton, 79, 18],
- [mediaControls.fullscreenButton, 111, 18]
</del><ins>+ [mediaControls.rewindButton, 27, 17, 16],
+ [mediaControls.playPauseButton, 78, 12, 26],
+ [mediaControls.forwardButton, 127, 17, 16],
+ [mediaControls.airplayButton, 12, 18, 14],
+ [mediaControls.pipButton, 44, 18, 16],
+ [mediaControls.tracksButton, 79, 18, 14],
+ [mediaControls.fullscreenButton, 111, 18, 18]
</ins><span class="cx"> ];
</span><span class="cx">
</span><span class="cx"> let button, x, y;
</span><span class="cx"> (function testButton(index)
</span><span class="cx"> {
</span><del>- [button, x, y, width] = buttonPositions[index];
</del><ins>+ [button, x, y, height] = buttonPositions[index];
</ins><span class="cx"> debug("");
</span><span class="cx"> debug(button.constructor.name);
</span><del>- shouldBecomeEqualToString("getComputedStyle(button.element).webkitMaskPositionY", `${y}px`, () => {
</del><ins>+ shouldBecomeEqualToString("getComputedStyle(button.element).top", `${y}px`, () => {
</ins><span class="cx"> shouldBeEqualToString("getComputedStyle(button.element).left", `${x}px`);
</span><del>- shouldBeEqualToString("getComputedStyle(button.element).height", "44px");
</del><ins>+ shouldBeEqualToString("getComputedStyle(button.element).height", `${height}px`);
</ins><span class="cx"> if (index === buttonPositions.length - 1) {
</span><span class="cx"> mediaControls.element.remove();
</span><span class="cx"> finishJSTest();
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsdragispreventedoverbuttonhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -22,9 +22,9 @@
</span><span class="cx"> shouldBecomeEqual("!!mediaControls.querySelector('.buttons-container.left')", "true", () => {
</span><span class="cx"> shouldBecomeEqualToString("mediaControls.querySelector('.buttons-container.left').style.width", "116px", () => {
</span><span class="cx"> const bounds = mediaControls.querySelector(".controls-bar").getBoundingClientRect();
</span><del>- eventSender.mouseMoveTo(bounds.left + 68, bounds.top + 10);
</del><ins>+ eventSender.mouseMoveTo(bounds.left + 68, bounds.top + 20);
</ins><span class="cx"> eventSender.mouseDown();
</span><del>- eventSender.mouseMoveTo(bounds.left + 18, bounds.top - 90);
</del><ins>+ eventSender.mouseMoveTo(bounds.left + 18, bounds.top - 80);
</ins><span class="cx"> eventSender.mouseUp();
</span><span class="cx">
</span><span class="cx"> window.requestAnimationFrame(() => {
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmacosfullscreenmediacontrolsmacosfullscreenmediacontrolsdraghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -22,9 +22,9 @@
</span><span class="cx"> shouldBecomeEqual("!!mediaControls.querySelector('.buttons-container.left')", "true", () => {
</span><span class="cx"> shouldBecomeEqualToString("mediaControls.querySelector('.buttons-container.left').style.width", "116px", () => {
</span><span class="cx"> const bounds = mediaControls.querySelector(".controls-bar").getBoundingClientRect();
</span><del>- eventSender.mouseMoveTo(bounds.left + 118, bounds.top + 10);
</del><ins>+ eventSender.mouseMoveTo(bounds.left + 210, bounds.top + 25);
</ins><span class="cx"> eventSender.mouseDown();
</span><del>- eventSender.mouseMoveTo(bounds.left + 68, bounds.top - 90);
</del><ins>+ eventSender.mouseMoveTo(bounds.left + 160, bounds.top - 75);
</ins><span class="cx"> eventSender.mouseUp();
</span><span class="cx">
</span><span class="cx"> window.requestAnimationFrame(() => {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/Source/WebCore/ChangeLog 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -1,5 +1,38 @@
</span><span class="cx"> 2017-03-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] Fullscreen controls are difficult to drag around
+ https://bugs.webkit.org/show_bug.cgi?id=169412
+ <rdar://problem/30931892>
+
+ Reviewed by Eric Carlson.
+
+ Up until now, we would simply check that the event target when attempting to
+ initiate a drag would be the controls bar and not any of its children. This
+ was not so great as this would encompass also a large margin around the left,
+ center and right button containers as well as the time labels. We now check
+ that the event target is anything but an interactive element (<button> or <input>).
+
+ The existing test at media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html
+ has been updated to initiate dragging right between the rewind and play/pause button,
+ which would fail prior to this patch since this would have hit-tested within the center
+ button container and thus prevent dragging.
+
+ * Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
+ (.media-controls.mac.fullscreen button.volume-down):
+ (.media-controls.mac.fullscreen button.volume-up):
+ (.media-controls.mac.fullscreen button.rewind):
+ (.media-controls.mac.fullscreen button.play-pause):
+ (.media-controls.mac.fullscreen button.forward):
+ (.media-controls.mac.fullscreen .buttons-container.right button):
+ * Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
+ (MacOSFullscreenMediaControls.prototype._handleMousedown):
+ * Modules/modern-media-controls/controls/macos-inline-media-controls.css:
+ (.media-controls.mac.inline > .controls-bar button):
+ * Modules/modern-media-controls/controls/macos-media-controls.css:
+ (.media-controls.mac > .controls-bar button):
+
+2017-03-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] Controls are not visible in fullscreen without the controls attribute
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169411
</span><span class="cx"> <rdar://problem/30931724>
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosfullscreenmediacontrolscss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -57,11 +57,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen button.volume-down {
</span><del>- -webkit-mask-position-y: 18px;
</del><ins>+ top: 18px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen button.volume-up {
</span><del>- -webkit-mask-position-y: 17px;
</del><ins>+ top: 17px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Button containers */
</span><span class="lines">@@ -79,15 +79,15 @@
</span><span class="cx"> /* Buttons placement for center container */
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen button.rewind {
</span><del>- -webkit-mask-position-y: 17px;
</del><ins>+ top: 17px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen button.play-pause {
</span><del>- -webkit-mask-position-y: 12px;
</del><ins>+ top: 12px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen button.forward {
</span><del>- -webkit-mask-position-y: 17px;
</del><ins>+ top: 17px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Make right container flush to the right */
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> /* Buttons placement for right container */
</span><span class="cx">
</span><span class="cx"> .media-controls.mac.fullscreen .buttons-container.right button {
</span><del>- -webkit-mask-position-y: 18px;
</del><ins>+ top: 18px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Scrubber */
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosfullscreenmediacontrolsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -115,7 +115,8 @@
</span><span class="cx">
</span><span class="cx"> _handleMousedown(event)
</span><span class="cx"> {
</span><del>- if (event.target !== this.controlsBar.element)
</del><ins>+ // We don't allow dragging when the interaction is initiated on an interactive element.
+ if (event.target.localName === "button" || event.target.localName === "input")
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> event.preventDefault();
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosinlinemediacontrolscss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -44,6 +44,10 @@
</span><span class="cx">
</span><span class="cx"> /* Controls placement */
</span><span class="cx">
</span><ins>+.media-controls.mac.inline > .controls-bar button {
+ height: 100% !important;
+}
+
</ins><span class="cx"> .media-controls.mac.inline button.play-pause {
</span><span class="cx"> -webkit-mask-position-y: 12px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsmacosmediacontrolscss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.css (213640 => 213641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.css 2017-03-09 15:59:58 UTC (rev 213640)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.css 2017-03-09 16:10:50 UTC (rev 213641)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-controls.mac > .controls-bar button {
</span><del>- height: 100% !important;
</del><span class="cx"> background-color: rgba(255, 255, 255, 0.45);
</span><span class="cx"> mix-blend-mode: plus-lighter;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>