<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213659] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213659">213659</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2017-03-09 13:18:25 -0800 (Thu, 09 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>
Source/JavaScriptCore:
std::isnan/isinf should work with WTF time classes
https://bugs.webkit.org/show_bug.cgi?id=164991
Reviewed by Darin Adler.
Changes AtomicsObject to use std::isnan() instead of operator== to detect NaN.
* runtime/AtomicsObject.cpp:
(JSC::atomicsFuncWait):
Source/WTF:
std::isnan/isinf/isfinite should work with WTF time classes
https://bugs.webkit.org/show_bug.cgi?id=164991
Reviewed by Darin Adler.
The consensus view (see comments in https://bugs.webkit.org/show_bug.cgi?id=152045) of how
to check if something is NaN is to use std::isnan(). To be able to do that for time
classes, they need to provide their own isnan() overhload. This also provides isinf()
overloads.
* wtf/MonotonicTime.h:
(std::isnan):
(std::isinf):
* wtf/Seconds.h:
(std::isnan):
(std::isinf):
* wtf/TimeWithDynamicClockType.h:
(std::isnan):
(std::isinf):
* wtf/WallTime.h:
(std::isnan):
(std::isinf):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeAtomicsObjectcpp">trunk/Source/JavaScriptCore/runtime/AtomicsObject.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfMonotonicTimeh">trunk/Source/WTF/wtf/MonotonicTime.h</a></li>
<li><a href="#trunkSourceWTFwtfSecondsh">trunk/Source/WTF/wtf/Seconds.h</a></li>
<li><a href="#trunkSourceWTFwtfTimeWithDynamicClockTypeh">trunk/Source/WTF/wtf/TimeWithDynamicClockType.h</a></li>
<li><a href="#trunkSourceWTFwtfWallTimeh">trunk/Source/WTF/wtf/WallTime.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-09 Filip Pizlo <fpizlo@apple.com>
+
+ std::isnan/isinf should work with WTF time classes
+ https://bugs.webkit.org/show_bug.cgi?id=164991
+
+ Reviewed by Darin Adler.
+
+ Changes AtomicsObject to use std::isnan() instead of operator== to detect NaN.
+
+ * runtime/AtomicsObject.cpp:
+ (JSC::atomicsFuncWait):
+
</ins><span class="cx"> 2017-03-09 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Use const AbstractLocker& (instead of const LockHolder&) in more places.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeAtomicsObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/AtomicsObject.cpp (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/AtomicsObject.cpp 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/JavaScriptCore/runtime/AtomicsObject.cpp 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -324,7 +324,7 @@
</span><span class="cx"> //
</span><span class="cx"> // exec->argument(3) returns undefined if it's not provided and ToNumber(undefined) returns NaN,
</span><span class="cx"> // so NaN is the only special case.
</span><del>- if (timeout == timeout)
</del><ins>+ if (!std::isnan(timeout))
</ins><span class="cx"> timeout = std::max(0_s, timeout);
</span><span class="cx"> else
</span><span class="cx"> timeout = Seconds::infinity();
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/WTF/ChangeLog 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2017-03-09 Filip Pizlo <fpizlo@apple.com>
+
+ std::isnan/isinf/isfinite should work with WTF time classes
+ https://bugs.webkit.org/show_bug.cgi?id=164991
+
+ Reviewed by Darin Adler.
+
+ The consensus view (see comments in https://bugs.webkit.org/show_bug.cgi?id=152045) of how
+ to check if something is NaN is to use std::isnan(). To be able to do that for time
+ classes, they need to provide their own isnan() overhload. This also provides isinf()
+ overloads.
+
+ * wtf/MonotonicTime.h:
+ (std::isnan):
+ (std::isinf):
+ * wtf/Seconds.h:
+ (std::isnan):
+ (std::isinf):
+ * wtf/TimeWithDynamicClockType.h:
+ (std::isnan):
+ (std::isinf):
+ * wtf/WallTime.h:
+ (std::isnan):
+ (std::isinf):
+
</ins><span class="cx"> 2017-03-09 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Use const AbstractLocker& (instead of const LockHolder&) in more places.
</span></span></pre></div>
<a id="trunkSourceWTFwtfMonotonicTimeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/MonotonicTime.h (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/MonotonicTime.h 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/WTF/wtf/MonotonicTime.h 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -139,6 +139,25 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><ins>+namespace std {
+
+inline bool isnan(WTF::MonotonicTime time)
+{
+ return std::isnan(time.secondsSinceEpoch().value());
+}
+
+inline bool isinf(WTF::MonotonicTime time)
+{
+ return std::isinf(time.secondsSinceEpoch().value());
+}
+
+inline bool isfinite(WTF::MonotonicTime time)
+{
+ return std::isfinite(time.secondsSinceEpoch().value());
+}
+
+} // namespace std
+
</ins><span class="cx"> using WTF::MonotonicTime;
</span><span class="cx">
</span><span class="cx"> #endif // WTF_MonotonicTime_h
</span></span></pre></div>
<a id="trunkSourceWTFwtfSecondsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Seconds.h (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Seconds.h 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/WTF/wtf/Seconds.h 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -259,6 +259,25 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><ins>+namespace std {
+
+inline bool isnan(WTF::Seconds seconds)
+{
+ return std::isnan(seconds.value());
+}
+
+inline bool isinf(WTF::Seconds seconds)
+{
+ return std::isinf(seconds.value());
+}
+
+inline bool isfinite(WTF::Seconds seconds)
+{
+ return std::isfinite(seconds.value());
+}
+
+} // namespace std
+
</ins><span class="cx"> using namespace WTF::seconds_literals;
</span><span class="cx"> using WTF::Seconds;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtfTimeWithDynamicClockTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/TimeWithDynamicClockType.h (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/TimeWithDynamicClockType.h 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/WTF/wtf/TimeWithDynamicClockType.h 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -138,6 +138,25 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><ins>+namespace std {
+
+inline bool isnan(WTF::TimeWithDynamicClockType time)
+{
+ return std::isnan(time.secondsSinceEpoch().value());
+}
+
+inline bool isinf(WTF::TimeWithDynamicClockType time)
+{
+ return std::isinf(time.secondsSinceEpoch().value());
+}
+
+inline bool isfinite(WTF::TimeWithDynamicClockType time)
+{
+ return std::isfinite(time.secondsSinceEpoch().value());
+}
+
+} // namespace std
+
</ins><span class="cx"> using WTF::TimeWithDynamicClockType;
</span><span class="cx"> using WTF::hasElapsed;
</span><span class="cx"> using WTF::sleep;
</span></span></pre></div>
<a id="trunkSourceWTFwtfWallTimeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/WallTime.h (213658 => 213659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/WallTime.h 2017-03-09 21:13:41 UTC (rev 213658)
+++ trunk/Source/WTF/wtf/WallTime.h 2017-03-09 21:18:25 UTC (rev 213659)
</span><span class="lines">@@ -138,6 +138,25 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><ins>+namespace std {
+
+inline bool isnan(WTF::WallTime time)
+{
+ return std::isnan(time.secondsSinceEpoch().value());
+}
+
+inline bool isinf(WTF::WallTime time)
+{
+ return std::isinf(time.secondsSinceEpoch().value());
+}
+
+inline bool isfinite(WTF::WallTime time)
+{
+ return std::isfinite(time.secondsSinceEpoch().value());
+}
+
+} // namespace std
+
</ins><span class="cx"> using WTF::WallTime;
</span><span class="cx">
</span><span class="cx"> #endif // WTF_WallTime_h
</span></span></pre>
</div>
</div>
</body>
</html>