<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213619] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213619">213619</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-08 18:37:42 -0800 (Wed, 08 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop support for non-standard document.all.tags()
https://bugs.webkit.org/show_bug.cgi?id=169337
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline web platform test now that one more check is passing.
* web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:
Source/WebCore:
Drop support for non-standard document.all.tags(). It is not part of the specification:
- https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmlallcollection-interface
It is not supported by Firefox and its support was dropped from Chrome back in early 2014:
- https://src.chromium.org/viewvc/blink?view=revision&revision=166870
No new tests, updated existing test.
* html/HTMLAllCollection.cpp:
* html/HTMLAllCollection.h:
* html/HTMLAllCollection.idl:
LayoutTests:
Update existing test to check that document.all.tags does not exist.
* fast/dom/document-all-tags-expected.txt:
* fast/dom/document-all-tags.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomdocumentalltagsexpectedtxt">trunk/LayoutTests/fast/dom/document-all-tags-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomdocumentalltagshtml">trunk/LayoutTests/fast/dom/document-all-tags.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlinfrastructurecommondominterfacescollectionshtmlallcollectionexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAllCollectioncpp">trunk/Source/WebCore/html/HTMLAllCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAllCollectionh">trunk/Source/WebCore/html/HTMLAllCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAllCollectionidl">trunk/Source/WebCore/html/HTMLAllCollection.idl</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLDocumentdocumentallexpectedtxt">trunk/LayoutTests/fast/dom/HTMLDocument/document-all-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLDocumentdocumentallhtml">trunk/LayoutTests/fast/dom/HTMLDocument/document-all.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/ChangeLog 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2017-03-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop support for non-standard document.all.tags()
+ https://bugs.webkit.org/show_bug.cgi?id=169337
+
+ Reviewed by Sam Weinig.
+
+ Update existing test to check that document.all.tags does not exist.
+
+ * fast/dom/document-all-tags-expected.txt:
+ * fast/dom/document-all-tags.html:
+
+2017-03-08 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Drop select.remove() / options.remove() overloads taking an option element in parameter
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169339
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLDocumentdocumentallexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/HTMLDocument/document-all-expected.txt (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLDocument/document-all-expected.txt 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/document-all-expected.txt 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,7 +0,0 @@
</span><del>-PASS htmlallcollection.toString() is '[object HTMLAllCollection]'
-PASS typeof htmlallcollection.tags == "function" is true
-PASS htmlallcollection.tags("body").length is 1
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLDocumentdocumentallhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/HTMLDocument/document-all.html (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLDocument/document-all.html 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/document-all.html 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="script-tests/document-all.js"></script>
-<script src="../../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomdocumentalltagsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/document-all-tags-expected.txt (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/document-all-tags-expected.txt 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/fast/dom/document-all-tags-expected.txt 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,9 +1,9 @@
</span><del>-Test that HTMLAllCollection.tags() matches IE behavior with too few arguments.
</del><ins>+Test that HTMLAllCollection.tags() does not exist.
</ins><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS document.all.tags() threw exception TypeError: Not enough arguments.
</del><ins>+PASS document.all.tags is undefined.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdocumentalltagshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/document-all-tags.html (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/document-all-tags.html 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/fast/dom/document-all-tags.html 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -5,8 +5,8 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span><del>-description('Test that HTMLAllCollection.tags() matches IE behavior with too few arguments.');
-shouldThrow("document.all.tags()");
</del><ins>+description('Test that HTMLAllCollection.tags() does not exist.');
+shouldBeUndefined("document.all.tags");
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-08 Chris Dumez <cdumez@apple.com>
+
+ Drop support for non-standard document.all.tags()
+ https://bugs.webkit.org/show_bug.cgi?id=169337
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline web platform test now that one more check is passing.
+
+ * web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:
+
</ins><span class="cx"> 2017-03-08 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Add support for history.scrollRestoration
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlinfrastructurecommondominterfacescollectionshtmlallcollectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> PASS Test lookup IMG in collection using ()
</span><span class="cx"> PASS Test lookup IMG in collection using []
</span><span class="cx"> PASS Test lookup IMG in collection using .
</span><del>-FAIL Test lookup tags in collection using . assert_equals: expected (string) "tags" but got (undefined) undefined
</del><ins>+PASS Test lookup tags in collection using .
</ins><span class="cx"> PASS Should find root element too
</span><span class="cx"> FAIL Should find both anchors and produce a list undefined is not an object (evaluating 'document.all["foo"].length')
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/Source/WebCore/ChangeLog 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-03-08 Chris Dumez <cdumez@apple.com>
+
+ Drop support for non-standard document.all.tags()
+ https://bugs.webkit.org/show_bug.cgi?id=169337
+
+ Reviewed by Sam Weinig.
+
+ Drop support for non-standard document.all.tags(). It is not part of the specification:
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmlallcollection-interface
+
+ It is not supported by Firefox and its support was dropped from Chrome back in early 2014:
+ - https://src.chromium.org/viewvc/blink?view=revision&revision=166870
+
+ No new tests, updated existing test.
+
+ * html/HTMLAllCollection.cpp:
+ * html/HTMLAllCollection.h:
+ * html/HTMLAllCollection.idl:
+
</ins><span class="cx"> 2017-03-08 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable async image decoding for large images
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAllCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAllCollection.cpp (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAllCollection.cpp 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/Source/WebCore/html/HTMLAllCollection.cpp 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -59,12 +59,4 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<NodeList> HTMLAllCollection::tags(const String& name)
-{
- if (name.isNull())
- return nullptr;
-
- return ownerNode().getElementsByTagName(name);
-}
-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAllCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAllCollection.h (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAllCollection.h 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/Source/WebCore/html/HTMLAllCollection.h 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> static Ref<HTMLAllCollection> create(Document&, CollectionType);
</span><span class="cx">
</span><span class="cx"> Element* namedItemWithIndex(const AtomicString& name, unsigned index) const;
</span><del>- RefPtr<NodeList> tags(const String&);
</del><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> HTMLAllCollection(Document&, CollectionType);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAllCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAllCollection.idl (213618 => 213619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAllCollection.idl 2017-03-09 02:16:51 UTC (rev 213618)
+++ trunk/Source/WebCore/html/HTMLAllCollection.idl 2017-03-09 02:37:42 UTC (rev 213619)
</span><span class="lines">@@ -35,8 +35,5 @@
</span><span class="cx"> [Custom] getter Element? item(unsigned long index);
</span><span class="cx"> [Custom] getter (HTMLCollection or Element)? namedItem(DOMString name);
</span><span class="cx"> // [Custom] legacycaller (HTMLCollection or Element)? item(optional DOMString nameOrIndex);
</span><del>-
- // FIXME: This is not in the standard. Can we remove it?
- NodeList tags(DOMString name);
</del><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>