<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213589] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213589">213589</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-08 11:52:30 -0800 (Wed, 08 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] Throttle DOM timers to 30fps in low power mode
https://bugs.webkit.org/show_bug.cgi?id=169213
<rdar://problem/30876965>
Reviewed by Simon Fraser.
Source/WebCore:
Throttle and align DOM timers to ~30fps in low power mode on iOS
to save battery.
Test: fast/dom/timer-throttling-lowPowerMode.html
* page/DOMTimer.h:
* page/Page.cpp:
(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::updateDOMTimerAlignmentInterval):
LayoutTests:
Add layout test coverage.
* fast/dom/timer-throttling-lowPowerMode-expected.txt: Added.
* fast/dom/timer-throttling-lowPowerMode.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageDOMTimerh">trunk/Source/WebCore/page/DOMTimer.h</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomtimerthrottlinglowPowerModeexpectedtxt">trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomtimerthrottlinglowPowerModehtml">trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213588 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-08 19:03:07 UTC (rev 213588)
+++ trunk/LayoutTests/ChangeLog 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-03-08 Chris Dumez <cdumez@apple.com>
+
+ [iOS] Throttle DOM timers to 30fps in low power mode
+ https://bugs.webkit.org/show_bug.cgi?id=169213
+ <rdar://problem/30876965>
+
+ Reviewed by Simon Fraser.
+
+ Add layout test coverage.
+
+ * fast/dom/timer-throttling-lowPowerMode-expected.txt: Added.
+ * fast/dom/timer-throttling-lowPowerMode.html: Added.
+
</ins><span class="cx"> 2017-03-08 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Mark editing/selection/move-by-word-visually-multi-space.html as flaky on Sierra Debug WK2.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomtimerthrottlinglowPowerModeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode-expected.txt (0 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode-expected.txt 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+Tests that DOM timers are throttled in low power mode.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Enabling low power mode
+internals.setLowPowerModeEnabled(true)
+* Nesting: 1
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 2
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 3
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 4
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 5
+PASS internals.isTimerThrottled(timerHandle) is true
+* Nesting: 6
+PASS internals.isTimerThrottled(timerHandle) is true
+
+Disabling low power mode
+internals.setLowPowerModeEnabled(false)
+* Nesting: 7
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 8
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 9
+PASS internals.isTimerThrottled(timerHandle) is false
+* Nesting: 10
+PASS internals.isTimerThrottled(timerHandle) is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomtimerthrottlinglowPowerModehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode.html (0 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode.html (rev 0)
+++ trunk/LayoutTests/fast/dom/timer-throttling-lowPowerMode.html 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that DOM timers are throttled in low power mode.");
+jsTestIsAsync = true;
+
+let i = 0;
+const maxNestingLevel = 5;
+
+let lowPowerModeEnabled = true;
+debug("Enabling low power mode");
+evalAndLog("internals.setLowPowerModeEnabled(true)");
+
+const timerHandle = setInterval(function() {
+ i++;
+ debug("* Nesting: " + i);
+ if (i >= maxNestingLevel && lowPowerModeEnabled)
+ shouldBeTrue("internals.isTimerThrottled(timerHandle)");
+ else
+ shouldBeFalse("internals.isTimerThrottled(timerHandle)");
+
+ if (i == maxNestingLevel + 1) {
+ debug("");
+ debug("Disabling low power mode");
+ lowPowerModeEnabled = false;
+ evalAndLog("internals.setLowPowerModeEnabled(false)");
+ }
+
+ if (i == 10) {
+ clearInterval(timerHandle);
+ finishJSTest();
+ }
+}, 10);
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213588 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-08 19:03:07 UTC (rev 213588)
+++ trunk/Source/WebCore/ChangeLog 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2017-03-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ [iOS] Throttle DOM timers to 30fps in low power mode
+ https://bugs.webkit.org/show_bug.cgi?id=169213
+ <rdar://problem/30876965>
+
+ Reviewed by Simon Fraser.
+
+ Throttle and align DOM timers to ~30fps in low power mode on iOS
+ to save battery.
+
+ Test: fast/dom/timer-throttling-lowPowerMode.html
+
+ * page/DOMTimer.h:
+ * page/Page.cpp:
+ (WebCore::Page::handleLowModePowerChange):
+ (WebCore::Page::updateDOMTimerAlignmentInterval):
+
+2017-03-08 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Update outdated comment about HTMLElement.dropzone
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169338
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMTimerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMTimer.h (213588 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMTimer.h 2017-03-08 19:03:07 UTC (rev 213588)
+++ trunk/Source/WebCore/page/DOMTimer.h 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -47,6 +47,7 @@
</span><span class="cx">
</span><span class="cx"> static Seconds defaultMinimumInterval() { return 4_ms; }
</span><span class="cx"> static Seconds defaultAlignmentInterval() { return 0_s; }
</span><ins>+ static Seconds defaultAlignmentIntervalInLowPowerMode() { return 30_ms; }
</ins><span class="cx"> static Seconds hiddenPageAlignmentInterval() { return 1_s; }
</span><span class="cx">
</span><span class="cx"> // Creates a new timer owned by specified ScriptExecutionContext, starts it
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (213588 => 213589)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2017-03-08 19:03:07 UTC (rev 213588)
+++ trunk/Source/WebCore/page/Page.cpp 2017-03-08 19:52:30 UTC (rev 213589)
</span><span class="lines">@@ -1138,6 +1138,7 @@
</span><span class="cx"> {
</span><span class="cx"> updateScriptedAnimationsThrottlingReason(*this, isLowPowerModeEnabled ? ThrottlingReasonOperation::Add : ThrottlingReasonOperation::Remove, ScriptedAnimationController::ThrottlingReason::LowPowerMode);
</span><span class="cx"> mainFrame().animation().updateThrottlingState();
</span><ins>+ updateDOMTimerAlignmentInterval();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Page::userStyleSheetLocationChanged()
</span><span class="lines">@@ -1349,7 +1350,7 @@
</span><span class="cx">
</span><span class="cx"> switch (m_timerThrottlingState) {
</span><span class="cx"> case TimerThrottlingState::Disabled:
</span><del>- m_domTimerAlignmentInterval = DOMTimer::defaultAlignmentInterval();
</del><ins>+ m_domTimerAlignmentInterval = isLowPowerModeEnabled() ? DOMTimer::defaultAlignmentIntervalInLowPowerMode() : DOMTimer::defaultAlignmentInterval();
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case TimerThrottlingState::Enabled:
</span></span></pre>
</div>
</div>
</body>
</html>